summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2019-03-12Move the Help URL to a different config pathAshod Nakashian1-2/+0
This partially reverts e5a0bafa330c58d6c9352d3acbe4e97fafa1ad56 and simplifies the Help URL configuration. Change-Id: Icc7c31b8955f3df978b57dbd8aa8816a9e1f98ad Reviewed-on: https://gerrit.libreoffice.org/69106 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-12Make the Help URL configurableAshod Nakashian2-0/+4
When the Help URL is blank, the Help buttons are hidden LOK (but not desktop). Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073 Reviewed-on: https://gerrit.libreoffice.org/69071 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-12fix build failures because of diff against masterTomaž Vajngerl1-0/+6
Change-Id: Iefe4683f456750b53c96e1634d7930f4b042e573
2019-03-11parse more attributes in SvgDrawVisitorTomaž Vajngerl1-0/+14
- add additional parameters for DrawRectangle, DrawPath - parse stroke width, stroke and fill color for path and rect - parse rx, ry for rect - use getCurrentViewPort for top-level SVG rectangle Change-Id: Ife498bdaa721852ef2542ac5df2be0e86dfb4e62 Reviewed-on: https://gerrit.libreoffice.org/68785 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8c0178870889a47c46fec8f59b7c94dcabf6d126)
2019-03-11use gfx namespace for DrawCommandsTomaž Vajngerl1-0/+11
Change-Id: Ib2d97c4fee4e1bb433beeba4fb507fdc7d542af9 Reviewed-on: https://gerrit.libreoffice.org/68775 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit d112761291b16c1d47bebdebf3169527f5e1249e)
2019-03-11svgio visitor, add draw commands and create the from svgTomaž Vajngerl1-0/+74
Adds a visitor for svgio for visiting svg nodes and create something useful from them. Basic draw commands - a tree of draw commands (with sub-pixel precision support) just to store a simple definition for drawing. Adds a svg draw visitor and create draw commands from the svg structure and expose the commands through UNO API. Change-Id: I073e891a2cffdd76d4e3b838590e3a19c998e9bf Reviewed-on: https://gerrit.libreoffice.org/68770 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7894fd2b442eff45ecf14088ebd17ee9f8678752)
2019-03-11Add support for <image> draw definition to draw a SVG imageTomaž Vajngerl1-9/+5
Attribute "source" is used to get the relative path to the image. Path is relative to the definition file. Reviewed-on: https://gerrit.libreoffice.org/68712 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 983566119c926d0e2478f74548f00a789de55c15) Change-Id: I6ca0c113385e26ad74b928e1f56635b4b0cef995
2019-03-11tdf#121744 XLSX Export Combinated Chart (Column and Line)Jozsef Szakacs1-1/+1
Each of the Column and Line Chart creates it's own x and y Axes. So now the LineChart Exporter Method uses the same Axes as the BarChart. Thanks for the help: - Balazs Varga - Adam Kovacs Reviewed-on: https://gerrit.libreoffice.org/64146 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/65449 (cherry picked from commit d58d92d72b00f45c56a3b0fe55ca9fd837d244a9) Change-Id: Ie763cf831c2ce63ef204d1fdcbff634e7ca8fad5
2019-03-04sfx2: include what we use onlyAshod Nakashian1-6/+4
Change-Id: If89e1ea4377549935ec27afe60543b4cf27fe5f2 Reviewed-on: https://gerrit.libreoffice.org/68266 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-04LOK: support creating view with optionsAshod Nakashian2-3/+10
This adds a new API createViewWithOptions that make createView similar to documentLoad, which also has documentViewWithOptions version. This is primarily to support setting per-view language and similar settings. Change-Id: I0ae5a5b2410cf9e053aee8f7c8a6204af9038a31 Reviewed-on: https://gerrit.libreoffice.org/68261 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-17MSForms: Make Drop-Down form field to have a default sizeTamás Zolnai1-1/+1
Similar to MSO Drop-down form field and LO Input List. Change-Id: Idba278d8c2a2106b6f3cc22d8b9f8570f45bfae9 Reviewed-on: https://gerrit.libreoffice.org/67908 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit d24fe1116ddd9eec3a0884c7b222455c44bd6eb4) Reviewed-on: https://gerrit.libreoffice.org/67923 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-17MSForms: Insert Legacy Form Fields from MS compatible Forms menuTamás Zolnai1-0/+1
I added a new submenu under MS compatible Forms menu called Legacy Forms. Under this submenu user can insert the three legacy form fields. These fields were already supported by DOC / DOCX filters, but were missing from the UI. When inserting text form field we insert 5 enspace to make the field visible, otherwise we use the same insertion methods what is called by DOC import. Reviewed-on: https://gerrit.libreoffice.org/67907 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5a94be3e677e4b7ccb2990a3a79fbf2219322f80) Change-Id: I1fb8c03d969b4c547ca92e783ac5e216767685d5 Reviewed-on: https://gerrit.libreoffice.org/67922 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-17MSForms: Show restart dialog when MS compatible Forms menu setting is changedTamás Zolnai1-0/+3
Reviewed-on: https://gerrit.libreoffice.org/67906 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 54b2615e0d209f815b3d503523fd4c517dc6b5cd) Change-Id: Icb98dac73dea5f5cb18e1ca34e37e9d9bf84782e Reviewed-on: https://gerrit.libreoffice.org/67921 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-17MSForms: Introduce a new compatibility flag to enable MS compatible Forms menuTamás Zolnai2-0/+41
* It's a global option not a document level setting (like other compatibility options) so I created a separate section on the GUI for this option on the same tab page. * In the configuration the option is placed under Compatibility/View since the existing Compatibility/FormattingOptions seems related to document formating and not the GUI. * Since it was added with a new configuration root I needed to add also a new ConfigItem derviative class to handle this option. Reviewed-on: https://gerrit.libreoffice.org/67902 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 11669b9cf970d953d41b8dd2c5ce85d6fa7e31ef) Change-Id: I54668ae9808a1ca3c3b7fe81f2f201720257b3fb Reviewed-on: https://gerrit.libreoffice.org/67918 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-02-04Related: tdf#94238 PPTX import: handle subset of radial gradient fillMiklos Vajna1-0/+3
Handle the case when the horizontal center is at 50%. Other cases are still unhandled, those are more complex. After fixing the style, center and border, the gradient fill looks similar to how PowerPoint renders it. Change-Id: I419da70482de37031aa2c7fc735692019d7665f5 Reviewed-on: https://gerrit.libreoffice.org/67175 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-01-25sw: Ctrl + shape insertion was not setting up the layer.Jan Holesovsky1-0/+3
The consequence was that the shapes were inserted into the background layer. The problem was particularly visible with the LOK, but reproducible on the desktop too. Includes unit test. Change-Id: I16137331f944101e25679ec8c4a034bea658bc57 Reviewed-on: https://gerrit.libreoffice.org/66915 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22Revert "lok: custom widgets: render editbox borders"Ashod Nakashian1-1/+1
Looks like this is no longer needed to correctly render editbox borders. Not clear what fixed the issue. This reverts commit 9c5bc82fdfa67d0149806a0b55962edc7925dd0f.
2019-01-03lok: add signDocument to "Office" iface - to sign not opened docs.Tomaž Vajngerl3-0/+63
LOKit function "signDocument" can sign document without the need to open them. This is useful to sign PDF documents after they are created from a currently opened (ODF, DOCX) document. This adds DocumentDigner to sfx2, which could also be used in desktop LibreOffice without opening them and in further tests. Reviewed-on: https://gerrit.libreoffice.org/65767 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a8cb7cf68ff661b502e7c006fe4330098b5b0944) Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a
2018-12-29tdf#34171: check foreign lockfiles to tell who has locked documentMike Kaganski1-1/+2
MS Office (Word/Excel/PowerPoint) lockfiles are supported now. Note that Excel does *not* create lockfiles for pre-OOXML files. This changes osl_openFile implementation on Windows, to treat osl_File_OpenFlag_NoLock to also include FILE_SHARE_DELETE flag for CreateFileW. This is required to allow opening files created with FILE_FLAG_DELETE_ON_CLOSE flag, such as Excel's owner files. The shange should be consistent with the overall meaning of the osl_File_OpenFlag_NoLock to not impose any locking constraints to the file being opened. Change-Id: I7b99012f4bd60ab3821fb91d5166a286031b7e93 Reviewed-on: https://gerrit.libreoffice.org/64496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 607b80ca3cddc239a35580470944a438ce144fc8) Reviewed-on: https://gerrit.libreoffice.org/65085 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-12-27Revert tdf#115639 fixesAron Budea3-12/+0
This reverts commit 62cf24fbd48064e3ba309109a92a2c408ae654b6. This reverts commit ea4a9ca0a6ccf747a34997dc1d50efb82f9106ee. This reverts commit 2a664263d043f0327a92d5d5f7507bd10143fd31. Change-Id: If57c9f2aed054335d214ce87f17ab3f62dbebe65 Reviewed-on: https://gerrit.libreoffice.org/65645 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-12-16tdf#121779: extend TWo CApitals list to also ignore sMALL iNITIALSMike Kaganski1-5/+3
Now this list is used also in rules for capitalizing first letter of every sentence, and for correcting accidental use of Caps Lock key. Change-Id: I4fbdbccbae32743d5e9a6757344361eefd88e167 Reviewed-on: https://gerrit.libreoffice.org/64759 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/65087 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-12-13Revert "Add a localisation API to LibreOfficeKitClass"Tor Lillqvist2-39/+0
Was reverted in master, too. The functionality is implemented differently now in the iOS app, without requiring any new methods in LibreOfficeKitClass. This reverts commit 36beb79184e5f4153c8cc92b176b21b697594228. Change-Id: Ic0c42848c81a9b48e50a2b01a0a5a98ef5220870
2018-12-10Add a localisation API to LibreOfficeKitClassTor Lillqvist2-0/+39
Combines the LanguageTag::Create() and Translate::get() functionality. Also add an ABI test for the Kit class in the LibreOfficeKit unit test, and a test for the translation function. (In this branch there is no Translate::nget() so no such functionality.) Change-Id: I78c48a8bbb434d6f204869290822830288022a53 Reviewed-on: https://gerrit.libreoffice.org/64894 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-12-10Get rid of ValueSet's internal VirtualDevice, draw to RenderContextMike Kaganski1-5/+3
This improves support for Online HiDPI scenarios. Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893
2018-12-10lok: shape scaling reworkMarco Cecchetti1-2/+4
Now shape scaling is handled through the transform dialog instead of simulating a drag and drop event in core. For Impress the unit used for length is '100th mm' instead of twips, so we need to transform positions and size from twips to '100th mm'. Anyway since we don't know in SetGeoAttrToMarked if the new data is due to a mouse event or by entering a new value in the transormation dialog or in the side pane, for Impress we need to convert the new values sent by the dialogs from '100th mm' to twips which are converted back in SetGeoAttrToMarked. For performing a uniform scaling when the shape/image is rotated we need to inform the client about the rotation angle for the selected graphic object that has been achieved but appending an angle argument to the graphic selection callback. Now it is also possible to reverse shapes/images through negative scaling. Change-Id: I8a32f3e4b28f36e884a59c59b7e1351e85ef4489 Reviewed-on: https://gerrit.libreoffice.org/64696 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-12-10custom widgets: Rename 'stock' to 'action'.Jan Holesovsky2-7/+7
If the button has this property, it means it is located in the action area, not that it is a stock button per se. Change-Id: Ia57ad24d8cd4ff1d7b74d7ef82da0f352fe3deb3
2018-12-10add parameter TransformRotationDeltaAngle to .uno:TransformDialogHenry Castro1-0/+1
Change-Id: Ib22ba6956afedf1eea055e0ac3a78c53b4ee5861
2018-12-10LOK: Fix API for renderShapeSelectionAshod Nakashian2-6/+5
Unlike C++, C doesn't allow reference-to-pointer types, and we do have C code that wouldn't compile with ref-to-ptr. Had to change to ptr-to-ptr, which is the proper way of having output arrays. For the same reason, we cannot use new/delete, rather we must use malloc/free. Another (lesser) issue was that we used the renderShapeSelection API to echo back an array we give it as prefix. This made the API unecessarily complex (in undocumented ways) and forced the implementation to both worry about user-data and managing the input memory. This logic is best moved to the client and the API simply returns the output data. Speaking of returning data, the API now returns the size of the array it allocated and wrote to, so the client can do a simple check on the return value directly. Change-Id: Ida216c10d5b37efd1e0861e26b72cabb25c568e6
2018-12-10Introduce client-server message for requesting the selected shape as SVGTamás Zolnai2-0/+14
It works for Impress only now. Change-Id: I95e3e37ae7df49b567108f6d6467038b715e886d
2018-12-08utility constructor for Image "private:graphicrepository" urlsNoel Grandin1-0/+3
Change-Id: I118039f4e47818a43da9302ce3550ea800522675 Reviewed-on: https://gerrit.libreoffice.org/64765 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/64803 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-06Use lazy-loading stock Image to simplify framework image lists.Michael Meeks2-1/+4
Project stock names through XGraphic via origin URL. Change-Id: Ib445694f7c142a163ef7e7bc0beea39b88b99e14 (cherry picked from commit 77b88eebaadebb626108172e4f2de36c60960051)
2018-12-06Add explicit API scaling via ImageTree API.Michael Meeks1-1/+6
Also add image scale to in-memory cache lookup. Change-Id: I1e84b922d4a9ab2f1723c5cb8a72f295c6940504 (cherry picked from commit 59b3cdbc27b65fb3e72dd0b3b2565851bc8f772c)
2018-12-06ViewShellBase const correctnessAshod Nakashian1-2/+1
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28)
2018-11-08lok: send signature status on document loadTomaž Vajngerl1-0/+5
Change-Id: If164d0edc9343b1db5ee96a2da46c9436ddbc73f Reviewed-on: https://gerrit.libreoffice.org/62776 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 30bb64dc2deb53409c72bc8d4c083bbc3fd99a7d)
2018-11-08sfx2: add RecheckSignature to run signature verification againTomaž Vajngerl1-0/+1
This was extracted from AfterSigning method and is needed when we add the certificate chain to the database after the document was loaded already. Reviewed-on: https://gerrit.libreoffice.org/62275 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit fcdc8178ee2907da231baafc2e1d6cf8ce0bf00b) Conflicts: include/sfx2/objsh.hxx Change-Id: I3087386d0131ce962eb3b588c409542617eb7bfe
2018-11-08lok: new function to add certificate to certificate DBTomaž Vajngerl2-2/+18
Also needed to extend XCertificateCreator with a new method "addDERCertificateToTheDatabase". Reviewed-on: https://gerrit.libreoffice.org/62273 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 08c3c504644ee978c2ec75ba083765b6ffddf08c) Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx Change-Id: I7b4df65365893bd5a0628aeec30b3156584849fe
2018-11-08lok: create certificate and private key with insertCertificateTomaž Vajngerl2-3/+9
Change-Id: Ie114068d9aec5259f9f7ed395c5dfeecf8bb787d Reviewed-on: https://gerrit.libreoffice.org/61915 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c2ceb1f54e85ebc8b38df3f2e4d1113a2fe1cc64)
2018-11-08lokit: add funct. to insert, sign and verify signatureTomaž Vajngerl4-0/+36
A lot of signing code paths trigger a GUI dialog (to select the certificate for example) which aren't acceptable when triggering through the LOKit. This code paths needed to be duplicated and reworked to not trigger any GUI action. Reviewed-on: https://gerrit.libreoffice.org/61780 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 23a2312344ac961ead9ee14140c0b3e879bb7a41) Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx include/LibreOfficeKit/LibreOfficeKit.hxx include/sfx2/objsh.hxx sfx2/source/doc/docfile.cxx sfx2/source/doc/objserv.cxx Change-Id: I2f0d6038fb1bcd00adcdf86e432f9df8858cc21c
2018-11-08Refactor SfxObjectShell sign methodsSamuel Mehrbrodt2-7/+10
for signature line signing Reviewed-on: https://gerrit.libreoffice.org/54473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0ca1659353cc9847f436280873e1047d2524395e) Conflicts: cui/source/dialogs/SignSignatureLineDialog.cxx sfx2/source/doc/objserv.cxx Change-Id: Iac4f3a248af53bdbf159e6e8d656e1dcbc3aacbf
2018-11-08tdf#83877 Write SignatureLineId to ODF & OOXML signaturesSamuel Mehrbrodt2-4/+6
Reviewed-on: https://gerrit.libreoffice.org/54432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 201321f648e82ecc610e7a3324a46248a19c1704) Conflicts: cui/source/dialogs/SignSignatureLineDialog.cxx xmlsecurity/source/component/documentdigitalsignatures.cxx xmlsecurity/source/helper/documentsignaturemanager.cxx Change-Id: I483a3b7895cdcb10ef9d6dacf167ed0f8db7e723
2018-11-08Sign Signature LineSamuel Mehrbrodt2-2/+10
This adds a new context menu entry "Sign Signature Line" to signature lines. You can directly sign the document from there. Still missing is the updating of the graphic to reflect the valid/invalid signature state. Reviewed-on: https://gerrit.libreoffice.org/53778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 86e8cfdd54ac1b9413f0c86cbc23a80162806685) Conflicts: cui/source/dialogs/SignSignatureLineDialog.cxx xmlsecurity/source/component/documentdigitalsignatures.cxx Change-Id: Ib8bc8c57f9d5370a10e379f86f9e41e57c715e3f
2018-11-08lok: custom widgets: render editbox bordersAshod Nakashian1-1/+1
Change-Id: I1962a4a1397363b1c15e49d57b0bbcc9c232ce30
2018-11-08vcl: mark stock buttons and transfer this to NWF on drawingTomaž Vajngerl2-4/+20
Stock buttons like OK/Cancel/Help need sometimes to be drawn differently than just another button. For this we need to mark such push buttons as "stock" when building them from a glade file and transfer this information down to the NWF backend when drawing the widget. Change-Id: I131657f026a731208db47f4c8220622c8aabb464
2018-11-08Avoid gcc: "specified bound depends on the length of the source argument"Tor Lillqvist1-1/+1
Just use memcpy(). Change-Id: Icb705acb6c12baf28684c763a77da7abc514ea6d Reviewed-on: https://gerrit.libreoffice.org/57714 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit efe42fca7c386340575088ecf94952f3ba0447de)
2018-11-08tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl2-10/+15
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2018-11-07lokdialog: Implement hi-dpi support for the routed dialogs.Jan Holesovsky2-3/+19
Change-Id: I770c605a049b7ac9c26c2773414eef8b6fc093a2
2018-11-07sc lok: Implement hi-dpi and zoom for spreadsheets.Jan Holesovsky1-0/+4
A bit different approach than trying to paint different zoom levels at the samet time, because it is terribly hard to achieve with Calc - things misalign, because Calc tries to fit the lines into the pixels etc. Instead, always paint the spreadsheet at 100%, but use cairo to scale the actual painting. Change-Id: I228a9dd41bf29862bdd188825d12e61e1c86cccc
2018-11-07lok: Notify about the current editing context.Jan Holesovsky2-0/+13
Change-Id: I47e67b680a6abdb66020b295f55ee6a73b7b5608
2018-11-06Revert "For iOS, do actually export UI builder factory functions"Tor Lillqvist1-13/+3
This doesn't work in a Release build. The functions in question don't get included in the binary. Will have to use a different approach, with actual references to the needed functions. Also revert "Use BUILDER_FACTORY_EXPORT instead of SAL_DLLPUBLIC_EXPORT" This reverts commit 6e9ca7c925671165057743cfdc73272afeffe7ab. This reverts commit 911742479eb5e8e406808f615697fea7caf82479. Change-Id: Iae26d0aac2ea14400725cc330a339c3a9499d85c Reviewed-on: https://gerrit.libreoffice.org/62941 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-05For iOS, do actually export UI builder factory functionsTor Lillqvist1-3/+13
In the DISABLE_DYNLOADING case there is normally no need for functions marked with SAL_DLLPUBLIC_EXPORT to be exported, as these functions won't be dynamically looked up anyway. Thus, when DISABLE_DYNLOADING, SAL_DLLPUBLIC_EXPORT is defined in <sal/types.h> to actually mean __attribute__ ((visibility("hidden"))). But we do need to export the UI builder factory functions so that the osl_getFunctionSymbol() in VclBuilder::makeObject() finds them. (I kinda dislike looking up symbols with dlsym() from the same binary. We know that the function is there and what its name is, we could just call it directly. But makeObject() gets the function name as a string, so we would need a long set of string comparisons to select which function to call. A bit ugly. Let's see if I can come up with something elegant enough later.) Change-Id: Idceaf8c1ed54cd7d372bf4eb85d0428f9b57baeb Reviewed-on: https://gerrit.libreoffice.org/62870 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 18:12:46 +0000