Age | Commit message (Collapse) | Author | Files | Lines |
|
Also add comment about the three sets of names for the same constants that
must match.
Change-Id: Id626b6f1cdaa4c2a8c391ae4f020186997ccb4d9
|
|
Full error:
error: conversion from const char* to non-scalar type rtl::OUString requested
This seems to be happening only where ITiledRenderable.hxx ends up being
included in an Objective C file.
|
|
Change-Id: I0e14a535124e93979ef05431255911245a11aa29
|
|
Writer doesn't understand the concept of parts at the moment, it
makes most sense to keep these dummy implementations central.
Change-Id: Iafbd89864b753ba2bed28a05b0f59df85f364feb
|
|
Change-Id: Iac31de0410d7f6187e5884152c329375047a23f4
|
|
Change-Id: I1362489c9aecf536b31bf6ab57ad8c149f37a876
|
|
This API seems to be simplest in the long run where we'll want to be
able to select between rendering slides/notes/both/embedded objects,
and maybe even adding the option of switching between continuous
and single page mode in writer (although I have no idea how hard
getting a single page mode out of writer would be).
Change-Id: I5bdfdb61854c37281c6992c8f3ed1c50c8aa0919
|
|
By default (i.e. for writer) we can just return an empty string,
and we only actually need to implement ITiledRenderable's
getPartName for components that actually support it (i.e. calc/impress).
Change-Id: I8b381e5d7a8000638b02f763b4bea8ef0226f8e0
|
|
Change-Id: I8ebe3ad2a6efcf1797a2dc941994c7fc1e36f4bf
|
|
by converting the bit munging to use bitfields.
Remove unused return values.
Add asserts to check that AddRef() is not called after the object
is deleted.
Fix the code in SfxObjectShell to not call AddRef() after
SfxObjectShell is deleted.
Change-Id: I3a3565a0bc45fc9d1d086222265ab8b8175818a7
|
|
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23
Reviewed-on: https://gerrit.libreoffice.org/10298
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
|
|
since none of the call sites specify it
Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
|
|
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.
Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
|
|
It looks like the cleanest method of getting lok_init into
a LibreOfficeKitInit.h header (in a c89 compatible way) is to
have it as a static function.
(inline is only available in C99 or later -- this is actually
available on Linux which is the only place that we can actually
use lok_init anyways currently, however given we have to keep
c89 for the C code (for MSVC) compatibility, selectively enabling
c99 would likely be more messy.)
Change-Id: I0493e7a68ed5397479220bb6ba8c3db870b6dd32
|
|
... by boost::ptr_vector.
Originally TextCharAttribList::Clear() was never called with false,
so this drops the argument.
Change-Id: I0306cd787dd38de0960af38afe9c08a910195b26
Reviewed-on: https://gerrit.libreoffice.org/10549
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07
Reviewed-on: https://gerrit.libreoffice.org/10565
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
|
|
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
|
|
|
|
Change-Id: Iff524c9065e9374b39db998e3860704555130995
|
|
Handlers are conceptually stateless; we can keep them as const objects.
Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
|
|
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
|
|
Change-Id: I6c0073d27d18676b85809bd5f294e90e23ec9770
|
|
And organize xmltypes.hxx a bit to make it easier to follow. Also
rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW.
Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
|
|
Let's hide its implementation for real this time.
Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
|
|
which required making SfxFrame subclass SvCompatWeakBase,
but that makes the relationships clearer anyhow.
Change-Id: I209d05359d50111eacac72c971bb46ccf569ba49
Reviewed-on: https://gerrit.libreoffice.org/10285
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This was apparently disabled before the MI_HATS_REPARIERT check was
removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday
something in the header inclusions changed to enable the DBG macros that
still used the removed stuff, but _only_ on Windows... now clean this up.
Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994
|
|
instead of creating with a blank name and changing it later
this way undo of a style creation is initialized with its name and so create a
style followed by deleting a style and undoing all those steps doesn't crash
Change-Id: Ida7a34410d5d7b05edcb86950aabb3c672b82c8f
|
|
These are internal constants, they don't need to be visible to the rest
of LO
Change-Id: I313def85b8c404948ec9ecb3996fed03b32ff9bf
|
|
Change-Id: I0c17f40b3e593ae3771fa751a817f84bf2f2323d
|
|
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c
Reviewed-on: https://gerrit.libreoffice.org/10347
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants
Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
|
|
Change-Id: I62127b23475dedf081fc981c20e916d5868ab086
|
|
and into a module-local header.
It's not like the methods have any actual relationship with the
SfxPoolItem class.
Change-Id: I1378364a1554642333b0c5c79d869d719b53fa0c
|
|
Change-Id: I57de8c0cebfd60fdf70c23c72ecf1e47c69d7ecd
|
|
Change-Id: I3cb720b62216f5534d0ff3b524c596158ffe824c
|
|
drop the ePresentation parameter, since all 4 of the callsites use
SFX_ITEM_PRESENTATION_COMPLETE as the parameter value,
and just inline the value into the method.
Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
|
|
Change-Id: I7cc9fa3ab6aebc541df4708e29b530f8021b14ba
|
|
so that we don't have to const-cast when modifying it
Change-Id: If584e4ddd440638169af00493f0194b34832177f
|
|
Change-Id: Ideb690df8a74efe55bff832e16e66a6b77b1530a
|
|
Change-Id: Idb20e9acd97a27801ff95dc53d3e179326c122d4
|
|
Change-Id: Ibf7b2f5e93748198eccbbbf54fad5f8053270003
|
|
since it is unused
Change-Id: Ib739240a362eeff6a72b2300804583b575edfb24
|
|
Change-Id: I4eade2d00d145d8f65ccd70a1c6bbd0a134a1ad5
Reviewed-on: https://gerrit.libreoffice.org/10346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I79c669c1635192199d6ef135e1ab9b48a9e7e63a
|
|
Change-Id: I0d3d1a14d8eb880a5a054fe2e736f8ac97f8b727
Reviewed-on: https://gerrit.libreoffice.org/10284
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
when calling SetAccessibleName GetAccessibleName is called
in order to send a name changed a11y event. Getting an Accessible
Name is very slow in a non-layout aware widget because it scans
for a "nearby" label and there is none in this widget, but it
has a huge pile of other widgets to iterate over.
call add_mnemonic_label before hand to cut off that entire
branch.
While we're at it, only call InitControl to adjust to a new
width if the new width is different from the old width
Change-Id: Ie4ba1276127226e49442278e46447b84bbeb1cde
|
|
Change-Id: Ie4cef54a943fc456b042425b53286492a0bed0be
|
|
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
|