summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2021-09-14tdf#142415 mouse events not propogated to table control event handlersCaolán McNamara1-0/+21
handle this with explicit callbacks from the cell widget for those events Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-13Related: tdf#144389: merge ThumbnailView and ThumbnailViewBaseCaolán McNamara2-26/+13
only ThumbnailView inherits directly from ThumbnailViewBase and it will simplify a11y if ThumbnailView instead of ThumbnailViewBase is available Change-Id: I715faa3f9b2cec68c1de07479b7d1dbbd9ddbcc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121848 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-13crashtesting: threaded scaling crash on re-export of ooo24840-1.sxw to odtCaolán McNamara2-11/+23
#13 0x00007f1cb843752a in o3tl::cow_wrapper<ImplBitmapPalette, o3tl::UnsafeRefCountingPolicy>::operator->() (this=0x5596086d5968) at include/o3tl/cow_wrapper.hxx:329 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)" #14 0x00007f1cb843752a in BitmapPalette::operator[](unsigned short) (this=0x5596086d5968, nIndex=nIndex@entry=0) at vcl/source/bitmap/bitmappalette.cxx:139 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)" #15 0x00007f1cb849f5f5 in BitmapInfoAccess::GetPaletteColor(unsigned short) const (nColor=0, this=0x5596085989f0) at include/vcl/BitmapInfoAccess.hxx:114 __PRETTY_FUNCTION__ = "const BitmapColor& BitmapInfoAccess::GetPaletteColor(sal_uInt16) const" the mpBuffer member of BitmapInfoAccess is BitmapBuffer* mpBuffer; not const BitmapBuffer* mpBuffer; so mpBuffer->maPalette.foo() calls non-const variants of foo(), (BitmapPalette::operator[](unsigned short) in this case), which is presumably non the expected outcome, as the copy-on-write mpImpl of BitmapPalette unsafely creates a new copy its internals on the first dereference of mpImpl in a non-const method. Change-Id: I1ebb3c67386a9028e5b8bab4b2d1cc5862700aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121888 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-09Resolves: tdf#144376 focus into protected ScTextWnd shouldn't be possibleCaolán McNamara1-0/+1
the expectations are that this isn't possible and if it happens then under windows there is a QueryCharPosition which will trigger the deletion of the ScTextWnd EditView due to that expectation before it is then unconditionally dereferenced Change-Id: Ied5d8031ae7d74669a2958dbcdec87843a26d384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121769 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-09tdf#142458 Set correct ScrolledWindow BorderWidth in the ctorCaolán McNamara1-2/+1
and keep it updated when the relevant properties that affect it change. This avoids the problem that the borderwidth can change during "Paint" (which is something we strongly want to avoid). a problem since: commit f39f21d92ec83c3a5062f29dd26214fc83012c06 Date: Thu Nov 19 11:51:13 2020 +0100 tdf#138010 (IV) VclScrolledWindow: Use actual border width and then remove the potential change of BorderWidth during paint Change-Id: I2ec317d86687fdb75e6323905f6d1c3b8fc655e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121557 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-09-08tdf#142129 vcl: add unit testMichael Stahl1-0/+1
Reportedly bug was fixed by commit 5fc6a601d7a1978db291fd0f7dcec638a7c25651 Change-Id: Iee32cacff0c939bdf498e9dc8102eb2d22a5a1c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121776 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 992f878e8c3424f7ce96a78ccf3a316b29ffd9ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121763 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-03tdf#142458 minimal width not including extra width needed by scrolledwindowCaolán McNamara1-0/+1
its only including the width of the panels and not the extra space possibly required by the container window. Which is 2x the m_nBorderWidth of 1pixel of VclScrolledWindow in this case. Change-Id: I56775c7183d7a8b87af263ddc8bb17373779e9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121290 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-02Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown()Eike Rathke1-3/+8
Calling SvNumberformat::GetThousandDivisorPrecision() for a "AA "General format resulted in 3000 as that was implemented for tdf#106253 without taking into account that ImpSvNumberformatInfo::nThousand may be abused under some conditions, which here is having FLAG_STANDARD_IN_FORMAT = 1000 as nThousand, multiplied by 3 gives 3000. Subtracted from the 0 precision gave -3000 decimals for which of course the new rounding produced 0 where it previously simply ignored the decimals and returned the original value. Change-Id: I66afaf1e2d8b2654d9f7cc8cfb66389357fb742d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121447 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 71b003a12f8afdff42a25786ad0a12ddd6609d59) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121459 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-01ofz#37796 limit to numeric_limits<int>::maxCaolán McNamara1-0/+4
Change-Id: I6e09226fad1e566ba2758d0084042b603b84d221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 72da4c623baf60eb2b7073697cd36ffb3022847d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121291 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-25tdf#128612: Support applying pattern fill from toolbarKatarina Behrens1-1/+2
List available pattern fills and add 'pattern' case to state and execute functions This is likely not perfect and there's still boatloads of code duplication that should be cleaned up eventually, but hey, it fixes the bug Change-Id: I3381a4271bb32a63c048cbecb0b54ebabe12ef51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119229 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit c1a8ff837e3e369561150c0022c6ab02aab27c2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120241 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25tdf#141097 Revert "Veto process exit while an OLE client is connected"Michael Warner1-8/+0
This reverts changes that were made to prevent process exit when an OLE client is connected. These commits had the side effect of preventing the use case of creating a document via OLE, and then allowing the user to view/edit and ultimately quit from the GUI. Revert "More hacks for quit requests from an OLE Automation client" This reverts commit 05e03911cd1f8a355b6410d3997cffc2c794a1e9. Revert "Veto process exit while an OLE client is connected" This reverts commit 89f883bd90a50587868a57397b6350ed9559a20f. Change-Id: I29a1e42a830815bc8d1ff0056c22d86b8f98cc1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118596 (cherry picked from commit 080e4550257a90597c241f83fd766b99c83ba6e8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120877 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25Resolves: tdf#143979 Write and read empty text element in number formatsEike Rathke2-1/+4
... as they may be significant as separators between keywords of same letters. Also strip trailing empty text as meaningless, except if the only element. >General;General< earlier both General were written as <number:number-style style:name="N111P0" style:volatile="true"> <number:number number:min-integer-digits="1"/> <number:text/> </number:number-style> for which now <number:text> is not. Change-Id: I4809b1c784667994303b49d8e4ab0e857367e2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120856 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit c6f15d228489ccfd0628ca80b45a5c2faaacc7d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120728 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-19tdf#143353 defer tip of the day until impress template dialog is goneCaolán McNamara1-0/+6
wait until that dialog is dismissed before showing the tip dialog Change-Id: Id0e7e28f09c5a9727e10eda55e468adb56bfda70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120677 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-17tdf#143357 use a DateFormatter and a separate Calendar menubuttonCaolán McNamara1-1/+3
similar to what we ended up with in DateControl in svtools/source/brwbox/ebbcontrols.cxx Change-Id: I37c843ff7e1e8e39b318db80fe590ce5f796f46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120453 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-12sw: use followby parameter of outline in Chapter fieldVasily Melenchuk1-0/+1
When Chapter field with format "Chapter number and name" is used it does not insert any delimiter between number and name. Best is to use outline/list property LabelFollowBy. But since it is done inside field we are limited with supported characters, so practically only space and nothing are correctly supported. Tab and newline are replaced by space. Change-Id: I4583b7051ae5ad963132980443fa70b5a19354e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119428 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit b67b3e2be0c80c3667ad2cb633e7e932d51d63a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120355
2021-08-10Resolves: tdf#143023 explicitly connect to ControlBase focus-[in/out]Caolán McNamara1-1/+8
instead of listening to the generic vcl::Window/Control focus events. The thing which really gets/loses focus is now a Widget hosted inside the ControlBase. also contains... fix comment Change-Id: Ia1783aff3fded7fd73de2b04b9aced647771a92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> establish that DbCellControl Window member is always a ControlBase and remove resulting known redundant dynamic_casting Change-Id: I5f098ef1adee3ad5d2a2bc5fcd30523f980df2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> EventWindow is always a svt::ControlBase Change-Id: I012d0bea687aa6d5965a4e2f6ce3899bfc629f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-09tdf#142915 PPTX import: support for presentation's timing attributeTibor Nagy1-0/+1
See Slide Show->Slide Show Settings...->Change slides manually, which is disabled by default. Now <p:showPr useTimings="false"> is imported correctly, i.e. with enabled "Change slides manually". Note: it seems, com::sun::star::presentation::IsAutomatic UNO attribute has got a bad name and documentation: if it's value is TRUE, "Change slides manually" is enabled, and vice versa. Check with the following Basic code: ' show presentation-level automatic transition (IsAutomatic = False) print ThisComponent.getPresentation().IsAutomatic ' show slide-level automatic transition (Change = 1) Dim oDrawPages as Object, oDrawPage as Object oDrawPages = ThisComponent.getDrawPages() oDrawPage = oDrawPages.getByIndex(0) print oDrawPage.Change Change-Id: Ie4a687a29077cad89f11e77b856c28a1fe09376b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119321 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f8ddaaf0f5e1fb61e0d4404ea28757bc652ae4be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120237 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-27tdf#143424: support for "Chapter number without separator"Vasily Melenchuk1-1/+1
If LO is using list format strings (this is default behavior since aa5c6d12) it was not able to show just numbering without all formatting, as it used in some fields. Change-Id: Ib4695b8e1c2d7a451522c7e04af2216d16aceefe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119309 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins (cherry picked from commit d44730148a95933f4a45a70241cb6d1d0546f626) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119440
2021-07-22tdf#143412 CRASH: converting imagesNoel Grandin1-1/+1
Revert "use unique_ptr in SdrEditView::ImpConvertOneObj" This reverts commit 2ec1dab4693cd45b475f02452114dd96ec0bda1b. I was wrong, we are no returning ownership here. Change-Id: Ib3b3b32248d4b56f0a48c658db5d6431b26fc352 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 58c6fad213024ef8f162984a66af565ac9ad4b97) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119260
2021-07-20tdf#123321 Fix DOC/DOCX export bug which made some lines disappearHossein1-0/+1
* Fix the wrong calculation of SdrPathObj (line) extent while exporting to .doc and .docx formats. This resolves tdf#123321 which cause some lines to disappear after save and reload. This fix does not break tdf#91687 * added tests to make sure this does not happen again, based on the .doc file provided in Bugzilla * Loading the bad exported file in MS Word is OK, but it does not work in LibreOffice, and some of the lines will be hidden. This needs additional work. The regression came from d72e0cadceb0b43928a9b4f18d75c9d5d30afdda Change-Id: Ic5a7af4d29df741204c50590728542e674ee9f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119116 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit bda4d7a7c3fcc259e023f568606be5dcba818db9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119185 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-19tdf#92796 ODF import: remove unused bitmap fillsMichael Stahl2-1/+15
With CWS impress64 a partial fix for this was implemented to drop unreferenced named items including all non-color fills after ODF import, but this is only done in sd so move the code that does that to svx and call it from sc and sw as well. Implement some UNO interface for this, it's at least better than a magic string, and not obvious how a better solution would look like since it's known only at the end of the import if a bitmap is used or not. Another problem: when the Area tab is used to change to a different kind of fill, the items with the details for the previous fill aren't cleared, and so they are written to ODF files. Hence bitmaps in the file can be referenced even if they aren't actually used, and bloat up the files. Fix this by dropping all unused draw:fill-image-name attributes in ODF import. Also do the same for Gradient and Hatch fills; Transparency gradients can be combined with anything so leave them as they are. Change-Id: I0b591fd9f963d974d0c3e7208b99621ad61dd93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118950 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 86c0f58b6f9f392865196606173d1b98a6897f32) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119036 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-07-15a11y crash on teardown of FmXGridPeerCaolán McNamara1-0/+2
the XAccessible is destroyed before the attempt to dispose via the IAccessibleBrowseBox* so call that first before the XAccessible is destroyed Change-Id: I908a3fbc05f92b5e56b8b6f2bc0b27757d39d1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118798 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-13tdf#143305 Remove remaining SID collision in .hrc filesHossein1-22/+21
There were some SID collisions in these files that should have been avoided: * include/sfx2/sfxsids.hrc * include/svx/svxids.hrc * include/editeng/editids.hrc This patch resolves this problem, filed as tdf#143305 Looking at b66d87086804460c1986df1b832fd6b2ea075a90 (2014-04-01) we read As commit 669ad519902e21e0cb3537fb7e203987f75a4077 (colliding SID_SVX_START based ids, 2013-06-24) suggests, new SID_SVX_START-based SID's shouldn't be added to include/editeng/editids.hrc. However, if it was done, at least add a comment about it to include/svx/svxids.hrc, so it becomes obvious that the two slots have the same ID. Also in include/sfx2/sfxsids.hrc:551 slot IDs from SVX (svxids.hrc) ------------------------------------ These SID_SVX_START entries came from include/svx/svxids.hrc, avoid accidentally colliding entries with include/svx/svxids.hrc and include/editeng/editids.hrc. Only add new SID_SVX_START entries to include/svx/svxids.hrc To make sure no collision is remaining, grep is used: git grep -h "SID_SVX_START[ ]*+" *.hrc | grep -Ev '^\s*\/\/' \ |awk -F\( {'print $2'} | awk -F\) {'print $1'} \ |awk '{gsub(/^ +| +$/,"")}1'|sort|uniq -c|grep " 2" It searches for 'SID_SVX_START +' in .hrc files, removes comments out of it, extracts the parts between paranthesis, trims spaces, sorts and then finds the number of unique occurances and looks for 2. Change-Id: Ife9b12c72ed5141a3404a291489dc1c11f4e967d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118544 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 04c7c90fe886c5fcebd52f727ff8b4edb840ad32) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118799 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-13Revert "flatten ValueSet item array"Caolán McNamara1-3/+5
I'm seeing a11y crashes in the impress slide transition ValueSet. The mxAcc member contains a ValueItemAcc which has a pointer back to the ValueSetItem so if its std::moved into another ValueSetItem then it continues to point to the older ValueSetItem and not the new one This reverts commit 30aa33e6a6b9fb230af96f619db27fcaf31ef914. Change-Id: I1fd81aa81e47f2e984dd47fdc8a905e25c9f6266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118728 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-12Resolves: tdf#123466 Add Microsoft ill-used {x-none} to known language tagsEike Rathke1-0/+1
'x-none' is a private-use tag and letting it escape into the wild isn't such a private use.. This just prevents the lt_string_value assertion that doesn't harm anyway but seems to confuse people and makes the tag known to LibreOffice with a reproducible assigned LCID instead of an on-the-fly generated one. Whatever it may take to actually support something tagged with 'x-none'. Change-Id: I3f32c9ba18a2528584a112157509c1dfda75e29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118788 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4e0a7df2dfa10bc52d5dbda34f43e0bc0df22ae7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118794 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-07-12editengine-columns: tdf#143258 Fix handling rotated textMike Kaganski1-0/+3
This reverts modifications to existing unit tests made in commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5. My idea that those changes were required because of more correct calculations was wrong, and in fact they were caused by off-by-1 error in height calculations. Change-Id: Ib94878a911238c977c35a8f8e3e5694cedc79a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118705 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118711 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-08Resolves: tdf#122191 BOOLEAN is a keyword, treat it as suchEike Rathke3-4/+5
... to not end up with "BOOL"E"AN" instead, which is a date type with an era year and literal strings. This never worked but only was uncovered by commit ce4fc2fc08be8ea2773194e303ed42d2579e93a0 CommitDate: Fri Mar 2 20:27:45 2018 +0100 Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean if the format also had to be converted between locales. Also preserve boolean equivalent formats during Excel export and try hard to convert back as much as possible if a literal boolean string format is a Boolean equivalent of the target locale. Change-Id: I54f65c276cbf7bb99e960b6d7053c5fa95fbccb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118591 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7a58221f800e215934cbcb2d3907c35b44981611) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118510 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-07tdf#143204 svx: fix SID_ATTR_TEXTCOLUMNS_SPACING SID collisionHossein1-2/+2
These two SIDs have the same ID, which is fixed now: * include/sfx2/sfxsids.hrc: #define SID_NOTEBOOKBAR (SID_SVX_START + 338) * include/svx/svxids.hrc: #define SID_ATTR_TEXTCOLUMNS_SPACING ( SID_SVX_START + 338 ) The symptom tdf#143204 is that the tabbed interface was hidden in Impress or Draw, which is now fixed. Looking at b66d87086804460c1986df1b832fd6b2ea075a90 (2014-04-01) we read: As commit 669ad519902e21e0cb3537fb7e203987f75a4077 (colliding SID_SVX_START based ids, 2013-06-24) suggests, new SID_SVX_START-based SID's shouldn't be added to include/editeng/editids.hrc. However, if it was done, at least add a comment about it to include/svx/svxids.hrc, so it becomes obvious that the two slots have the same ID. Also in include/sfx2/sfxsids.hrc:551 slot IDs from SVX (svxids.hrc) ------------------------------------ These SID_SVX_START entries came from include/svx/svxids.hrc, avoid accidentally colliding entries with include/svx/svxids.hrc and include/editeng/editids.hrc. Only add new SID_SVX_START entries to include/svx/svxids.hrc Change-Id: I5e8c14bdbaa72f1b030a686dd5fffc9ae8dd1306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118459 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8ea9a8bc43ea054521a44dc8e3bc537110ca9e33) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118504 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-07tdf#139301 tdf#141933 (related) Translate new preset dash namesGabor Kelemen1-3/+13
Change-Id: I9cd7ad0eca1a6fb471a284fb2828a7ad12816337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117024 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8b3ff370ab0fe2e7593a69513c8ff3df35810c4e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118107 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-07-06Related: tdf#125035 Introduce LongDateOrder and handle YDM in DateFormatterEike Rathke1-3/+11
This fixes also unotools/source/i18n/localedatawrapper.cxx:1473: LocaleDataWrapper::scanDateOrder: no magic applicable lv-LV requested lv-LV loaded that is the only locale with a YDM long date order. Change-Id: I776b8706bf5bd3ec11cc46d38fd3613c8df7519f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118482 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5e3bfdeb5ea4878a2546a7e1e16d0f3b6482024e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118520
2021-07-06Remove now unused LocaleDataWrapper::getLongDate()Eike Rathke1-11/+0
Change-Id: I8e9614a4d77aa8b0c0e68a248ea57f921e3ed424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6e0b7d2aad6f1a041dd9e0e28aa4bf27eb3fc077) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118519
2021-07-05Pass Formatter::StaticFormatter also from weld:DateFormatter, tdf#125035Eike Rathke1-1/+1
Change-Id: I8e6b0e581b9522fb04225fc945e579406a4be208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118438 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0335a319c5662f0b849a2231e48338dfeb6aa845) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118427
2021-07-05Resolves: tdf#125035 Use number formatter for long date in DateFormatter fieldsEike Rathke2-3/+5
Change-Id: Ib0cd55d9ad4e3abb4839d70c0086063a3f1a90f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118344 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2cc8ec691cc37b07e4f134bf379164f375b8a481) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118310
2021-07-03tdf#143176 Old Hungarian transliteration: fix AutoCorrect->ApplyLászló Németh1-1/+2
and "Apply and Edit Changes". Transliteration worked only during typing, because AutoCorrect->Apply and "Apply and Edit Changes" remove right-to-left text direction silently, which resulted missing transliteration of text (with Default Paragraph Style and right-to-left direction) to Old Hungarian. Change-Id: I1481d958494828b6dce66f2eeecb44b327c70db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118346 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f5ff7a967b09a715c56630aff92cfb636e7c232b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118305
2021-07-02tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc.Attila Bakos (NISZ)1-3/+3
Regression from commit 63cd67e5e18f01aca303131e148c80398a181a41 (tdf#92525 tdf#142398: fix export of simple custom shapes) Missing property in the shape export property list caused an exception. The return value false led to writing the shape transformation again, resulting a corrupt DOCX file. Optional values have been introduced and if one of the required value is unset, writing of the transformation happens only once. Thanks to Regina Henschel for reporting the problem. (cherry-picked from commit 99a459dfdfd9f82ed3506708e131dd52a1a62384 "tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc." and commit e190196f255b7d0147d61fd967a2b2a61a932185 "tdf#143028 DOCX export: fix RangeY regression of preset shapes") Change-Id: Ifcb81a5df9dc568f8f21c39e072d58009ed04237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118232 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-02tdf#143149 fix crash if app exits while print progress is runningCaolán McNamara1-1/+3
dismiss the dialog if its parent goes away, but leave the print job running Change-Id: Ic29ee0300a7d9476ad27a2594a555312e30c74f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118253 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30editengine-columns: add sidebar property panelMike Kaganski1-0/+3
Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit dd5bf12193471f064bf7f581dd1b21783390e735) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117217
2021-06-29tdf#142913 PPTX: slideshow setting “Start from” not importedTibor Nagy1-0/+1
Note: see Slide Show->Slide Show Settings...->Range->From: on the UI, or press Shift-F5 after loading the unit test document sd/qa/unit/data/pptx/tdf142913.pptx. Change-Id: I2e10a4353c26600bf405475cb89990413c81dc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117705 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 3d55149dcf19cffefcc19c16a3abbe8851453c5e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118062 Tested-by: Jenkins
2021-06-29new ODF numbered list parameter loext:num-list-formatVasily Melenchuk2-1/+4
Instead of style:num-prefix and style:num-suffix new list format is much more flexible for storing list multilevel numberings. Now it is possible to have not just prefix/suffix but any random separators between levels, arbitrary levels order, etc. Internal LO format for list format is changed: instead of placeholders like %1, %2, etc we right now use %1%, %2%... Reason: for ODT documents, having more than 9 levels there is ambiguity in "%10": it is "%1" followed by "0" suffix, or "%10"? Aux changes: * removed zero width space hack: since format string is always defined this hack is interfering with standard list numbers printing (see changes in ooxmlexport14.cxx, ww8export3.cxx tests) * changed cross-references values to lists: they are now including full list label string: previously this was bit self-contradictory (see changes in odfexport.cxx and check_cross_references.py tests) Conflicts: sw/qa/extras/odfexport/odfexport.cxx Change-Id: I9696cc4846375c5f6222539aeaadbca5ae58ce27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118040 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-06-25tdf#135316 add SvFileStream::SetDontFlushOnCloseNoel Grandin1-1/+3
if we're going to be deleting a temporary file, there is no point flushing it on close, which has a measureable cost This takes my load time from 17s to 16s Change-Id: I2fce7eeaf0ce9fef826b4ce9a1a4d4c8114cac76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9815bf197c27afdfeccf967898c3a000bcf7b256) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117731
2021-06-24tdf#92525 tdf#142398: fix export of simple custom shapesAttila Bakos (NISZ)1-0/+138
Most of the custom shapes were exported with DrawingML custom geometry instead of DOCX preset shapes, losing their preset type, adjust handles and text position. Add a preset exporter class to handle all possible preset shapes later, and fix the export of the following shapes now: "bevel", "blockArc", "bracePair", "bracketPair", "hexagon", "octagon", "parallelogram", "plus", "roundRect" and "triangle". tdf#92525: keep text position in triangles with different adjustments, too. tdf#142398: part 1: export simple shapes as preset shapes. Change-Id: I6aee74f7670bea8c1fe5909cbf307778ea728669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115606 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 63cd67e5e18f01aca303131e148c80398a181a41) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117715 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-21tdf#142590 PPTX import: fix custom slide show use as defaultTibor Nagy1-0/+1
If the PPTX file contains a custom slideshow, which set by default and opening in Impress, this setting wasn't imported. See also commit 312334f8488a668e9b5302959b60292ce151e4fc "tdf#47365 PPTX export: support loop attribute" and commit a4b66458a7b8da2f5580014813e5dabe3fa670b6 "tdf#125071 PPTX: fix missing custom slide show export". Change-Id: I9c2b3773f6883ee795f119df5b8534fcdfa6618f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117172 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8bf44b9cdceb7926fe52ef0bd4a38af24e7c700a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117562 Tested-by: Jenkins
2021-06-21fix loading calc files with embedded form macrosNoel Grandin1-1/+4
GraphicHelper was trying to use the current frame/ window to convert values, but during initial load there is no current window. Change-Id: I8a79501df1d2e83a13d3cfb64ae8e66152c60561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8fa14ac550ddc43790b65858f18d23f522aff1f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117553
2021-06-17tdf#90401 xmloff: remove personal info of comments and changesLászló Németh2-0/+18
If Options → LibreOffice → Security → Security Options and Warnings → Options... → Security Options → Remove personal information on saving" is enabled. Use the same time (1970-01-01T00:00:00) for mandatory time stamps, and replace authors and creator-initials with "1", "2", "3" etc., also to avoid of joining adjacent redline ranges. Note: to see the work of the unit test in Linux command line: (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen) Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 12da70f88517bf3c053afe1c504bb70bd27573f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117301 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-06-16sw HTML export: allow larger bitmaps for shapes than the vcl defaultMiklos Vajna1-1/+1
VCL default would be 500k pixels, i.e. a 2" x 1" shape at 600 dpi would be already truncated from 1200 pixels width to 1000 pixels. That's a bit too extreme, use a larger limit in the sw HTML export. Change-Id: I52b85d77cd27410d53c700a89190c99348de5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117287 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 3c46fd3d727e4885fedef7c9f3fcd6f4c9a9ebb9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117296
2021-06-14Workaround internal compiler error on tb77Mike Kaganski1-18/+0
As reported in https://ci.libreoffice.org/job/gerrit_windows/98360/console : C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2639): fatal error C1001: Internal compiler error. (compiler file 'msc1.cpp', line 1591) To work around this problem, try simplifying or changing the program near the locations listed above. If possible please provide a repro here: https://developercommunity.visualstudio.com Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2631): note: while evaluating constexpr function 'svl::ItemsArray' INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1427~1.291\bin\Hostx64\x86\cl.exe' Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information tb77 uses VS 16.7.7 (cl.exe is under Tools/MSVC/14.27.29110); tb68 with cl.exe under Tools/MSVC/14.28.29910 has no problems compiling this. Let's make the code simple for now, until we upgrade the tooling on CI. Change-Id: I10aaf289454c89b2f49b4be947627a9a3be30fde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117137 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 90cb57eb53e28ecb983001bf8f018577abb6d145) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117118 Tested-by: Jenkins
2021-06-14Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski1-4/+35
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8aaa28ed43978a9a4a20d62368410a57ec05c23f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117114
2021-06-11MetaAction::Clone() -> constLuboš Luňák1-54/+54
Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-11loplugin:unnecessaryreturn in SvxColorValueSet::layoutToGivenHeightNoel Grandin1-1/+1
Change-Id: Ia42158597588fe802a2f06a6e8e59f372c62c022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11"drawinglayer" -> "drawinglayer.emf" log area for some emf codeLuboš Luňák1-0/+1
Change-Id: I83fa2d40225f83b82cea7f8934f4afdee181abe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117000 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-27 00:02:20 +0000