summaryrefslogtreecommitdiff
path: root/include/vcl/layout.hxx
AgeCommit message (Collapse)AuthorFilesLines
2024-01-29tdf#143148 use pragma once instead of include guardsKeldin Maldonado (KNM)1-4/+1
Change-Id: I42c39d991d243191f410ebb8f91940d5922a6fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162678 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-12-16cid#1545970 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1545957 COPY_INSTEAD_OF_MOVE cid#1545944 COPY_INSTEAD_OF_MOVE cid#1545939 COPY_INSTEAD_OF_MOVE cid#1545931 COPY_INSTEAD_OF_MOVE cid#1545926 COPY_INSTEAD_OF_MOVE cid#1545909 COPY_INSTEAD_OF_MOVE cid#1545899 COPY_INSTEAD_OF_MOVE cid#1545896 COPY_INSTEAD_OF_MOVE cid#1545894 COPY_INSTEAD_OF_MOVE cid#1545858 COPY_INSTEAD_OF_MOVE cid#1545823 COPY_INSTEAD_OF_MOVE cid#1545820 COPY_INSTEAD_OF_MOVE cid#1545819 COPY_INSTEAD_OF_MOVE cid#1545772 COPY_INSTEAD_OF_MOVE cid#1545749 COPY_INSTEAD_OF_MOVE cid#1545743 COPY_INSTEAD_OF_MOVE cid#1545739 COPY_INSTEAD_OF_MOVE cid#1545635 COPY_INSTEAD_OF_MOVE cid#1545603 COPY_INSTEAD_OF_MOVE cid#1545602 COPY_INSTEAD_OF_MOVE cid#1545592 COPY_INSTEAD_OF_MOVE cid#1545544 COPY_INSTEAD_OF_MOVE cid#1545532 COPY_INSTEAD_OF_MOVE cid#1545520 COPY_INSTEAD_OF_MOVE cid#1545512 COPY_INSTEAD_OF_MOVE cid#1545490 COPY_INSTEAD_OF_MOVE cid#1545483 COPY_INSTEAD_OF_MOVE cid#1545467 COPY_INSTEAD_OF_MOVE cid#1545461 COPY_INSTEAD_OF_MOVE cid#1545458 COPY_INSTEAD_OF_MOVE cid#1545428 COPY_INSTEAD_OF_MOVE cid#1545394 COPY_INSTEAD_OF_MOVE cid#1545385 COPY_INSTEAD_OF_MOVE cid#1545383 COPY_INSTEAD_OF_MOVE cid#1545366 COPY_INSTEAD_OF_MOVE cid#1545357 COPY_INSTEAD_OF_MOVE Change-Id: I76224326977b4067b94ca3176cad1ca6de17930a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-04-06jsdialog: implemented mouse events for drawingareaSzymon Kłos1-5/+5
Change-Id: Ieab3d9fdbcee90ccd125e84f74c06cd1d6711a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149953 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150057 Tested-by: Jenkins
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski1-6/+6
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-21jsdialog: dump properties of scrolled windowSzymon Kłos1-0/+1
Change-Id: Id6d072e951efec4c1de7641c94017c82840fa50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148609 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149190 Tested-by: Jenkins
2022-04-01uitest: add wrapper for VclExpanderXisco Fauli1-0/+1
Change-Id: I725c51fdddea9da9aa79d166d747261e80ca9376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132416 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-07Related: tdf#142458 don't change border size during PaintCaolán McNamara1-2/+0
so GetOptimalSize/get_preferred_size before/after paint has the same result Change-Id: I25abe31c069561e30a9af7c4b9b81582298e0f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121616 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03tdf#142458 Set correct ScrolledWindow BorderWidth in the ctorCaolán McNamara1-0/+1
and keep it updated when the relevant properties that affect it change. This avoids the problem that the borderwidth can change during "Paint" (which is something we strongly want to avoid) since... since: commit f39f21d92ec83c3a5062f29dd26214fc83012c06 Date: Thu Nov 19 11:51:13 2020 +0100 tdf#138010 (IV) VclScrolledWindow: Use actual border width hopefully after this we can then double-check to see if we can remove the potential change of BorderWidth during paint. Change-Id: I2ec317d86687fdb75e6323905f6d1c3b8fc655e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05move RequestHelp into layout.cxxCaolán McNamara1-21/+2
Change-Id: I6b0642a77ffd247f9a77d5a4bdd0b593025a7797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-19loplugin:finalclassesNoel Grandin1-1/+1
improve the plugin to detect more cases. I only apply the new final changes to classes in /include here. Which reveals that RoadmapWizard::getPageController( TabPage* _pCurrentPage ) will always return nullptr Also needed to sprinkle some SAL_DLLPUBLIC_TEMPLATE around to workaround Visual Studio linking problems. Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-13make some classes privateNoel Grandin1-1/+1
Change-Id: I14b2c27a99e76b1141c7a7bd3d0edaf57737bee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-16jsdialog: uitest: handle click for drawing areaSzymon Kłos1-6/+1
Change-Id: I5ea78697b87f4b2a468f8507470b62031bee4aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113524 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114202 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-06remove support for deprecated GtkAlignmentCaolán McNamara1-22/+0
Change-Id: I29e21e9e4d9b80b8c8e331ed9cce76b2e7fe0f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29jsdialog: export alignment typeSzymon Kłos1-0/+1
Change-Id: I846f51d522fb0639b22148c73563b177d091178c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107589 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108412 Tested-by: Jenkins
2020-12-28jsdialog: dump buttonbox propertiesSzymon Kłos1-0/+1
Change-Id: I638169db902961cff58a415b009f7412cd8b274a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107449 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108395 Tested-by: Jenkins
2020-11-26jsdialog: dump VclExpander typeSzymon Kłos1-0/+1
Change-Id: Ie40632ab8ce53e0b1f9277dce3d46032a508edce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106663 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-19tdf#138010 (IV) VclScrolledWindow: Use actual border widthMichael Weghorn1-1/+3
The frame drawn by 'DecorationView::DrawFrame' may use native drawing, in which case the frame may be wider than 1 pixel. Take that into account and calculate the frame width and resulting position/size of the scrollbars and child widget using the content rectangle returned when drawing the frame using 'DecorationView::DrawFrame'. This avoids that the child widget is drawn on top of the frame, which e.g. resulted in no visible border when using the Qt/KDE Breeze style, which has a frame width of 2, with the actual 1 pixel border being surrounded by a 1 pixel padding/margin, and the content being drawn on top of the 1 pixel border. With the child widget being drawn on top of the actual border, only the invisible padding was left where a visible border was expected. (The current implementation assumes that the same frame width is used on all sides, which matches the way Qt styles handle it, but could be further extended if necessary.) Change-Id: I44268728838406fc578774c0f4fcc167fb2798b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106157 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-11-19tdf#138010 (III) Extract VclScrolledWindow border width to varMichael Weghorn1-0/+1
commit 1fe4a1a76da8fd3c196ccd9529b01ee093516b25 Date: Fri Mar 30 13:30:38 2018 +0100 draw a border around scrolled window had added a 1 pixel border for scrolled windows. Extract the value for the border width (currently hard-coded to 1) to a variable. This will be extended to take into account the actual width of natively drawn frames in a follow-up commit. Change-Id: I2503105c42fae9eae66ec931d54c9d6883f83bf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106156 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-11-11support getting Expander's labelCaolán McNamara1-0/+1
Change-Id: Ibd3fe335e645895eedb6330cfc98590ad3c31fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10allow VclBuilder to set expander label attributesCaolán McNamara1-0/+2
Change-Id: I0b78db778d230509e6bbb59d965540a5f5d6f3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-28convert some more long -> tools::LongNoel1-2/+2
grepping for stuff in template params this time Change-Id: Ia37bfd85480b3a72c3c465489581d56ad8dde851 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-27Resolves: tdf#137620 add DeleteSurroundingText at vcl::Window levelCaolán McNamara1-0/+6
a) give it a default implementation based on the current one b) re-use code introduced for WeldEditView::DeleteSurroundingText for the EditView containing vcl::Window in impress/draw and various similar Annotation windows Change-Id: I55547c70e90ee394795b5545450cf8131538fad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-19use tools::Long in vclNoel1-38/+38
Change-Id: Ice1055021e8568634e9a66ba89d3bb4ef4e731df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel1-2/+2
Change-Id: If7fbb25037343e18081a8ee7064840d75e9a45a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104010 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02tdf#134566 gtk IM support for custom widgetsCaolán McNamara1-0/+7
Change-Id: I5c731161768d09d021db5c353de816e173159096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-01vcl: remove duplicate forwardThorsten Behrens1-1/+0
Change-Id: Id6021cae4bbde8e420ee82e311f4221e49199ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103716 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-27use monoborder widget css name as a WindowBorderStyle::MONO replacementCaolán McNamara1-0/+1
Change-Id: I563f917c741130909a9d726754cd3eb23a651a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen1-5/+0
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-08drop WB_BORDER if the border style is invisibleCaolán McNamara1-0/+1
Change-Id: Ie88818cb2b61d411f868f748d6a7c2fdf8028e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29jsdialog: click action for drawing areaSzymon Kłos1-10/+10
Change-Id: I2434bec675559a97e5d251c6d6a958464b6db034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96853 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97395 Tested-by: Jenkins
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin1-4/+4
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24Move DumpAsPropertyTree code to cxx fileSzymon Kłos1-20/+1
Change-Id: Ib450c860aa11f0e8be933de4c6e216ca9c0d0b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24jsdialog: generate JSON for drawing areaSzymon Kłos1-0/+25
Change-Id: Ic9402f0f7c891868790b657cd7e9860e46f3e8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96852 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96985 Tested-by: Jenkins
2020-06-01allow sorting buttons via weld::BoxCaolán McNamara1-1/+7
Change-Id: I315fe2dd2e40c976edd802c1e87b7ccdb0c298fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12make VclPaned::set_position take effectCaolán McNamara1-1/+3
Change-Id: Id4ae096b413196cfb7118cd3a09a3f0a6c333f01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22typeinfo for VclGrid still needed with --enable-mergelibsStephan Bergmann1-1/+1
...for the dynamic_casts in SAL_WARN_IF and assertin VclBuilder::get, > LNK] Library/libbiblo.so > include/vcl/builder.hxx:430: error: undefined reference to 'typeinfo for VclGrid' > include/vcl/builder.hxx:430: error: undefined reference to 'typeinfo for VclGrid' > include/vcl/builder.hxx:433: error: undefined reference to 'typeinfo for VclGrid' > collect2: error: ld returned 1 exit status > make[1]: *** [extensions/Library_bib.mk:12: instdir/program/libbiblo.so] Error 1 (see e.g., <https://ci.libreoffice.org/job/lo_tb_random_config_linux/2358/>). Broken with 01159643623de55f9e1de84d568032ca919dbd8f "make more classes private in mergedlibs mode". Change-Id: Ic20abe22b52026907a5624993008e497b173d14c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-23make more classes private in mergedlibs modeNoel Grandin1-3/+4
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara1-4/+10
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-02don't include vcl/button.hxx from vcl/layout.hxxCaolán McNamara1-22/+8
Change-Id: I16a1b392c33734ef89f26e7ff9318573e9bfce88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21weld gallery panelCaolán McNamara1-0/+17
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04honour GtkScrolledWindow shadow-typeCaolán McNamara1-0/+1
Change-Id: If6cc9f9f6c310261d783f2698b86329aa2a12c5a Reviewed-on: https://gerrit.libreoffice.org/84401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15make some classes module-privateNoel Grandin1-9/+9
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5 Reviewed-on: https://gerrit.libreoffice.org/82116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-13Resolves: tdf#128758 scrollbars added during scrolledwindow layoutCaolán McNamara1-0/+1
Change-Id: I1eee32278f6b46ff4f0447eb39543836c3d687f0 Reviewed-on: https://gerrit.libreoffice.org/82589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-03find symbols that can be privateNoel Grandin1-5/+5
update the script and make private standalone functions Change-Id: Icb26ce258107700c90f89ad4e0d3329d075a2eb1 Reviewed-on: https://gerrit.libreoffice.org/81879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-31loplugin:finalclasses in vclNoel Grandin1-20/+16
Change-Id: Id6dd59d0a335d84c513059ed7870135cf9959af8 Reviewed-on: https://gerrit.libreoffice.org/81827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24create a VclHPanedCaolán McNamara1-6/+27
Change-Id: Iec1076cdca03fe75ad832c0b9f8133ee4276dd6f Reviewed-on: https://gerrit.libreoffice.org/81444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08implement gtk dialog screenshottingCaolán McNamara1-1/+1
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02extend popup handler to cover all CommandEventsCaolán McNamara1-4/+4
Change-Id: I26360ce5c696d0e571385d83a15876eb2286e12f Reviewed-on: https://gerrit.libreoffice.org/80021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01jsdialogs: set frame as a separate typeSzymon Kłos1-0/+1
Change-Id: I7f56d49dbe3b403c3716798bb52691748974aaae Reviewed-on: https://gerrit.libreoffice.org/79801 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01jsdialogs: export vertical property for BoxesSzymon Kłos1-0/+1
Change-Id: I377638b0e9c5575e41ea3f3714541cc94f61a92b Reviewed-on: https://gerrit.libreoffice.org/79798 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>