summaryrefslogtreecommitdiff
path: root/include/vbahelper
AgeCommit message (Collapse)AuthorFilesLines
2017-12-05loplugin: unnecessary destructor vbahelper..vclNoel Grandin6-6/+0
Reviewed-on: https://gerrit.libreoffice.org/33577 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 32a461bdd6ffda4b59ff262e1fcbcbe8bf2be7a0) Change-Id: I6b7800d4a456391251168f7923a1ec7a5ca9efc9 (cherry picked from commit 6a734daa02e7d816bf924465e53765b811a517d5)
2016-11-07loplugin:unnecessaryvirtual in test..vbahelperNoel Grandin1-1/+1
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-25loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin1-2/+0
Change-Id: I7e607df2a1f6d4eb207ee0d3eb30f41fac44a0c6 Reviewed-on: https://gerrit.libreoffice.org/30262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin1-2/+0
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:dllprivateStephan Bergmann1-5/+5
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann12-12/+12
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-01loplugin:countusersofdefaultparamsNoel Grandin1-1/+1
Change-Id: Icfc2fdde493619fefaf6119d366f8f7166b3ff36 Reviewed-on: https://gerrit.libreoffice.org/28547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin2-2/+2
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann3-3/+3
Change-Id: I1d02b91f908c744dd3f7664cd453a791da7bd675
2016-06-13tdf#42949: clean up includes in include/vbahelper with iwyuJorenz Paragas21-74/+400
Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38 Reviewed-on: https://gerrit.libreoffice.org/26206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-26loplugin:unusedmethodsNoel Grandin3-26/+0
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifierStephan Bergmann1-1/+1
Change-Id: Iefea30eb0db96462aee87349968baf4756e1b786
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-2/+2
Change-Id: I94b3d976bd6d4cd3ce918668a5a921857675b6c9
2016-04-14loplugin:passstuffbyref in vbahelperNoel Grandin1-1/+1
Change-Id: I09e6ea5cbab5b06dd284a096503b19c15b2136ce
2016-04-11clang-tidy performance-unnecessary-value-param in vbahelperNoel Grandin1-2/+2
Change-Id: Ifbe78c4a43b9d77d6ecf481bb1a9aaac6bcd01a6
2016-03-14inline some use-once macrosNoel Grandin1-29/+14
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard1-1/+1
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-26loplugin:unuseddefaultparam in include/vbahelperNoel Grandin1-3/+3
Change-Id: Idac2134dce40a54cc04f595464357a0f9ca71be0
2016-02-09Remove excess newlinesChris Sherlock3-13/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-23loplugin:unusedfields in /includeNoel Grandin1-8/+2
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-11-17use unique_ptr for pImpl in vcl,vbahelper,uuiNoel Grandin1-1/+2
Change-Id: Icb7573c24c681a8fc0570d61b6a30dab91378eb8
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-1/+1
Change-Id: I6eb8949e3e14d82b52af9a2ba26d67bf1bd8e1a5
2015-10-27loplugin:unusedmethodsNoel Grandin1-3/+3
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23com::sun::star->css in include/ucbhelper to include/xmlscriptNoel Grandin2-3/+3
Change-Id: Iaa7f0b8455a601d3992c08cde0943c709c417256
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann18-245/+245
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06vba: convert to variadic InheritedHelperInterfaceImpl&WeakImpl etcDouglas Mencken15-72/+40
Variadic templates ~-i.e. templates, which can take an arbitrary number of arguments of any type-~ is new C++11 feature note that uno::Reference and cppu::UnoType can only take one parameter thus leave XNamedObjectCollectionHelper non-variadic in vbacollectionimpl.hxx Change-Id: I22e60fa050ee31d39ae8bb7cac06cf243c4587b1 Reviewed-on: https://gerrit.libreoffice.org/19145 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann1-1/+1
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-21loplugin:unusedmethods vbahelperNoel Grandin2-2/+0
Change-Id: Ia04e2682e3bd05591b67b9fe15557ce8c0e7939e Reviewed-on: https://gerrit.libreoffice.org/17234 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02some other coverity thingsCaolán McNamara1-1/+1
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02coverity#1309054 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I81c8983a981e1dfeff17f62c852163e6290dceb4
2015-06-27coverity#1308448 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: Ib6e994cc89ddfaf504f5b585127d5ea4fb257458
2015-05-22convert POINTER constants to scoped enumNoel Grandin1-1/+1
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-08fix shadow errorNoel Grandin1-23/+23
introduced by my commit 216fdcbdb4c17f349ffd68abd1f372bea3287fad "convert RECALCMODE_ constants to scoped enum" Change-Id: Ie7db053741205faeac70e3d21757774567f43ce0
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann1-3/+7
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-06V801: Decreased performanceCaolán McNamara2-2/+2
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
2015-03-04V813: Decreased performanceCaolán McNamara1-2/+2
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin4-6/+6
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara1-3/+3
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini1-1/+1
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin1-1/+1
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10cid#1244949 Uncaught exceptionNoel Grandin1-1/+1
Change-Id: Ic33d60a435ee875e8e342420046aae436739c123
2014-09-29vbahelper: std::auto_ptr -> std::unique_ptrStephan Bergmann2-4/+2
Change-Id: Ic1b28e7f79cc7dad6a045eb64e5191991533990d
2014-09-15scripting: sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: I3b2d410dfdd9bc779e7f1f1674fb6fc8b74a42c2
2014-09-15Mark template member fns that are supposed to override as SAL_OVERRIDEStephan Bergmann1-6/+6
Change-Id: I712f352635a2e258bfaf60dc30ed764666a51f15
2014-09-15Mark template member fns that are supposed to override as SAL_OVERRIDEStephan Bergmann1-6/+6
Change-Id: Ifb5798a9f01961dd916857a0dca44a3fd8587ec4
2014-07-22callcatcher: update unused codeCaolán McNamara1-3/+0
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-18some other coverity fooCaolán McNamara1-2/+2
Change-Id: Ide5a10d7f9c45970c3cc5c78213c151c85ff4570
2014-07-10coverity#707480 Uncaught exceptionCaolán McNamara1-1/+2
Change-Id: I27732316c42face6750ffb7eccc238f66519e4e6
2014-07-09coverity#707382 Uncaught exceptionCaolán McNamara1-3/+10
and coverity#707383 Uncaught exception coverity#707384 Uncaught exception coverity#707385 Uncaught exception coverity#707386 Uncaught exception coverity#707387 Uncaught exception coverity#707388 Uncaught exception coverity#707389 Uncaught exception coverity#707390 Uncaught exception coverity#707391 Uncaught exception coverity#707409 Uncaught exception coverity#707411 Uncaught exception coverity#707413 Uncaught exception coverity#707414 Uncaught exception coverity#706919 Uncaught exception coverity#706920 Uncaught exception coverity#706933 Uncaught exception coverity#706935 Uncaught exception coverity#706968 Uncaught exception coverity#706970 Uncaught exception coverity#706973 Uncaught exception coverity#706974 Uncaught exception coverity#707032 Uncaught exception coverity#707044 Uncaught exception coverity#738455 Uncaught exception coverity#738456 Uncaught exception Change-Id: Ifd4c0a2b6b4ddcb5df01a951b8d56435ee32d754
2014-07-03coverity#707193 Uncaught exceptionCaolán McNamara1-1/+4
Change-Id: Ie3e6bc593365311bfe80972b26d1189acbb6afcb