Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
|
|
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.
Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
|
|
...given that vnd.sun.star.wfs is long gone. Note that the old code could have
behaved differently in that for one it could have worked for relative URL input
(as osl_getSystemPathFromFileURL is allowed to accept relative URLs) and for
another could have failed for some file URLs (for which
osl_getSystemPathFromFileURL would return something other than osl_File_E_None
for whatever reason), but it looks plausible to assume that what the call sites
are really interested in is whether a given URL is a file URL.
Simplifies those call sites that already have a INetURLObject instance even
further.
Change-Id: Iaee4595d933a760b8321e42414a9ef0865311833
|
|
Change-Id: I08021f18d53e1748927f8847649994f95252bbc2
Reviewed-on: https://gerrit.libreoffice.org/17844
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1c60c60f9b5318626f42e33091920a4404fb6d1c
|
|
Change-Id: I7dc0e1b596f80b8f0870aed1722f711bb287ec0a
|
|
Change-Id: I02cacfeaf26788ed024fa9753af132f0d5822e6f
|
|
vnd.sun.star.wfs is long gone---or what else could this have been used for?
Change-Id: If39c9bdcb983f94206e0f58b7e1e8410fdcef089
|
|
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Changes done to the code in framework, comphelper and unotools,
in no particular order
- add an interaction handler dedicated to WebDAV
The stock interaction handler can be missing depending on the need of
the framework performing its tasks, so a dedicated handler is
provided, this one is always present.
- force opening of a WebDAV file.
A WebDAV file sould be open r/o even if explicitly requested to open
as r/w.
This is a limitation of current WebDAV implementation, not of the
standard.
This change is needed in order to reopen correctly a file as
requested by a 'Edit Mode' GUI command.
Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082
Reviewed-on: https://gerrit.libreoffice.org/17182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
not used anymore
Change-Id: Ib9436ea0cafef29ed7da5076e89d97419a9c7443
Reviewed-on: https://gerrit.libreoffice.org/17147
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I48d51cd24831072af647dd0172a2fd2e4a9ed2a5
|
|
Change-Id: Ieb73b50471263212285b9c3883c082477c1ad656
Reviewed-on: https://gerrit.libreoffice.org/16729
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2.
We need to consider 2 use-cases:
1. Protecting an existing document with a password (by overwriting
the original file). In this case we don't want to generate a
thumbnail from the now encrypted file, but we do want to erase
the stored thumbnail and show a generic icon instead.
2. Closing a modified document without saving the changes. Here we
don't want to generate a thumbnail either, because it may
contain the unsaved changes, but either we don't want to replace
the stored thumbnail, because most likely it correctly represents
the last saved state of the document.
Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826
Reviewed-on: https://gerrit.libreoffice.org/16659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: I7f7f99ba93d4f06575228e62f96703fd2c54c469
Reviewed-on: https://gerrit.libreoffice.org/16271
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d.
iff can mean "if and only if" so not a typo
|
|
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
|
|
Change-Id: Ida1257337c6e0916f2228fe053d9c9f085183af6
|
|
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
i.e. follow up to
commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba
Author: Michael Stahl <mstahl@redhat.com>
Date: Wed Mar 11 16:39:24 2015 +0100
do not call virtual Commit() from dtors of utl::ConfigItem subclasses
~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.
to avoid assert in SvtSearchOptions dtor
Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22
|
|
This reverts commit 480ca7434a330b2678f9ef287cffd6d9cf27bed5.
Change-Id: I69a16425fc36979d49f409bbd7921495a22a35dc
Reviewed-on: https://gerrit.libreoffice.org/15737
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
|
|
Superseded by 7ad4e562b462af22a1c29c955293238cdb30267b
This reverts commit fbd85c25ba90b8db461555d735ab8b13f52d01ee.
|
|
include/o3tl/typed_flags_set.hxx: In instantiation of 'o3tl::is_typed_flags<ImplFontAttrs, -0x00000000000000001>':
include/unotools/fontcfg.hxx:88:94: instantiated from here
include/o3tl/typed_flags_set.hxx:66:5: error: static assertion failed: "is_typed_flags expects only non-negative bit values"
Change-Id: Ica7873bef3fd664370a96d8066d63c473ff6798f
|
|
Change-Id: I32d8b8f4301188245721d31fd234bb1784a1ae8d
|
|
Change-Id: I2a54f0c2694bb069478a8c8764a1789a377b4c0a
|
|
Change-Id: I85a1c9f89ac79e0e54fcd8dfd1908325fae9a8ac
|
|
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
|
|
Change-Id: Ic66191ac4cdfa753dc784e7bd1a6dd20f50def6b
|
|
Change-Id: I994bfc76d709d01406404991dbfbd49b15bd03f4
|
|
Change-Id: I2b5986ea69dc09e6ba18b23a80029f6551b48152
|
|
Change-Id: Iadc9b6240121e9fee91de299b94a9f8629656507
|
|
Change-Id: I1b0fb976e7bf8d7de06da0c30012e8bba1320498
|
|
Converted existing method that provides application name and version in two functions
Change-Id: I93b70da7c78ee5db3d6eb710a2a2a9f4b7b4fb86
Reviewed-on: https://gerrit.libreoffice.org/15151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
|
|
Bin pointless '// predeclarations' or '// forward declarations' comments. If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?
Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.
Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
|
|
... by adding a XCloseListener that vetoes any attempt to close it.
The Calc document can be opened by the user in the UI and closed again.
Change-Id: Ied427b67274d925c911e516c0a50a4c0b2b18db9
|
|
- also add needed infrastructure to o3tl::enumarray so we can use
std::find on it
- move the Impl inside the .cxx file, no need to expose it in the header
Change-Id: I7758a6175849f46723d97b1e657f846524c3b7cd
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I9665fc003cb3a44f4db857b24584fa3a70487259
|
|
and fix issues in iterating through o3tl::enumarray
Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
|
|
A running ODFVER_LATEST is fine for configuration purposes, but not for
determining how to store a feature.
Change-Id: I8ebc13f900f62f8c36d2cdc50a18855fc6693527
|
|
Export as highlighting or shading.
Highlighting is the default.
Change-Id: Ib2a38e4cd0d49317288bb565383b690d4222c8ed
|
|
Not in UI yet, but code can be prepared to distinguis between ODF 1.2
with extension and ODF 1.3
Change-Id: I898af587048fcfa21f567feecc754c279fe4c388
|
|
Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650
|
|
Rename the virtual function, and add a new non-virtual Commit() to do
that.
Change-Id: I09421df781ba965d6ff638b46cd8214fb3a00022
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
|