summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)AuthorFilesLines
2017-10-08tdf#106642 Wide color buttons are only for the sidebarMaxim Monastirsky1-3/+2
Change-Id: I3c75495b0f450ccf0eb8f9de715c7c7befc7bbe6 Reviewed-on: https://gerrit.libreoffice.org/43238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-08Make Color a forward declarationChris Sherlock5-4/+9
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin1-2/+2
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05loplugin:mergerclass merge FillAttrLB with SvxFillAttrBoxNoel Grandin2-19/+6
Change-Id: I5dfa7689eb219548bde7ce181a0a453c84b0f066 Reviewed-on: https://gerrit.libreoffice.org/43136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05clang-tidy modernize-use-equals-default in svxJochen Nitschke6-20/+0
SfxPoolItem has a copy constructor and its copy assignment operator is deleted. Derived classes have a implicit defined copy constructor too, if all members are copy constructible. This patch removes default-able copy constructors and destructors on such items. Also removing copy constructors of pool item members SvxClipboardFormatItem_Impl and SvxColumnItem. Change-Id: Ic0f39c992d1fd7b667cb56134fd7c953681a3131 Reviewed-on: https://gerrit.libreoffice.org/43143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann2-2/+2
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-04simplify memory management in ImpXPolyPolygonNoel Grandin1-1/+1
just use a std::vector<XPolygon> Change-Id: I1adb801faa8341e0759a86fd209a530b8f5c5a1c Reviewed-on: https://gerrit.libreoffice.org/43086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04drop WB_SDRMODE in favour of explicit methodNoel Grandin1-7/+4
was the only style being used on the class anyhow, and there was already a field for it Change-Id: Icdbc9f312851e0476a8b1d21fd4dc9c8166d4e08 Reviewed-on: https://gerrit.libreoffice.org/43085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04convert SDR_TRISTATE to TriStateNoel Grandin2-5/+3
Change-Id: Iac440d313006d01667e433bea97925ccaa9282da Reviewed-on: https://gerrit.libreoffice.org/43084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04PLinkStub is deadNoel Grandin1-2/+0
since commit 1d852b32d7ad89b2317c04958060f366f8922ca4 Date: Thu Jul 16 09:49:37 2015 +0200 loplugin:unusedmethods svx Change-Id: I1c039fd71571a069531684857ae971e6acb4f49c Reviewed-on: https://gerrit.libreoffice.org/43081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03svx: Simplify SdrGluePointList with std::unique_ptrTakeshi Abe1-10/+7
This also inlines SdrGluePointList::GetObject(). Change-Id: I70052a5e94b3451f5a00e1185e6dee59e5537184 Reviewed-on: https://gerrit.libreoffice.org/43059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-30svx: Stop returning unused XPolygonTakeshi Abe1-1/+1
Change-Id: I2cbd98f788a6b68365e094449f8f7e6d5e7426f4 Reviewed-on: https://gerrit.libreoffice.org/42930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-09-29check for unnecessary DLLPUBLIC annotationsNoel Grandin2-2/+2
on classes which are fully defined in a header file Rename the dllprivate plugin to dllmacro and add the functionality there. Change-Id: I4581d551c46a8f61213d95973f323359d08278d8
2017-09-28Resolves: tdf#112680 start color picker with currently selected colorCaolán McNamara1-1/+1
Change-Id: I939a0b88646b4654337505e985cceff883f09343 Reviewed-on: https://gerrit.libreoffice.org/42899 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28tdf#112555 Mark default area pattern names for translationGabor Kelemen1-0/+54
These need to be kept in sync with the contents of extras/source/palettes/standard.sop:Contents.xml Change-Id: I424919cacafd19dc456b4975b13f1c7333d14fa4 Reviewed-on: https://gerrit.libreoffice.org/42671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-26TSCP: sign paragraph from classification dialogAshod Nakashian1-1/+4
Change-Id: Iebd50de0abecb80a4de38257fa2eea10b81962b7 Reviewed-on: https://gerrit.libreoffice.org/42738 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: paragraph classification dialogAshod Nakashian2-1/+2
Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620 Reviewed-on: https://gerrit.libreoffice.org/42737 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-25Improve resizing chevrons so the control point is a fixed distance from endCaolán McNamara1-1/+2
during resizing, because... "If I want to use LibreOffice Draw to illustrate process steps with chevrons (which I do a lot, working on for example customer project roadmaps), I always get stuck if the steps I want to illustrate are not equal lengths, because the sizes/angles of the chevron "arrow heads" are proportional to the length of the chevron, rather than being fixed, and thus don't "fit" together. Which makes for an incredibly ugly diagram." Change-Id: Ib8b5e0ea7db5383cae754127023f7ab12d748537 Reviewed-on: https://gerrit.libreoffice.org/42754 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Translate German comments and debug strings (leftovers)Johnny_M1-2/+2
Additionally: - A few grammatical fixes Change-Id: I15ba3809f6b4746be5a691ec2adc0ea17730fa4a Reviewed-on: https://gerrit.libreoffice.org/42690 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-25borderline: Refinement of line end overlapsArmin Le Grand1-26/+7
Change-Id: Ifb1a061ed39f92a13ad5c7b2daf103f3a48938a5 Reviewed-on: https://gerrit.libreoffice.org/42712 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt1-1/+1
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Related: tdf#112388 last Fraction leakCaolán McNamara1-22/+6
This SdrEngineDefaults never changes its initial Fraction or Color and always returns a copy, so drop all the complicated stuff Change-Id: Ic26d221be022f4d1e75498eca675b4aae1c020f1 Reviewed-on: https://gerrit.libreoffice.org/42723 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25tdf#83320 Hide vertical text commands earlyMaxim Monastirsky1-0/+3
Instead of listing all commands in one big "if", just do it unconditionally in the shared controller. Change-Id: Ie415c4551a77ca8e1e29e73c0dabaff1dd13cbcb Reviewed-on: https://gerrit.libreoffice.org/42715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-09-24tdf#106762 Keep the previous m_xColorWindow lifecycleMaxim Monastirsky1-0/+2
Some logic here seems to depend on it. Change-Id: I62a2eeba1511a9be77030f726ceaa67e3ca3ace8
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky2-6/+20
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-09-22tdf#112552: Shape's gray background is lost after saving to PPTXTamás Zolnai1-2/+2
Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115 Reviewed-on: https://gerrit.libreoffice.org/42598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt2-3/+3
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt1-1/+1
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21TSCP: add advanced classification dialogTomaž Vajngerl4-1/+199
This adds a advanced classification dialog, which enables the user to manually construct a header/footer message from classification properties in cases where the user needs more control. All the text is inserted as fields into the end document and can be changed by changing the document properties. The simple classification still functions as it did before, which is what most users will want to use in this case. The BAF policy has been extended with new xml extension elements: - loext:Marking - loext:IntellectualPropertyPart - loext:IntellectualPropertyPartNumber They are used to fill the values in the advanced classification dialog. Change-Id: Ie2d638d69b8a9b0799cff9c2b785eb789f8af1d5 Reviewed-on: https://gerrit.libreoffice.org/42474 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-19svx: Simplify FmSearchEngine's code with std::unique_ptrTakeshi Abe1-4/+3
Change-Id: Ibda0f912c940091676889529224488846c91b50f Reviewed-on: https://gerrit.libreoffice.org/42456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-18borderline: restuctured used classesArmin Le Grand1-12/+70
Restructuring for more efficcient usage of helper values, some obstacles removed with that Change-Id: Ia8c4b2d4c423db9500cda507107d87913b79e23c Reviewed-on: https://gerrit.libreoffice.org/42409 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-09-18loplugin:unusedfields in SvxPixelCtlNoel Grandin1-1/+0
aLineColor is unused since commit fa1807ad5457d10f8fa073c209a27547e8922c8c Date: Thu Aug 27 21:18:58 2015 +0300 tdf#93558 Hardcode black text on white background Change-Id: Idadfa926808568195256c7ea7ac92d71533fe9a9
2017-09-15borderline: Fixed PatternScaleArmin Le Grand1-3/+3
The applied PatternScale factor was not consequently used in svx::frame::Style so that the Previews in the Dialogs look weird. Fixed that and stumbled over Writer applying it's own scale which then was leading to double scaling, ceaned that up. Change-Id: I89f41bfd7884e5e743080301e219491e215054c3
2017-09-15borderline: Added merge BorderLinePrimitive2DArmin Le Grand1-0/+5
Added BorderLinePrimitive2D merges for Writer and fixes.
2017-09-15borderline: merge redefined, mirrored StylesArmin Le Grand1-49/+10
Redefined merge of BorderlinePrimitives, removed old Writer stuff for it. Also added support for handling Styles mirrored for extension calculations.
2017-09-15borderline: Adapt ViewContactOfTableObjArmin Le Grand3-89/+29
Adapted to usage of svx::frame::Style helpers for primitive creation, need much less SvxBorderLine classes and less overhead. Class SdrBorderlinePrimitive2D completely removed. Working on Array::DrawRange to get it using the Coodinate Systems which are available and include the rotation. Solved problems in BorderLinePrimitive creation in DrawRange and DrawArray by completely restucturing these. Also changed to now return a sequence of primitives to the caller instead of handing over a primitive renderer and using it for each single primitve. This is a preparation for later buffering these and not re-create for each paint. Have now a working version that uses the Cell used by the Style and creates all info on the fly, so that the correct coordinate systems will be used. Works in Calc and it's dialogs with one or multiple cells.
2017-09-15borderline: Adapted Writer to use CreateBorderPrimitivesArmin Le Grand1-53/+37
Also further refined svx::frame::Style, some more cleanups in svx using CreateBorderPrimitives, got rid of one implementation of CreateBorderPrimitives Change-Id: I4c2481181df4fc4aa0dbb4cb9f4352066b9d8ec0
2017-09-15borderline: move geometry creation to linear algebraArmin Le Grand1-27/+22
Adapted Array::DrawRange to Style/Vector usages, feeding new CreateBorderPrimitives method. That one roughly feeds the old implementations to test and check (and keep working) Change-Id: I09557f826cd023d27db6b53e53aa69c149308711
2017-09-15borderline: Preparing further to use CellCoordinateSystemArmin Le Grand2-32/+59
Multiple cleanups, made svx::frame::Style a std::shared_ptr class, preparing basing all border stuff on transformations, so it will need a CellCoordinateSystem. Added stuff to get this Coordinate System from the svx::frame::Cell using the Frame and knowledge about ownerships Change-Id: Ic2cb59cc92e648ac2fef72f22f8913479769d3e2
2017-09-15borderline: Abstraction of BorderLinePrimitiveArmin Le Grand2-89/+7
As preparation for more detailed definition of BorderLine primitives I have adapted the BorderLine definition to work with motre possibilities to define the LineStartEnd definitions in a BorderLineExtend class. That one is flexible to hold all kinds of definitions - from none to all four possible extends (Start/End, Left/Right of vector) Cleanup of DiagStyle and others: DiagStyle is not needed anymore due to no longer using angles calculated, but being based on vectors defining the geometry. Also cleaned up quite a bit of no longer needed calculation stuff for the control.
2017-09-14convert SvxCellOrientation to scoped enumNoel Grandin1-2/+2
Change-Id: Ia4c75c6394b47805f24a7daca593e0074a8ddf0b Reviewed-on: https://gerrit.libreoffice.org/42268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13svx: Simplify SdrHelpLineList with std::unique_ptrTakeshi Abe1-13/+10
This also kills no longer used SdrHelpLineList::GetObject(). Change-Id: I6e08e44214657c536717e96693c89104d7118cfd Reviewed-on: https://gerrit.libreoffice.org/42234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-12listening to modify is sufficient to get all changesCaolán McNamara1-2/+0
Change-Id: Ic6872ec80cc4a36192fe23f9abf76c4fa10b94bd Reviewed-on: https://gerrit.libreoffice.org/42213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08clean up SdrDragStatNoel Grandin1-27/+26
- some light formatting in the header file - change aPnts from std::vector<Point*> to std::vector<Point>, no point in dynamically allocating a small value class - rename aPnts -> mvPnts - use std::unique_ptr for userdata - rename pUser to mpUserData - change some methods protected->private, since nothing external is using them Change-Id: I7a3f4c30c60ae1be3713f460fe65de95bed2f124 Reviewed-on: https://gerrit.libreoffice.org/42102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08svx: Make SdrDragStatUserData's dtor pure virtualTakeshi Abe1-0/+1
to clarify that it is an abstract base class, and to avoid memleak when deleting derived instance as pUser in SdrDragStat::Clear(). Change-Id: I39670841fda1ea3c45698585ce50aec944e0d4ab Reviewed-on: https://gerrit.libreoffice.org/42097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08set parent for file dialog helperCaolán McNamara1-2/+2
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-06Don't run the OLEObjCache timer for an empty cacheJan-Marek Glogowski1-1/+0
Change-Id: I210f6bdec14491bea6d15bca133011059091f21b
2017-09-04New loplugin:dyncastvisibilityStephan Bergmann2-2/+2
...to find uses of dynamic_cast where the static (base) type has hidden visibility while the dynamic (derived) one has default visibility, and which may thus fail at least on macOS like happened in d5ed3cd6dbd22bb18542778f1c48f4d5b3ae0f95 "Make WinMtfFontStyle's base class EMFIO_DLLPUBLIC, too". libcxxabi's __dynamic_cast takes static_type and dst_type arguments. Now, if dst_type (the derived type, with default visibility) is taken from .so A (and thus references the version of the base type info hidden in .so A) but the __dynamic_cast call is made from .so B, it passes for static_type the base type information hidden in .so B, and __dynamic_cast will consider the cast to fail. I'm not sure whether hidden intermediary types (in the hierarchy between the dynamic_cast's base and derived types) acutally cause a problem too, but lets flag them with the plugin anyway. The fixes use SAL_DLLPUBLIC_RTTI. For one, there appear to be no other reasons than type visibility to make those classes SAL_DLLPUBLIC. For another, this nicely avoids any actual changes on Windows (where SAL_DLLPUBLIC expands to nothing, and many of the affected classes were explicityl introduced into class hierarchies as "MSVC hacks"). Change-Id: Ia85a9635cebffb1009a9efc1484b8bd4025585d4 Reviewed-on: https://gerrit.libreoffice.org/41802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-02svx: Simplify code with std::unique_ptrTakeshi Abe1-2/+2
as SdrPathObj owns mpDAC. Change-Id: I3e4411046fa55ae8ffae2da5e406ad7d20a7ca6e Reviewed-on: https://gerrit.libreoffice.org/41818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29move ListControl to vclMarkus Mohrhard1-59/+0
Change-Id: I022bba9a9a4d3d0bdb25ca8fa43aef2544decddb Reviewed-on: https://gerrit.libreoffice.org/41682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 23:09:25 +0000