summaryrefslogtreecommitdiff
path: root/include/svx
AgeCommit message (Collapse)AuthorFilesLines
2016-10-04Resolves: tdf#101711 revert attempt to drop unused bg imagesCaolán McNamara1-12/+2
for 5-2/5-1 simply revert the effort Revert "Related: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit 19c191a0a92b6ae9ca86aa4ee7afb887fd42a209. Revert "Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if..." This reverts commit fad4d7877ac8d04ab82e8acd21205f315d6eab1f. Revert "rhbz#1326602 avoid exp. bg bitmaps from deleted slides" This reverts commit fd45334b49c09538598f82f5ffa2f61f6bdd9d24. Change-Id: I591083b6b1d7b08316ee24c0788386799d01724b Reviewed-on: https://gerrit.libreoffice.org/29491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-16disable generation of ole previews in ODF format until after loadCaolán McNamara1-0/+16
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3) detangle gadzillion checks into something readable no logic change intended (cherry picked from commit fad9786b06d188ba6e354620f57176f3d94a6637) + partial merge of commit c09b3e32372537be739182b02ae83a96386d1e1c Author: Noel Grandin <noel@peralex.com> Date: Tue Mar 8 13:13:59 2016 +0200 loplugin:constantparam in sw for bool bUI is always true in UpdateLinks Unmodified default SdrOle2Obj size is 101x101 svx/source/unodraw/unoshape.cxx sets a css::awt::Size maSize to 100, 100 svx/source/unodraw/unopage.cxx increases that by 1, 1 awt::Size aSize = xShape->getSize(); aSize.Width += 1; aSize.Height += 1; to call SdrObjFactory::MakeNewObject with 101, 101 so default size is 101x101 (getWidth() vs GetWidth() confusion ?) Reviewed-on: https://gerrit.libreoffice.org/28895 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7f0a219c9ad38ae33b51ff69d545f69659691c1e) Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 b6af93afc1f80b7fc36239c96d5e0a71fcbcb789 4d4375dff64d7b8e236d1a24322e749e04ee530f Reviewed-on: https://gerrit.libreoffice.org/28930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-08Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...Caolán McNamara1-2/+3
the master page is not the sole owner. Which happens when copying and pasting slides which bring along a duplicate master page to an already existing one, and the attempt to remove the duplicate strips the fill properties from the shared stylesheet in use by the other regression from... commit b876bbe2cacce8af379b10d82da6c7e7d229b361 Author: David Tardon <dtardon@redhat.com> Date: Tue Apr 26 09:17:11 2016 +0200 rbhz#1326602 avoid exp. bg bitmaps from deleted slides (cherry picked from commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1) Change-Id: I91fb8f622a0e35741ecc37cef14fc93199bb730b Reviewed-on: https://gerrit.libreoffice.org/26976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-17Resolves: tdf#82532 parent mutex dtored before child dtor uses itCaolán McNamara1-2/+2
Mutex belonged to DisposeListenerGridBridge which inherits from FmXDisposeListener, FmXDisposeListener dtor accesses a reference to the parent mutex in its dtor, but the mutex has been destroyed at this point. Move the mutex from parent to child. FWIW these classes are on the candidate list to merge. (cherry picked from commit e841ed93d6c6d817be1f7fdc18ff971325c861cc) (cherry picked from commit 1c0d1199fe02666de0d162f071ce7e6e812a23df) Change-Id: Ic639eaed97c2b0625c368ed249f09920af37f94e Reviewed-on: https://gerrit.libreoffice.org/26382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-09tdf#100269 svx: fix undo of table column resizeMiklos Vajna1-0/+2
SdrTableObjImpl::LayoutTable() assumed no re-layout is needed in case the total width of the table and the number of columns is the same, but undo of resize is a situation where we also need to check the individual widths of the columns, otherwise layout won't be up to date. (cherry picked from commits a106165e7fd39215c4717e1486aef05f6af9180f and 9cea9137b2534da4056f72d3c8a07f85a02f85be) Conflicts: sd/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: Ia5ebb05af79dda1c0d8c5bb10e7f37f81ee1d035 Reviewed-on: https://gerrit.libreoffice.org/26072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-30tdf#100115: _nColId is sal_uInt16Julien Nabet1-2/+2
like the other methods, so fix it in canCopyCellText + copyCellText Change-Id: I3395f8823602f0a1791908945e3dec5034d3d612 Reviewed-on: https://gerrit.libreoffice.org/25605 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 634fd0016ef7396a782d28272852302841f37201) Reviewed-on: https://gerrit.libreoffice.org/25622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-03rhbz#1326602 avoid exp. bg bitmaps from deleted slidesDavid Tardon1-0/+9
ODF export uses SvxUnoBitmapTable (impl. of com.sun.star.drawing.BitmapTable) to create fill bitmap styles. That returns all XATTR_FILLBITMAP items that are in the document's pool. So we ensure that bitmaps that are only used on deleted (either explicitly or by undoing their insertion) slides are not in the pool. (cherry picked from commit b876bbe2cacce8af379b10d82da6c7e7d229b361) Change-Id: I54c594a94989158f22b156fe660c1e716b988b3e Reviewed-on: https://gerrit.libreoffice.org/24590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-02tdf#99452 svx: fix undo of table row edge dragMiklos Vajna3-0/+10
The problem as seen by the user: if you have a table of 2 rows and 1 column, and the separator line is dragged upwards by the mouse, then undo doesn't restore the original situation. Two items are created on the undo stack: sd::UndoGeoObject and sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two cell heights are 4000 and 4000. If the user resizes the first cell, so that its height is 2000, then the new table height will be 6000. The problem is that when undo is executed, first sd::UndoGeoObject resizes the table, distributing the newly available 2000 between the existing rows, and then sdr::table::TableRowUndo sets the row height of the first row: the height of the second cell will be larger than expected. Fix the problem by not doing a relayout during sd::UndoGeoObject, but doing a relayout after sdr::table::TableRowUndo in this case. This is done by: 1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in case a row edge is dragged, as otherwise it's not guaranteed that a TableRowUndo will follow the UndoGeoObject on the undo stack.) 2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the layout. 3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout. 4) Marking the table model as modified in TableRowUndo::setData(), so it does the layout at the end of the undo group. (cherry picked from commits cafc53f8b4c08443524b1da6f4918d49afd45bb5, 8d1fa417bc49a9e9eee923e3ce6a37d7b0f056f1 and 758e6f39d96237881198818e3bac432012be61d8) Conflicts: sd/qa/unit/tiledrendering/tiledrendering.cxx svx/source/table/svdotable.cxx Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1 Reviewed-on: https://gerrit.libreoffice.org/24392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-04-26-Werror=misleading-indentation (GCC 6)Stephan Bergmann1-1/+5
Change-Id: I83e38c017600946e4055a5b8ada87a0f64e83222 (cherry picked from commit 84800b5e65e03c744b01225a1d44f8d54481b5f4) Signed-off-by: David Tardon <dtardon@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/24410 Tested-by: Jenkins <ci@libreoffice.org>
2016-04-26tdf#99396 SvxTableController::SetVertical: implement undo supportMiklos Vajna1-0/+4
All the table and cell objects know how to undo this change, what was missing is the begin/end undo calls and the broadcast of the cell format change. (cherry picked from commits 3057b5cdb989d44613518900b25ebad8b7c600a2, d60d70d92cec7bbc471f8f0c653d443282227d34, 6819992113947e7a6272bf750fee712c2df41905 and 100eb15b4d8529d7a11d98a28742f31f0f792fa1) Conflicts: sd/qa/unit/misc-tests.cxx Change-Id: I3dfd203faf5c579da2937fedab5647129a8e903a Reviewed-on: https://gerrit.libreoffice.org/24276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-04-07tdf#65642 RTF filter: import \pgnrestart and \pgnucltrMiklos Vajna1-1/+3
This implicitly adds support for DOCX import of <w:pgNumType w:fmt="upperLetter"> as well. (cherry picked from commits abaf6bde4ee91c628bd55a7ec2e876a5d0ecff6e and d29b75c402ea635b3865501e43c9f349885913af) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: Ib19ecb8f7ca0c867ae3be2b41e49ac4cacfd5bb6 Reviewed-on: https://gerrit.libreoffice.org/23730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock9-9/+9
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-01-07tdf#96708: don't modify document while copying to clipboardMike Kaganski1-2/+4
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3b4059dc53ec764be5423517363223043d6dbfad) Reviewed-on: https://gerrit.libreoffice.org/21104
2015-11-25loplugin:unusedfields in include/svxNoel Grandin15-64/+6
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-23crashtesting: fdo30583-1 hits the Clone ugly tree all the way downCaolán McNamara2-0/+8
Change-Id: I091c3a61a28275e090975016908e3b25c7506fba
2015-11-23crashtesting: ooo55544-2.sxi, etc. missing ClonesCaolán McNamara2-0/+8
Change-Id: I3e1b8f78289500bad8013e858f9abf03ab14914a
2015-11-23Fix buildMaxim Monastirsky1-0/+1
Change-Id: I310d10793613bae05d7b89f6cb4773a1c2d5556b
2015-11-23SvxSmartTagsControl: Do not leak sub menusMaxim Monastirsky1-2/+3
And while on it, move other things to smart pointers as well. Change-Id: I8b234b8a9fe60e0ca82bb08e48f6b7db94cbcd4d
2015-11-22crashtesting: fdo72067-2.odp missing SdrEdgeLineDeltaAnzItem::CloneCaolán McNamara1-0/+4
Change-Id: I6dea8c690d07b670358f8488c6be83ec49c8ee43
2015-11-18svx: SdrEdgeNode1HorzDistItem etc. missing Clone overridesMichael Stahl1-0/+6
Change-Id: I2bc2de3c3a71dd54e432905c129a3dbd5395f6ab
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin1-2/+1
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17loplugin:unnecessaryvirtualNoel Grandin2-4/+4
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-14tdf#95403 Add Outline buttonMaxim Monastirsky1-0/+2
Change-Id: I0d5187ed34539a05ab9f2ffdfb89118df0aa3511 Reviewed-on: https://gerrit.libreoffice.org/19964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-11-13tdf#86886 Shortcut keys missing in undo and redo tooltipsSamuel Mehrbrodt1-1/+1
Change-Id: I8df003bdad4430a174815ce51197b997717ef379
2015-11-13svx: remove unused typedefMichael Stahl1-1/+0
Change-Id: I3d892ba544e1c3e569e3c1968e034836dde5b555
2015-11-12Namespace cleanup and disambiguationAshod Nakashian1-8/+10
Change-Id: Ib6d2f8b4e71436c3a7c26bdfc9847152ebaf0739 Reviewed-on: https://gerrit.libreoffice.org/19900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-11loplugin:nullptrStephan Bergmann7-13/+13
Change-Id: Id0cab3b90ea9f3de7dc63f58ef247ba512af79f4
2015-11-11Resolves: tdf#95723 arrange GridControl buttons to be always visibleCaolán McNamara1-3/+1
as long as there's space for them Change-Id: Id96069b5c50483309611381afdf62bb0d30e9c38
2015-11-115th step to remove tools/rtti.hxxOliver Specht138-255/+128
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10XDash: salu_uIntPtr to sal_uInt32Matteo Casalin1-11/+11
Unsigned integer was used tp be consistent with previous integral type, but both unsigned and signed integers are used by callers. Change-Id: I3f902e00fbff690a72a7ca0f1c818976d3d2bebe
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann164-401/+401
Change-Id: I71682f28c6a54d33da6b0c971f34d0a705ff04f5
2015-11-06coverity#1338250 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I0c78b48213b4a638eca86eb9481974f49bc35319
2015-11-06coverity#1338240 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I3b1b1c9745cae1dd7a765769ea761973d0a60134
2015-11-05sal_uIntPtr to sal_uInt32Matteo Casalin1-1/+1
Change-Id: Ia0830dda74ab312fd1ca42297b43d48777374eb7
2015-11-05fix tdf#95488, crash in report wizardNoel Grandin2-3/+43
This reverts commit bb76b8f10697f3d5ca1f9a2f19902b043bd61cd7 "loplugin:mergeclasses" Change-Id: Ib65459ab45cd4cefa859ed75f9ddc4f070879b1d
2015-11-04tdf#86595 One "Text Background Color" missedMaxim Monastirsky1-1/+0
Change-Id: Ia640b9bc044a8445751f0ebad7f027466c352d1f
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin5-6/+3
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27Missing includeStephan Bergmann1-0/+1
Change-Id: Icbffa2973b3cb803950ffe280b95194795f8861c
2015-10-27Missing includeStephan Bergmann1-0/+4
Change-Id: I55595fdbc6ae5a51f402201cdc5f4adbdd86b984
2015-10-26fix includes that are not stand-aloneNorbert Thiebaud1-0/+2
includes should be able to be included on their own fix some of the ones that do not respect that rule. Change-Id: Id161224a1978461d3cea43252f232f18888a4f61 Reviewed-on: https://gerrit.libreoffice.org/19612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-23com::sun::star->css in include/sot to include/typelibNoel Grandin128-1374/+1374
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
2015-10-23tdf#48456 : when searching for a number, consider formattingDennis Francis2-0/+2
Change-Id: I4a1e3e269a269bb37e88aa8810a46d0f4ecfc518 Reviewed-on: https://gerrit.libreoffice.org/19420 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-22crashtesting+ubsan: kde170880-1.html bad cast to SdrTextAniCountItemCaolán McNamara1-1/+7
because a clone of SdrTextAniCountItem is a SfxUInt16Item not a SdrTextAniCountItem Change-Id: I7b8f99b52b1f42a6a28af4495ff25ddb6d497f61
2015-10-21add block/subset names new in Unicode Standard 8.0 / ICU 56Eike Rathke1-0/+10
Change-Id: I42685ff22f61f2c6c82439dd23393fd1ac17daa0
2015-10-21remove untyped Link<>Noel Grandin1-3/+1
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b Reviewed-on: https://gerrit.libreoffice.org/19491 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16remove unimplemented and private methodNoel Grandin1-3/+0
Change-Id: Ic0d869720890b21c65e7736326d9bd0ee53cada0
2015-10-16convert Link<> to typedNoel Grandin14-21/+21
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15convert Link<> to typedNoel Grandin1-0/+1
Change-Id: I2ef1e5fe5c6dc65c254b3a16b0b12fca5caba16e
2015-10-15convert Link<> to typedNoel Grandin1-0/+1
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-13implement dialog control over enhanced shape control pointsCaolán McNamara1-0/+1
use case is a desire to enable viewing and setting rounded rectangle radiuses to an exact known value Change-Id: I7e6a4db0699076950adf5869a61825159766c46a