summaryrefslogtreecommitdiff
path: root/include/svx/tbcontrl.hxx
AgeCommit message (Collapse)AuthorFilesLines
2019-10-30loplugin:finalclasses svxNoel Grandin1-7/+6
Change-Id: If55e51b8627083ba3ece2b3270adb47668b25e9d Reviewed-on: https://gerrit.libreoffice.org/81705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03loplugin:constmethod in svxNoel Grandin1-1/+1
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18tdf#42949 Fix IWYU warnings in include/svx/[t-v]*Gabor Kelemen1-3/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327 Reviewed-on: https://gerrit.libreoffice.org/73977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-17Rename BorderColorStatus to ColorStatusMaxim Monastirsky1-1/+1
Next commit will use this for all color status updates, not just for borders. Change-Id: Ibd95d755a33bfc079fcbffabfd8896b6b777609f Reviewed-on: https://gerrit.libreoffice.org/63498 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-25tdf#117987 tdf#118138 Compare with the currently used colorMaxim Monastirsky1-1/+0
... when deciding whether to toggle highlighting. Had to move the whole thing into sw, as otherwise there is no way to correctly handle the "brush" mode (as the toolbox controller in svx has no way to know in advance which text will be selected by the user). Change-Id: Id2dec4c3647332e82260d12da1311b249f5b9c12 Reviewed-on: https://gerrit.libreoffice.org/56358 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-04loplugin:useuniqueptr in SvxStyleToolBoxControlNoel Grandin1-1/+1
Change-Id: Ia4f7c1bd1b8e411013d4d8c084e2d5342bdbfbfb Reviewed-on: https://gerrit.libreoffice.org/55220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28tdf#63438 Toggle highlight color to no fill if the same value is activeDaniel1-0/+1
Change-Id: I7553bc7bffeb0a8d1275aadc44bf2813564087b5 Reviewed-on: https://gerrit.libreoffice.org/51794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-25Adjust includesAron Budea1-1/+1
Change-Id: I11385fc987e6951570454919c110de7167f41f5a Reviewed-on: https://gerrit.libreoffice.org/47036 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-11-09Resolves: tdf#113695 crash in color picker after parent is closedCaolán McNamara1-1/+1
Change-Id: If2217abed784bf24e37e3403fa33cd2663dc51a4 Reviewed-on: https://gerrit.libreoffice.org/44545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky1-5/+18
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-07-30tdf#109309 Currency dropdown is misplaced under WaylandMaxim Monastirsky1-7/+14
- Base SvxCurrencyToolBoxControl on PopupWindowController, so we still allow tearoff, but without marking the window as self-decorated (unless actually teared-off). - Add support for toggle state to PopupWindowController. Change-Id: I60e004e6ada3efe092352cb93be5aae346073f83 Reviewed-on: https://gerrit.libreoffice.org/40557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-07-21migrate to boost::gettextCaolán McNamara1-1/+1
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-06-12cleanup unused css/frame/* includesJochen Nitschke1-0/+1
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26Translate German comments (leftovers in include/svx/)Johnny_M1-5/+5
Change-Id: I1f4238525962d57956fd08c93e7c4d3bc52e4dc5 Reviewed-on: https://gerrit.libreoffice.org/36808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-31tdf#39468 Translate German commentsJens Carl1-1/+1
Translate German comments in filter/ Change-Id: I2b5856f1d4b894ca64a5b8105ca3f6466b17360b Reviewed-on: https://gerrit.libreoffice.org/35953 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-26Related: tdf#104312 create palette on demandCaolán McNamara1-1/+2
Change-Id: I741323c41231a08fe9561d72ca6079079e888e90
2017-01-26Remove dynamic exception specificationsStephan Bergmann1-13/+9
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-08XSubToolbarController is only used by SvxColorToolBoxControlMaxim Monastirsky1-1/+4
Change-Id: I10c31aa9c773649c99b52c2d34cb648a37bf42ac
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara1-13/+3
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud1-3/+13
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04unify color selectorsCaolán McNamara1-13/+3
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-10-15Use UNO registration for font name toolbox controlMaxim Monastirsky1-11/+0
Should help to eventually get rid of the wrapper in reportdesign. Change-Id: I9fc94f2ed650561eb47f2f91939b3aa37f031c3b Reviewed-on: https://gerrit.libreoffice.org/29910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-13Use FeatureStateEvent directly for status updatesMaxim Monastirsky1-5/+4
... for SfxPopupWindow and SvxColorToolBoxControl (the latter shares BorderColorStatus with SvxColorWindow_Impl, so it was easier to convert it too). Change-Id: Ifcb23fe5809e467322d1cf4d790420886ac79b47
2016-10-13SvxColorToolBoxControl: Unify members prefixMaxim Monastirsky1-4/+4
and rename bSidebarType to something more sensible. Change-Id: Ia41afe4ecc3068394cb41cc4c3caddce59905103
2016-10-07Base SvxLineWindow_Impl on ToolbarPopupMaxim Monastirsky1-11/+0
Change-Id: I93dbb180fc65bca77e0eb58f116d0a0a5266556a
2016-10-05Base SvxFrameToolBoxControl on PopupWindowControllerMaxim Monastirsky1-11/+0
Change-Id: I7666c7c5c99b1705bc8ece2913c2cdf9fdecced3
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-2/+2
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-4/+4
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-04Non-split currency buttonMaxim Monastirsky1-0/+4
Change-Id: I002af2140dd372302509509baf8d5f400ed4341a
2016-09-04Restore the toggle state of the currency buttonMaxim Monastirsky1-2/+0
Change-Id: Ibe7d8b183038c4a925282ccab1b637342a714712
2016-04-11clang-tidy performance-unnecessary-value-param in svxNoel Grandin1-1/+1
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
2016-03-23tdf#82641 Changes to currency drop-down listMohammed Abdul Azeem1-0/+2
Common codes have been shared in a static function. Now the list shows complete set of currency options. Change-Id: I17639b3123d2fd86c5a414df927ef5f07e37d845 Reviewed-on: https://gerrit.libreoffice.org/23444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-19tdf#82641 Currency drop-down listMohammed Abdul Azeem1-0/+18
Currency drop-down list has been added. It retains the position of selected entry. Clicking on button toggles between the previously selected currency and number formats. Change-Id: I0dea8fc2773497bfaababa418f119d0a5e76cb03 Reviewed-on: https://gerrit.libreoffice.org/22958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-17/+17
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-17convert Link<> to typedNoel Grandin1-1/+2
Change-Id: I72074f247d9435e600a5cf84728753e72a83fe2e
2015-09-17convert Link<> to typedNoel Grandin1-1/+1
Change-Id: I161636252c47af6f6f8458e41bfa0d0be8461ace
2015-08-20handle new color picker correctly in chart sidebarMarkus Mohrhard1-0/+4
This implements the basics for that and implements it in the AreaPanel. Change-Id: I6d9e5012bbcc2c953d478a09a839f35f2ef64c5b
2015-07-06tdf#83541 Redraw the last used color after theme changeMaxim Monastirsky1-0/+4
That's not what XSubToolbarController was originally designed for, probably, but it has more in common than otherwise. A split button offers a dropdown with some functions, and the main part of that button updates with the last selection, to easily re-apply it. This is based on the change made in commit dd69bde36a4ee4636933a80c0291486593a37670, so that updateImage method is called once an icon refreshing is requested. Change-Id: I6bd15638665f917ed7060886cd7835cdcd1a34f9
2015-07-05SfxToolBoxControl::GetPopupWindowType seems unused, kill itMaxim Monastirsky1-3/+0
together with SfxPopupWindowType enum. Change-Id: Ia0b2388b34c96bb044f1bfcc7e89b33ac37d5f95 Reviewed-on: https://gerrit.libreoffice.org/16766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-04-17svx: convert new to ::Create.Noel Grandin1-3/+3
Change-Id: I52f589dabdedb538a4a5d0eadfa42b0d10de9b80
2015-04-16make CreateItemWindow return a VclPtr<>.Michael Meeks1-2/+2
Change-Id: Id15ff8900376aaee4343d7ee08ae062e1c462ce4
2015-04-09use std::unique_ptr for Impl in SvxStyleToolBoxControlTomaž Vajngerl1-1/+2
Change-Id: Ia01755ee617002ef2c234e29b1edd497b031ef8a
2015-04-09cleanup header tbcontrl.hxxTomaž Vajngerl1-63/+47
Change-Id: I8b424a21b7a1fcc72b607fec00cbfaa6a6961c8b
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara1-2/+2
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2014-11-03Related: fdo#84844 Prepare border color status updateMaxim Monastirsky1-0/+15
The Sidebar button handles also the color of diagonal lines. Change-Id: I26d75472a8c9ca482274797127994d4546b1b3e8
2014-10-24Forgot to update this commentMaxim Monastirsky1-1/+5
Change-Id: I3922bcf22b7efe43fd42c937d88251b230d6384a
2014-10-22Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControlMaxim Monastirsky1-0/+1
The end goal is to convert the Sidebar to use SvxColorToolBoxControl, and get rid of the Sidebar specific color popup, so we don't need to maintain two popups. Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-09-23fdo#82577: Handle WindowNoel Grandin1-2/+2
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-26 16:30:16 +0000