libreoffice/core - main, development code repository

Age	Commit message (Collapse)	Author	Files	Lines
2014-04-23	RTL_UNICODETOTEXT_FLAGS_NOCOMPOSITE has never had any effect	Tor Lillqvist	1	-2/+1
	Change-Id: I9004ec2229cd31fb899b23c8ce59f5fd49ac03a2
2014-02-18	Stick to a single O[U]String hash function	Stephan Bergmann	1	-18/+0
	8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String class" had introduced a new getHash64 that, besides returning sal_uInt64 instead of just sal_Int32, didn't do sampling of only a handful of characters, but always computed the hash over all characters (as the usage in SfxItemSet and SdPage appears to require for either performance or approximated correctness). However, it would be advantageous to keep the stable URE interface as small as possible. Now, O(1) sampling was apparently considered state of the art when the rtl string classes were first created, closely copying java.lang.String, which at that time demanded sampling for hashCode(), too---but never sampling more than 15 characters, with the obvious (in hindsight, at least) performance catastrophes, so they changed it to O(n) somewhere along the way. Based on that, this commit changes the existing hash functions to not do sampling any more, and removes the newly introduced -64 variants again. (Where the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not vital to the existing uses.) The old implementation used sampling only for strings of length >= 256, so I did a "make check" build with an instrumented hash function that flagged all uses with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295 characters, and only the remaining four where of 2472 characters. Those four were from CppunitTest_sc_subsequent_filters_test, importing long text into a cell, causing ScDocumentImport::setStringCell to call svl::SharedStringPool::intern, which internally uses an unordered_set. These results appear to justify the change. Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
2014-02-13	Move string hash function into String class.	Muthu Subramanian	1	-0/+18
	hashCode() seems to do sampling while creating the hash. hashCode64() will not. Change-Id: Id30f5a2a774cf5244dbc00da9649e95a532484be
2013-11-09	fdo#65108 inter-module includes <> include/rtl	Norbert Thiebaud	1	-5/+5
	Change-Id: Ic90a365a237aa23846f97131146a5aa2c46b5fd2
2013-10-23	fixincludeguards.sh: include - the rest	Thomas Arnhold	1	-3/+3
	Change-Id: If1ee11da444a7f96f2d8668b277540da0bb4dbe9
2013-06-13	Introduce O[U]String::toUInt32	Stephan Bergmann	1	-0/+21
	...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39 "Handle oveflow in O(U)String::toInt() functions" reduces values in the range (SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied on getting a correct (unsigned) value for the whole input range ["0" .. "FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3 "Revert overflow checks in O[U]String::toInt{32,64} again"). Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO comment in oox/source/helper/attributelist.cxx, and stoc/source/typeconv/convert.cxx will still need some love and test code.) Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-05-15	Spelling "separate" (etc) correctly is hard	Tor Lillqvist	1	-1/+1

2013-04-24	move URE headers to include/	David Tardon	1	-0/+1408
	Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d Reviewed-on: https://gerrit.libreoffice.org/3499 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>