summaryrefslogtreecommitdiff
path: root/include/oox/core
AgeCommit message (Collapse)AuthorFilesLines
2017-06-06Related: tdf#108269 oox: allow recovering broken DOCM filesMiklos Vajna1-2/+3
The content type inside an OOXML file differs for DOCX and DOCM. These must be in sync with the file extension, otherwise MSO refuses to open the file. We used to always write the DOCX content-type even for files which had the DOCM extension. Allow users to recover those broken files by detecting a "has docm extension but docx content-type" file as docm, so re-saving it will produce output that's accepted by MSO as well. (cherry picked from commit 97fa7024ce608b7908aca369e8c643a5de9ebf78) Change-Id: I7d60c6f6c1d0421e95b3dc9e8fff617f101919f5 Reviewed-on: https://gerrit.libreoffice.org/38356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-04-05add a clearDocumentHandler for null document handler caseCaolán McNamara1-0/+2
Change-Id: I661a2fd5381013056c69b379792560aed7121214
2017-04-05loplugin:constantparam part2Noel Grandin1-10/+2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30loplugin:unusedenumconstantsNoel Grandin1-2/+1
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c Reviewed-on: https://gerrit.libreoffice.org/35854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:unusedmethodsNoel Grandin1-43/+0
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:unnecessaryvirtualNoel Grandin1-2/+3
Change-Id: I5076f8700ee29cfec3875dfbc4b149229d776712 Reviewed-on: https://gerrit.libreoffice.org/35823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06loplugin:unusedenumconstants in ooxNoel Grandin1-4/+3
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED constant Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd Reviewed-on: https://gerrit.libreoffice.org/33954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna1-0/+6
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33866 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-26Remove dynamic exception specificationsStephan Bergmann11-108/+64
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24use rtl::Reference in FastParserNoel Grandin2-10/+9
instead of storing both a raw pointer and a uno::Reference Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ooxStephan Bergmann5-5/+29
Change-Id: I83c6995e4f15d6a042e57bac4d71874124402547
2016-12-26use the existing namespace map for the oox namespace exportMarkus Mohrhard1-0/+2
Change-Id: I7909b08db556c6c65c1547303f2b899c30feaba4 Reviewed-on: https://gerrit.libreoffice.org/32425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-09crashtesting: unexpected exception on novell403458-1.pptxCaolán McNamara1-3/+3
since commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c Date: Thu Oct 13 23:43:41 2016 +0200 chartx: fix sparse chart import because - Matrix< Any > aMatrix( rDataSeq.maData.size(), 1 ); + Matrix< Any > aMatrix( rDataSeq.mnPointCount, 1 ); where rDataSeq.mnPointCount is -1 Change-Id: I4bb4805dd81a342d4c0ce24e3240154daf53b452
2016-11-08loplugin:unnecessaryvirtual in hwpfilter..rscNoel Grandin1-2/+2
Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868 Reviewed-on: https://gerrit.libreoffice.org/30661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann8-9/+9
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann1-1/+1
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-06-10update mergeclasses resultsNoel Grandin1-3/+1
and do one trivial merge Change-Id: Iff30553f73de946c74fa6b082928e7d47adadd04
2016-05-26loplugin:unusedreturntypesNoel Grandin1-3/+1
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28tdf#42949: prefer including Reference.hxx over Reference.h...Jorenz Paragas11-20/+20
...and so on for Any.hxx and Sequence.hxx. This commit follows up on two of my previous commits, which are 6a4a15c87c03feffb90cc416ce22d2819e41442d and 474eca1f9b42749665bbf69f6dc62c66ea4ad7fd. Many non-static inline functions that are declared in Reference.h and similar files are not defined in the .h file, but their definitions are in the corresponding .hxx files instead. Thus, let's prefer including the .hxx files over the .h one so that we don't include inline functions without their definitions. In practice, the corresponding .hxx file is included transitively from many other places, but it's better not to rely on that. Change-Id: I3bada39eb879ae736c0360f435b16cd5a61adba8 Reviewed-on: https://gerrit.libreoffice.org/24456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25tdf#42949: clean up includes in include/oox/core using iwyuJorenz Paragas13-41/+171
This allows the headers in that folder to stand on their own and not depend on any transitively included headers. All changes to other files are needed to fix compiler errors related to missing includes that occurred afterwards. Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4 Reviewed-on: https://gerrit.libreoffice.org/24355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-13loplugin:passstuffbyref in ooxNoel Grandin1-1/+1
Change-Id: Iec989e9060c77dd5b010224b37633179cee4f7e9
2016-04-11clang-tidy performance-unnecessary-value-param in ooxNoel Grandin1-2/+2
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
2016-03-14inline some use-once macrosNoel Grandin1-5/+0
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04loplugin:unuseddefaultparam in oox/reportdesign/sdNoel Grandin1-1/+1
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
2016-03-03loplugin:unuseddefaultparams in ooxNoel Grandin2-2/+2
Change-Id: If05662102e161d3dd56bbb6ed3964e63ba853cf9
2016-02-09Remove excess newlinesChris Sherlock11-26/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-14fix the MSVC 2013 --enable-lto buildMichael Stahl1-1/+2
... by sacrificing the appropriate number of chickens to the template dllexport gods. Change-Id: I27fb6a1f0a8a32c9bdc67574b3a2f3ec9f27b00f Reviewed-on: https://gerrit.libreoffice.org/21442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-12loplugin:unusedmethods unused return value in include/ooxNoel Grandin1-8/+2
Change-Id: I22acb6b94774c5944d8276827c53a419f0803f83
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-21loplugin:unusedmethodsNoel Grandin2-13/+0
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin1-2/+0
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23com::sun::star->css in include/linguistic to include/sfx2Noel Grandin12-162/+160
Change-Id: Id69e293fda98ee6cf2cc3d3296a0cd2e06bd847e Reviewed-on: https://gerrit.libreoffice.org/19527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_FINAL" with "final" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-8/+8
Change-Id: Ifa5ba21308e32df44571fa2941370f2f11179580
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann9-84/+84
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-2/+2
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-09-25better OOXML VBA exportMarkus Mohrhard1-0/+1
Change-Id: If02aa26e974b0f16b45c5476234c6425fd128ae4
2015-09-25remove whitespaceMarkus Mohrhard1-4/+0
Change-Id: If01b299fd40597cc3ee91c01a6a7785c6d44352e
2015-08-23oox: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe5-12/+11
with the variadic variants. Change-Id: I8a82df7ea24874d8e246dc983418d872f1943c8e Reviewed-on: https://gerrit.libreoffice.org/17919 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04include: inline some use-once typedefsNoel Grandin1-4/+4
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-07-21loplugin:unusedmethods ooxNoel Grandin5-12/+0
Change-Id: I5381e0da0efc1f951e248cfcfb35fc680ace94e4 Reviewed-on: https://gerrit.libreoffice.org/17225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-05loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-04-19import chart MSO 2007 streams correctly for docx files, tdf#82216Markus Mohrhard1-0/+3
Change-Id: Icda809faf315dac5953d38781b2b401d51f7a40a
2015-04-16Revert "make more classes dllpublic"David Tardon1-3/+1
This reverts commit add2ca7b3ab10ed9d18e60d8e50020168d922836. It causes too much breakage on windows. It is better to start again from scratch.
2015-04-16make more classes dllpublicDavid Tardon1-1/+3
... to fix asan+ubsan+dbgutil build Change-Id: I1400774d383879bbff9bf28251a104cd53bafaed
2015-03-17Remove oox::core::FilterBase::implGetImplementationName indirectionStephan Bergmann1-6/+0
Change-Id: Ib275192452c6836cbaac2e517942ec5356dfd9ab
2015-03-10detect MSO 2007 OOXML documentsMarkus Mohrhard1-0/+2
Change-Id: I4052c6f1e5dde71ce4cede1ec9a313f461861d71
2015-03-10remove whitespacesMarkus Mohrhard3-16/+1
Change-Id: Ie9d303a7200cf2a6bfd8c0f5f547cfffccaa0444
2015-03-09V801: Decreased performanceCaolán McNamara1-1/+1
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-02-19boost->stdCaolán McNamara4-9/+9
Change-Id: Icae6b6f07ad8dbd287fdfc689739187883a07775
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara2-4/+2
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a