summaryrefslogtreecommitdiff
path: root/include/editeng/editview.hxx
AgeCommit message (Collapse)AuthorFilesLines
2016-09-13sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()Miklos Vajna1-0/+2
With this, in case the first view has an active text edit selection and a new view is created, then the text selection is instantly visible in the second view, even if the first view's text selection does not change later. Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
2016-09-13sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback()Miklos Vajna1-0/+2
With this, in case the first view has an active text edit and a new view is created, then the cursor position is instantly visible in the second view, even if the first view's cursor does not move later. Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
2016-08-25new loplugin: countusersofdefaultparamsNoel Grandin1-4/+4
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04 Reviewed-on: https://gerrit.libreoffice.org/28353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02editeng: make SfxUndoAction::GetViewShellId() interface availableMiklos Vajna1-4/+3
Extend the existing OutlinerViewCallable interface to be able to obtain the view shell ID of a view shell, even from editeng. Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223 Reviewed-on: https://gerrit.libreoffice.org/27788 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-20sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna1-2/+2
The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-1/+1
Change-Id: I5bb3c63790cb153c0d6f57a681ec6dda71d482be
2016-06-22Remove no longer needed ImpEditView::mpLibreOfficeKitSearchableMiklos Vajna1-2/+0
All clients has been ported to use ImpEditView::mpLibreOfficeKitViewCallable instead. Change-Id: I3a2513ac5900f801a2e7aec79807f4e333dfba3d Reviewed-on: https://gerrit.libreoffice.org/26561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10editeng: implement per-view LOK_CALLBACK_INVALIDATE_VISIBLE_CURSORMiklos Vajna1-1/+4
Given that the per-view callback is in SfxViewShell, and editeng doesn't depend on sfx2, add an interface class in editeng to invert the dependency. With this, gtktiledviewer no longer crashes when starting editeng text edit with per-view callbacks. Change-Id: I783cdc646b890a6b597000f1d88428c8042417cf Reviewed-on: https://gerrit.libreoffice.org/26169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-11clang-tidy performance-unnecessary-value-param in editengNoel Grandin1-2/+2
Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44
2016-04-05loplugin:constantparam in editengNoel Grandin1-1/+1
Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin1-1/+1
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna1-1/+1
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna1-1/+0
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna1-1/+2
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-12loplugin:unusedmethods unused return value in include/editengNoel Grandin1-1/+1
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970 Reviewed-on: https://gerrit.libreoffice.org/21361 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-18editeng: clean up no longer necessary isTiledRendering() member functionsMiklos Vajna1-1/+0
Change-Id: I4bf3e9bd9cbf2b32d79cebd5ba0a818b1f4970c2
2015-12-07Let LIBO_INTERNAL_ONLY imply LOK_USE_UNSTABLE_APIMiklos Vajna1-1/+0
Change-Id: Ifbed5e534ba79d32b7188bb7fb7108338b6e124d
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-6/+6
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-10-21com::sun::star->css in include/editengNoel Grandin1-5/+5
Change-Id: I2a46f2128ef86ea0d692240b968ea52ab8e09dcc Reviewed-on: https://gerrit.libreoffice.org/19489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13editeng: add EditView::GetSelectionRectangles()Miklos Vajna1-0/+2
This gives sd access to the selection rectangles as well (as opposed only to the document model positions of selections). Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-2/+2
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-09-22convert Link<> to typedNoel Grandin1-1/+1
Change-Id: I684a72cc3eeff0caf27132ff641f0d3b20ff7c08 Reviewed-on: https://gerrit.libreoffice.org/18770 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28convert RGCHK constants to scoped enumNoel Grandin1-1/+9
Change-Id: Iafeae0f85f751469900471cf8fccd5f763407890
2015-07-16loplugin:unusedmethods editengNoel Grandin1-4/+0
Change-Id: I15b2be5a9cd6e72447b674a65eabe9f89cb6ff12 Reviewed-on: https://gerrit.libreoffice.org/17115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-30Gradually typed LinkStephan Bergmann1-2/+2
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin1-1/+2
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-25convert EV_CNTRL constants to enum classNoel Grandin1-2/+3
Change-Id: I0ffc0e222c978ce7c734228f712e88422d3a615f
2015-03-23editeng tiled rendering: implement drag of the middle selection handleMiklos Vajna1-0/+2
With this, it's possible to drag the middle selection handle of editeng text (e.g. Writer shape text) and the cursor position will be updated accordingly. Change-Id: I2b03c8543efca477f2e377f3bb93732cd1775f81
2015-03-16LOK: extract the callback typedef to a separate LibreOfficeKitTypes.h headerMiklos Vajna1-1/+1
With this, most LO code can avoid rebuilding when touching LibreOfficeKit.h, something that caused a mass-rebuild earlier. Change-Id: I4880fc7ad82cc535377b2b602897e3172ffa480b
2015-03-16Add ImpEditView::libreOfficeKitCallback()Miklos Vajna1-0/+4
And various other methods, so that it's possible to invoke the callback in ImpEditView. This will be needed by the blinking editeng cursor. Change-Id: Ie1b6957e5c48f606e71d5808df3f632924d3a2ec
2015-02-23ImpEditEngine::UpdateViews: need to go via Invalidate() for tiled renderingMiklos Vajna1-0/+3
This makes typed characters appear as you type it (and not only after the editing of the shape text is finished) in Impress. Change-Id: Id47efe8223ddfdbad36f436366c9c8c8e0cb45f4
2015-02-07loplugin:deletedspecialStephan Bergmann1-2/+2
Change-Id: Ia5cdc216ef4e5ebb11709fa1079e70c9ac2ff360
2014-10-07Resolves: fdo#44998 crash when opening context menu of a fieldCaolán McNamara1-0/+1
If you right click on a field in an inactive text box, then a mouse down, context command, mouse up sequence is sent. The mouse up is supposed to be captured by the context menu here. But it doesn't because the mouse down in draw sends an artificial mouse down to the editengine which eventually sets up a MouseCapture window so the context menu doesn't get considered (because it occurs before the capture window is released) so the mouse up gets send to sd while the context menu is up and that causes all sorts of havoc. Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-09-23fdo#82577: Handle WindowNoel Grandin1-6/+6
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin1-2/+2
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-08-23fdo#82577, fdo#82579: Handle CursorTor Lillqvist1-2/+2
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor typedef and some ancient Carbon (?) Cursor typedef on OS X. Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-03-15fdo#63154 Remove some solar.h referencesAlexandre Vicenzi1-1/+1
Remove some solar.h from tools. Replace sal_uLong by size_t, sal_uInt32 and sal_Int32. Change-Id: I38961db046337a3ea4ef75d64afa424d81391f34 Reviewed-on: https://gerrit.libreoffice.org/8582 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-21editeng: sal_Bool->boolNoel Grandin1-26/+26
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud1-4/+4
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-11-26Integrate branch of IAccessible2Steve Yin1-2/+4
WaE: Reorder initializations to prevent compiler warnings. (cherry picked from commit c05431aa92fa2c7c7258418a6ecd651b5c26d982) WaE: unname unused variable to prevent compiler warnings. (cherry picked from commit 2259256a390c4b6f83cfb5dbe4a65df5032aee47) Conflicts: editeng/source/accessibility/AccessibleEditableTextPara.cxx ad61537527a74670af266feb9e4d26d2d654daf7 66044902b8d94fc15d4c30270e6cc419fb7d3565 Change-Id: I3ec9798f2c7d854824722c0cf44b62128b4f4cb4
2013-11-09fdo#65108 inter-module includes <>Norbert Thiebaud1-1/+1
Change-Id: I82b0309c4430a8393e17b9a30a6e898f82c0f25c
2013-10-23fixincludeguards.sh: include/editengThomas Arnhold1-3/+3
Change-Id: I5a172bb12b62940b9994b2740e054b43145b08f0
2013-09-11convert include/editeng/editview.hxx from String to OUStringNoel Grandin1-4/+4
Change-Id: I1d21fd48dfaa8cfe4a2807cd6e50e05db4c24e28
2013-08-14XubString->OUStringCaolán McNamara1-3/+3
Change-Id: I9ccb06134dfadd9bf1ecb8e5edcd24c02980b754
2013-05-10resolved fdo#35756 import more than 64k HTML table cellsEike Rathke1-5/+5
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used also in RTF import Calc and Writer, so that could benefit as well. * changed all EditEngine,Outliner,... related paragraph index/count variables from sal_uInt16 to sal_Int32 * sal_Int32 instead of sal_uInt32 to match accessibility API * matched some Outliner methods' paragraph parameters from sal_uLong to sal_Int32 * containers capable to hold size_t nevertheless are limited to a maximum of sal_Int32 * changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to SAL_MAX_INT32 + added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize ESelection with what previously were hard coded 0xFFFF all over the place + for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL to initialize an ESelection spanning all available text like aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL) Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00 Reviewed-on: https://gerrit.libreoffice.org/3838 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-04-23execute move of global headersBjoern Michaelsen1-0/+247
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a