Age | Commit message (Collapse) | Author | Files | Lines |
|
The "ParentNumbering" property is not a string.
(regression from 97eb8a6e0eb830f37dcba64a51d725aab4c5ff53)
Change-Id: Ib33e95847b388bb1126a63812e128c96a0c00730
(cherry picked from commit 4d3c9ed257e51af55f358d2b44d5fc2e341c7202)
Reviewed-on: https://gerrit.libreoffice.org/10875
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I4bbcff7963520426d4c04e15d2239431aff65b56
Reviewed-on: https://gerrit.libreoffice.org/10042
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ia2f482fb7737e61cfc42966dbc7af6e1cdb3b41d
Reviewed-on: https://gerrit.libreoffice.org/9544
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
ICU 53.1 changed API behavior:
https://ssl.icu-project.org/apiref/icu4c/classicu_1_1RuleBasedCollator.html#a2f4c7eeaf020ad68e3bd9722dd272357
isn't correct anymore:
length: size of the image. If negative, the API will try to figure out the
length of the image
NO, IT WILL NOT! It bails out with an error instead.
Introduced a function to obtain the length for each collator data.
base: collator, usually root. The base is required to be present through the
lifetime of the collator. Currently it cannot be NULL.
NOT "usually root"! There's a check now that bails out if
if(base->tailoring != CollationRoot::getRoot(errorCode))
So using an instance created with icu::Locale::getRoot()
(cherry picked from commit a3c627fe38236e82bc6008075d862b3cbfbd9ce3)
Conflicts:
i18npool/source/collator/collator_unicode.cxx
Backported.
make DISABLE_DYNLOADING on Android happy, fdo#77071 related
(cherry picked from commit dc7ba1af236ec28d399eff833d56608fde9fb70d)
Change-Id: Ia9c4e27d5ef4f8083bbe57e4e2f4b3ff63bb42ed
Reviewed-on: https://gerrit.libreoffice.org/9215
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Korean charset collator can't be built from ko_charset.txt because of
"The runtime code decomposes Hangul syllables on the fly, with recursive
processing but without making the Jamo pieces visible for matching. It
does not work with certain types of contextual mappings."
"While handling a Hangul syllable, contractions starting with Jamo L or
V would not see the following Jamo of that syllable." (this is where we
bail out already with the first syllable of ko_charset.txt)
Another condition to fail is described as "A contraction ending with
Jamo L or L+V would require generating Hangul syllables in
addTailComposites() (588 for a Jamo L), or decomposing a following
Hangul syllable on the fly, during contraction matching."
Excluded the file from the build for ICU >=53 and hope that ICU in the
mean time handles Korean collation correctly.
Additionally, ICU 53 took ages (if it would had finished at all) to
build the collator from zh_TW_charset.txt because of the \u#### escaped
notation. Converted the file's content to characters using
http://www.rishida.net/tools/conversion/
Change-Id: I6520a362b94428eac42085e2740aee2c468ed693
Reviewed-on: https://gerrit.libreoffice.org/9205
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1603dfad68261c917532f88397305eef57356da6
(cherry picked from commit 20fb1bfc72e626251b435bcff2339e1e425c7130)
Reviewed-on: https://gerrit.libreoffice.org/8911
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Namely: Estonian has several sets of correct quote mark glyphs for double
quotes („”, „“, «» are all common), however the Institute of Estonian
Language [1] recommends using the first of these, i.e. „” (99 low, 99
high) [2]. As for single quotes, Estonian texts rarely use them, except in
a few fields such as linguistics and biology -- and both ‘’ (9-9) and ’’
(6-9) are considered correct [2, 3]. However, apostrophe in the beginning
of a word (which is effectively the same as a starting single quote) can
also be used to indicate omitted character(s) -- but there, only ’ (9) is
correct [3].
[1] Eesti Keele Instituut, the main official body which maintains and
studies the usage of Estonian language; http://en.eki.ee/index.php
[2] The last page of
https://docs.google.com/viewer?url=http://keeleabi.eki.ee/pdf/164.pdf (in
Estonian)
[3] Handbook of Estonian Language,
http://www.eki.ee/books/ekk09/index.php?p=2&p1=11&id=86 (in Estonian)
Change-Id: If88e6e03e3e4aa1919a25dbe2fa2ffc8c9a04f4a
(cherry picked from commit 51fc602184ab8d1afbfb183a3d25b1122c8b1e29)
Signed-off-by: Eike Rathke <erack@redhat.com>
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
(cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d)
Conflicts:
sc/source/ui/unoobj/nameuno.cxx
sc/source/ui/unoobj/styleuno.cxx
sfx2/source/appl/sfxhelp.cxx
stoc/source/security/permissions.cxx
sw/source/core/unocore/unocrsrhelper.cxx
(None of those bogus startsWith calls seem problematic enough to warrant
backporting also to libreoffice-4-2-0.)
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
Reviewed-on: https://gerrit.libreoffice.org/7578
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Issue:
OUString uses UTF-16, so for a Unicode surrogate character there are 2
values stored, not just 1.
So we are getting assert failure in "rtl_uString_iterateCodePoints" method.
erAck: Underlying cause was that the dictionary breakiterator misused
UTF-16 positions as Unicode code point positions.
Change-Id: I923485f56c2d879b63687adaea2b489a3479991c
Reviewed-on: https://gerrit.libreoffice.org/6955
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit d8fd15875901d584a4bbcc07c927fa20332e4841)
Reviewed-on: https://gerrit.libreoffice.org/7322
|
|
Change-Id: Iee8da90c70589b8053c8c5b696afb4968072f47e
(cherry picked from commit c32996987354d045523beaa98b5d227d161f72fb)
|
|
This breaks windows build with localized versions of MSVC.
Change-Id: I23c46830f96ae661eced88352476e7ae61fbcc2a
Reviewed-on: https://gerrit.libreoffice.org/6847
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I390bfec0d36dcc9529785e97994dad2b0704dc80
(cherry picked from commit d838ea200e7d6060d4a759616f9e1fcbf3c36c8e)
|
|
Change-Id: Ic31811c287e2dc2908243a228a340c3005077297
|
|
Change-Id: I59d553f7b70955de18562046f1d7aa5fae6e9fb1
|
|
Change-Id: I82b093f7778a9d85016903cad1e39fc97f696cf2
|
|
Convert code like:
aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
aOStringBuf.append( " is missing )" );
which compiles down to the same code.
Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
Complete set is now Y-M-D;M-D;M/D/Y;M/D
Change-Id: I42ed59fb325b391943608a10ded7ce74c80656e1
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
for AED and KWD currencies, simply referring [ar-SA] in all other
aspects
Change-Id: I2ca19d1f7d2e807406bf207babe76cae967eea81
|
|
Change-Id: I8069657d8829a0315c704e884a1cf15b26e02eb8
|
|
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
These horrible headers use "#pragma GCC system_header" and thereby
prevent generated Makefile dependencies, which is what broke incremental
builds after the ICU upgrade today.
Change-Id: Ife983b3c4de86968da8a0187a1acb1bbb2b5c81f
|
|
Change-Id: I6da721dc25394dfee12e3028aefbf0546d1be984
Reviewed-on: https://gerrit.libreoffice.org/6669
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit fc04b55f7f96a4f70f31c145dafd44c1d9276a41.
|
|
They are accessed from multiple threads frequently.
Change-Id: I3f9720ede076109efe0b7eaa4a05dd50f2e38102
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Convert code like
if( ! aStr.compareToAscii("XXX") )
to
if( aStr.equalsAscii("XXX") )
which is both clearer and faster.
Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
Change-Id: Ie1e8c4beb3d2e17d311a5363d82feddfdff8e958
|
|
- WORKDIR path is just workdir
- INSTDIR path is just instdir
- WORKDIR_FOR_BUILD is workdir_for_build
- INSTDIR_FOR_BUILD is instdir_for_build
- replace other usage of INPATH by combination of OS and CPUNAME
Change-Id: Ie398387ebd82a968ec2605f2103c55b43a231482
Reviewed-on: https://gerrit.libreoffice.org/6601
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
And use some templates inside include/com/sun/star/uno/Sequence.hxx
Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I86fc8a6e7a1b09f54a20db55b6079d945fdb7338
|
|
Change-Id: I562fbdb9eec3af297ea95a0d161721ec345e6a19
|
|
Change-Id: I788d1d1c54cc0a30cbbdc07066bf133c2814304a
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Change-Id: I6d8259df3d4f2e73f9236b7c0547f87c89801082
|
|
Change-Id: I51f7408a81a10e2c586cb05b863f20b13bb7b263
|
|
Change-Id: Id2ddbbff90f3cd32c03c7623af6d458717c7e8a8
|
|
Change-Id: I2bef2334392dba63f86b24917a50bf1eb0df98dc
|
|
At least for Winfried CppunitTest_sd_import_tests aborts with triggering the
assert in OUString::operator[] at (presumably past-the-end) index 18 from
com::sun::star::i18n::BreakIterator_th::makeIndex (this=0x2b775adf9440,
Text=..., nStartPos=18) at
i18npool/source/breakiterator/breakiterator_th.cxx:122
com::sun::star::i18n::BreakIterator_CTL::previousCharacters
(this=0x2b775adf9440, Text=..., nStartPos=18,
rLocale=..., nCharacterIteratorMode=1, nCount=1, nDone=@0x7fff9a84a8fc: 0) at
i18npool/source/breakiterator/breakiterator_ctl.cxx:62
com::sun::star::i18n::BreakIteratorImpl::previousCharacters
(this=0x2b775ae00a98, Text=..., nStartPos=18, rLocale=...,
nCharacterIteratorMode=1, nCount=1, nDone=@0x7fff9a84a8fc: 0) at
i18npool/source/breakiterator/breakiteratorImpl.cxx:65
ServerFontLayout::setNeedFallback (this=0xfba5d0, rArgs=..., nCharPos=17,
bRightToLeft=false) at vcl/generic/glyphs/gcach_layout.cxx:114
HbLayoutEngine::layout (this=0xfba670, rLayout=..., rArgs=...) at
vcl/generic/glyphs/gcach_layout.cxx:437
...
and from the preceding if block in BreakIterator_th::makeIndex it indeed looks
like the invariant is that nextCellIndex need not be larger than cellIndexSize
which needs not be larger than Text (ake cachedText) getLength().
Change-Id: Ib92a76020b2bb3902c5e58aa2e6c4e679e51b94a
|
|
Change-Id: I9d7d2a0c4a6029e983689884d3daec3e9cab291b
|
|
Change-Id: Icf3324a224d02425acd679a286f3c4a0b7e3ed1c
|
|
This came in with 04212c3015cd4ab118a0aec2bb04bc153a64af41 but
the bug number of #i86439# appears to be the wrong id. It doesn't
make sense to me. Rework cclass_Unicode::getStringType to iterate
safely over the codepoints of the requested range. Perhaps that
was the reason for the original commit.
Change-Id: Ice4287eb6f9fc6a9705845c0cf995263815de2e7
|
|
* allow overriding higher level lll-Ssss-CC with lower level lll-CC for
known MS-LangID mappings that use tags with suppress-script
* internal override "canonicalization", e.g. ca-XV => ca-ES-valencia
Change-Id: I067d7515fb9144a896697617ad1b079e294f1ced
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
Change-Id: I7c0e88ee9d01eec3df471d84f122123dfb24f4fe
|
|
Change-Id: I0a24fb53c2ff48c26b1c97b9a4768c3a725cd686
|