summaryrefslogtreecommitdiff
path: root/hwpfilter
AgeCommit message (Collapse)AuthorFilesLines
2017-02-28hwp: avoid low hanging invalid inputCaolán McNamara1-0/+6
Change-Id: I06133d6db14edb9d915c38e4c120a9d0905495dd
2017-02-27loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: If630131272b5ed4c589ed76be340a4107632c461
2017-02-26ofz#691 leak of emblist dataCaolán McNamara1-3/+5
Change-Id: Ic4231b93fafe73bf87995f226def64f7c9e131c3
2017-02-25ofz: epic slow use of std::listCaolán McNamara3-68/+30
Change-Id: I790a3098272101fd33f83f21bdcef1bb061efd76 Reviewed-on: https://gerrit.libreoffice.org/34635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-24hwpfilter needs a new filter for each documentCaolán McNamara2-12/+4
setUp is called just once at the start of the sequence of loads so we're reusing the previous import state which isn't what this filter expects This reverts commit 0af436083e12516eb9251d4cc6f594f80ed06d3d. Change-Id: Iae355ed6099086fd3cc1c79203786017507d4ed4
2017-02-24add hwp fuzzerCaolán McNamara1-3/+2
Change-Id: I07fe351a182328f9ef98cb9866529637a6688c64 Reviewed-on: https://gerrit.libreoffice.org/34570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-23remove test for the momentCaolán McNamara1-0/+0
Change-Id: Ib583e336f5ba560b9c1648291853b14582446ee3
2017-02-23ofz: don't loop endlessly on failed skipCaolán McNamara2-2/+6
Change-Id: Ibc105d8156e1b1ddf22948fb02165f8d03b4cfd5
2017-02-06default ctor is fine hereJochen Nitschke2-3/+0
this was hiding a Wunused-variable warning Change-Id: I32bd853846bc6f56c082541109eedfdab2402c3d Reviewed-on: https://gerrit.libreoffice.org/33942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03TyposJulien Nabet3-3/+3
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin1-3/+1
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann4-32/+28
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor forms..idlcNoel Grandin2-3/+0
Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23new loplugin useuniqueptrNoel Grandin2-3/+4
Change-Id: Ic7a8b32887c968d86568e4cfad7ddd1f4da7c73f Reviewed-on: https://gerrit.libreoffice.org/33339 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, hwpfilterStephan Bergmann1-0/+1
Change-Id: I03131a228843e6848c0b2d2468d160ca0cdaf508
2017-01-18use rtl::Reference in HwpReaderNoel Grandin2-329/+326
instead of storing both a raw pointer and an uno::Reference Change-Id: I02dd356d9693116f98ad2b96951570b3ba448b14
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl1-1/+1
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17new loplugin: useuniqueptr: helpcompiler..ioNoel Grandin3-18/+16
Change-Id: I6b394163c144e6b5540cb160abb613d56fe327de Reviewed-on: https://gerrit.libreoffice.org/33165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17use rtl::Reference in FormulaNoel Grandin2-39/+33
instead of storing both a raw pointer and a uno::Reference Change-Id: I7f8baae687e528e89c7cdea1a92099ff4a759878 Reviewed-on: https://gerrit.libreoffice.org/33169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann3-6/+1
Change-Id: I29c40113f9248f9041dacc398416f39889f5ddf8
2017-01-09loplugin:externvarStephan Bergmann1-1/+1
Change-Id: Iedb9b26dbe33d447de309a763eaeeeb57d1fcdd1
2017-01-09New loplugin:externvar: hwpfilterStephan Bergmann5-21/+15
Change-Id: I275d67b2878400cd0774f21b1a7489a0dd392e82
2016-11-18includes should be at the top of the fileNoel Grandin1-2/+1
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin1-2/+2
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin2-10/+10
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-08loplugin:expandablemethods in hwpfilter..linguisticNoel Grandin2-7/+1
Change-Id: I62ae20ab4a47b3b7e2b0d503cedcad3319cc9c85 Reviewed-on: https://gerrit.libreoffice.org/30683 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in hwpfilter..rscNoel Grandin1-2/+2
Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868 Reviewed-on: https://gerrit.libreoffice.org/30661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19loplugin:expandablemethodds in hwpfilter..linguisticNoel Grandin4-16/+2
Change-Id: If20fd4a6cf8a8e005804dbb7caf41cce73d587a5 Reviewed-on: https://gerrit.libreoffice.org/30016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-16clang-cl loplugin: hwpfilterStephan Bergmann3-12/+12
Change-Id: I63677cea6ee2cec0589bd853ca9b135931df63d4 Reviewed-on: https://gerrit.libreoffice.org/29863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-28remove define 'local'Jochen Nitschke1-10/+6
Change-Id: I7b8ff60a25a5b835b7a2893befeb82b424bbcd2c Reviewed-on: https://gerrit.libreoffice.org/29354 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-16No need for an abstaract HIODev::closeStephan Bergmann2-25/+7
...that was only called from dtors anyway, where its virtual-ness doesn't actually help (and would trigger loplugin:fragiledestructor if that were enabled) Change-Id: I477a22f2cadd1124b7106c5338e525629968a284
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl1-1/+1
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-14/+14
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-05loplugin:countusersofdefaultparams in framework..lotuswordproNoel Grandin1-1/+1
Change-Id: I9833d85eb6543e996b0f357657c53b1c076ecde4 Reviewed-on: https://gerrit.libreoffice.org/27898 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann2-42/+1
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann5-26/+26
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2-2/+2
Change-Id: Ic7827a5bb9afe04e76336e98e66483eabcaa9dde
2016-06-29move #includes to top of fileNoel Grandin1-2/+1
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-24loplugin:singlevalfields in hwpfilterNoel Grandin4-78/+39
Change-Id: I53adaca40f0cce6c155f3e35e92809dc6b2a4ab9
2016-06-23loplugin:implicitboolconversionStephan Bergmann1-1/+1
Change-Id: I21aeb9504be38e4a6b55892730131a878234ced3
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2-10/+14
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-07cppcheck: noExplicitConstructorCaolán McNamara1-5/+2
Change-Id: I2bd2fd9c5768128130659213305b7da04686125a Reviewed-on: https://gerrit.libreoffice.org/26000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl1-1/+1
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03loplugin:constantparamsNoel Grandin1-2/+2
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin2-2/+2
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19remove leftover commentJochen Nitschke1-1/+0
of commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae Change-Id: Ic3847bf36666de598f79d19c1b28ff0f8a4881f0 Reviewed-on: https://gerrit.libreoffice.org/25123 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-1/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-1/+1
Change-Id: I41dec58c163bdd33b71b3519fa0fd6eca72faae6
2016-05-10Add SAL_FALLTHROUGH to what looks like flex-generated codeStephan Bergmann1-0/+3
Change-Id: Icd980dbbdc8b55d76b7f8abe4dd1a9d7e475143d
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 03:44:36 +0000