summaryrefslogtreecommitdiff
path: root/hwpfilter
AgeCommit message (Collapse)AuthorFilesLines
2022-06-03No need for a cast here when comparing against const int DATE_SIZE = 40Stephan Bergmann1-1/+1
Change-Id: I2e9190ac08dc79fe624572ff3a96c32c18afce29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135341 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-16ofz#47473 OOM just skip the unused "reserved" data on readCaolán McNamara2-3/+1
and don't store it Change-Id: I7e68111b5ed724c5eab9e8040b8c28f542064ae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-07GCC 12 is still just as brokenStephan Bergmann1-2/+2
Change-Id: Ic2e151eb78512388150492b6dff0c39046d4d3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133979 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-02Pick a better variable typeStephan Bergmann1-1/+1
Change-Id: I2a24201d0e9cb230aefbb92dadf30907b0d1dccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133677 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-01ofz#47118 TimeoutCaolán McNamara1-7/+12
Change-Id: I5cf7f07c00faebb8005b150c9638dfbb742d156f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133666 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-27remove static bufferCaolán McNamara1-34/+33
Change-Id: I77ebc45000e09d1553c8e63402f30e720852c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26ofz#47042 previous use of static variable affecting later runsCaolán McNamara1-6/+6
Change-Id: I64fb184e43fb025798781c85c9a0a8e0354b21b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Use o3tl::make_unsigned in some placesStephan Bergmann1-2/+3
...where a signed and an unsigned value are compared, and the signed value has just been proven to be non-negative here Change-Id: I9665e6c2c4c5557f2d4cf1bb646f9fffc7bd7d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133442 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25ofz#46794 TimeoutCaolán McNamara1-0/+8
Change-Id: I58bfdbe4bab0ee8b7ff49f937711dff649392bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-25vector is a little faster than deque hereCaolán McNamara1-1/+1
Change-Id: I0471143b13ea8113919ed71abe956f27729cecad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133372 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-14Pick a better variable typeStephan Bergmann1-1/+2
Change-Id: I1c9d3bcb1e750b130a04105ab9cf370b7f31f392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132994 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-07ofz#46467 TimeoutCaolán McNamara1-20/+26
Change-Id: Ib2a248a6f912a340d2f0b79a068b68036fa357c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-04ofz#46331 Null-dereference READCaolán McNamara1-1/+1
Change-Id: Id03c7fc437d67e01d6a1ec0547b2584396066201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132497 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-25ofz: ensure unsigned indexCaolán McNamara1-6/+6
Change-Id: I38d6238a6eede0188f942229b2fb931614e56309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara3-54/+51
Change-Id: I73ed541c9a8fb6d9b0a8ee86ce7cf581721a9b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara1-0/+6
Change-Id: I63f4828fb35a1f24c98ccd235af91d186b48058a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYDEBUG is always 0Caolán McNamara1-161/+0
Change-Id: I9255b0c6447126e5b0907b12622b668bb4c79474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21yyoverflow is not definedCaolán McNamara1-11/+0
Change-Id: I5769b82ededd15a50892bc4e9478f69edb4722c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYPARSE_PARAM is not definedCaolán McNamara1-15/+0
Change-Id: Icda8e09ceb5e2bebb5187d00c0baa1bcccda88a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYPURE is not definedCaolán McNamara1-19/+0
Change-Id: I5942de482c6216fba2c35fa6d113c44639d349e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131891 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYLSP_NEEDED is not definedCaolán McNamara1-88/+0
Change-Id: I324e811a84916f27037b2fe9df0aed2db5458564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21dval can be constCaolán McNamara1-1/+1
Change-Id: I452f666230aca5b6033dcb16495ae382e4fd1073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara2-11/+10
Change-Id: Iaf31e6b46cc5ab68de46c250926d6a4709eddd75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-19ofz: Null-dereference READCaolán McNamara1-1/+1
Change-Id: Ie42af72e321bd55e3373aca33f0bcb6884bf8836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-18ofz: Direct-leakCaolán McNamara3-5/+11
Change-Id: I40024334b394e4de6a1766321556689234da86ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-17ofz: Null-dereference READCaolán McNamara1-1/+1
Change-Id: I0e3dfed65db245779d3402293d23864b0a4fb6e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-17ofz#45598 Integer-overflowCaolán McNamara1-2/+3
Change-Id: Ib3c6f9af746693678f9b031a23e4a703d0615b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-17can use a reference instead of a pointerCaolán McNamara1-12/+12
Change-Id: I3811c9d24e4890022be7c6179148d0eac0e5525c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-16ofz#45598 Integer-overflowCaolán McNamara2-5/+3
Change-Id: I1b997a35630bdb3a14fe606c9a34faf4330099ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-15hwpfilter: why isn't that path string null terminatedMichael Stahl1-0/+1
Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-03-14ofz#45525 Null-dereference READCaolán McNamara2-4/+8
Change-Id: I9d31b89fc7fa9447823ded4f6891b47100215c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-13ofz#45525 Null-dereferenceCaolán McNamara1-1/+1
Change-Id: If55d049f12eb00ba786f12d565081404fcdf147b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11new loplugin:trivialdestructorNoel Grandin2-3/+4
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-10ofz#45385 Integer-overflowCaolán McNamara1-2/+3
Change-Id: I7d5e4ffa7fc2c46d7a2ad679598aa1a62a623862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-10can be constCaolán McNamara2-4/+2
Change-Id: Iccb2f715025aad564850f3d21d46794337400237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131306 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-09ofz#45385 Integer-overflowCaolán McNamara1-11/+12
Change-Id: If65451a787c5709d792f9972e75e353b9b09f2ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131233 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-08ofz#45125 Indirect-leakCaolán McNamara1-1/+7
Change-Id: I208c0b6751eefbe6dddffa126fe3d89a3bd353af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-07ofz#45314 limit to valid day/month indexesCaolán McNamara1-7/+25
Change-Id: Ibf53fa1a0c1db3046a25367fb79da3b90f7cd924 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-07ofz: Null-dereferenceCaolán McNamara1-1/+1
Change-Id: I11213a5ab05389b7c5020d878b0f657045693e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-05ofz#45167 Integer-overflowCaolán McNamara1-16/+20
Change-Id: Ib112686b192558421419a8695db9c3f35c5312da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-05Use rtl::isAsciiDigit instead of custom macroMike Kaganski1-11/+11
Change-Id: Iabca31825dd47cee661b47b14f09e96459a42015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131033 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-05Convert some macros to local lambdasMike Kaganski1-66/+76
Change-Id: I22942588c7e7ebfb3f53cc5739d2bbd9a7ccfd41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130983 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04ofz: Null-dereferenceCaolán McNamara1-2/+4
Change-Id: I01be4c06c6d97430953ada8f3f5f84ef0a389267 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131032 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-04ofz: Null-dereferenceCaolán McNamara1-2/+2
Change-Id: I7d8e30dc85df3cc5800617e5b2f232136bb72cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131006 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-04Restore damaged commentsMike Kaganski1-22/+22
They were broken in commit d1af3a5fc102f9bb3464541d83ef0fa4bb2ce2a1 Author Vladimir Glazounov <vg@openoffice.org> Date Wed Jun 04 09:02:42 2008 +0000 INTEGRATION: CWS sw30bf04 (1.4.2); FILE MERGED It changed the original EUC-KR file encoding to ASCII. Change-Id: I423b6e7dac0a47ad7688175780f062ecaefb9101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131027 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04Turn conversion macros to proper functionsMike Kaganski1-18/+7
Change-Id: I463dff95d81e497bafacb60268288bf7526fb3d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04Avoid some sprintf used with colorsMike Kaganski3-43/+27
Also addresses possible buffer overflow because of possible color channel values greater than 255 (found by a fuzzer; likely by some unexpected value of shade exceeding 100; see https://gerrit.libreoffice.org/c/core/+/130956/3/hwpfilter/source/hcode.cxx#1292) Change-Id: I168685c3b51cbc8c9f664282bc9378b3c6669ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131003 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04Convert rstartEl/rendEl/rchars macros to proper methodsMike Kaganski2-439/+461
Change-Id: I0cdb7d0047e153b4eb6f6a1fc0bb09c116366b7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130959 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04Expand padd macroMike Kaganski1-667/+666
Change-Id: Ic3a5bbb872ae36151aed5c108f7694cb4a12495e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-04Expand ascii macroMike Kaganski1-31/+30
Change-Id: Ief7ce8c5477c0904cf1f9796913aa02d30ffce3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>