summaryrefslogtreecommitdiff
path: root/hwpfilter
AgeCommit message (Collapse)AuthorFilesLines
2016-09-28remove define 'local'Jochen Nitschke1-10/+6
Change-Id: I7b8ff60a25a5b835b7a2893befeb82b424bbcd2c Reviewed-on: https://gerrit.libreoffice.org/29354 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-16No need for an abstaract HIODev::closeStephan Bergmann2-25/+7
...that was only called from dtors anyway, where its virtual-ness doesn't actually help (and would trigger loplugin:fragiledestructor if that were enabled) Change-Id: I477a22f2cadd1124b7106c5338e525629968a284
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl1-1/+1
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-14/+14
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-05loplugin:countusersofdefaultparams in framework..lotuswordproNoel Grandin1-1/+1
Change-Id: I9833d85eb6543e996b0f357657c53b1c076ecde4 Reviewed-on: https://gerrit.libreoffice.org/27898 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann2-42/+1
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann5-26/+26
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2-2/+2
Change-Id: Ic7827a5bb9afe04e76336e98e66483eabcaa9dde
2016-06-29move #includes to top of fileNoel Grandin1-2/+1
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-24loplugin:singlevalfields in hwpfilterNoel Grandin4-78/+39
Change-Id: I53adaca40f0cce6c155f3e35e92809dc6b2a4ab9
2016-06-23loplugin:implicitboolconversionStephan Bergmann1-1/+1
Change-Id: I21aeb9504be38e4a6b55892730131a878234ced3
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2-10/+14
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-07cppcheck: noExplicitConstructorCaolán McNamara1-5/+2
Change-Id: I2bd2fd9c5768128130659213305b7da04686125a Reviewed-on: https://gerrit.libreoffice.org/26000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl1-1/+1
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-03loplugin:constantparamsNoel Grandin1-2/+2
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin2-2/+2
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19remove leftover commentJochen Nitschke1-1/+0
of commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae Change-Id: Ic3847bf36666de598f79d19c1b28ff0f8a4881f0 Reviewed-on: https://gerrit.libreoffice.org/25123 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-1/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-1/+1
Change-Id: I41dec58c163bdd33b71b3519fa0fd6eca72faae6
2016-05-10Add SAL_FALLTHROUGH to what looks like flex-generated codeStephan Bergmann1-0/+3
Change-Id: Icd980dbbdc8b55d76b7f8abe4dd1a9d7e475143d
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-2/+2
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-2/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-04-28clang-tidy modernize-loop-convert in h-l/*Noel Grandin1-6/+6
Change-Id: I843528327b25d18476f8959cabba16371213a48a Reviewed-on: https://gerrit.libreoffice.org/24460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-52/+52
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-3/+3
Change-Id: Icfa6686ee96e4c9ddf23abc3ece6beae6521473a
2016-04-12Get rid of odd _HCHAR_, _UTYPE_, _ZZRECT_ guardsStephan Bergmann1-9/+0
Change-Id: Ic44d1c751319897c55fdd03c912cd670624f928f
2016-04-12Get rid of _DATECODE_WEEK_DEFINES_Stephan Bergmann2-23/+22
Change-Id: I1b50fadd64df0a18339410068696a836850e9248
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin1-1/+1
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann1-1/+1
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07improve defaultparams lopluginNoel Grandin1-2/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04-Werror,-WundefStephan Bergmann1-1/+1
see c665a1bc0f45aa4a4c679e6f004581168e03f93d for __STDC__ not defined under MSVC/clang-cl. Change-Id: I65d8a3b33ff40fc80c52b294b0c5bc75d9f5cf2f
2016-03-03loplugin:unuseddefaultparams variousNoel Grandin2-3/+3
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22loplugin:write only fieldsNoel Grandin4-110/+1
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-16use consistent #define checks for the Windows platformNoel Grandin8-34/+24
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-09Remove excess newlinesChris Sherlock6-11/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock1-29/+31
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-21coverity#1349757 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ia2286fa9e1c351c4e4c9579b31b94ce1eac3b841
2016-01-20loplugin:unusedmethodsNoel Grandin3-65/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18loplugin: unused return valuesNoel Grandin6-30/+26
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-11loplugin:unusedmethods unused return value in hwpfilterNoel Grandin12-73/+65
Change-Id: Ib225db89e60708f6b55b3cb86f8e881386fab86f
2016-01-10Fix typosAndrea Gelmini1-12/+12
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-04cppcheck: duplInheritedMemberCaolán McNamara2-2/+2
Change-Id: I451a7a04fd1578d3095e5931f0792a32870a647e
2016-01-02cppcheck: allocaCalledCaolán McNamara1-32/+3
Change-Id: I253f71f851621d8a3d1244468b9da63ba2d10b09
2015-12-29cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann1-6/+6
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-07unused Picture::Type()Juergen Funk2-12/+0
and removed unused TxtBox::Type(), too Change-Id: I4a1d7f1cbbc5bb4d929fe7420db8f827dd8b142d Reviewed-on: https://gerrit.libreoffice.org/20424 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2015-11-28Adapt to true wchar_t in clang-clStephan Bergmann1-4/+4
Change-Id: Id127668e6786665b819b7c0b1c0cd424ebff96bf
2015-11-24'#pragma setlocale("C")' is probably no longer necessaryStephan Bergmann2-10/+0
...as in both files the direct use of non-ASCII characters in ordinary string literals has since been changed to use \xXX escapes instead Change-Id: Ic3e17a9849288a02dc69d7702782fefccb7026ee Reviewed-on: https://gerrit.libreoffice.org/20148 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-24Translate Korean commentsStephan Bergmann1-3/+3
...via translate.google.com, to make file plain ASCII Change-Id: Icbf25074bd92eb1f0fb453f9887b1f1f1ca82b57
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 08:54:49 +0000