summaryrefslogtreecommitdiff
path: root/helpcompiler
AgeCommit message (Collapse)AuthorFilesLines
2015-07-30loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02coverity#1309070 Uncaught exceptionCaolán McNamara1-0/+5
Change-Id: I33eca20633236ab98df0eabdec4e3761d544167d
2015-06-28coverity#1308500 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I38d6c03ee380ba6b3055e000f905a4cc568d5ab6
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-2/+1
Change-Id: I4d168bda12604116c223b6fd0d78ded484591855
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe1-2/+2
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-2/+1
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-1/+1
Change-Id: Idca144969e2b978fee8cd5b0868fcf418b193967
2015-05-29loplugin:loopvartoosmallNoel Grandin1-1/+1
Change-Id: I5518e40a30bdad53470cc52b59eff04ab6d873d4
2015-05-29loplugin:loopvartoosmallNoel Grandin1-1/+1
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-14Rename makefile to match target nameMatúš Kukan3-2/+2
Change-Id: Iba879e0c2c79fd1c307c3dfe45370dbbfd4ae998
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin2-2/+2
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07loplugin:staticmethodsNoel Grandin3-3/+3
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-03-09V801: Decreased performanceCaolán McNamara2-2/+2
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-02-21Typo: containted->containedJulien Nabet1-1/+1
Change-Id: I678c35ca2007169a38529b36fd31367bac4ed481
2015-02-21Typo: trough->throughJulien Nabet1-1/+1
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
2015-02-02Resolves: fdo#88970 fix Incorrect Extended-tips with dodgy ahelp tagsCaolán McNamara1-5/+25
ahelp puts the tip on the previous bookmarks with hid branches but has a scattergun effect if those previous bookmarks have nothing to do with the current element being described. So take the hid attribute of the ahelp and if its hid="." use the current set of bookmarks as the context otherwise believe it and apply the tip just to the stated hid Change-Id: I00648daadf5673e1abc96f222a4526959f1f7d7a
2015-01-22replace '\n' to space in extended help textAndras Timar1-0/+1
Change-Id: Ida354ee41b4158716ab39a92f009fa7c9a2ce21f Reviewed-on: https://gerrit.libreoffice.org/13919 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-01-20Some more loplugin:cstylecast: helpcompilerStephan Bergmann4-31/+31
Change-Id: I9e094356601cf156537f75d0629fd214710d80e8
2015-01-07fdo#39440 reduce scope of local variablesŁukasz Hryniuk1-1/+1
Beside scope changes, it fixes lack of initialization in a few places. Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2 Reviewed-on: https://gerrit.libreoffice.org/13755 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann1-1/+1
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara2-4/+4
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-17indent try-block, remove obsolete commentMichael Weghorn1-136/+135
indent block one level deeper than block in which it is contained Change-Id: Ibefd1a87c25100001f842f42f053d9e68feba8a6 Reviewed-on: https://gerrit.libreoffice.org/13498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15coverity#704150 Resource leak in objectCaolán McNamara1-9/+9
and coverity#704151 Resource leak in object coverity#704152 Resource leak in object Change-Id: I68c455adc25375b8027236fd44d99a397e372994
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-2/+1
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-09-11(Rudimentary) C++11 support is a hard requirement nowStephan Bergmann1-4/+1
Change-Id: I43ed776d52336b822aa6152f0f2a29e39303bb75
2014-07-01New loplugin:stringconcatStephan Bergmann1-2/+1
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-17coverity#1223090 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iec100b86e2952a5efe4fa52bd85fbc00b51f78c3
2014-06-10coverity#983682 Uncaught exceptionCaolán McNamara2-2/+4
Change-Id: Ie5c7ce0ba499ce67365c5e2079a50d73b9849e73
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin3-8/+1
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-28Fix memory leakStephan Bergmann1-6/+11
...and add---most likely necessary---null check Change-Id: I3f31c20442c45ddfd98429347f5c2521597c1769
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante1-1/+1
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold4-8/+8
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-17Avoid possible memory leaks in case of exceptionsTakeshi Abe2-8/+8
Change-Id: Ibadadacbe09a93e7d7a7210868c52a8fa582d427
2014-04-14typo: paramter -> parameterThomas Arnhold1-2/+2
2014-02-26Remove visual noise from helpcompilerAlexander Wilms1-1/+1
Change-Id: Ied20352592de019c3b4735af8cc63947cd7d61a2 Reviewed-on: https://gerrit.libreoffice.org/8266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-11coverity#707948 Uninitialized scalar fieldCaolán McNamara1-3/+5
Change-Id: I254c5695f1a80eba8a90421da3417969b3e0e8f8
2014-01-28bool improvementsStephan Bergmann1-2/+2
Change-Id: I510d75d784c357dfd3420202fc8c5769e665e456
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin1-2/+2
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin1-3/+3
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-11remove unnecessary use of OUString constructorNoel Grandin1-3/+2
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-04remove redundant calls to OUString constructorNoel Grandin1-4/+3
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-10-28Remove unnecessary SyntaxHighlighter::Tokenizer statefulnessStephan Bergmann1-1/+0
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it. Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann1-2/+2
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann1-2/+2
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-22Use conventional std::vector idiomsStephan Bergmann1-5/+5
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22Unwind HighlightPortions typedefStephan Bergmann1-1/+1
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-06-20remove last uses of config 'GUI' variableMatúš Kukan1-5/+4
Change-Id: I97188235f0b72b5b54423e05deeaf17c5c681048 Reviewed-on: https://gerrit.libreoffice.org/4188 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-06-13rename HAVE_CXX0X->HAVE_CXX11 and clean up to #define in a config headerLuboš Luňák2-7/+3
Change-Id: Id13e77fe890301a8510952994a91853568a7aea6
2013-05-07helpcompiler: remove Package_incMichael Stahl13-281/+14
Change-Id: Iddafa9068edcc20135c08ed205b8fb7fb5382eba