summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2014-09-23Related fdo#77813: $(workdirurl) was always emptyStephan Bergmann1-2/+1
Regression introduced with cb021fcafba06ccf973f2abe229a4761c0a002de "fdo#46037: remove 1 comphelper/configurationhelper in framework." Change-Id: I07727d93315e0d3d87004ce71708271e90a173a3 (cherry picked from commit 3c6da8e49a96513eda73656f3f6212f980a74b51)
2014-09-17fdo#71625 Don't loop autosave if userautosave failsMaxim Monastirsky1-7/+17
Should also fix most of the reports of fdo#46635 (I have no idea regarding the original report, because it predates the autosave feature.) Change-Id: I006d62053a159ab3157438a57dee56d6d99990a8 (cherry picked from commit 5b9509115bd4adc5ef2618f0d9436cda1c0d9fbe) Reviewed-on: https://gerrit.libreoffice.org/10859 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 9799a623161f43a0ca0c7a4806416ce466b558a6) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-08-21bnc#529470: I can't remove a path in AutoText dialogTor Lillqvist2-5/+31
This is, not surprisingly, somewhat weird code, but I think this patch does what is necessary, it does fix the bug. Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31 Reviewed-on: https://gerrit.libreoffice.org/11032 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-06-29fixes for up-casting to Reference<XInterface>Noel Grandin4-17/+27
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Signed-off-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 533c6cb6bad6ef0432e8eebbfd4daf90ef71f3b4) Conflicts: framework/source/uifactory/menubarfactory.cxx Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Reviewed-on: https://gerrit.libreoffice.org/9921 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-10fdo79368 Don't process overflow menu items twice.Andrzej Hunt1-2/+14
We reuse the toolbox overflow menu for toolbarmanager's context menu -- toolbarmanger previously added its menu listener to the toolboxes menu permanently, meaning that it would try to handle overflow menu items (in addition to the context menu items which it should handle), instead we should only add the listener when we are actually using the menu as a context menu. Perhaps it would be better in the long run to actually use fully separate menus instead, and ask toolbox to specifically add its items to that rather than trying to hack the context menu on top of the overflow menu? Change-Id: Iecface2c6eae9ab79dbcdb25ffdbaf446e2885ea (cherry picked from commit 1ae89d189200c1e351a396a3f02612b84a69985f) Reviewed-on: https://gerrit.libreoffice.org/9602 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-10avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard1-1/+1
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8 Conflicts: include/vcl/metric.hxx svtools/source/control/ctrlbox.cxx svtools/source/control/ctrltool.cxx svtools/source/control/stdmenu.cxx svx/source/sidebar/nbdtmg.cxx Conflicts: include/svtools/ctrltool.hxx include/vcl/metric.hxx include/vcl/outdev.hxx svtools/source/control/ctrlbox.cxx svtools/source/control/ctrltool.cxx svtools/source/control/stdmenu.cxx svx/source/sidebar/nbdtmg.cxx sw/source/core/uibase/docvw/srcedtw.cxx vcl/source/gdi/metric.cxx vcl/source/outdev/font.cxx
2014-05-02Add the "quoteright" key to the list of available keyboard shortcuts.Kohei Yoshida1-0/+1
Change-Id: I24800c28b1513b883c42d9ce1c787eaf07815b92
2014-04-30Toolbar overflow/context menu: keep ordering and don't discard separator.Andrzej Hunt1-1/+2
Previously the overflow/context menu should have had a separator shown between the overflow items and the hidden items, however these were inadvertently removed by ImplClearPopupMenu which filters the items before the menu is displayed. The previous ordering of items was also the REVERSE of the ordering in the toolbar -- the overflow menu is a logical extension of the toolbar hence items should be in the same order as they were in the toolbar. (cherry picked from commit 3dc6808532d86c4b00a6cb81e0adb74878c13fdd) Conflicts: vcl/source/window/toolbox2.cxx Change-Id: I8444f4814fea64be1d8f8790445ad6aa01532e70 Reviewed-on: https://gerrit.libreoffice.org/9171 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-30fdo#75489 Pass toolbar context menu commands to toolbar for handling.Andrzej Hunt1-0/+9
The toolbar context menu is handled by the toolbar manager, however the items are provided and managed by the toolbar itself -- previously any events on the list of toolbar items in the context menu were silently discarded, whereas now we pass them on to the owning toolbar. Change-Id: Ia17718c3ff8acfba1b6d655022dd9469932f3493 (cherry picked from commit 944c78ecb91608f4c3e9bab32fdbc90c67326525) Reviewed-on: https://gerrit.libreoffice.org/9170 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-25fdo#51819: autorecovery: fix saving password in protected documents.Matúš Kukan1-3/+5
Thanks to sayt@mailinator.com for the idea. Change-Id: Ib79abafe3d4d3ba21f7914aeb284d86ce662824c (cherry picked from commit ef87ff6680f79362a431db6e7ef2f40cfc576219) Reviewed-on: https://gerrit.libreoffice.org/8633 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-09coverity#1169826 Dereference after null checkCaolán McNamara1-2/+4
Change-Id: Ie431672b5a6ba1d613ae1cb9e48fa6d1db6a6b4a (cherry picked from commit 57e0062f2043f7a0382db5f4d01c6c70ca8aca46) Reviewed-on: https://gerrit.libreoffice.org/7953 Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com> Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2014-02-04fdo#70376: Put only document (file) name in window title on OS XTor Lillqvist1-1/+4
(cherry picked from commit eeb840d6ba930015b969c3d0a98031f0ae508d61) Change-Id: I0b975a1a0e73c546beec96599fd4e5f87caa51db Reviewed-on: https://gerrit.libreoffice.org/7838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann6-48/+48
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-09Startcenter: Refresh RecentDocsView when select 'Clear list' menu optionZolnai Tamás1-0/+5
Change-Id: I9cbe647563699b9b610661003084d2cd16093f9a (cherry picked from commit d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1) Reviewed-on: https://gerrit.libreoffice.org/7304 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09fdo#71883 Startcenter: Re-introduce the 'Tools' -> 'Customize...' menuZolnai Tamás1-0/+1
Change-Id: I4d3993dc855c030f8c51fe2ce3d364240e241dff (cherry picked from commit 43d355d25db1144668a59346b37b041b8a9fdbc3) Reviewed-on: https://gerrit.libreoffice.org/7333 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2013-12-16initial install-package-foo target for partial installsBjoern Michaelsen1-1/+1
make packageinfo target add uiconfig file translations add missing l10n config files add missing help files in packageinfo Reviewed-on: https://gerrit.libreoffice.org/6754 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Conflicts: helpcontent2 translations a2498a118e729276a78ef3a4eb43b5d0b302d326 9bb39bdd677af4be0da621370c51eb9e22ecc33f a7e654cdeffd832f51016ff51aa180fe3924ff4e 4ee41fdb600cb3a89da387dffe64e6a30192761c 349fb24a388775c58be7a326832b3fc0ec38180f 8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06 Change-Id: Id5f6f5c1f3e46df2d9033ccd5bbf2af6ab38a9e8 Reviewed-on: https://gerrit.libreoffice.org/6982 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2013-12-12Start center: Re-introduce the Macros menu, people use it.Jan Holesovsky1-0/+9
Change-Id: I99da1fbbd158622933445f7e97f4266a24a2d85d
2013-12-10Get rid of $(share_subdir_name) againStephan Bergmann2-8/+2
Quoting 56211a166ab25d80de84c2cccce22be15a9be051 "fdo#72394 Don't endlessly expand $(share_subdir_name) into itself": * The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime framework path variable, esp. since accidentally re-substituting it for "share" segments in unrelated URLs like <file:///export/share/for-all> does not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters" had already attempted a fix for that, but it had to be reverted again with 791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not work if BUILDDIR is different from SRCDIR." So this time fix it not via configure-expanded *.in files, but via xsltproc (for officecfg/registry/ files) and sed (for wizards/soruce/configshare files). The changes to officecfg/util/alllang.xsl will replace @LIBO_SHARE_FOLDER@ only in oor:name attribues (and in <value> text), not in any other attributes, because I have no idea how to write that generically in XSLT and it happens to be only needed in oor:name for now. Change-Id: Iec78eb70dcbf1a5bbabf4e42f21c44dc65c3e438 (cherry picked from commit 87dd1780a31de9ea1df70a8511c262ff252bf99a)
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin7-68/+68
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-09fdo#72394 Don't endlessly expand $(share_subdir_name) into itselfStephan Bergmann1-1/+2
The introduction of $(share_subdir_name) expanding to "share" in c6a73009747814513ab5a7277c211449c7378870 "Use subfolder names from <config_folders.h>" shows that SubstitutePathVariables::impl_reSubstituteVariables is fundamentally flawed in that it allows reducing variable occurrences even in variable names, so that it will expand an occurrence of "share" into an endless recursion of "$(share_subdir_name)" -> "$($(share_subdir_name)_subdir_name)" -> ... Adding $(share_subdir_name) to the list of variables that can only replace a complete path segment (delimited by "/"), from which it had erroneously been missing, "fixes" this problem for now. But the code is still wrong in at least two respects: * SubstitutePathVariables::impl_reSubstituteVariables arguably needs to be made more robust, to never reduce variable occurrences in variable names. * The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime framework path variable, esp. since accidentally re-substituting it for "share" segments in unrelated URLs like <file:///export/share/for-all> does not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters" had already attempted a fix for that, but it had to be reverted again with 791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not work if BUILDDIR is different from SRCDIR." Change-Id: If214c179c0068fbaa475c1c9cac804d6a1dbb2dc (cherry picked from commit 56211a166ab25d80de84c2cccce22be15a9be051)
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin1-4/+4
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin5-25/+25
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin6-48/+48
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin8-70/+70
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin35-160/+148
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin9-20/+20
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18fdo#69500: Revert "fix bug #60700 - de-crutify ODF files"Andras Timar1-1/+3
This reverts commit da06166015689eca260c702602bef4cea58afbd3.
2013-11-15fdo#66864: Return from full-screen should restore toolbars.Jan Holesovsky1-15/+11
The fix for fdo#37758 was not correct, we shouldn't fiddle with the m_bVisible itself, but instead react on the m_bMasterHide flag; or at least that is my understanding of the related framework code (why is it so confusing?!) Change-Id: I791fcea9e5e5313b6a5b776cb3187cbd1a028386
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann2-3/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14startcenter: Remove useless menu entries.Jan Holesovsky1-45/+0
Change-Id: Ie886beceb57201ee1a0893943c455d5f87b0d6cc
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann10-114/+113
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin1-6/+6
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13expand out the A2S macroNoel Grandin1-9/+7
Which is not doing anything useful anymore. Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin2-8/+8
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11remove unnecessary use of OUString constructorNoel Grandin1-1/+1
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11remove unnecessary use of OUString constructor in FRAMEWORK moduleNoel Grandin13-46/+43
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
2013-11-10cppcheck: reduce scopeJulien Nabet1-2/+1
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
2013-11-08Unwind SFX_REFERER_USERStephan Bergmann5-14/+6
...and remove remaining unused content of sfx2/source/inc/referers.hxx. Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
2013-11-05fixincludeguards.sh: frameworkThomas Arnhold203-582/+582
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin4-7/+7
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin1-2/+2
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-7/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03StatusIndicatorFactory::impl_reschedule(): lock SolarMutexMichael Stahl1-1/+4
... before calling Reschedule(). Change-Id: I244fdd1a4642ea0e1ad266f6d9c4c56527018952
2013-11-01Improve exception messages (for debugging)Stephan Bergmann1-2/+5
Change-Id: Id2e00e0b0363c58c88585dd15f34156e57a7aaac
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin13-22/+22
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl1-2/+0
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28remove local css namespace definitionsThomas Arnhold2-3/+0
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-23clean up some include guardsThomas Arnhold3-9/+9
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl1-2/+2
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486