summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2014-12-09changed timers to idleJennifer Liebel4-22/+22
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09changed timers to idleJennifer Liebel1-2/+2
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09changed some timer to idleJennifer Liebel4-20/+20
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09framework: avoid double-free in ToolBarManager()Michael Stahl1-0/+6
The timer could run after the ToolBarManager is deleted because the dispose() method can accidentally restart the timer somehow. Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935
2014-12-09changed timers to idleJennifer Liebel4-22/+22
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller1-2/+2
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-12-09changed some timer to idleJennifer Liebel4-27/+21
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-08Resolves: fdo#86820 executing toolbar menu entry can destroy menuCaolán McNamara1-5/+12
Change-Id: Ide0ea8f8ff145d487e409b0091918b59f1f83405
2014-12-04Avoid automatic toolbars in the non-desktop caseTor Lillqvist1-0/+6
Change-Id: I9e5bff735b0035c147e10ae066da3a4873d66749
2014-12-04Ignore exceptions when getting the background color configurationTor Lillqvist1-3/+14
We are experimenting with a pruned configuration database in the desktop case, and letting the exception propagate here killed the document loading. Change-Id: I59e5d016617c17c2bc36de2fd69c6691bfa6b135
2014-12-03Further clean-upStephan Bergmann2-9/+0
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
2014-12-03Code clean-up/consolidation task.Vishv Brahmbhatt2-47/+6
Removing the duplicate code,and consolidating changes by using method "getExpandedFilePath" of comphelper. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: adapted to recent change from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the two changes in framework to actually modify the by--non-const--ref argument; fixed a loplugin:unreffun. More clean-up to follow. Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl3-5/+5
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25java: final fields that can be staticNoel Grandin1-1/+1
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25java,framework: remove unused vars and parametersNoel Grandin7-28/+12
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951 Reviewed-on: https://gerrit.libreoffice.org/13098 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin3-6/+6
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-24typo: unknownAndras Timar1-2/+2
Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
2014-11-20Revert "coverity#1169848 Uncaught exception"Stephan Bergmann1-48/+38
This reverts commit b0a7722ebfa720255b6ce1e383a3aacae0ce5e9f, now that fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw IllegalArgumentException" made the underlying problem go away. Conflicts: framework/source/services/modulemanager.cxx Change-Id: I6599cf25d4f28d2bab19da67d5de5caacd84a622
2014-11-19Revert "cid#706553 Uncaught exception"Stephan Bergmann2-3/+2
This reverts commit 0a87f4ad1a45aaaaad885a1418d0d6bed21db456, now that fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw IllegalArgumentException" made the underlying problem go away. Conflicts: framework/source/inc/loadenv/loadenv.hxx framework/source/loadenv/loadenv.cxx Change-Id: Id2f468bf0f24f5a8a7a0e6eb113ccfedd35b03cc
2014-11-19Revert "cid#706552 Uncaught exception"Stephan Bergmann2-2/+2
This reverts commit ecd00991fd5884cd769ed00c9c3f42ba44d64511, now that fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw IllegalArgumentException" made the underlying problem go away. Conflicts: framework/source/inc/loadenv/loadenv.hxx framework/source/loadenv/loadenv.cxx Change-Id: I7821ae67b5cc99b8591fbf06396ac20098e55c8d
2014-11-19Revert "cid#706551 Uncaught exception"Stephan Bergmann2-2/+2
This reverts commit ec651eaead5aaa2a74f4c87d3bf17f7feddb958e, now that fced31697bcc2a2a4da34d804582002de0320302 "comphelper::SequenceAsHashMap: throw IllegalArgumentException" made the underlying problem go away. Conflicts: framework/source/inc/loadenv/loadenv.hxx framework/source/loadenv/loadenv.cxx Change-Id: I473815256b95f6e20a2e1a4a5617f491636305ab
2014-11-19comphelper::SequenceAsHashMap: throw IllegalArgumentExceptionStephan Bergmann1-0/+1
...instead of IllegalTypeException (where the latter is not a RuntimeException). Fixes cid#707218, cid#1224993, etc., and reverts previous fix 358f5280e0f6afb968edc295d8f1dce55f05e18f "Fix coverity#1224993 w/o breaking JunitTest_framework_unoapi." Change-Id: I13ce153e1513749fb0be2ee8e560cec86a30c5ba
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl10-0/+10
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-18java: make fields final where possibleNoel Grandin15-33/+33
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18fdo#82708 editing statusbar tooltip textsYousuf Philips1-1/+1
Change-Id: I3ac2e46f89d5c1e4decb6d6aaf8487663e904a43 Reviewed-on: https://gerrit.libreoffice.org/12433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17coverity#705177 Missing break in switchCaolán McNamara1-0/+1
this is the "close toolbar" button on right clicking a toolbar. close toolbar continues to work as expected Change-Id: I436fbe9f133442136b6e60a1f6080926f64eaef6
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+2
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava16-36/+36
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13coverity#1251595 Uncaught exceptionCaolán McNamara2-4/+5
Change-Id: I24eaec49bb89e9f490d5bb0071723b41673e1845
2014-11-12typo: represant->representAndras Timar2-3/+3
Change-Id: If783e9338644a97206d99864ed19807e5fb3882d
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini26-93/+93
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin3-27/+25
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo82708 Add missing tooltips to Writer StatusbarSamuel Mehrbrodt3-0/+7
Change-Id: Ie44b8de69b98ebfa789cc8f9a1d8a60b698fc154 Reviewed-on: https://gerrit.libreoffice.org/12368 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann3-4/+5
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin3-5/+4
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06rename KEY_MODTYPE to KEY_MODIFIERS_MASKNoel Grandin2-2/+2
Change-Id: I7948988e4fd89bf94a98afee15298cd33e2a4d06
2014-11-05markup with event type not checker typeCaolán McNamara1-2/+2
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin2-3/+3
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-16/+13
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin8-20/+20
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31framework: avoid double-free in ToolBarManager()Michael Stahl1-3/+11
The timer could run after the ToolBarManager is deleted because the dispose() method can accidentally restart the timer somehow. Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30Kill some static OUStrings.Jan Holesovsky5-53/+19
Change-Id: Ic06a3b4673446bbadd21f2380c04ec628a6f86a9
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin4-4/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1202880 annotate Dereference before null check as false positiveCaolán McNamara1-0/+2
and coverity#1202881 Dereference before null check as false positive Change-Id: Id2c1ff2a5913755e9160807eace3219be3b35fd1
2014-10-24coverity#704649 Unchecked dynamic_castCaolán McNamara1-3/+3
Change-Id: Ibeb096d98cba7a55d9d806802473660d30000924
2014-10-23coverity#736876 Negative array index readCaolán McNamara1-3/+2
Change-Id: I5e0f2e4633286b320abfb6735232b57aedd3a5b3
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin5-19/+19
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-22framework, unotest: do not override UserInstallation from environmentMichael Stahl1-1/+3
The PythonTest_dbaccess_python may fail in incremental builds because of stale JVM path in workdir/unittest/user/config/javasettings_Linux_X86_64.xml so it's better to use the fresh UserInstallation that is already passed in from PythonTest.mk. To make that work, tolerate non-existing path in SubstitutePathVariables::SetPredefinedPathVariables() at least when running in the build environment, which is probably better than effectively running with "/" as UserInstallation anyway... This partially reverts commit 6dbb6275ebd1a4299099c3b6bc82ec4ee0e1fb86. Change-Id: I4d42d53c049056590662828360c4ce5a29af0f4b
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-24 04:52:42 +0000