summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2016-04-05tdf#98837 - Fail loading a new document with read only property set to trueAkash Jain1-3/+15
When opening a new document, via any API, (URL: "private:factory/swriter") with read-only property set to true, Writer opens with a new document in edit mode. But the title still has (read-only) in it. Since a document can only open in read-only mode if it has been saved first, the loading of new documents with read-only property set to true will now fail. Change-Id: I370e6fb1c94b6476c2ded872d6d7c820b25db53a Reviewed-on: https://gerrit.libreoffice.org/23812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan12-27/+18
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan10-25/+13
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke9-10/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01sequence->vector in frameworkNoel Grandin20-110/+104
Change-Id: I457c3da4f4a31f58d688dcd96a2ccfc36518490d Reviewed-on: https://gerrit.libreoffice.org/23692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack6-12/+12
Including no keywords from extern "C" blocks Change-Id: Id9dd5a53d6ea5134ebb473bd0463f8f42965a211 Reviewed-on: https://gerrit.libreoffice.org/23674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-01tdf#98849 SaveToolbarController: Correct initial modified stateMaxim Monastirsky1-0/+3
Regression of 69882b0ef861099fd6bfa802d6f7ba5d1391c269 Change-Id: I3698efff2f1e62e513d779400eff7f1c4a4145e4
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke2-2/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin2-6/+6
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin1-3/+3
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30tdf#96896-Fix infinite recursion to prevent Writer crashakash1-1/+1
To prevent infinite recursion set m_xOwner to null. Removed impl_sendTitleChangedEvent from disposing method ensuring that title is never constructed for a component that is disposing. Change-Id: I9bc20a9a582d5d911509d2aa30fb0d0122eb588e Reviewed-on: https://gerrit.libreoffice.org/23509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-30notebookbar: Instantiate the notebookbar via sfx2 infrastructure.Szymon Kłos1-5/+0
Change-Id: Iaed4596246245560e646d9086e717d5fb516897e
2016-03-29framework: cid#1357163 fix the fix d5e4fe23Michael Stahl1-4/+1
The branch was never taken in the old code, and re-acquiring the mutex without releasing it first is pointless. Change-Id: Ic865dccf2c442d2625436e175aef91be59d05325
2016-03-29Rename OfficeIPCThread to RequestHandlerStephan Bergmann1-2/+2
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
2016-03-29handle failure to expand ~ in path elements.Michael Meeks1-4/+4
This can occur in some online corner-cases. Change-Id: Id8b419179d775a21110d682ba76d8a02f45eb828 Reviewed-on: https://gerrit.libreoffice.org/23577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-29cid#1357163: 'Constant' variable guards dead codeStephan Bergmann1-6/+2
...after 2f804099b7daa42aecb8fa445072a381671f3385 "loplugin:constantparam in framework" Change-Id: Ife3ca1da7652ffc52ae2d6057712dcaa35ba2e06
2016-03-23loplugin:constantparam in frameworkNoel Grandin11-70/+25
Change-Id: I7b7914365ef5d5c6f120f34c93f359c156aa6a02
2016-03-21tdf#98745 Optional save button without the dropdownMaxim Monastirsky1-9/+16
Change-Id: I66499a9108dce76e661df9b5b45b249caf9eece8
2016-03-17tdf#92049 NewMenuController: track icon theme changes tooMaxim Monastirsky2-1/+5
Change-Id: I2f2c990b2cbacddf94bf74329d641d5a7e489773
2016-03-16Related: tdf#98637 make this a tractable problemCaolán McNamara3-15/+28
This is just too hard, it would all be much easier if the ActionGroup existed right from the start of the entire process. So smuggle in to the ctor the toplevel frame that the menubar will be inserted into so we can use its ActionGroup from the start. That would suggest that we could then just keep the hierarchy in sync as it is created rather than finding opportune moments to update /generate it. Change-Id: I550f94a994210423ab9cea1986e643056cb5bd29 Reviewed-on: https://gerrit.libreoffice.org/23287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-15loplugin:salboolNoel Grandin1-2/+2
Change-Id: I4d76392263cce45eb34cbc2f35afff0416b08c4a
2016-03-15loplugin:constantparamNoel Grandin1-1/+1
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-15tdf#91794 remove OSL_DEBUG_LEVLEL > 1 conditionalsRohan Kumar1-4/+4
I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 and made sure that the build doesn't break. Change-Id: I9a07da5b0f19d695339705e00112956a56589327 Reviewed-on: https://gerrit.libreoffice.org/23230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14remove some unused Java codeNoel Grandin1-1/+1
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-14inline some use-once macrosNoel Grandin2-125/+46
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack2-2/+2
Change-Id: Iced527f48afa828cc9acf5b6461674a2706cbcd7 Reviewed-on: https://gerrit.libreoffice.org/23135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11framework: Kill BmkMenuMaxim Monastirsky5-244/+34
Change-Id: I182e752f5602d946f27206a1bb744c5d2248bdf8
2016-03-10MenuDispatcher::m_pMenuManager is always nullptrMaxim Monastirsky14-1594/+132
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f. Which means that MenuManager is unused, and MenuDispatcher does nothing useful. Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c Reviewed-on: https://gerrit.libreoffice.org/23117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-10loplugin:constantparam in toolsNoel Grandin1-2/+2
Change-Id: Ibd093ba4e8140ed3fda87ef340280433302f82a5
2016-03-10loplugin:constantparam in frameworkNoel Grandin5-46/+13
Change-Id: I41c83b6214e3af7b3a40c8e00df5f100e39ebad7
2016-03-08tdf#98407 PathSubstitution: Add substitution for $(username)Samuel Mehrbrodt2-0/+9
This allows to use the username as a placeholder in the config paths (Autotext, Gallery, etc) Change-Id: I76434e980cd8ec8785a5587d0bc5fdd67dc42de2 Reviewed-on: https://gerrit.libreoffice.org/22901 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07improve defaultparams lopluginNoel Grandin1-1/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-02extra menubar displayed after exiting embedded object editCaolán McNamara1-11/+46
when using native gtk3 menubars. The issue is that MenuBarManager does not own its MenuBar. And in this embedded menubar situation a new menubar is newed and passed to m_pInplaceMenuBar but nothing destroys it. Now with native gtk3 menubars this becomes obvious as the native menubar stays behind, while in the non-native case the old menubar is replaced by the new one so while it still leaks the menubar you don't see it. Change-Id: Id732cb66664a71efc471d7bad35f4de890e1017e
2016-03-02loplugin:unuseddefaultparam in frameworkNoel Grandin3-14/+5
Change-Id: I4c5baa6f524e3382794c4844b7444904cc38584a
2016-03-01tdf#98277 Display shortcut only in tooltip, not in toolbutton nameSamuel Mehrbrodt1-2/+4
When toolbar buttons have no icon, the text is displayed instead. In this case the shortcut should not be displayed (only in the tooltip). Change-Id: I42ac855c8f9bbbad5114b77a29927003b8ca095e
2016-03-01tdf#98277 Extensions: Display shortcut in toolbar tooltipSamuel Mehrbrodt1-0/+3
Change-Id: Icc16860d8b47a3724838fdb3dcb72dfb4398167d Reviewed-on: https://gerrit.libreoffice.org/22779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-29language submenu from tools->language->for selection->"languages"...Caolán McNamara1-14/+11
is always disabled/empty since... commit a6e8910a3c5d33e671a13559438b7228596b8bca Date: Wed Feb 17 12:07:59 2016 +0100 allow disabling file/new, wizards, recent documents menu entries disabling the dispatches '.uno:AutoPilotMenu' and '.uno:AddDirect' and .uno:RecentFileList via UNO API now results in disabled menu entries as expected Change-Id: Id99be9374306ff8c0cea919ea94ed96f715a8058 Reviewed-on: https://gerrit.libreoffice.org/22422 reverting this hunk restores them again Change-Id: I029c9c3f25fb593127ee8371b278cee102c65882 Reviewed-on: https://gerrit.libreoffice.org/22749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-28tdf#84258 Allow creation of command aliasesMaxim Monastirsky3-11/+24
We already can use different labels for commands, based on whether they're in a menu, context menu or a toolbar. But in some cases we need different labels for the same type of UI element, or even different icons. One example is page/slide commands in Draw/Impress, as they share same commands, but need different icons/labels. Creating full-fledged duplicate slots just to satisfy the need of UI representation seems like overkill, and isn't flexible enough. The proposed solution is to allow creation of command entries, that do not correspond to real application slots, but instead link to another existing commands. The "real" commands will be used for controller factory and dispatch (execute/status) APIs, thus fully retaining functionality. This can be useful also for giving icons to complex commands (i.e. commands with arguments). Change-Id: I9b261b406ec8fc781cae06cf283963386379d4ad
2016-02-24convert EConfigurationModes to scoped enumNoel Grandin7-26/+26
Change-Id: I1e81c8d637e738f536f7efad8b67d0c9183e6483
2016-02-22loplugin:write only fieldsNoel Grandin4-98/+0
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-20tdf#57950 Replace chained O(U)StringBuffer::append() with operator+irem1-6/+1
Change-Id: I6e428222bfb3045b6a379716586aa5e37a3cae35 Reviewed-on: https://gerrit.libreoffice.org/22052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-18allow disabling file/new, wizards, recent documents menu entriesOliver Specht3-36/+47
disabling the dispatches '.uno:AutoPilotMenu' and '.uno:AddDirect' and .uno:RecentFileList via UNO API now results in disabled menu entries as expected Change-Id: Id99be9374306ff8c0cea919ea94ed96f715a8058 Reviewed-on: https://gerrit.libreoffice.org/22422 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin3-3/+3
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#91013 Convert freezepanes menu to xmlMaxim Monastirsky3-109/+0
Change-Id: Iedab5e5be5358f7716a2b33de3f0db582a401155
2016-02-17tdf#91013 Add new uno commands to freeze one row and column.Gulsah Kose4-4/+118
Added freezepanesfirstcolumn and freezepanesfirstrow commands. FreezePanes button became a split button that includes this two new uno commands. And this new commands added to menu. Change-Id: Ic6958067cc98b3df50bcd06a1eac220bd9a61473 Reviewed-on: https://gerrit.libreoffice.org/21604 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2016-02-16tdf#39440: reduce scope of local variablesArnold Dumas1-2/+2
Change-Id: I6ba411d2e07240821518281996d543f71acf3259 Reviewed-on: https://gerrit.libreoffice.org/22378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-15tdf#97665 Let's hope that over activation isn't really neededMaxim Monastirsky1-7/+4
- MenuBarManager::Activate has a check for duplicate activation, which makes the second activation attempt fail. Removing this check or deactivating after each activation will likely affect performance even more, but on the other hand should solve lp#1296715, which was the main reason of the over activation in the first place. So let's activate only one menu at a time, and do full activation only on the initial update. - Unfortunately the HUD activation callback doesn't work, so we still have to keep active status listener for all menu items. (Which is BTW against the recommendation in XPopupMenuController::updatePopupMenu IDL doc. Fortunately the performance problem hardly noticeable on modern hw.) Change-Id: I96affa72412f3f38160fdca4b6efd20ca68d059f Reviewed-on: https://gerrit.libreoffice.org/22369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-10tdf#97435: Avoid persistent window state crack when used from LibreOfficeKitTor Lillqvist2-1/+11
Change-Id: Icab7dea3cf63f3932b7759acec339b498a8ac9c5 Reviewed-on: https://gerrit.libreoffice.org/22233 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-02-09Revert "tdf#97435: Avoid persistent window state crack when headless"Tor Lillqvist2-9/+1
The change caused failures in some Java unit tests. This reverts commit 882d27fce20ee0537f785a619be1dd065ea6bbca.
2016-02-09tdf#97435: Avoid persistent window state crack when headlessTor Lillqvist2-1/+9
Change-Id: Icab7dea3cf63f3932b7759acec339b498a8ac9c5 Reviewed-on: https://gerrit.libreoffice.org/22233 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 16:53:27 +0000