summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2016-05-26lokit: ensure progress value sequentialHenry Castro1-1/+1
When it is saving a impress file, the status indicator sometimes receives lower values, that it is reflected to client side a flash to the progress bar. Change-Id: Ib3e8499357984843650c8d897c7b1d6baeb65ff6 Reviewed-on: https://gerrit.libreoffice.org/24326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-25sw: replace boost::shared_array with std::shared_ptrMichael Stahl1-1/+0
Change-Id: I99eec60db7f6d586b3b424661e03a7891422ab2e
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara4-31/+0
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25convert ImageType to scoped enumNoel Grandin3-55/+49
and drop duplicate definition in framework. Change-Id: I6cb95241e659ad58429bffeaaf2f95b07ad12df6 Reviewed-on: https://gerrit.libreoffice.org/25400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Fix typosAndrea Gelmini1-2/+2
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25tdf#98753 Find Toolbar does not display "Search key not found"Samuel Mehrbrodt1-7/+22
Revert "Toolbar: Refactor insert toolitem code" This reverts commit 27bdc70d83d4a4f1ebb89429f61b39084e739aaa. Change-Id: I1d46cddfd656ab8c809b6cd6308725a8e67fe538 Reviewed-on: https://gerrit.libreoffice.org/25433 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin2-5/+6
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin2-6/+5
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23framework: last dispatchInterceptor gets asked firstThorsten Behrens1-9/+8
Align implementation with API contract as spelled out in offapi/com/sun/star/frame/XDispatchProviderInterception.idl - no idea why this change happenend in 2003: Date: Fri Apr 4 16:16:05 2003 +0000 INTEGRATION: CWS fwk01 (1.1.72); FILE MERGED 2003/04/01 12:40:09 as 1.1.72.1: #107642# change order of used interception objects At any rate, with this change extensions actually get a chance to see dispatch requests first, and process/ignore at will. Change-Id: I58876150ee6d67e592f41b3e82a9ffc314e091a3 Reviewed-on: https://gerrit.libreoffice.org/25215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-20framework: avoid excessive queryDispatch callsThorsten Behrens1-7/+14
Make better use of the css::frame::XInterceptorInfo interface, to avoid calling queryDispatch() pointlessly on interfaces that have explicitely opted out. Since that already broadcasts which urls we're interested in - so just don't bother calling entries who are not matching. Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae Reviewed-on: https://gerrit.libreoffice.org/25214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin8-8/+11
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin1-1/+0
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Fix unnecessary indent.Jan Holesovsky1-9/+11
Change-Id: Icf60f59e997afba28ac5115f7d7c4709a3f11a4a
2016-05-19tdf#99926 Add "Save as template" to Save dropdownSamuel Mehrbrodt1-15/+24
Change-Id: Ia594e69e46253eb2db4fcf27ca108323a3d45f5f Reviewed-on: https://gerrit.libreoffice.org/25113 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin9-830/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Resolves: tdf#99857 missing items from toolbar right clickCaolán McNamara2-15/+6
we do an activate/deactivate to force the vcl menu to update so we have a full model before we try to show the gtk one. This particular toplevel menu has a deactivate handler which empties out the submenus on the deactivate, so we don't get the full thing, so we end up with missing entries. The Deactivate to empty the menu is a bit dubious. Even if we limited the activate/deactivate to submenus we still get the deactivate before the "select" so the ordering is fragile. The Deactivate handler seems dubious anyway, why not just clear it out after the Execute has finished which is simpler and more direct anyway dde83e3cea5b5fc1f91ebd336a2071ce8ff75e75 Change-Id: I56145f6236db1787cc4ee623c513cb927bf2a972
2016-05-12framework: register DispatchDisabler serviceMiklos Vajna1-0/+3
Change-Id: I72d9f8b00ba8b2e4e5dc70d7fd77e13ccf9d3bcc Reviewed-on: https://gerrit.libreoffice.org/24940 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-12framework: initial implementation of a dispatch disabler.Michael Meeks6-3/+295
This should allow remote, eg. URE dispatchers to trivially disable lots of the UI without requiring a large volume of round-trip IPC. Change-Id: Ibd0681ac993196f826b4ed411da5ffedb7f85786 Reviewed-on: https://gerrit.libreoffice.org/24938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-11Include cppumaker-generated .hpp, not .hdlStephan Bergmann1-1/+1
Change-Id: Ib0451f26edbfbcdfdca78caa97bd09bc65ec2782
2016-05-10Convert TOOLBOX_MENUTYPE_ to scoped enumNoel Grandin3-6/+6
Change-Id: I8eb25fc274b45b8add04dfc03e4b52f130ad04de Reviewed-on: https://gerrit.libreoffice.org/24827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Convert StatusBarItemBits to scoped enumNoel Grandin5-32/+32
Change-Id: Ic979d1470052039c4b966edd1d896af31ef55668 Reviewed-on: https://gerrit.libreoffice.org/24826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin2-4/+1
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-04LoadEnv::getTargetComponent() is supposed to return nothingMaxim Monastirsky1-0/+1
... if loading the document failed. Make sure that's the case also when the frame containing BackingComp was about to be recycled. Can be tested by trying to open password-protected odt, but canceling the password prompt. Change-Id: I733357b3a961fd88db010dd8eb89e01f0cad10fa
2016-05-01tdf#97499 Fixed containers parameters clearing #8tymyjan1-2/+2
Change-Id: I82ca89ac483e9742be0d38a3c6882a240c7c38d8 Reviewed-on: https://gerrit.libreoffice.org/24499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28framework: CheckXTitle still sometimes fails on WNT...Michael Stahl1-0/+2
... when dispatching the .uno:CloseWin. Change-Id: Iaf0651ea7e05bd8a6629d5af6e62f5918ef241ce
2016-04-27SubToolBarController: Use initialize to change tb bitsMaxim Monastirsky1-6/+6
update is called so late that the dropdown addition is noticeable by the user. Change-Id: I36d76770125f927a851caef010e81f12f40d4405
2016-04-27tdf#80999 Canceling password prompt should abort detectionMaxim Monastirsky1-0/+5
... instead of continuing the detection loop and being "detected" as plain text. The detection API will from now return a type based on the file extension only, which is far more useful than "plain text" anyway. Plus the media descriptor has a flag to indicate that the detection wasn't completed, which can be also used by the loading code to abort the loading process. Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946 Reviewed-on: https://gerrit.libreoffice.org/24428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-04-27clang-tidy modernize-loop-convert in f*Noel Grandin6-28/+28
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
2016-04-27tdf#99527: show all accelerators in menus of extensionsOliver Specht1-1/+4
XCUBasedAcceleratorConfiguration::getPreferredKeyEventsForCommandList() throws if the command string of a menu entry is empty. Parent entries of sub menus of extensions are empty. As the method doesn't know about the source of the command a dummy entry is supplied. Change-Id: I1d12bbf41c22b66e9ee29f1f05ea216134168795 Reviewed-on: https://gerrit.libreoffice.org/24423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-26Change label to title case similar to other surrounding labelsYousuf Philips1-1/+1
Change-Id: I4b02aada5e50e7b30ed23fe12fab1c99f38ccfeb Reviewed-on: https://gerrit.libreoffice.org/24056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-22loplugin:salboolStephan Bergmann1-1/+1
Change-Id: I14a902c644c467d8e02474e5d0ba8d3dced2860f
2016-04-22Fix typosAndrea Gelmini2-2/+2
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21Fix typosAndrea Gelmini2-2/+2
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann49-160/+160
Change-Id: Idf27ee5370f1fa24adf22908d9e801c7d40db935
2016-04-19Elide macros used onceStephan Bergmann2-22/+11
Change-Id: I5d5c916c966c9e9f2c77c9655f3e8d13a7032117
2016-04-18Remove unused XMLNS_XLINKStephan Bergmann2-6/+0
Change-Id: Ibb2831ed71f61461e7f23edd6eea29ba64df05a9
2016-04-18Elide macro used onceStephan Bergmann2-3/+3
Change-Id: Ie0ad7834f54a5bf9cea65b4bb6d7501a90da0f24
2016-04-18Clean up framework/inc/dispatchcommands.hStephan Bergmann3-16/+12
Change-Id: I6a9a8ae34c2f5abafd4192287fb12d4289a761ff
2016-04-18Remove dead ENABLE_COMPONENT_SELF_CHECKStephan Bergmann2-349/+0
There is no sign it got ever used past 4011187ff516846635d4e2c3256dca3eb8c3719f "MWS_SRX644: migrate branch mws_srx644 -> HEAD" at least. Change-Id: Ia98613420a095b326ad26c024ff74f3c62bf4f99
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin10-91/+43
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke2-2/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-16bin theseDouglas Mencken1-15/+2
Change-Id: Ic43d15d68533ee19b1a7268e5b139e4584ceeb42 Reviewed-on: https://gerrit.libreoffice.org/24121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14Race between Frame::dispose and timer-triggered LayoutManager::AsyncLayouHdlStephan Bergmann1-1/+13
Change-Id: I8e9ca61c2a8334697b7a0adef7a2fc20f503f299
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke2-2/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13Avoid null ToolBox::mpData deref during Frame::closeStephan Bergmann1-0/+3
Oh my, whatever the true cause for this SEGV in JunitTest_framework_complex, <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/6628/console>, processing an incoming URP request > ToolBox::GetMenu() const at vcl/source/window/toolbox2.cxx:1775 > framework::ToolBarManager::ImplClearPopupMenu(ToolBox*) at framework/source/uielement/toolbarmanager.cxx:1309 > framework::ToolBarManager::dispose() at framework/source/uielement/toolbarmanager.cxx:470 > framework::ToolBarWrapper::dispose() at framework/source/uielement/toolbarwrapper.cxx:106 > framework::ToolbarLayoutManager::destroyToolbars() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:654 > framework::ToolbarLayoutManager::reset() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:363 > framework::LayoutManager::implts_reset(bool) at framework/source/layoutmanager/layoutmanager.cxx:413 > framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) at framework/source/layoutmanager/layoutmanager.cxx:2804 > (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) at framework/source/services/frame.cxx:2953 > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1449 > (anonymous namespace)::Frame::close(sal_Bool) at framework/source/services/frame.cxx:1689 > framework::Desktop::impl_closeFrames(bool) at framework/source/services/desktop.cxx:1674 > framework::Desktop::terminate() at framework/source/services/desktop.cxx:238 and the main thread idling in Application::Yield. Change-Id: I41ff8007ee4bbc37473aa5f077ff706b51d31c64
2016-04-13Use UNO service constructorsStephan Bergmann1-10/+4
Change-Id: I8ac2621a4594b2d8a7cf8fdafd2191f3bf52579b
2016-04-13remove unused m_xFrame in CheckXTitle unit testAkash Jain1-14/+0
Change-Id: I1b654b308b79d13d23a1b9a935fd2eaf84836d91 Reviewed-on: https://gerrit.libreoffice.org/24044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-13Tooltip/bits should also depend on state changeMaxim Monastirsky1-8/+5
Change-Id: I18093e42dd2fc54483e620759e4ba00c988ce9db
2016-04-12Avoid reserved identifiersStephan Bergmann2-4/+4
Change-Id: I13bbc627ba058143862a77d27bbca85f2d961d60
2016-04-12Try to fix Windows buildMaxim Monastirsky1-1/+1
Change-Id: I46d1d3428ba1cfd8c0ab47aff6b32807e52c3c48
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 01:02:31 +0000