summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák3-123/+15
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-30loplugin:unusedfieldsNoel Grandin2-8/+0
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28remove some unused local varsNoel Grandin1-2/+0
found by my new loplugin:unusedvariableplus Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28New loplugin:unsignedcompareStephan Bergmann4-7/+11
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-27Use properly typed variables for iterationStephan Bergmann1-4/+4
Change-Id: I3c8a8adc20fe404befa360e49ab42f2ffd93d27f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87489 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26rename some local variablesNoel Grandin2-2/+2
mostly to make the job of my very aggressive unused local vars plugin easier Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25lok: status update - avoid SIGFPE on zero range.Michael Meeks1-4/+7
Change-Id: I75597696b529f833bbc699f66f5a4bcdc06748d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87368 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-24tdf#130096 Wrap Sidebar update use common .uno commands and layoutandreas kainz1-0/+4
Change-Id: Ie8185169582616179fd96850283836f4e3d60ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87309 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-21remove unused GSOC 2005 "Tabbed Document Windows for OOo"Caolán McNamara10-1234/+0
this was #i54847# Change-Id: I312e3ea9b123976e9929f6601a931ff8a108d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: If130c8a4861998d7eafd2e9525592f3c811ec21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-17m_aListenerContainer is effectively unused hereNoel Grandin2-17/+4
ever since initial commit Change-Id: Ia4cde1696edd26b8ddac3d093e043064d1cf87d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15hold SolarMutex on calling vcl toolbox enable itemCaolán McNamara1-0/+1
Change-Id: I35bbe90fbda6c46c1ad173746171b3ede1b2105c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15tdf#125089 Fix shoowing a separator in View-User interfaces submenusRoman Kuznetsov1-1/+2
for non EN GUI Change-Id: I8761560e48f781ed516494984fc5a86c72019ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86619 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2020-01-14loplugin:finalclasses in frameworkNoel Grandin72-113/+92
Change-Id: I5405a123e887173fe4b90d66dab6225bf43883ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-13loplugin:unusedfieldsNoel Grandin2-2/+0
Change-Id: Iaf188bfd43396eeec31e62ac3de3fbc76da4331a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09tdf#129600 Delete "Formula bar" item from View-ToolbarsRoman Kuznetsov1-3/+1
Change-Id: Iec6c6c998a12aafdbf63bc1e5083cf577aefb437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86354 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-08Fix typo/grammarAndrea Gelmini1-1/+1
Change-Id: I8e7320224a9cb4ff9317b842a2c1c0b1a3ddcd17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86390 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I0cf1ab7a86fd3b9323f1b5d219b6943b2f61884c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86300 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini1-2/+2
Change-Id: Ic26a634c3f7cb089743f6d6d2a67e38f8104f724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86302 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-07Fix typoAndrea Gelmini1-2/+2
Change-Id: I0c62fbf27986f20388d6fb7f44f4e998657d791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86301 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-06weld AreaPropertyPanelCaolán McNamara12-64/+64
Change-Id: I5f4c4b43067b99cd57f8ea941002481ef5977e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86144 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06Don't crash on exiting print preview with NotebookbarMike Kaganski1-1/+1
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Display menu item keyboard shortcuts in toolbar menuJim Raykowski1-0/+6
Change-Id: I288d4850f9a8e9ac51dfefddff7a2a7d359178c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85832 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-28Fix typoAndrea Gelmini1-1/+1
Change-Id: Iebf4da702da03d9888bad314eb401cff6a26bd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85903 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-23tdf#46037: remove configurationhelper in framework/helponstartupJulien Nabet2-20/+9
Change-Id: I56b3e0351255e2b73871d69189338fdf3a97e9be Reviewed-on: https://gerrit.libreoffice.org/85716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-23tdf#46037: use officecfg/SetupJulien Nabet2-25/+10
+ replace define OFFICEFACTORY_PROPNAME_ASCII_WINDOWATTRIBUTES used once Change-Id: I0930dc8a2d8df76b93e634a594cbfdf4a4cd634b Reviewed-on: https://gerrit.libreoffice.org/85706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19sal_Char->char in forms..frameworkNoel Grandin6-6/+6
Change-Id: I756c1f54d50403aa9b4f03dbbc2a387556f07084 Reviewed-on: https://gerrit.libreoffice.org/85475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-17Elide use of rtl_Instance (which is obsoleted by C++11 thread-safe statics)Stephan Bergmann1-34/+8
Change-Id: I9ee0d2ecbb75afe5a341eac308bb6718e5830749 Reviewed-on: https://gerrit.libreoffice.org/85262 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Remove redundant member clear() from dtorStephan Bergmann1-7/+0
...and then remove newly-redundant user-provided dtor completely, similar to <https://gerrit.libreoffice.org/#/c/85032/> "Remove some redundant user-provided dtors" Change-Id: I185d3aa7c16b5d4e6e64345c7fa221b9ed0cde6e Reviewed-on: https://gerrit.libreoffice.org/85038 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-04-Werror=maybe-uninitializedStephan Bergmann1-1/+1
And /org.openoffice.Office.Recovery/RecoveryEntry/DocumentState is nillable, so xItem->getPropertyValue(CFG_ENTRY_PROP_DOCUMENTSTATE) >>= tmp; can presumably fail. Change-Id: I08c38aec13b2ceda512925b18aefd5981cf85bcd Reviewed-on: https://gerrit.libreoffice.org/84422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-04Harmonize mask value notation (across DocState and Job enums)Stephan Bergmann1-1/+1
Change-Id: I39bd6fd2c7e47b53139ad149e38d21042d61917c Reviewed-on: https://gerrit.libreoffice.org/84407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-04use scoped enumStephan Bergmann1-111/+117
Change-Id: I1b8604e8f06eaea39fbd505e632fc090c0a37d0e Reviewed-on: https://gerrit.libreoffice.org/84379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03enum WindowsStateMask type itself is unusedStephan Bergmann1-1/+1
(found with upcoming loplugin:unusedmember) Change-Id: I2a7de15da061c4c0d4dc163c59370db6da763c2c Reviewed-on: https://gerrit.libreoffice.org/84316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann1-81/+89
Change-Id: I41a810d14be0a7f18c91b62e5d982c12db593183 Reviewed-on: https://gerrit.libreoffice.org/84315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-02Disable macro menu entries when DisableMacrosExecution is setSamuel Mehrbrodt1-0/+5
Change-Id: Ica9a4f4a6510717dcd9fe53676e5a6f261f005ce Reviewed-on: https://gerrit.libreoffice.org/84231 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2019-12-02loplugin:mergeclasses TransactionBase with DesktopNoel Grandin3-55/+4
Change-Id: Ied33d099f89c767420f6fcb9342151d9a8356920 Reviewed-on: https://gerrit.libreoffice.org/84196 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann5-5/+5
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Rewrite uses of boost::optionalStephan Bergmann2-2/+2
...to only use functions that are also available for std::optional (in preparation for changing from boost::optional to std::optional): * uses of get are replaced with operator * or operator -> * uses of is_initialized are replaced with operator bool * uses of reset with an argument are replace with operator = (All of the replacements are also available for boost::optional "since forever", so this change should not break builds against old --with-system-boost. An alternative replacement for is_initialized would have been has_value, but that is only available since Boost 1.68.) Change-Id: I532687b6a5ee37dab28befb8e0eb05c22cbecf0f Reviewed-on: https://gerrit.libreoffice.org/84124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-27do not claim in titlebar test that OpenGL is enabled if it's notLuboš Luňák1-1/+2
Skia takes precedence, if enabled. And I'm not going to add Skia text to the titlebar, it'd need to include whether it's raster or vulkan, which would be longer, and I don't see why this information needs to be in the titlebar in the first place (or if it needs, then it should be consistent and include also gtk3, qt5, etc.). Change-Id: I9b95c1a986a38293ee65ee49d1a1970c75b3d202
2019-11-26tdf#94288: Show chart props sidebar on activationMuhammet Kara1-3/+21
Change-Id: I2119b59e3b4e36a34c9925cb624558d2da49ecc7 Reviewed-on: https://gerrit.libreoffice.org/83715 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara7-15/+29
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-24cppcheck: performing init in init list (filter/fpicker/framework)Julien Nabet4-21/+11
Change-Id: I7b602d17949f75c32dfe87acb92498111812ac32 Reviewed-on: https://gerrit.libreoffice.org/83612 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann14-0/+80
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-20tdf#42949 Fix IWYU warnings in framework/*/*cxxGabor Kelemen131-656/+104
Also drop the now unused framework/inc/general.h Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8e19036a507dbdcd178835b6ac4182719d27a654 Reviewed-on: https://gerrit.libreoffice.org/82744 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-19make some classes module-privateNoel Grandin13-31/+29
Change-Id: I53809ab01d5e8eb091305c3cb618a64920ad22ad Reviewed-on: https://gerrit.libreoffice.org/82783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann3-0/+12
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-11tdf#42949 Fix IWYU warnings in framework/*/*hxxGabor Kelemen160-451/+148
Also drop unused framework/inc/fwkdllapi.h Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61 Reviewed-on: https://gerrit.libreoffice.org/81927 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-10Typo meesages->messages (framework)Julien Nabet1-1/+1
Change-Id: I9e43e516482292ce8f0506e260152b7e678c716e Reviewed-on: https://gerrit.libreoffice.org/82392 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-08Combine LoadEnv's initializeLoading and startLoadingStephan Bergmann3-34/+23
...as they are only ever called directly one after the other. Rename the original initializeLoading to startLoading, and rename the original startLoading to private start (called at the end of the original initializeLoading). Change-Id: I5271387450324cc26743195329c4f401cf3aa0f9 Reviewed-on: https://gerrit.libreoffice.org/82308 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07MenuBarManager: Honor visible property of menu itemsMaxim Monastirsky2-8/+12
This became a problem recently with the introduction of notebookbar customization, as it allows to hide menu items. As a solution, use the same approach as for toolbars (see GenericToolbarController::statusChanged): Force menu item visibility only if it was previously hidden via a special status update of css::frame::status::Visibility. Change-Id: Ief9f70a289bd2e6a4855c1f92dbc20e31c62924c Reviewed-on: https://gerrit.libreoffice.org/82222 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 12:08:33 +0000