summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2019-05-24use vcl::Timer in StatusIndicatorFactoryNoel Grandin5-132/+18
does not need a separate thread Change-Id: I47bf2b255a331f4ec3ea24ad3a5d4c3ca398557e Reviewed-on: https://gerrit.libreoffice.org/72901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-23No need for AcceleratorCache::takeOver...Stephan Bergmann3-52/+13
...as it does the same as the copy assignment op. And both of those are apparently already only called with SolarMutex locked, so no need to lock it again. So the copy assignment op (as well as the other special memeber functions) can be left implicitly-declared. (And some uses of the original takeOver can be optimized to use move assignment.) Change-Id: I279a5e3ee85ff2342d6ef5f672108a0712fe116d Reviewed-on: https://gerrit.libreoffice.org/72831 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-23PathInfo::takeOver does same as copy assignment opStephan Bergmann1-11/+5
(but even better to actually use move assignment op) Change-Id: I6d9c4a9568ef03d84b7acd48a129d0c723c915cb Reviewed-on: https://gerrit.libreoffice.org/72820 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22New loplugin:dataStephan Bergmann1-1/+1
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16Don't call Application::Quit() in Desktop::terminate() on iOSTor Lillqvist1-0/+4
When exiting from a document in the iOS app, the Application::Quit() would post an ImplQuitMsg user event that would however not be handled for that document. Instead, it would be handled by the next document opened and thus the code would immediately stop editing the document, causing grief. Change-Id: Id24c843b3f329673035da55f53c2134265fce003
2019-05-15tdf#83722: Restrict the condition only to File > NewKatarina Behrens1-2/+2
referrer =~ private:user Change-Id: Ic67b0285ab7f49546499e4a9d90d9061c9d1274c Reviewed-on: https://gerrit.libreoffice.org/72346 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-13tdf#83722: don't recycle frame with unmodified templateKatarina Behrens1-1/+10
a frame that contained valid but unmodified document opened from template or explicitly opened by the user (File > New) was treated the same as blank document i.e. it was reused and the content was overwritten by newly opened document (even if it already had non-empty content provided by the template). So let's not do that and let's open a new document in a new frame instead Change-Id: I10252d114e8cc5fcad3c98194ef07fd59873d6da Reviewed-on: https://gerrit.libreoffice.org/71919 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-13Remove java mouse/keyboard event testsSamuel Mehrbrodt2-555/+0
These tests has been implemented as a UITest in sw/qa/uitest/writer_tests5/xwindow.py Change-Id: I0c1ae6d086a5a7d6e15b89bb3e810b49434da01e Reviewed-on: https://gerrit.libreoffice.org/71950 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin3-5/+5
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák2-4/+4
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-10an uno -> a unoCaolán McNamara24-30/+30
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara8-13/+13
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák4-331/+53
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-04tdf#105881 Toolbar keyboard navigation fixesJim Raykowski1-0/+8
This patch makes toolbar keyboard navigation wrap to the begining or end toolbar item and enables access to the overflow menu using the keyboard. Change-Id: I5975b0f731beb00cf26f8e8a33e6ea4fa9322881 Reviewed-on: https://gerrit.libreoffice.org/71718 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-02tdf#45904 Move XReplaceDescriptor Java tests to C++Jens Carl1-1/+0
Move XReplaceDescriptor Java tests to C++ for ScCellSearchObj. Change-Id: Ica5042ce8b5eac3663a0fb5f66ae0a2830c89d93 Reviewed-on: https://gerrit.libreoffice.org/71645 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-30improve loplugin:stringconstantNoel Grandin1-1/+1
to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl3-3/+3
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-25tdf#45904 Move TableColumn Java tests to C++Jens Carl1-1/+0
Move TableColumn Java tests to C++ for ScTableColumnObj. Change-Id: I3f17fa1f25c2676124b56c384364e36736fac849 Reviewed-on: https://gerrit.libreoffice.org/71261 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-23tdf#124886 Toolbar button icons are off by oneNoel Grandin1-1/+2
regression from commit 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 Date: Thu Apr 18 15:13:19 2019 +0200 optimise find/insert pattern Change-Id: I24edd5a89beed392c86058cd60155caf94bcf9ca Reviewed-on: https://gerrit.libreoffice.org/71137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19optimise find/insert patternNoel Grandin1-9/+6
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-16fix usage of successful/successfully in commentsNoel Grandin11-15/+15
Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b Reviewed-on: https://gerrit.libreoffice.org/70813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-15tdf#124649 framework menubar: show icons for most importent itemsandreas kainz1-7/+7
Change-Id: I2d94a7cf6fbaea952f9d802307202648587189f3 Reviewed-on: https://gerrit.libreoffice.org/70784 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-13loplugin:sequentialassign in frameworkNoel Grandin16-45/+19
Change-Id: I98da731a0f6b72ea0cb890dae2f25992c75a0984 Reviewed-on: https://gerrit.libreoffice.org/70701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12internally resize image instead of scaling bitmaps outsideTomaž Vajngerl1-15/+7
When we want a different size Image, we can now set that as a parameter at construction of the Image. Previously we needed to create an Image, forcefully take the bitmap out, resize the bitmap and create a new Image out of that. Doing it internally gives us the benefit to have a more control over the scaling process, especially when dealing with HiDPI images. Change-Id: I104118f4d863d519cc7aad1a17ca0289c01ed9ff Reviewed-on: https://gerrit.libreoffice.org/70617 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-09[API CHANGE] Asserts to never clear already cleared guardMike Kaganski2-54/+60
... which could help catch copy-paste errors when wrong guard is cleared second time. Also an assert added that when resetting, there's something to reset (i.e., no descendant class had cleared protected pResetT, making reset impossible, and thus actually unable to guard anything). framework/source/layoutmanager/layoutmanager.cxx: made sure to not call clear() second time framework/source/layoutmanager/toolbarlayoutmanager.cxx: restored lock lost in commit 777bc22ca6490a4300f30fc1b45287dce789a36f forms/source/misc/InterfaceContainer.cxx: removed a leftover from commit a19cd21e3c03559877428315bebc0ceaf367a461 which reduced guarded scope forms/source/component/DatabaseForm.cxx: fixed clear-reset sequence broken from the initial commit bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d Change-Id: Ibab6660c79561eee31faf3e6c1128ab141a7e8a3 Reviewed-on: https://gerrit.libreoffice.org/70381 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski20-518/+533
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Clear correct guardMike Kaganski1-1/+1
Change-Id: I3f3ab91c10f3077d61a8fd0c351be75cf2e63963 Reviewed-on: https://gerrit.libreoffice.org/70375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06Simplify: avoid OUString copy() and get just needed tokensMatteo Casalin1-11/+5
Change-Id: I708f222e408223cfaeaac56f87d68375f1d0503f Reviewed-on: https://gerrit.libreoffice.org/69237 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-04-05Remove unused using declarations in directories [e-l]*Gabor Kelemen5-8/+0
Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-03Fix typosJens Carl3-4/+4
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03tdf#45904 Move XCellRange Java tests to C++Jens Carl1-1/+0
Move XCellRange Java tests to C++ for ScTableRowObj. Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df Reviewed-on: https://gerrit.libreoffice.org/70163 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-02tdf#45904 Move XPropertySet Java tests to C++Jens Carl1-1/+0
Move XPropertySet Java tests to C++ for ScAutoFormatObj. Change-Id: I01ad72f7f48b3626085203ceac4f49bca847cdab Reviewed-on: https://gerrit.libreoffice.org/70097 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-25new loplugin:unoqueryNoel Grandin1-1/+1
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-21tdf#121671 Floating toolbars remain their position after reopenIlhan Yesil1-7/+29
Calculate the relative position of the floating toolbars by calling the ImplCallMove function, where the current position is read from the real window. Change-Id: I6a142055c3340dda2339980fbc5a7ebb431e228b Reviewed-on: https://gerrit.libreoffice.org/64093 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-20Simplify: avoid OUString copy() and get just needed tokensMatteo Casalin1-20/+12
Change-Id: I10c4b59cce39bc4e436d26d8a1d391cb2ec4a922 Reviewed-on: https://gerrit.libreoffice.org/69236 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-17tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl1-1/+0
Move XEnumerationAccess Java test to C++ for ScAutoFormatsObj. Change-Id: I2cbf6dd7f8dd77da51e20c5f60f19d300ecae62e Reviewed-on: https://gerrit.libreoffice.org/69350 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-15tdf#45904 Move XTableColumns Java tests to C++Jens Carl1-1/+0
Move XTableColumns Java tests to C++ for ScTableColumnsObj. Change-Id: Iead7ca3d7c07820086f75d86833b7bfc97978751 Reviewed-on: https://gerrit.libreoffice.org/69286 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-14Use indexed getToken()Matteo Casalin3-6/+9
Change-Id: Ie6a69f8d7630fefd18404c7a93e2d38bd06e3d16 Reviewed-on: https://gerrit.libreoffice.org/69238 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-13tdf#124042: There are no progress bars that vcl would handle on iOS or AndroidTor Lillqvist1-5/+14
Don't even bother trying to dislay such. Any progress feedback to the user will be handled through LibreOfficeKit callbacks. (Sure, the code probably thought it had created a "window" for the progress bar, but there wasn't anything real in the data structure that would actually display anything anywhere, no CG context (on iOS) etc.) Change-Id: Ie0ca18bbb22da41882bdaba4a0ce77a52112a059
2019-03-13tdf#45904 Move XNameReplace Java tests to C++Jens Carl1-1/+0
Move XNameReplace Java tests to C++ for ScStyleFamilyObj. Fixes i#23594 by creating a new "com.sun.star.style.CellStyle" rather then using an existing one. Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56 Reviewed-on: https://gerrit.libreoffice.org/69140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-09loplugin:unusedmethodsNoel Grandin2-14/+0
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06loplugin:unnecessaryparen improve member expressionNoel Grandin2-12/+3
Change-Id: I304621018cb1e2a47e478e86df4229bcf2176741 Reviewed-on: https://gerrit.libreoffice.org/68757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06tdf#45904 Move XPropertySet Java tests to C++Jens Carl1-1/+0
Move XPropertySet Java tests to C++ for ScDataPilotFieldObj. Change-Id: I9fa5d153cced1aae8892d2422025dfcdcda73c69 Reviewed-on: https://gerrit.libreoffice.org/68782 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03tdf#45904 Move XTextRange Java tests to C++Jens Carl1-1/+0
Move XTextRange Java tests to C++ for ScAnnotationObj (also fixes i109517). Change-Id: Id7e45d9f1159b45fb267cb28dc875b62eae12e24 Reviewed-on: https://gerrit.libreoffice.org/68634 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-01clang-format DispatchHelperSamuel Mehrbrodt1-44/+37
To reduce excessive whitespace in function definitons Change-Id: I8dbf58e5ba53ddcf6c5a8e212636c1306584aa2e Reviewed-on: https://gerrit.libreoffice.org/68533 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-01Use lambda instead of std::bind + wrapper functionSamuel Mehrbrodt1-15/+3
Change-Id: I52ef7c61d615120b172268b78827affa9b5f8f96 Reviewed-on: https://gerrit.libreoffice.org/68532 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-27CppunitTest_framework_dispatch: use CPPUNIT_TEST_FIXTURE()Miklos Vajna1-8/+2
Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c Reviewed-on: https://gerrit.libreoffice.org/68435 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-24loplugin:unusedfields in frameworkNoel Grandin18-102/+0
Change-Id: I7c633bf3e217a71c51bd3781fe716cb06fe92b0c Reviewed-on: https://gerrit.libreoffice.org/68227 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19tdf#42949 Fix IWYU warnings in include/framework/Gabor Kelemen18-1/+27
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481 Reviewed-on: https://gerrit.libreoffice.org/67745 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-19MSForms: Fix a regression in inplace menu handlingTamás Zolnai1-2/+1
We should not call implts_resetInplaceMenuBar() unconditionally. The problem which was fixed by that call can be solved by setting m_bInplaceMenuSet to false, which is the proper solution. So after the menu cleared up (inplace menu too), this indicator flag also contains the right value. Regression from: dc3a2546bd0ad0afe20cba9940934405174fd593 Change-Id: I85243417eb273629cc57b762b98fdd32dc9b1dd5 Reviewed-on: https://gerrit.libreoffice.org/68009 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 23:02:12 +0000