path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2018-06-30tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk6-6/+47
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: Tested-by: Jenkins Reviewed-by: Thorsten Behrens <> (cherry picked from commit d77f8eef165a7c6fd97cc06dcbc4ead55e7b633c) Reviewed-on:
2018-06-22tdf#118238 Only disable UI interaction when loading document as hiddenSamuel Mehrbrodt1-1/+9
The "quiet" interaction handler was used unconditionally when loading a document via the loadComponentFromURL API method. So no dialog was shown asking the user whether he wants to enable macros. With this patch, the "quiet" interaction handler is only used, when the document was loaded with the "Hidden" property set. Change-Id: Idd522d0bf605499b071390fb58312181b755dfca Reviewed-on: Tested-by: Jenkins Reviewed-by: Stephan Bergmann <> (cherry picked from commit 1115a60e6d825c049680e7f2caf318e36d481b12) Reviewed-on: Reviewed-by: Thorsten Behrens <>
2018-06-11menubar: framework/startpage sync help menubar entryandreas kainz1-1/+2
Change-Id: I8895c79a65750330600ebf0be19d184736fe2c1c Reviewed-on: Reviewed-by: Heiko Tietze <> Tested-by: Jenkins <> (cherry picked from commit 878785291da91d74cb13f005ce5287bd9ead8b79) Reviewed-on: Reviewed-by: andreas_kainz <>
2018-05-30tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."Tor Lillqvist3-46/+2
Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e9516fbbd8a92d97680524f32dd260fb2. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: Reviewed-by: Tor Lillqvist <> Tested-by: Tor Lillqvist <> (cherry picked from commit c1452e73091412ba0bb72306329e1912df2ba513) Reviewed-on:
2018-05-24tdf#115284: Unify LibreOffice and system full-screen concepts on macOSTor Lillqvist3-2/+46
Also tdf#76476, and probably more. Make it so that when a window is in full-screen mode from LibreOffice's point of view, it is also full-screen from the system's point of view, and vice versa. All three ways to enter and leave full-screen mode can now be used with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full Screen" menu entry, and the green bubble on the title bar. Don't disable/deactivate/etc menus while in full-screen mode. The menu auto-hides so there is no harm in having it function normally. Don't display the floating toolbar with a single "Full Screen" button in it as the way to leave full-screen mode. Instead, the same three ways that can be used to enter full-screen mode work to leave it, too. Sadly I could not figure out a way to set a window properly to full-screen at the point where a document window is created and set to be the same size as that kind of document window was the previous time it was open in LibreOffice. Thus don't save state for full-screen windows as we can't properly restore them. At least not for macOS. It is not good to just restore them as non-full-screened but still at the size they had when full-screen. One irritating glitch remains, and I was unable to fix that properly: I now prevent closing the document window that is in full-screen mode. Otherwise, if it is closed, the full-screen mode remains even if no window is open there; the desktop is completely black. Moving the cursor to the top edge, the LibreOffice menu is there, though. I tried to fix that but with no fully satisfying result. (Some attempts even lead to crashes, so just disabling closing is better than crashing at least.) Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tor Lillqvist <>
2018-05-22Fix typosAndrea Gelmini1-1/+1
Change-Id: Idbe136fbfd222e8baad588dc36a2f9b7ce6996ec Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Jenkins <>
2018-05-17loplugin:unusedfields in formula..registryNoel Grandin6-43/+13
Change-Id: I031654d8bb4f1788d364ef4f8d3bf7a05fadb148 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-05-05Fix typosAndrea Gelmini3-5/+5
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-05-03loplugin:useuniqueptr in PathSettingsNoel Grandin1-5/+3
Change-Id: Ib0e6e293e10473b7ada3919f781cfd05ef78749c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-05-03loplugin:useuniqueptr in ImageManagerImplNoel Grandin2-17/+12
Change-Id: I686d68ccee120246c20c2c52977422f49a318af9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-27loplugin:constantparamNoel Grandin1-3/+2
Change-Id: I966dcf87be021520e7cc394338b9c0574bb8afee Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-27make WB_LINESPACING a bool field on ToolboxNoel Grandin3-3/+6
Change-Id: If9332993a4917b00c230d2a3693daf8c5d3f5559 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-21cppcheck: identicalInnerConditionJochen Nitschke1-2/+1
renamed temporary list in EnhancedCustomShape2d.cxx to avoid shadow of a local variable Change-Id: I17a2261dafd2067480fcc5314af4f48765d6b690 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jochen Nitschke <>
2018-04-15Empty ELMENT should say EMPTY in dtd; fixes tdf#116791Kevin Brubeck Unhammer1-1/+1
Change-Id: I27906786edddd37d6e616f1bb5b6e8f6902e8049 Reviewed-on: Reviewed-by: Mike Kaganski <> Tested-by: Mike Kaganski <>
2018-04-15remove some unused comphelper includesJochen Nitschke4-4/+0
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jochen Nitschke <>
2018-04-14Remove useless iterator in XCUBasedAcceleratorConfiguration::storeToStorageArnaud Versini1-1/+0
Change-Id: Ibe3c89901e02d495eb367882138f79cb4b7513fc Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Arnaud Versini <>
2018-04-13Fix typosAndrea Gelmini1-1/+1
Change-Id: If4bc1698af2a43a2dbc45b8518c0f5b736d6abaf Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-04-11tdf#42949 Remove unnecessary localization headers from frameworkGabor Kelemen6-12/+0
Found by searching for the header names and the localization function: git grep -l -e \<fwkresid.hxx\> -e \<strings.hrc\> framework/ | xargs grep -c FwkResId | grep :0$ | grep -v /pch Change-Id: I026d78b5d1400c66705bd717eca9ed95e8c75366 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-04-11new loplugin:unusedvariablemoreNoel Grandin1-2/+0
collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-07Revert "long->sal_Int32 in tools/gen.hxx"Stephan Bergmann2-13/+13
This reverts commit 8bc951daf79decbd8a599a409c6d33c5456710e0. As discussed at <> "long->sal_Int32 in tools/gen.hxx", that commit caused lots of problems with signed integer overflow, and the original plan was to redo it to consistently use sal_Int64 instead of sal_Int32. <> "sal_Int32->sal_Int64 in tools/gen.hxx" tried that. However, it failed miserably on Windows, causing odd failures like not writing out Pictures/*.svm streams out into .odp during CppunitTest_sd_export_ooxml2. So the next best approach is to just revert the original commit, at least for now. Includes revert of follow-up 8c50aff2175e85c54957d98ce32af40a3a87e168 "Fix Library_vclplug_qt5". Change-Id: Ia8bf34272d1ed38aac00e5d07a9d13fb03f439ae Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-04-04Fix typoAndrea Gelmini1-1/+1
Change-Id: I6c03a7e99b31251eb0fe1c197d565e85bec419df Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jens Carl <>
2018-04-03Remove leftover framework/inc/uielement/notebookbarmenucontroller.hxxStephan Bergmann2-88/+0
...after 5c573a2f7473bae7bb965ca36557cd1b0bf7b9c9 "tdf#115131 made a common submenu for toolbars and notebookbars" Change-Id: Ic1713fa1173a8dbb1bcc971c30d0df4549c825a9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-04-03long->sal_Int32 in tools/gen.hxxNoel Grandin2-13/+13
which triggered a lot of changes in sw/ Change-Id: Ia2aa22ea3f76463a85ea077a411246fcfed00bf6 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-03pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin6-8/+8
and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-02tdf#115131 made a common submenu for toolbars and notebookbarsKshitij Pathania6-331/+39
Also added the submenu in base, maths and draw Change-Id: I94850c09c08fd3848eabe2597679634f30fbc735 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: andreas_kainz <> Reviewed-by: Szymon Kłos <>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke34-34/+1
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jochen Nitschke <>
2018-03-21tdf#115683 there are other cases of dialogs before document loadCaolán McNamara2-3/+39
Change-Id: I97ddbb528927fecb66072b42baa90272de2af39a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-03-20Resolves: tdf#114648 don't show new document until wizard is finishedCaolán McNamara1-1/+2
Change-Id: Ia9cb3fd549c17cb602fa3d7f9163a89697395c77 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-03-20loplugin:useuniqueptr in ImplImageListNoel Grandin3-9/+7
and fix leak in RemoveImage in the process Change-Id: I20e395178f92f7127e99011aebbe97246f255d1d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke4-4/+0
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-17Use for-range loops in frameworkJulien Nabet27-709/+480
Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2018-03-16simplify ImageList::GetAsHorizontalStripNoel Grandin1-8/+1
no need to repeat logic the BitmapEx constructor already implements Change-Id: Ic958b3a3baafe9911b8461e1fc512e36616db89c Reviewed-on: Reviewed-by: Michael Meeks <> Tested-by: Jenkins <>
2018-03-16move framework/toolkit use of BitmapEx::GetMask inside vclNoel Grandin1-16/+3
Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943 Reviewed-on: Reviewed-by: Michael Meeks <> Tested-by: Noel Grandin <>
2018-03-14loplugin:constantparamNoel Grandin3-11/+5
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-13tdf#116277 blank frame into which document will load shown too earlyCaolán McNamara1-1/+3
normally we want this to be the window that is the parent for any warning or password dialog. But for these (weird, see also impl_findSlotParam) frames dispatched with slotid arguments, they are opened before the dialog which will fill them is launched. Presumably in sane land the dialog would be dispatched from the menu entry, then on its create the frame opened with the desired contents. Change-Id: I1234b648ca1bd7fd2109cb4d3c70d5bfed9ab563 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin2-3/+2
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-08loplugin:constantparam in desktop..i18npoolNoel Grandin3-62/+9
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-06Fix typosAndrea Gelmini4-9/+9
Change-Id: I005023337dbe593e0ac1d76f7b10848d24f314a5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Samuel Mehrbrodt <>
2018-03-02delete colordata.hxxNoel Grandin4-4/+0
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-01menu bar behavior consistency: remove checkbox from disabled menu itemVasily Melenchuk1-0/+11
If menu item which can have checkbox is disabled, checkbox is not drawn near it. After matching to enabled criteria this checkbox can appear and after disabling menu item again it still remain, so initial and final state of menu are different. Change-Id: I31be02da892212e12276aa56bae15e6fa453a5bf Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <>
2018-03-01make Color::GetRGBColor return Color instead of ColorDataNoel Grandin1-1/+1
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-02-28use less COLORDATA_RGBNoel Grandin1-1/+1
part of removing ColorData Change-Id: I5518cddeeefe66f70380367e1e3f78af0f3b5fbc Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke5-5/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara1-6/+6
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin1-2/+1
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-02-24Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie1cff6b690e69d23c16a1a60ef4271d6cf48c13b Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Jenkins <>
2018-02-23get headless build to work again for LinuxThorsten Behrens1-0/+2
This makes --disable-gui option build successfully again - which means we again run on a headless server w/o any X11 or OpenGL libs. Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9 Reviewed-on: Reviewed-by: Thorsten Behrens <> Tested-by: Thorsten Behrens <>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann1-1/+1 it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-02-21New loplugin:nestedunnamedStephan Bergmann2-61/+55
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2018-02-21ColorData->Color in sd..svxNoel Grandin1-1/+1
Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>