summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2015-09-20convert Link<> to typedNoel Grandin5-35/+24
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511 Reviewed-on: https://gerrit.libreoffice.org/18700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20tdf#76197 Make OfficeMenuBar work again in the start centerMaxim Monastirsky1-1/+2
Regression of 46666a7720e18238b926531a7082dbb8bc524889. The code in MenuBarManager::FillMenuManager merges the addon menu before .uno:WindowList, which doesn't exist in the start center since that commit. As a last resort, let's also check for .uno:HelpMenu (assuming that it's never placed before the Window menu). Change-Id: If45eebe4351c40d8ed69daba527844ffc02e8458
2015-09-18boost->stdCaolán McNamara8-17/+14
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-15tdf#94198 Printer missing from tooltipSamuel Mehrbrodt1-0/+1
Need to update the tooltip also on state change. This partially reverts the fix for tdf#83558, 1fb8724f9834dbc07b741eeed31b31347bc0c2a1 Verified that the fix for tdf#83558 still works. Change-Id: I023a5e4b101dc91522f19b0d3ed2ed0c4a47e64b
2015-09-15convert Link<> to typedNoel Grandin1-1/+1
Change-Id: I5c4021c9cb3fdeace7f7d99d580dc7fe2f7c354a
2015-09-15convert Link<> to typedNoel Grandin2-3/+2
Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
2015-09-13Replace snwprintf with _snwprintfDavid Ostrovsky1-2/+2
Change-Id: Ieb7009f6fbbd7ac6a3532cfa7b71eb0c1339d1ef Reviewed-on: https://gerrit.libreoffice.org/18524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-09-12Advertise GL rendering in frame titles in dbgutil mode.Michael Meeks1-0/+3
Change-Id: I1883d137eb65a030c58e1e4ec11df3e63800339b Reviewed-on: https://gerrit.libreoffice.org/18512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2015-09-11framework: yet another WeakImplHelper<XPropertySetInfo> dupcliateMichael Stahl1-71/+3
There's a very similar comphelper::PropertySetInfo, unfortunately with an additional mnMemberId on its properties, so convert a little... Change-Id: I2a5fc0bb0ff6d680d546192b9d09afee6348f218
2015-09-11valgrind: silence worrying invalid pthread lock/unlock warnings on exitCaolán McNamara1-0/+1
Invalid read of size 4 at 0x57F48E0: __pthread_mutex_unlock_full (in /usr/lib64/libpthread-2.21.so) by 0x4E903F7: osl_releaseMutex (mutex.cxx:136) by 0xB3EECF0: osl::Mutex::release() (mutex.hxx:74) by 0xB3EF92C: osl::Guard<osl::Mutex>::~Guard() (mutex.hxx:135) by 0xB3F755A: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:318) by 0xB3F75B3: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:328) by 0x2B13BDE9: std::default_delete<SvtCommandOptions>::operator()(SvtCommandOptions*) const (unique_ptr.h:76) by 0x2B13A3C6: std::unique_ptr<SvtCommandOptions, std::default_delete<SvtCommandOptions> >::~unique_ptr() (unique_ptr.h:236) by 0x2B134063: framework::Desktop::~Desktop() (desktop.cxx:183) by 0x2B13418B: framework::Desktop::~Desktop() (desktop.cxx:187) by 0x79892AD: cppu::OWeakObject::release() (weak.cxx:205) by 0x2B1399B7: framework::Desktop::release() (desktop.hxx:133) by 0x2B13B860: rtl::Reference<framework::Desktop>::~Reference() (ref.hxx:81) by 0x2B13956B: (anonymous namespace)::Instance::~Instance() (desktop.cxx:1780) by 0x54635D7: __run_exit_handlers (in /usr/lib64/libc-2.21.so) by 0x5463624: exit (in /usr/lib64/libc-2.21.so) Change-Id: I98e0e70567ab39a06813fd9b614ba1e04ec22bd1
2015-09-07convert Link<> to typedNoel Grandin8-14/+14
Change-Id: I38f2c15b4f8bb1d7187b019d26a2644b087898c1 Reviewed-on: https://gerrit.libreoffice.org/18357 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04convert Link<> to typedNoel Grandin2-10/+6
Change-Id: I936606b6fdbb5db50661bde68fc8472bb9dd8861 Reviewed-on: https://gerrit.libreoffice.org/18317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03loplugin:stringconstant also for cases using char const v[] = "..."Stephan Bergmann3-3/+3
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03convert Link<> to typedNoel Grandin4-7/+4
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83 Reviewed-on: https://gerrit.libreoffice.org/18258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann20-114/+114
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson1-0/+1
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-28make PostUserEvent Link<> typedNoel Grandin14-28/+25
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28don't protect the gnumeric filter with the USE_ORCUS flagMarkus Mohrhard1-11/+11
Change-Id: Id91c7844879bea589bf97f999fd0c69669dfa7f6
2015-08-28remove crazy whitespacesMarkus Mohrhard1-3/+3
Conflicts: framework/source/loadenv/loadenv.cxx Change-Id: Ia104e5dedbaf19dff5b0eaf4eb6f4c355570cc00
2015-08-28make experimental orcus import work againMarkus Mohrhard1-0/+1
Change-Id: I2e599331669c3018557835ab227395c54c247ac9
2015-08-28cosmetic clean-upMarkus Mohrhard1-4/+8
Change-Id: I7e6689e07873dcb85c2bf1aac0db2ecddc01fe4b
2015-08-27Clean up sEmptyStephan Bergmann2-5/+3
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27Clean up aEmptyStephan Bergmann2-4/+2
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-22tdf#39440 reduce scope of local variablesMichael Weghorn1-2/+1
This addresses some cppcheck warnings. Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad Reviewed-on: https://gerrit.libreoffice.org/17920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-20more config skipping stuff and a tester toolCaolán McNamara1-0/+4
Change-Id: I5e93a4c84b3a0940239213766eb24d21fb5fd649 Reviewed-on: https://gerrit.libreoffice.org/17863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-19for testing allow disabling configmgr for time critical pathsCaolán McNamara2-3/+6
Change-Id: I83396e7c90d3b182f353a77c9bdf06fd17af92a1
2015-08-19Remove redundant checkStephan Bergmann1-7/+2
...became redundant with previous commit d3d7cb989b8d3c7d8e9947511bf78e9aefedc490 "Remove ConvertOSLtoUCBURL." Change-Id: I08c436dec8ed661eae60a17723fc63e6aafb1f86
2015-08-19Remove ConvertOSLtoUCBURLStephan Bergmann1-21/+4
"Not all OSL URL's can be mapped to UCB URL's" might have been true in the days of vnd.sun.star.wfs, but I can't see any good reason for this functionality today. Change-Id: Ia887531ee9fa70092766406cee1fc8962576a8ac
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann1-2/+1
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-14framework: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe102-207/+198
with the variadic variants. Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57 Reviewed-on: https://gerrit.libreoffice.org/17734 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-14loplugin: defaultparamsNoel Grandin3-3/+3
Change-Id: I0538bbb2e121d8feeff03535cb327c957e03de1b
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin1-1/+1
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14append '(Remote)' in the titlebar when remote file is openedSzymon Kłos3-0/+19
Change-Id: Idf0a9594406601154319ae17e42ece4bf2d56dc9
2015-08-13Related tdf#93404: Fix deadlock when joining WakeUpThreadStephan Bergmann1-3/+7
...after 54f10a9654b617c4c993044e52e7bd40d0151c53 "tdf#93404: Forgot to launch WakeUpThread," when the WakeUpThread blocks on locking StatusIndicatorFactory::m_mutex in StatusIndicatorFactory::update() while the joining thread blocks on StatusIndicatorFactory::impl_stopWakeUpThread() -> WakeUpThread::stop() -> Thread::join(). Change-Id: I3480014b1f522901064ea9b71ffa2ebf5d74fef5
2015-08-13tdf#93404: Forgot to launch WakeUpThreadStephan Bergmann1-0/+1
...in 017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 "Ensure WakeUpThread is joined before exit" Change-Id: Iaa5a5772f099b11229bd40c3cc10d863ef0ad5b3
2015-08-11loplugin: defaultparamsNoel Grandin15-35/+35
Change-Id: I44772f7c26568353d02278486a8e960f40af6354
2015-08-05loplugin:unusedmethodsNoel Grandin8-41/+8
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04idl,framework,forms: inline some use-once typedefsNoel Grandin2-20/+7
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-03inline some use-once typedefsNoel Grandin2-6/+4
Change-Id: I55cc82c8e180cce371c996690608090b1bfdfda4 Reviewed-on: https://gerrit.libreoffice.org/17494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03remove some unused definesNoel Grandin2-74/+0
Change-Id: I85a9a2bc12681e13fc482374165ff9bd6858dc93
2015-08-03remove some unused typedefsNoel Grandin1-2/+0
Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501 Reviewed-on: https://gerrit.libreoffice.org/17491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-01Whitespace.Jan Holesovsky1-8/+8
Change-Id: Ifcccd6376a6a44bf6761e9fa451b46933adb6ce9
2015-07-31framework: replace boost::function with std::functionMichael Stahl2-6/+6
Change-Id: I9342bbdaa626c88592d3a7bdf12f150cc2a605b1
2015-07-30loplugin:unusedmethodsNoel Grandin12-216/+6
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28SimplifyMaxim Monastirsky1-25/+16
Every button has a controller, so it should be enough to just iterate the controllers map. Change-Id: I9e3d269a00ddd9362164a45000a90d9dc6220cab
2015-07-27Fix image update of DROPDOWNONLY buttonsMaxim Monastirsky1-1/+1
Change-Id: I787878d6ac02d15286a405ccfcc1f09f04c39501
2015-07-27remove some unused definesNoel Grandin2-750/+0
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24string: 'Remote File' -> 'Save Remote File...'Szymon Kłos1-1/+1
Change-Id: I30e664e6fa16cdcbdffa97c57905b73224d42636
2015-07-24Don't show open remote entry in the recent doc menuMaxim Monastirsky1-22/+40
We use the same menu controller for both the Open toolbar button and the Recent Documents menu. While it's reasonable to put the open remote file command under the open button, it has nothing to do with recent documents, so it shouldn't appear there. Also don't add the "No Document" entry in case the open remote entry is visible. The whole point of the "No Document" entry is that we can't leave the menu empty, but if there is another visible entry, it's not needed. Change-Id: Ibefbdc6dc7d1d49f555d8ee23f67b47eba19b445 Signed-off-by: Szymon Kłos <eszkadev@gmail.com>
2015-07-24convert WindowAlign to scoped enumNoel Grandin3-16/+16
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52