summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2013-12-12Start center: Re-introduce the Macros menu, people use it.Jan Holesovsky1-0/+9
Change-Id: I99da1fbbd158622933445f7e97f4266a24a2d85d
2013-12-10Get rid of $(share_subdir_name) againStephan Bergmann2-8/+2
Quoting 56211a166ab25d80de84c2cccce22be15a9be051 "fdo#72394 Don't endlessly expand $(share_subdir_name) into itself": * The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime framework path variable, esp. since accidentally re-substituting it for "share" segments in unrelated URLs like <file:///export/share/for-all> does not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters" had already attempted a fix for that, but it had to be reverted again with 791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not work if BUILDDIR is different from SRCDIR." So this time fix it not via configure-expanded *.in files, but via xsltproc (for officecfg/registry/ files) and sed (for wizards/soruce/configshare files). The changes to officecfg/util/alllang.xsl will replace @LIBO_SHARE_FOLDER@ only in oor:name attribues (and in <value> text), not in any other attributes, because I have no idea how to write that generically in XSLT and it happens to be only needed in oor:name for now. Change-Id: Iec78eb70dcbf1a5bbabf4e42f21c44dc65c3e438 (cherry picked from commit 87dd1780a31de9ea1df70a8511c262ff252bf99a)
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin7-68/+68
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-09fdo#72394 Don't endlessly expand $(share_subdir_name) into itselfStephan Bergmann1-1/+2
The introduction of $(share_subdir_name) expanding to "share" in c6a73009747814513ab5a7277c211449c7378870 "Use subfolder names from <config_folders.h>" shows that SubstitutePathVariables::impl_reSubstituteVariables is fundamentally flawed in that it allows reducing variable occurrences even in variable names, so that it will expand an occurrence of "share" into an endless recursion of "$(share_subdir_name)" -> "$($(share_subdir_name)_subdir_name)" -> ... Adding $(share_subdir_name) to the list of variables that can only replace a complete path segment (delimited by "/"), from which it had erroneously been missing, "fixes" this problem for now. But the code is still wrong in at least two respects: * SubstitutePathVariables::impl_reSubstituteVariables arguably needs to be made more robust, to never reduce variable occurrences in variable names. * The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime framework path variable, esp. since accidentally re-substituting it for "share" segments in unrelated URLs like <file:///export/share/for-all> does not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters" had already attempted a fix for that, but it had to be reverted again with 791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not work if BUILDDIR is different from SRCDIR." Change-Id: If214c179c0068fbaa475c1c9cac804d6a1dbb2dc (cherry picked from commit 56211a166ab25d80de84c2cccce22be15a9be051)
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin1-4/+4
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin5-25/+25
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin6-48/+48
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin8-70/+70
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin35-160/+148
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin9-20/+20
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18fdo#69500: Revert "fix bug #60700 - de-crutify ODF files"Andras Timar1-1/+3
This reverts commit da06166015689eca260c702602bef4cea58afbd3.
2013-11-15fdo#66864: Return from full-screen should restore toolbars.Jan Holesovsky1-15/+11
The fix for fdo#37758 was not correct, we shouldn't fiddle with the m_bVisible itself, but instead react on the m_bMasterHide flag; or at least that is my understanding of the related framework code (why is it so confusing?!) Change-Id: I791fcea9e5e5313b6a5b776cb3187cbd1a028386
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann2-3/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14startcenter: Remove useless menu entries.Jan Holesovsky1-45/+0
Change-Id: Ie886beceb57201ee1a0893943c455d5f87b0d6cc
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann10-114/+113
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin1-6/+6
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13expand out the A2S macroNoel Grandin1-9/+7
Which is not doing anything useful anymore. Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin2-8/+8
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11remove unnecessary use of OUString constructorNoel Grandin1-1/+1
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11remove unnecessary use of OUString constructor in FRAMEWORK moduleNoel Grandin13-46/+43
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
2013-11-10cppcheck: reduce scopeJulien Nabet1-2/+1
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
2013-11-08Unwind SFX_REFERER_USERStephan Bergmann5-14/+6
...and remove remaining unused content of sfx2/source/inc/referers.hxx. Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
2013-11-05fixincludeguards.sh: frameworkThomas Arnhold203-582/+582
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin4-7/+7
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin1-2/+2
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-7/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03StatusIndicatorFactory::impl_reschedule(): lock SolarMutexMichael Stahl1-1/+4
... before calling Reschedule(). Change-Id: I244fdd1a4642ea0e1ad266f6d9c4c56527018952
2013-11-01Improve exception messages (for debugging)Stephan Bergmann1-2/+5
Change-Id: Id2e00e0b0363c58c88585dd15f34156e57a7aaac
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin13-22/+22
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl1-2/+0
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28remove local css namespace definitionsThomas Arnhold2-3/+0
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-23clean up some include guardsThomas Arnhold3-9/+9
Conflicts: sw/source/ui/inc/content.hxx Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6 Reviewed-on: https://gerrit.libreoffice.org/6388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl1-2/+2
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-20drop unnecessary tools/string includesCaolán McNamara5-5/+0
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-15update pchThomas Arnhold1-0/+1
Change-Id: I475bee35ca5d24903d85e7f2427fab0e47d8db4d
2013-10-12WaE: unused parameter 'SystemType'Tor Lillqvist1-0/+2
Change-Id: I52717d85269dd1802b942ba19f5710b9e469faf1
2013-10-12SimplifyTor Lillqvist1-9/+1
Change-Id: Ic2afa7e60da57c5b516a043f717dea21a3cf0d55
2013-10-09CID#738544 unitialized memberCaolán McNamara1-0/+1
Change-Id: I4f2342776467594f3512af624a653a9b827a0afe
2013-10-04'ist' -> 'is' here and there.Jan Holesovsky2-2/+2
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-02WaE: unused variableTor Lillqvist1-1/+0
Change-Id: I73aabeff7d28ef3526d18188c6fab2e0bc2529d7
2013-10-02-Werror,-Wunused-variableStephan Bergmann1-2/+0
Change-Id: I703d08f4c1080e5c5afaab9652ea2c18b4f365f1
2013-10-02-Werror,-Wunused-variableStephan Bergmann1-1/+0
Change-Id: I548eec1fdcc862b76361c56724667f2d9f6e0950
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-1/+0
Change-Id: Iac6d103afb5d6ed3f59e589ec174f6aad253a0aa
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-10/+0
Change-Id: Id416a7bcb3ac3ea5354f6f7b5ec3daa1dc742f8d
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-6/+0
Change-Id: I52bd479bd40031acc2742b93ab77420f26070b59
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-2/+0
Change-Id: I93796237cb953445e42fde5822ad51bc3edcce10
2013-09-26typo fixes in commentsAndras Timar48-105/+105
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26Everytimes -> Every timeJesús Corrius7-9/+9
Change-Id: Ib84cee7dbb493387760ce68c25ec442bf0a4a121
2013-09-26Otherwhise -> OtherwiseJesús Corrius30-33/+33
Change-Id: Iaec23e1d240f675a04b52cd251c4cb2a1242bb44
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 18:36:17 +0000