Age | Commit message (Collapse) | Author | Files | Lines |
|
Previously the overflow/context menu should have had a separator shown
between the overflow items and the hidden items, however these were
inadvertently removed by ImplClearPopupMenu which filters the items
before the menu is displayed.
The previous ordering of items was also the REVERSE of the ordering in
the toolbar -- the overflow menu is a logical extension of the toolbar
hence items should be in the same order as they were in the toolbar.
(cherry picked from commit 3dc6808532d86c4b00a6cb81e0adb74878c13fdd)
Conflicts:
vcl/source/window/toolbox2.cxx
Change-Id: I8444f4814fea64be1d8f8790445ad6aa01532e70
Reviewed-on: https://gerrit.libreoffice.org/9171
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
The toolbar context menu is handled by the toolbar manager, however
the items are provided and managed by the toolbar itself -- previously
any events on the list of toolbar items in the context menu were silently
discarded, whereas now we pass them on to the owning toolbar.
Change-Id: Ia17718c3ff8acfba1b6d655022dd9469932f3493
(cherry picked from commit 944c78ecb91608f4c3e9bab32fdbc90c67326525)
Reviewed-on: https://gerrit.libreoffice.org/9170
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Thanks to sayt@mailinator.com for the idea.
Change-Id: Ib79abafe3d4d3ba21f7914aeb284d86ce662824c
(cherry picked from commit ef87ff6680f79362a431db6e7ef2f40cfc576219)
Reviewed-on: https://gerrit.libreoffice.org/8633
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ie431672b5a6ba1d613ae1cb9e48fa6d1db6a6b4a
(cherry picked from commit 57e0062f2043f7a0382db5f4d01c6c70ca8aca46)
Reviewed-on: https://gerrit.libreoffice.org/7953
Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com>
|
|
(cherry picked from commit eeb840d6ba930015b969c3d0a98031f0ae508d61)
Change-Id: I0b975a1a0e73c546beec96599fd4e5f87caa51db
Reviewed-on: https://gerrit.libreoffice.org/7838
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
(cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d)
Conflicts:
sc/source/ui/unoobj/nameuno.cxx
sc/source/ui/unoobj/styleuno.cxx
sfx2/source/appl/sfxhelp.cxx
stoc/source/security/permissions.cxx
sw/source/core/unocore/unocrsrhelper.cxx
(None of those bogus startsWith calls seem problematic enough to warrant
backporting also to libreoffice-4-2-0.)
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
Reviewed-on: https://gerrit.libreoffice.org/7578
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9cbe647563699b9b610661003084d2cd16093f9a
(cherry picked from commit d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1)
Reviewed-on: https://gerrit.libreoffice.org/7304
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I4d3993dc855c030f8c51fe2ce3d364240e241dff
(cherry picked from commit 43d355d25db1144668a59346b37b041b8a9fdbc3)
Reviewed-on: https://gerrit.libreoffice.org/7333
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
make packageinfo target
add uiconfig file translations
add missing l10n config files
add missing help files in packageinfo
Reviewed-on: https://gerrit.libreoffice.org/6754
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Conflicts:
helpcontent2
translations
a2498a118e729276a78ef3a4eb43b5d0b302d326
9bb39bdd677af4be0da621370c51eb9e22ecc33f
a7e654cdeffd832f51016ff51aa180fe3924ff4e
4ee41fdb600cb3a89da387dffe64e6a30192761c
349fb24a388775c58be7a326832b3fc0ec38180f
8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
Change-Id: Id5f6f5c1f3e46df2d9033ccd5bbf2af6ab38a9e8
Reviewed-on: https://gerrit.libreoffice.org/6982
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I99da1fbbd158622933445f7e97f4266a24a2d85d
|
|
Quoting 56211a166ab25d80de84c2cccce22be15a9be051 "fdo#72394 Don't endlessly
expand $(share_subdir_name) into itself":
* The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime
framework path variable, esp. since accidentally re-substituting it for
"share" segments in unrelated URLs like <file:///export/share/for-all> does
not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't
(attempt to) do run-time expansion of build-time parameters" had already
attempted a fix for that, but it had to be reverted again with
791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not
work if BUILDDIR is different from SRCDIR."
So this time fix it not via configure-expanded *.in files, but via xsltproc
(for officecfg/registry/ files) and sed (for wizards/soruce/configshare files).
The changes to officecfg/util/alllang.xsl will replace @LIBO_SHARE_FOLDER@ only
in oor:name attribues (and in <value> text), not in any other attributes,
because I have no idea how to write that generically in XSLT and it happens to
be only needed in oor:name for now.
Change-Id: Iec78eb70dcbf1a5bbabf4e42f21c44dc65c3e438
(cherry picked from commit 87dd1780a31de9ea1df70a8511c262ff252bf99a)
|
|
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.
Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
Reviewed-on: https://gerrit.libreoffice.org/7008
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
The introduction of $(share_subdir_name) expanding to "share" in
c6a73009747814513ab5a7277c211449c7378870 "Use subfolder names from
<config_folders.h>" shows that
SubstitutePathVariables::impl_reSubstituteVariables is fundamentally flawed in
that it allows reducing variable occurrences even in variable names, so that it
will expand an occurrence of "share" into an endless recursion of
"$(share_subdir_name)" -> "$($(share_subdir_name)_subdir_name)" -> ...
Adding $(share_subdir_name) to the list of variables that can only replace a
complete path segment (delimited by "/"), from which it had erroneously been
missing, "fixes" this problem for now.
But the code is still wrong in at least two respects:
* SubstitutePathVariables::impl_reSubstituteVariables arguably needs to be made
more robust, to never reduce variable occurrences in variable names.
* The compile-time variable LIBO_SHARE_FOLDER should not end up as a runtime
framework path variable, esp. since accidentally re-substituting it for
"share" segments in unrelated URLs like <file:///export/share/for-all> does
not make sense. ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0 "fdo#68552: Don't
(attempt to) do run-time expansion of build-time parameters" had already
attempted a fix for that, but it had to be reverted again with
791a8b96f754798192875da287c84f8cfa4e533e because it "Unfortunately does not
work if BUILDDIR is different from SRCDIR."
Change-Id: If214c179c0068fbaa475c1c9cac804d6a1dbb2dc
(cherry picked from commit 56211a166ab25d80de84c2cccce22be15a9be051)
|
|
Convert code like:
aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
aOStringBuf.append( " is missing )" );
which compiles down to the same code.
Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
|
|
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
Simplify code like:
aStr.equalsAsciiL( "%", 1 )
to
aStr.startsWith( "%" )
Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
This reverts commit da06166015689eca260c702602bef4cea58afbd3.
|
|
The fix for fdo#37758 was not correct, we shouldn't fiddle with the m_bVisible
itself, but instead react on the m_bMasterHide flag; or at least that is my
understanding of the related framework code (why is it so confusing?!)
Change-Id: I791fcea9e5e5313b6a5b776cb3187cbd1a028386
|
|
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
|
|
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
the product
- packagers should then be able to build l10n and non-l10n parts of the
product independently, thus:
- enable quicker rebuilds
- distribution of load
- updates to l10n without a full rebuild
- security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
upstream -- while this exsists in distros, the number of test
scenarios for this would explode upstream
Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863
Conflicts:
filter/Module_filter.mk
|
|
Change-Id: Ie886beceb57201ee1a0893943c455d5f87b0d6cc
|
|
...so it will be able to use SvtSecurityOptions internally.
Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Which is not doing anything useful anymore.
Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
|
|
Change-Id: Icbed4f318043a166ed78fe0c49a53f87ebf7201d
|
|
Change-Id: I06c97b99a55d8b291ea31e6a751ced01b0b80e23
|
|
...and remove remaining unused content of sfx2/source/inc/referers.hxx.
Change-Id: I5c533f63e13da930f6944af0e85d4b061c30e5b0
|
|
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
|
|
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
|
|
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
... before calling Reschedule().
Change-Id: I244fdd1a4642ea0e1ad266f6d9c4c56527018952
|
|
Change-Id: Id2e00e0b0363c58c88585dd15f34156e57a7aaac
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
|
|
As we have it globally in sal/types.h those are not necessary.
Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
|
|
Conflicts:
sw/source/ui/inc/content.hxx
Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
|
|
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
|
|
Change-Id: I475bee35ca5d24903d85e7f2427fab0e47d8db4d
|
|
Change-Id: I52717d85269dd1802b942ba19f5710b9e469faf1
|
|
Change-Id: Ic2afa7e60da57c5b516a043f717dea21a3cf0d55
|
|
Change-Id: I4f2342776467594f3512af624a653a9b827a0afe
|
|
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
|
|
Change-Id: I73aabeff7d28ef3526d18188c6fab2e0bc2529d7
|