summaryrefslogtreecommitdiff
path: root/framework
AgeCommit message (Collapse)AuthorFilesLines
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava16-36/+36
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13coverity#1251595 Uncaught exceptionCaolán McNamara2-4/+5
Change-Id: I24eaec49bb89e9f490d5bb0071723b41673e1845
2014-11-12typo: represant->representAndras Timar2-3/+3
Change-Id: If783e9338644a97206d99864ed19807e5fb3882d
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini26-93/+93
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin3-27/+25
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo82708 Add missing tooltips to Writer StatusbarSamuel Mehrbrodt3-0/+7
Change-Id: Ie44b8de69b98ebfa789cc8f9a1d8a60b698fc154 Reviewed-on: https://gerrit.libreoffice.org/12368 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann3-4/+5
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin3-5/+4
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06rename KEY_MODTYPE to KEY_MODIFIERS_MASKNoel Grandin2-2/+2
Change-Id: I7948988e4fd89bf94a98afee15298cd33e2a4d06
2014-11-05markup with event type not checker typeCaolán McNamara1-2/+2
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin2-3/+3
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-16/+13
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin8-20/+20
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31framework: avoid double-free in ToolBarManager()Michael Stahl1-3/+11
The timer could run after the ToolBarManager is deleted because the dispose() method can accidentally restart the timer somehow. Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30Kill some static OUStrings.Jan Holesovsky5-53/+19
Change-Id: Ic06a3b4673446bbadd21f2380c04ec628a6f86a9
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin4-4/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1202880 annotate Dereference before null check as false positiveCaolán McNamara1-0/+2
and coverity#1202881 Dereference before null check as false positive Change-Id: Id2c1ff2a5913755e9160807eace3219be3b35fd1
2014-10-24coverity#704649 Unchecked dynamic_castCaolán McNamara1-3/+3
Change-Id: Ibeb096d98cba7a55d9d806802473660d30000924
2014-10-23coverity#736876 Negative array index readCaolán McNamara1-3/+2
Change-Id: I5e0f2e4633286b320abfb6735232b57aedd3a5b3
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin5-19/+19
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-22framework, unotest: do not override UserInstallation from environmentMichael Stahl1-1/+3
The PythonTest_dbaccess_python may fail in incremental builds because of stale JVM path in workdir/unittest/user/config/javasettings_Linux_X86_64.xml so it's better to use the fresh UserInstallation that is already passed in from PythonTest.mk. To make that work, tolerate non-existing path in SubstitutePathVariables::SetPredefinedPathVariables() at least when running in the build environment, which is probably better than effectively running with "/" as UserInstallation anyway... This partially reverts commit 6dbb6275ebd1a4299099c3b6bc82ec4ee0e1fb86. Change-Id: I4d42d53c049056590662828360c4ce5a29af0f4b
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin7-32/+32
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17coverity#1247630 Uncaught exceptionCaolán McNamara2-3/+4
Change-Id: Ic15d712a26bdb6565b78efc4e9cab1bb09fd1cf4
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin2-3/+2
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann10-30/+4
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11convert vcl StateChangedType to enum classNoel Grandin2-4/+4
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10cid#1244948 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: I421f245fd3be90f0e1d08ad92b0723a64121ae12
2014-10-10cid#1244950 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: I1aa4d437838dac42ac1fc803a2ba2a437fa3addb
2014-10-10cid#1244951 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: I3bb5dc5932f4239507920cb9cafa66caab9ff7e0
2014-10-10cid#1244952 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: Ied23e7df1d8ebda9976e63d03c122c058addf274
2014-10-08spelling: instanciated -> instantiatedNoel Grandin2-2/+2
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin1-2/+2
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-03coverity#1078526 Logically dead codeCaolán McNamara1-2/+1
Change-Id: I203511fcb1e740d7d371821d49a7c13a72e6fc3b
2014-10-02coverity#1242768 Unused valueCaolán McNamara1-2/+1
Change-Id: Ida66a4a4d00caa49e993938f86e357e4351a60c5
2014-10-02coverity#1242970 Result is not floating-pointCaolán McNamara1-2/+2
Change-Id: Icd0b04a2b8d9250418dfec95668fa6c496e45e5e
2014-10-02fix for older compiler, doesn't like <::Noel Grandin4-10/+10
Change-Id: I8113125b7eb9d919aaf84a1dcde3e58e41e978f4
2014-10-02loplugin: cstylecastNoel Grandin29-109/+110
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
2014-10-01loplugin: cstylecastNoel Grandin9-51/+51
Change-Id: Idac41288539ff171e1c9fb0e12b172a311878ed6
2014-10-01fdo#82577: Handle TimeNoel Grandin1-1/+1
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30framework: std::auto_ptr -> std::unique_ptrStephan Bergmann2-4/+2
Change-Id: I6ef5e9018d1e33c205eae934c404d3391a4693f2
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin1-5/+11
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-24fdo#83558 Don't change toolbar tooltip on state changeSamuel Mehrbrodt1-3/+1
Also removed EraseAllMnemonicChars since that method is called later by SetItemText Change-Id: I10139d437290ccfed6a8a15e8e5ce501e15c2560 Reviewed-on: https://gerrit.libreoffice.org/11306 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin39-154/+154
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22Always add the keyboard shortcut to the toolbar tooltipsSamuel Mehrbrodt1-14/+9
Change-Id: I6f6e385cf6d09b0a3f18b708daeff2df9aba83c6 Reviewed-on: https://gerrit.libreoffice.org/11595 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-22Revert "Related fdo#81475 Improve toolbar tooltips in Writer standard toolbar"Jan Holesovsky1-9/+14
Unfortunately this breaks the Edit menu - it is now crowded with long texts; so while it may improve the toolbar, it definitely breaks the menu. This reverts commit b59c5ace4b7213ffd62495d0c0e5b6411f5071be.
2014-09-22Related fdo#77813: $(workdirurl) was always emptyStephan Bergmann1-2/+1
Regression introduced with cb021fcafba06ccf973f2abe229a4761c0a002de "fdo#46037: remove 1 comphelper/configurationhelper in framework." Change-Id: I07727d93315e0d3d87004ce71708271e90a173a3
2014-09-22Unwind one level of cluttering indirectionStephan Bergmann1-27/+27
Change-Id: Iceaed0e5490b6002c1421d74dfb8f2d0ba38cbf5
2014-09-22vcl: Allow creation of button content from action name (.uno: commands).Jan Holesovsky1-5/+5
Change-Id: If4b2aef59d45a848fb77de9e1b7bf80d49548a75
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 16:01:54 +0000