summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)AuthorFilesLines
2016-01-31unnecessary use of OUString constructorNoel Grandin2-6/+4
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-26-Werror,-Wsign-compare (clang-cl)Stephan Bergmann1-1/+1
According to MSDN: "If [StretchDIBits] fails, or no scan lines are copied, the return value is 0." Change-Id: I882b97b55f92618f0163f8829bf779a35b5a1452
2016-01-25more Windows build fixesNoel Grandin3-3/+3
after my OInterfaceContainerHelper2 change Change-Id: Id63fd81643b030e0570f00d6e0506cb8ea5d3742
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin3-3/+3
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-21loplugin: unused return valuesNoel Grandin1-5/+2
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini6-7/+7
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08Related tdf#96833: display WebDAV path in remote files dialogGiuseppe Castagno1-3/+8
Folder WebDAV paths have the '/' at the end, this needs to be removed in RemoteDialog logic while filling the treeview. Change-Id: I8336de3e08ff030b27b1e48594448ff66106cff6 Reviewed-on: https://gerrit.libreoffice.org/21041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-07cppcheck: noExplicitConstructorCaolán McNamara23-34/+33
Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde Reviewed-on: https://gerrit.libreoffice.org/21201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-23loplugin:unusedfields in fpickerNoel Grandin7-26/+15
Change-Id: Ia5d9211a668c25c9891ed69902fe1a4fbb2d8483
2015-12-07Undef RGB where it was defined, not where it gets usedStephan Bergmann2-3/+1
Change-Id: I1e122bb7c32850dfdd74de029c8d92a328207a95 Reviewed-on: https://gerrit.libreoffice.org/20430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-02-Werror,-Wunused-private-fieldStephan Bergmann2-13/+0
Change-Id: Icf15313f5bcacbe9c7efa0b4161929dbb3e39c1e
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann1-3/+0
Change-Id: I4331396f5bbc37306c09f0e9a1c6b2969922f66f
2015-11-28-Werror,-WreorderStephan Bergmann1-1/+1
Change-Id: I0988cf701dea563e3990b4179879fbcd3778662d
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann1-4/+0
Change-Id: Ie539b4f3e4295a8dcb1126371e5f2c75e9d723ab
2015-11-28-Werror,-Wunused-const-variableStephan Bergmann1-1/+0
Change-Id: Ib725e544d058c735e485db1586743746a5236488
2015-11-28Avoid ambiguity which OUStringBuffer ctor to selectStephan Bergmann1-3/+3
...for size_t (i.e., unsigned long long on Windows 64-bit), chosing among the int, unsigned int, long, unsigned long overloads. MSVC apparently happily picks one of them, but clang-cl rightly complains. Change-Id: Ib245925bdf9e4a34add6ca435a95559f4f07c4d7
2015-11-28-Werror,-Wunused-functionStephan Bergmann1-2/+2
Change-Id: Id53c00a90f4f2d87e469ae4fe4121a5678dff5a4
2015-11-20loplugin:unusedfields forms,formula,fpicker,frameworkNoel Grandin2-4/+1
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin1-3/+1
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17loplugin:unnecessaryvirtualNoel Grandin1-2/+2
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann2-4/+4
Change-Id: I82bb9471479523d68641fd815da1208f0d45b8a8
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin1-3/+1
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-6/+2
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin3-12/+6
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin2-4/+2
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann8-42/+42
Change-Id: I14ed4aa3cfc52dcb9a75de2364074dec18be3d5d
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann11-103/+103
Change-Id: I7f32320f38be2bb4f62b57e856e93cff708d5ee0
2015-11-09Prevent += called on temporary O[U]String instancesStephan Bergmann1-9/+7
...found regression e31205f3ec1f941ab5a188bfde6329edf2acc55b "EditUndoRemoveChars::GetStr must return a reference" and dubious code 0e23f7b0839df68d277186b4df54ba391ac3406a "Lets assume this doesn't want to update m_pForcedPrefix->GetText() anyway" in addition to the apparent sillies directly fixed in this commit. Introduces HAVE_CXX11_REF_QUALIFIER. Change-Id: I564e98254fd53c1dd9b34193d7057c59721ee24c
2015-11-09Replace a few for_each and one-liner locals by range-based loops in fpicker.Mario J. Rugiero1-67/+6
Change-Id: I07cb510b8c8ab195d5d3addb715cfb0af488ab9b Reviewed-on: https://gerrit.libreoffice.org/19849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann4-10/+10
Change-Id: Ib9c9daa113fecff495a51dca1bfaace1239b6ebc
2015-11-02use uno::Reference::set method instead of assignmentNoel Grandin3-11/+8
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659 Reviewed-on: https://gerrit.libreoffice.org/19733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01no need to be so verbose in constructing uno::ReferenceNoel Grandin1-2/+2
Change-Id: I187a26e200e9ecaff2adaf53a2ba3f6e87346030 Reviewed-on: https://gerrit.libreoffice.org/19724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin2-2/+2
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-21more removal of com::sun::star typedefsNoel Grandin5-9/+5
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21remove untyped Link<>Noel Grandin1-3/+1
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b Reviewed-on: https://gerrit.libreoffice.org/19491 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-19loplugin:defaultparamsStephan Bergmann2-9/+9
Change-Id: I6372cf755a78772094bf5fdcb076cc6ea395fc89
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin1-1/+1
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-16convert Link<> to typedNoel Grandin5-11/+6
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15convert Link<> to typedNoel Grandin2-4/+2
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14convert Link<> to typedNoel Grandin6-11/+9
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-14com::sun::star->css in fpicker/Noel Grandin54-508/+498
Change-Id: I211687bfeaf456e0f9639567bff401083011cd74 Reviewed-on: https://gerrit.libreoffice.org/19353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann13-198/+198
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann4-8/+8
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12convert Link<> to typedNoel Grandin5-16/+10
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-06tdf#94811: Crash in Open Remote File dialog fixedOliver Specht1-1/+1
Edit control needed a disposeAndClear instead of a clear Change-Id: I24f4ec8c391080cb83574949cc141c883b43cfb9 Reviewed-on: https://gerrit.libreoffice.org/19185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-05Remember password after setting new serviceSzymon Kłos1-2/+4
Change-Id: I14ba319307f74b24fa474e742504b70c46539a08
2015-10-05Focus for file list after opening folderSzymon Kłos1-0/+2
Change-Id: Ibac322b873315fd8a0ec63c930f4c76562a5e704
2015-10-05Focus for file name field after using it to open folderSzymon Kłos1-0/+3
Change-Id: Ic3ae0c899c5feea659d22100f98dbeca4df217eb
2015-10-02tdf#57370 : Open place after pressing 'Enter'Szymon Kłos2-0/+19
Change-Id: Iabcf17b71b3fe06a25bb7b0e7f3aa65ad0663e69 Reviewed-on: https://gerrit.libreoffice.org/19085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-01Fix typosAndrea Gelmini5-9/+9
Change-Id: Id94c03249b2752e88499628b3ad12936b361bb2f Reviewed-on: https://gerrit.libreoffice.org/18950 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 07:41:20 +0000