summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)AuthorFilesLines
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2-20/+22
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-04Fix leak in resolveAlias (fpicker/aqua)Julien Nabet1-1/+5
Change-Id: I9b154337769763139ee5571d4ec8df9cfb6208f9 Reviewed-on: https://gerrit.libreoffice.org/43104 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski1-3/+3
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01Prefer prefix operatorJulien Nabet2-6/+6
Change-Id: I82f3f66bfc675dbc4a5d5b57d8715c3de01d9620 Reviewed-on: https://gerrit.libreoffice.org/42994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-30Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski1-14/+14
This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski2-32/+31
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-29Drop check for Windows versions we don't supportMike Kaganski3-35/+0
Since we dropped support of Vista and below in master toward 6.0, those checks are needless. Removing the code that only worked in older versions, and streamlining the resulting code. Also, use kernel32.dll version for Windows version, instead of deprecated GetVersionEx, and inconvenient VersionHelpers. Since both GetVersion(Ex) and VersionHelpers (based on VerifyVersionInfo) are subject to manifest-based behavior since Windows 8.1, this move will hopefully result in more reliable OS version detection. Change-Id: I3edd8fc1843e64b6a65bd3a126be6a085511f13c Reviewed-on: https://gerrit.libreoffice.org/42905 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-26Silence macOS 10.13 -Werror,-Wdeprecated-declarationsStephan Bergmann1-0/+3
Change-Id: Idde11cd740dd67b5df06945557e5580c7d16b1e3
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt1-1/+1
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt1-1/+1
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt2-8/+8
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt3-3/+3
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski5-0/+15
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-11clang-tidy modernize-use-emplace in editeng..frameworkNoel Grandin1-2/+2
Change-Id: I7739c4f77c856d34f8484754244df13d8fef840e Reviewed-on: https://gerrit.libreoffice.org/42151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-09tdf#112289 OSX fpicker: don't default to trueJan-Marek Glogowski1-1/+0
When LO requests a value for the currently unimplemented GPG encryption checkbox, the Aqua file picker defaults to a "uno::Any <<= true", which triggers the GPG key dialog. This simply returns an empty uno::Any for values of unknown controls, which is handled fine. If something else relies on the current default value, it must to be properly implemented. Change-Id: I3637ca833d59e19416e25f3096bc90a756aa8840
2017-09-02Add context attribute to translatable entry in .ui file.Kiyotaka Nishibori1-1/+1
a translatable entry without context attribute in 'fpicker/uiconfig/ui/explorefiledialog' causes failure of 'make translation': Traceback (most recent call last): File "/home/kiyotaka/Sources/libreoffice-testing/solenv/bin/uiex", line 30, in <module> keyid = entry.msgctxt + '|' + entry.msgid TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' Error: Failed to execute /home/kiyotaka/Sources/libreoffice-testing/solenv/bin/uiex -i /home/kiyotaka/Sources/libreoffice-testing/fpicker/uiconfig/ui/explorerfiledialog.ui -o /home/kiyotaka/Sources/libreoffice-testing/workdir//pot/fpicker/messages.pot Change-Id: Icdd5e283a30108b45f4b62967e2ce287d338b582 Reviewed-on: https://gerrit.libreoffice.org/41828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-30gpg4libre: Encrypt with GPG checkbox in SaveAs file dialog, 1st stabKatarina Behrens5-1/+32
LibO's own file dialog only so far Change-Id: Ic5f6c180afb5d4e0fc151ad57d769b99ad7fbdf3 Reviewed-on: https://gerrit.libreoffice.org/41292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-08-21avoid out of bounds accessMarkus Mohrhard1-2/+3
Change-Id: I4c7ddf2fcabc231b7250306b4a9255fab1a9ef7c
2017-08-18drop unused CntContentTypeItemJochen Nitschke1-1/+0
unused since commit cdae06a664bfc3279bd9f177473357cce316b9b1 Date: Fri Apr 6 11:17:10 2001 +0000 #78400# Template scanning reimplemented using UCB Change-Id: I3e742be5a7c5467628dbe5a19171c4dfcef07c58 Reviewed-on: https://gerrit.libreoffice.org/41274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini1-1/+1
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-07loplugin:oncevarStephan Bergmann2-6/+2
Change-Id: I1bb87b9c1a34326694d8096f67bb32adb17af1e6
2017-08-07loplugin:staticmethodsStephan Bergmann2-9/+7
Change-Id: Iaf9b6afa7c2d3d8044d50e0bfac898319fff8f22
2017-08-02remove unnecessary use of 'this->'Noel Grandin1-1/+1
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara4-28/+4
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-01fix aqua buildCaolán McNamara1-0/+1
Change-Id: I814cecc30c95e967b16fd6d57cb4b3eaf3d5e5b4
2017-08-01move resmgr to unotoolsCaolán McNamara4-6/+6
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-07-31use empty instead of size() == 0Markus Mohrhard1-1/+1
Change-Id: I08b1e73323a15dd977daba98946e7deec3967503 Reviewed-on: https://gerrit.libreoffice.org/40575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-21de-hrc various thingsCaolán McNamara4-5/+5
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara25-533/+168
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-20loplugin:constparams in fpickerNoel Grandin4-17/+17
Change-Id: I1ef422ccd902a3bc5e4fce5ea373cfef24f8edef Reviewed-on: https://gerrit.libreoffice.org/40204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06use more begin()/end() for SequenceNoel Grandin1-7/+2
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-07-03loplugin:oncevar (clang-cl): fpickerStephan Bergmann1-2/+1
Change-Id: I13e11f07a8022b315ffa80282575472bcb0c3acc
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke2-4/+2
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-30loplugin:oncevarStephan Bergmann2-7/+3
Change-Id: If1f4f8136368349777c6fb616328cfa89efd9e0f
2017-06-25loplugin:oncevar in formula..frameworkNoel Grandin1-3/+1
Change-Id: I96d6af49c1994ebd7d6dcc41469127e3151b4350 Reviewed-on: https://gerrit.libreoffice.org/39186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in forms..idlcNoel Grandin5-11/+1
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822 Reviewed-on: https://gerrit.libreoffice.org/39133 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56 Reviewed-on: https://gerrit.libreoffice.org/38208 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-30fpicker: global default _WIN32_WINNT is sufficient nowMichael Stahl2-9/+0
Remove local overrides. Change-Id: I588b6543848f962d7533c49b138bc6d836fe5c47
2017-05-29fpicker: remove ifdef __IFileDialogCustomize_INTERFACE_DEFINED__Michael Stahl5-25/+0
No idea what SDK problem this once worked around but surely it's obsolete now. Change-Id: I5cfa37710ea8cecee8acc9c8f5a6a08fae4babbd
2017-05-29fpicker: remove some Win32 helper code that is now unusedMichael Stahl2-270/+0
Change-Id: I5414df94487fc9918ca28b694d6f94eeeac20b70
2017-05-29fpicker: remove PreviewCtrl.[ch]xxMichael Stahl3-715/+0
These were apparently never used; the Windows 7 file picker can preview images nicely without this anyway. Change-Id: I0e4a1bb94506cbeae10675400a471b2211659d6e
2017-05-29fpicker: remove legacy XP FilePicker implementationMichael Stahl42-7614/+4
Long live VistaFilePicker. Change-Id: I362a582a1922abad66ecfd1f5c4ce1a5a25fcd11
2017-05-28remove unnecessary use of OString::getStrNoel Grandin1-4/+2
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20Translate German comments and debug strings (leftovers in f... dirs)Johnny_M2-2/+2
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "f". Additionally: - Fixed translation in formula/source/ui/dlg/funcutl.cxx (translated in https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=5e04331fc0a6434c61d3d18843cb4f80a44e5989 ), because clearing an event is quite the opposite of its triggering. Change-Id: I0fd62193a29883796cd05e5a80ce8a2900636b6c Reviewed-on: https://gerrit.libreoffice.org/37839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-19loplugin:stringcopy: fpickerStephan Bergmann2-5/+5
Change-Id: Iec08e4ed6241faba9b858e42cb6b55abdcdab3ee
2017-05-18gives names to mysterious 500 and 501Caolán McNamara1-2/+5
Change-Id: Ie2b02f10ab100ce11330d1a0808e60a02394e230 Reviewed-on: https://gerrit.libreoffice.org/37750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18SVT_RESSTR can go nowCaolán McNamara3-27/+30
Change-Id: I641fbea510d56cabb440f894aae938430ce30ce0
2017-05-12Clean up uses of SAL_U/SAL_W: fpickerStephan Bergmann2-2/+3
Change-Id: I9fe1a639bee624eea3ab91d5f29a86ef8ac3d97c
2017-05-12remove unused uno::Reference varsNoel Grandin1-2/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 11:19:52 +0000