path: root/fpicker
AgeCommit message (Collapse)AuthorFilesLines
2017-07-20loplugin:constparams in fpickerNoel Grandin4-17/+17
Change-Id: I1ef422ccd902a3bc5e4fce5ea373cfef24f8edef Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-07-06use more begin()/end() for SequenceNoel Grandin1-7/+2
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-07-03loplugin:oncevar (clang-cl): fpickerStephan Bergmann1-2/+1
Change-Id: I13e11f07a8022b315ffa80282575472bcb0c3acc
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke2-4/+2
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: Reviewed-by: Stephan Bergmann <> Tested-by: Stephan Bergmann <>
2017-06-30loplugin:oncevarStephan Bergmann2-7/+3
Change-Id: If1f4f8136368349777c6fb616328cfa89efd9e0f
2017-06-25loplugin:oncevar in formula..frameworkNoel Grandin1-3/+1
Change-Id: I96d6af49c1994ebd7d6dcc41469127e3151b4350 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-06-23loplugin:unusedfields in forms..idlcNoel Grandin5-11/+1
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jochen Nitschke <>
2017-06-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56 Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Julien Nabet <>
2017-05-30fpicker: global default _WIN32_WINNT is sufficient nowMichael Stahl2-9/+0
Remove local overrides. Change-Id: I588b6543848f962d7533c49b138bc6d836fe5c47
2017-05-29fpicker: remove ifdef __IFileDialogCustomize_INTERFACE_DEFINED__Michael Stahl5-25/+0
No idea what SDK problem this once worked around but surely it's obsolete now. Change-Id: I5cfa37710ea8cecee8acc9c8f5a6a08fae4babbd
2017-05-29fpicker: remove some Win32 helper code that is now unusedMichael Stahl2-270/+0
Change-Id: I5414df94487fc9918ca28b694d6f94eeeac20b70
2017-05-29fpicker: remove PreviewCtrl.[ch]xxMichael Stahl3-715/+0
These were apparently never used; the Windows 7 file picker can preview images nicely without this anyway. Change-Id: I0e4a1bb94506cbeae10675400a471b2211659d6e
2017-05-29fpicker: remove legacy XP FilePicker implementationMichael Stahl42-7614/+4
Long live VistaFilePicker. Change-Id: I362a582a1922abad66ecfd1f5c4ce1a5a25fcd11
2017-05-28remove unnecessary use of OString::getStrNoel Grandin1-4/+2
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-05-20Translate German comments and debug strings (leftovers in f... dirs)Johnny_M2-2/+2
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "f". Additionally: - Fixed translation in formula/source/ui/dlg/funcutl.cxx (translated in;a=commitdiff;h=5e04331fc0a6434c61d3d18843cb4f80a44e5989 ), because clearing an event is quite the opposite of its triggering. Change-Id: I0fd62193a29883796cd05e5a80ce8a2900636b6c Reviewed-on: Reviewed-by: Chris Sherlock <> Tested-by: Chris Sherlock <>
2017-05-19loplugin:stringcopy: fpickerStephan Bergmann2-5/+5
Change-Id: Iec08e4ed6241faba9b858e42cb6b55abdcdab3ee
2017-05-18gives names to mysterious 500 and 501Caolán McNamara1-2/+5
Change-Id: Ie2b02f10ab100ce11330d1a0808e60a02394e230 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-05-18SVT_RESSTR can go nowCaolán McNamara3-27/+30
Change-Id: I641fbea510d56cabb440f894aae938430ce30ce0
2017-05-12Clean up uses of SAL_U/SAL_W: fpickerStephan Bergmann2-2/+3
Change-Id: I9fe1a639bee624eea3ab91d5f29a86ef8ac3d97c
2017-05-12remove unused uno::Reference varsNoel Grandin1-2/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin1-2/+2
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke6-6/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: Tested-by: Jochen Nitschke <> Reviewed-by: Michael Stahl <>
2017-05-09fp010 is not in fpicker like the othersCaolán McNamara1-1/+1
Change-Id: I4c574596a4aaaf7584818e167805748dd02cff6c
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke2-2/+0
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert OS X fpicker codebase away from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: I3e04db9ffb82f591dcff9b91eb915cf059a9b312
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann1-8/+8
Change-Id: I5ed7a980da0d8f6d320db306fcfca969ae700c4f
2017-04-26remove fpicker bitmaps from .src filesCaolán McNamara10-33/+37
Change-Id: Ice75bf15e509869bb7e8344381595838918acd81 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock1-1/+1
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: Reviewed-by: Chris Sherlock <> Tested-by: Chris Sherlock <>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock4-0/+4
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Chris Sherlock <>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky3-3/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: Reviewed-by: David Ostrovsky <> Tested-by: David Ostrovsky <>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin1-8/+2
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara1-2/+1
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <>
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin1-4/+4
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-04-05loplugin:constantparam part2Noel Grandin1-1/+1
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann2-2/+2
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna2-2/+2
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2017-03-30tdf#39468 Translate German commentsJens Carl1-1/+1
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/, and idl/ Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <>
2017-03-29convert EViewType to scoped enumNoel Grandin2-4/+4
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-27Resolves: tdf#106729 ensure VistaFilePicker init before accessCaolán McNamara2-1/+18
Change-Id: I238599cf5ed464c4bb99a894ac47126fbc32796d
2017-03-25Fix typosAndrea Gelmini5-8/+8
Change-Id: Ifb779b6c96a009e6c770a8017bb2e2031a288f5f Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Julien Nabet <>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin1-1/+1
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-23Typo: boder->borderJulien Nabet1-2/+2
Change-Id: I46940c5b584f93b478b1dfca9aa66e036fe951c2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2017-03-19Fix typos + some German translationsAndrea Gelmini1-1/+1
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253 Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Julien Nabet <>
2017-03-19Fix typosAndrea Gelmini1-1/+1
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek1-4/+2
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-17remove unused defines from HRC files in fpickerNoel Grandin3-7/+0
Change-Id: If3ee3225524b745c6a337b1c4e9e963678622c7b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-14loplugin:subtlezeroinit (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I19f41363e3efcc716d3258106ebee2424be25b6a