summaryrefslogtreecommitdiff
path: root/fpicker/source
AgeCommit message (Collapse)AuthorFilesLines
2022-09-21use more string_view in svtoolsNoel Grandin1-3/+3
Change-Id: Id0317c400d7bc868916b97cd1c7abae04c4a9e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-05Simplify by using replace instead of replaceAt in loop in fpickerJulien Nabet1-8/+1
Change-Id: Ibe601294bd55ac9a93a535b6acd092064fdad364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-20cid#1500521 silence Dereference before null checkCaolán McNamara1-1/+1
Change-Id: Ia17524dd7bf9a56cad0a1358fa2f076b9e1776c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann3-3/+3
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-08VCL add vcl::WindowPosSize abstract classJan-Marek Glogowski2-2/+2
... and use it to remove a duplicate and simplify code. Should mostly be a refactoring, which was mainly done by some larger sed calls, except for the new API calls, which helped shrinking some LOC. All data is also now private. Originally two of the "replaced" "classes" had unsigned width and height and one had signed. Noel pointed out, that during calculations, the value might get negative temporarly, so this now settles with signed values. Still the set size should never be negative and this is enforced this way. Not sure that is what Noel had in mind. This also includes: - rename WindowState => WindowData - rename WindowStateMask => WindowDataMask - rename WindowStateState => WindowState - move WindowState and WindowDataMask to vcl/windowstate.hxx - move WindowData(Mask) and WindowState into vcl namespace - readability: replace or'ed WindowState enums with "meta" enums + add "meta" WindowState enums PosSize and PosSizeState Change-Id: Icd16cfb498531aa7238ddbde83fcb0ed6d9e4f77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135426 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-01clang-tidy modernize-pass-by-value in fpickerNoel Grandin8-19/+25
Change-Id: I9940338307241958e478ec6919068454d3a07b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-07tdf#62776 - Add tooltip for folder location shortcutsAndreas Heinisch2-0/+13
Change-Id: I326fd3c3695e5467a49688fc2164fe591aef2397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133709 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-05-05use more o3tl::getTokenNoel Grandin1-3/+3
found by inspecting call sites of OUString::getToken Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#146007: make sure to not hold solar mutexMike Kaganski1-0/+5
COM might need to forward the call to another thread (with corresponding apartment); if that thread happens to wait for solar mutex, COM call may deadlock. Change-Id: I8fcf04619cd29b678fd7ade87254b9aad2f639a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133853 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-04Just use Any ctor instead of makeAny in fpickerStephan Bergmann3-4/+4
Change-Id: Ib23b10759bdc7c2eca4b585992756075e2642dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133807 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-29use more string_view in INetURLObjectNoel Grandin5-7/+7
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-25loplugin:stringviewparamStephan Bergmann2-17/+19
...and loplugin:stringview(param) follow-ups Change-Id: I5ccb5c7b246a35aefb43c8f608d781b753f9830c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133392 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-15use more string_view in fpickerNoel Grandin3-8/+8
Change-Id: I2568dfa05082bbd2d3a433c54b47039455d91153 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-15loplugin:stringviewStephan Bergmann1-1/+2
Change-Id: I4e03bb0674dff734c41f4206b1849ede3c6949ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133055 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-14tdf#148101 don't autocomplete remote files dialog entry on delete/backspaceCaolán McNamara2-1/+26
Change-Id: Ieddb41eb37e7090416a418afeffb76ce0eddf90a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12loplugin:stringview more o3tl conversionNoel Grandin1-1/+2
look for call sequences that can use string_view and the new o3tl functions in o3tl/string_view.hxx Also add a few more wrappers to said #include file Change-Id: I05d8752cc67a7b55b0b57e8eed803bd06bfcd9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11loplugin:stringview add check for getToken().toInt32Noel Grandin3-7/+8
where we can convert that to o3tl::toInt32(o3tl::getToken( and avoid the heap allocation of a temporary string Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-22Simplify CoCreateInstance / CoGetClassObject with COMReferenceMike Kaganski1-1/+1
Change-Id: Ieb1035410c3c6c4b40ea779e829a940460d19b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131922 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-11tdf#114150: Remove duplication of strings found in file dialogsJulien Nabet5-5/+5
Change-Id: I86f720a23dd9d400d39d9606e073b483850a9df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-07do not pass XComponentContext to officecfg::...::get() callsLuboš Luňák3-10/+7
It's used only for the ConfigurationWrapper singleton, so it's used only the first time and then ignored. It also causes calls to comphelper::getProcessComponentContext() for every single invocation despite the value not being needed, and the calls may not be cheap (it's ~5% CPU during ODS save because relatively frequent calls to officecfg::Office::Common::Save::ODF::DefaultVersion::get()). Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-09expand out IMPLEMENT_FORWARD_XTYPEPROVIDER3Noel Grandin1-1/+9
Change-Id: I31a7452bd8822f13905812e8f3fcd31a0753e0a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use some more add toId/fromIdCaolán McNamara1-1/+1
Change-Id: I3a21e2aa5a2c482c0bac1d4c9bf84f8b56261408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara2-15/+15
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17Recheck modules [e-f]* with IWYUGabor Kelemen2-3/+0
See tdf#42949 for motivation Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-21loplugin:flatten in filter..frameworkNoel Grandin2-52/+51
Change-Id: I15a577b3c6da03001bbbf2c2b43b29b41c4007c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-11Fix typosAndrea Gelmini1-1/+1
Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-11-30loplugin:stringviewStephan Bergmann1-2/+2
Change-Id: I941fc246211968f14654a9ee3540d2ed9bf13221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126113 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-25Related: tdf#145842 fix a crash after deleting an entryCaolán McNamara1-1/+0
delete an entry in remote files dialog and go one level up and crash, ownership of the SvtContentEntry is not with the entry, but belongs to mpImpl->maEntries Change-Id: I4a052ada1fd4f5e8142ac4396877b15ac49149b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-24tdf#145842 canceling remote file delete makes file disappear from treeviewCaolán McNamara1-2/+7
we remove the selected entries from the treeview, so the user cancel's the deletion of an entry we should unselect it from the candidates to remove. Change-Id: Ieb2258960fc647ad15d8f315a18454a0dae8a420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-24loplugin:stringliteraldefine in formual,fpickerNoel Grandin2-21/+21
Change-Id: I663a31ff6b207f43dd6f1c8240a341845b9e20b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23tdf#145769 fpicker: RemoteFilesDialog: don't use FStatHelperMichael Stahl2-4/+24
FStatHelper doesn't use an XCommandEnvironment and is thus unsuitable for remote access as it can't even authenticate with the password container; it should only be used for local access. Due to this problem, the ContentIsDocument() would always return a hard-coded "true" value from the webdav UCP, causing a spurious dialog that an existing file would be overwritten in Save Remote. (regression from 67fa088be7db1df661188ef4bab490a76fb06b85) Change-Id: Ibe667f2012e261b84d4c69c84fdd499b7276e64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125666 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-12Fix (mis-)uses of temporary O[U]StringLiteralStephan Bergmann1-1/+2
...as sub-expressions of ternary operators, which happened to keep compiling after 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String" and e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" because both branches are of the same type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling pointers to those temporary objects escaped the surrounding full expressions. This was found with an experimental build with VS 2022 with --enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking fix in the configure.ac detection code (which is forthcoming in a later commit) and flagged all these uses in ternary operators as error C7595 "call to immediate function is not a constant expression". That error looks bogus (and it also caused a false > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that compiler bug is fixed), but it nicely found all these cases that should arguably be cleaned up. Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-31Unused TOOLBOXBUTTON_DEFAULT_LOCATION in fpickerJulien Nabet2-2/+0
Change-Id: I6da38e7585a2e607e407e5f829b64fc5498d04d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124506 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31Typo: TOOLBOXBUTOON->TOOLBOXBUTTON in fpickerJulien Nabet3-8/+8
Change-Id: I7110afbdd554b180c368894b9aa6b3b79a8fb2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124498 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-30Prepare for removal of non-const operator[] from Sequence in fpickerMike Kaganski6-38/+37
Change-Id: I918b785082b89833839fc0a7eeb7cb36a91f897a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124369 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-27Add support for macOS SDK 12.0Stephan Bergmann1-0/+4
...and for now just silence all the new deprecation warnings Change-Id: Ic6e04f4bade91a823872cd4e453c41ee1950bd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124275 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-27Remove line that has been commented out since 2008Tor Lillqvist1-1/+0
Change-Id: I4dc8b6c4e324a0b2ec2d3dba25cc322e0fbefa6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124263 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-27There is nothing deprecated about these calls as far as I seeTor Lillqvist1-6/+0
Must have been some misunderstanding, or temporary mistake in the 10.9 SDK? Change-Id: I19d86c7a0e752676b317423361a18d2b156f0d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124259 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Use NSModalResponseOK instead of deprecated NSFileHandlingPanelOKButtonTor Lillqvist1-4/+1
NSFileHandlingPanelOKButton is defined as NSModalResponseOK in NSSavePanel.h: NSFileHandlingPanelOKButton API_DEPRECATED_WITH_REPLACEMENT("NSModalResponseOK", macos(10.0,10.13)) = NSModalResponseOK, For some reason, when as a test I just removed the SAL_WNODEPRECATED_DECLARATIONS_PUSH and _POP lines, I still did not get any depreation warning about NSFileHandlingPanelOKButton. I wonder if there is some problem in latest Xcode or in our build system that means we don't get any deprecation warnings at all any more on macOS. Change-Id: Ia61dd9f800eb7d251508dbd491a9c48c8e6118f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123964 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Bin dead codeTor Lillqvist10-197/+8
Change-Id: I2098172d065a195a15b7fd81a34dab25b1f38e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123956 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-19Related: tdf#145169 make double-click call same handler as ok buttonCaolán McNamara1-1/+1
so that the user is asked to confirm an overwrite of a file Change-Id: I1340fb33559b68c28fc91e272f05e122f8c519ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123806 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-10-18Related: tdf#145169 change to selected dir on remote "save"Caolán McNamara2-24/+21
if a dir is selected then try to change to that dir when save is clicked instead of saving using that as basename, which is consistent with standard fpicker. don't change the contents of the Entry, leave it alone. Change-Id: Id19fbf0f3ef2b8220059a1fa166b7783feb8d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Resolves: tdf#145169 only position treeview cursor at the first entryCaolán McNamara1-4/+4
when the view is filled, don't actually select the entry. With these single selection trees the default is to select when the cursor is positioned, so move the unselect to after the cursor positioning to achieve this. Now nothing is considered "selected" in the view unless the user explicitly does that so the contents of the entry are used by default on save/load because nothing is selected in the treeview unless the user does that. Change-Id: I2a740616205bab35614f85f62e8240cd11df90ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123754 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18tdf#145169 have one button per responseCaolán McNamara1-4/+2
not two sharing the same response, so the other buttons response handler is not a candidate to be called on pressing return which is the circumstance which causes the dialog to return even after cancel was selected in its child dialog warning about overwrite Change-Id: I09eb0ea5e94c89ce0860be362e1c7632887e7a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123753 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18tdf#145169 for IsDocument/IsFolder I think we want no interactionCaolán McNamara2-53/+4
rather than installing something to sometimes disable interaction I think we just want to not have any interaction here at all Change-Id: Ic775f0cd88f796db873d2980bb40043caac498bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Related: tdf#145169 unwanted dialogs on sftp save to remote to a new documentCaolán McNamara1-1/+5
which is similar to: commit f12e483589888f87843026ceff5ae3c1e615ca02 Date: Mon Feb 1 16:04:49 2016 +0100 Fix tdf#97500 Reinstate missing file error dialog on WebDAV this all looks a bit dubious, but make a safely backportable change first Change-Id: Ia6dbaacf7024d05083c336135a80b5acf607dfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123749 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Related: tdf#145169 use INetURLObject::getName and removeSegmentCaolán McNamara1-34/+22
to get the name and link for each part of the path otherwise for sftp:// clicking on the "Root" doesn't work for me Change-Id: If6f0ac8f105afd8be2d264b54f76a3d8f345ad75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123735 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16Simplify vector initialization in fpickerJulien Nabet1-2/+1
Change-Id: If75810cb09e13d5d9b9490b20a0a99b1745e17be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123687 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-28gives names to all the Idles and TasksNoel Grandin3-2/+3
enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin2-3/+1
Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>