summaryrefslogtreecommitdiff
path: root/formula
AgeCommit message (Collapse)AuthorFilesLines
2016-05-03Resolves: tdf#96426 significant whitespace as intersection in Excel syntaxEike Rathke3-8/+161
Also when reading/writing OOXML, so change SC_OPCODE_INTERSECT of RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML accordingly to " ", where previously "!" was expected and written, which was plain wrong. (cherry picked from commit 26adceb098134d918f6d57c8687ab057e24adc39) simplify the ReplaceToken() offset logic to absolute offsets (cherry picked from commit f41257dc9913cd6020a3a37bf425c20b51e18ece) fully check for adjacent RPN end, tdf#96426 follow-up (cherry picked from commit b0992e11905e36a64edeb92a13acfde5837c1878) narrow down where a space could be an intersection, tdf#96426 follow-up (cherry picked from commit e0875f8e348a3aca036bc0cc629fb038fabc8062) Adapted to backport. more differentiated significant whitespace recognition, tdf#96426 follow-up (cherry picked from commit 0f8a8332a52cd03b43aaab86e0c232e0964d7111) first range can be anywhere before second at RPN end, tdf#96426 follow-up ... not just adjacent to the one at the end. So we actually can handle INDIRECT("A2:C2") INDIRECT("B1:B3") (cherry picked from commit 0c5663cfb13f4f55e246d42ac464d5e2c2f23099) check presence of token, tdf#96426 follow-up (cherry picked from commit edd4370f5ba49a26a526995b6a28f623d68041ce) 4c368dfd113b02d208013b4ba79dff606769a150 8d02fb63bc0c5cb48aabaf7a8800f5f9ac95cbf5 886e559c6f6041bf4889fdd6d89c12a10be70e5f c53a4a0d19a11298895efb28e2786e48a071e72b 081409a82a9ff64f163115bf4597afbb9b2f5fa6 e8030ebc13bb1ae2246611f5722da97970b8c544 Change-Id: Ic0cfd7afc657f07bfd8e37de61b3621cc68685ff Reviewed-on: https://gerrit.libreoffice.org/24374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-29missing nullptr check, tdf#98427Markus Mohrhard1-1/+1
Change-Id: I657dc0c84eab6ff5b31976fac3317adc0a99dd51 Reviewed-on: https://gerrit.libreoffice.org/23487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-23Function Wizard: don't overwrite an unlisted functionEike Rathke2-4/+18
* in a spreadsheet cell enter =LOG(foobar(SIN(1))) * invoke Function Wizard on that cell (Ctrl+F2) LOG(foobar(SIN(1))) is marked in Formula edit field * activate Functions page LOG(foobar(SIN(1))) is marked in Formula edit field Function LOG is selected * click Next button foobar(SIN(1)) is marked in Formula edit field Function ABS is selected * click Next button foobar(SIN(1)) is overwritten with ABS( ) * only Cancel solves the problem foobar() could be any user defined or macro function that have no function description in the Formula Wizard. Change-Id: I1cb69a9e38c0b8f251d783bd0f67b4b24ade50d0 (cherry picked from commit 8aee44c94fd2abdb7f1566ad237da4bfdfc011fa) Reviewed-on: https://gerrit.libreoffice.org/21292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-08tdf#96198 postpone conversion from WEEKNUM to ISOWEEKNUM, tdf#50950 follow-upEike Rathke1-0/+11
Have two releases be able to read ISOWEEKNUM first. Change-Id: I7ea8141043d18076a65396374dec40a806c8ab6a (cherry picked from commit 7994b77819a5de7a6da46ab01386883559e7a7d1) Reviewed-on: https://gerrit.libreoffice.org/21229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-05for new'ed FormulaToken use FormulaTokenArray::Add()Eike Rathke1-2/+2
... instead of AddToken() that just clones it again. Change-Id: I99b02b0924d0a0c070435501f8ecd45f030e9c2c (cherry picked from commit c3d2313eca8fdab9eb3b4c9a49fd14e255feb2c0)
2016-01-05tdf#96198 add WEEKNUM_OOO compatibility function, tdf#50950 follow-upEike Rathke3-6/+30
The remaining cases when loading old and wrong ISOWEEKNUM that can't be mapped to either new WEEKNUM or ISOWEEKNUM now are mapped to WEEKNUM_OOO(date,mode) with calculations identical to the old and wrong OOo WEEKNUM. These WEEKNUM_OOO cases are still wrongly saved as ISOWEEKNUM so can be read by 5.0 or earlier versions as the old WEEKNUM, which should be changed for 5.3 or later. WEEKNUM_OOO is not offered in the Function Wizard to prevent deliberate usage. Also reverts the interim unit test change to sc/qa/unit/data/contentCSV/date-time-functions.csv that was necessary to catch the error generated by ISOWEEKNUM with two arguments. (cherry picked from commit 902c593196741ffec2d096855369313f6bbe756e) Conflicts: include/formula/compiler.hrc sc/inc/helpids.h sc/source/filter/excel/xlformula.cxx Change-Id: I874c4c7225900f03b879f2947512ae02270cbd4f
2016-01-05formula: add missing algorithm include for std::min.Michael Meeks1-0/+1
Change-Id: Ica344a8f1351826e53c109ef49f80e4b022a0364 (cherry picked from commit 15494f0f99d1cf6f75e8c2996377b242af247bbf)
2016-01-05tdf#96198 detect old ISO/WEEKNUM usage with two arguments, tdf#50950 follow-upEike Rathke2-1/+82
5.0 and earlier implemented WEEKNUM(date,mode) with mode!=1 such that effectively an ISO 8601 week number was calculated. WEEKNUM was wrongly saved as ISOWEEKNUM (even with two parameters though it is defined to have only one) so that when reading it we can try to detect a literal double argument for mode and if it is not 1 remove it to keep ISOWEEKNUM(date) instead of calling WEEKNUM(date,mode) which wouldn't match. A further change to 5.0 to accept also only one parameter in WEEKNUM(date) and for this default the mode to not 1 for ISO week will yield forward compatibility. Change-Id: I88de7dd809d69b6826a190505d2a1dd3fe79c90b (cherry picked from commit 2f79244cb3fcc4cbfd2b818380ea9d62b49aaade)
2015-12-18Formula Wizard: evaluating expressions always in matrix context is wrongEike Rathke1-12/+20
Change-Id: I276f7bbf2bd6fa7c67d8691634ad9d79e4a08b1c (cherry picked from commit dc89367a5622748dd7c37b89ac300a663b8b98e9)
2015-12-18Resolves: tdf#96366 replace Edit...() calls with actually working codeEike Rathke1-17/+38
... and way less overhead, geez.. Change-Id: Id9277301fbe69bc9a83ca39a907032b0b86b1c81 (cherry picked from commit 9d1ee5a5b4730a6d3da4e8a02a08d1d27e9d27e4)
2015-12-18tdf#96366 disable treeview results until fix availableEike Rathke1-0/+3
Since f82d89f35207fc1cfc00ad5cd914b74c55c3e3d2 EditThisFunc() and EditNextFunc() are used to iterate through the formula to obtain expression results to display in the treeview. Calling the Edit...() functions spoils about everything as it messes around with the edit state. As the name suggests.. Change-Id: I8b35d85b7bbf8821b5a995e84f9dd88a0f6f00b9 (cherry picked from commit 8217ddbfc863dd9b313d6b5eaecb1877e42b2d02)
2015-12-18Function Wizard shoots itself in the footEike Rathke2-3/+21
Currently the Function Wizard is broken in that editing a function call as argument within another function's parameter leads to selections being reset and mismatching argument/function information being evaluated. Not sure yet what's going on there, but at least don't access vectors out-of-bounds or crash. Change-Id: I633c775556a0b90278d22d0f74d2975c20a08a5d (cherry picked from commit 88f3c8f995e04aaecc9c7fefe4fe347e87d5e05e)
2015-12-17out-of-bounds arg mapping access, this was always wrong but never hit it seemsEike Rathke1-1/+1
Change-Id: I15843b320ac8ddcefce8094da7aa7c6b81b42e4f (cherry picked from commit 5b404cc2adcea04938c8159c0bc84a8cd44ec5df)
2015-12-15Resolves: tdf#95440 SharedString are interned per document, re-internEike Rathke1-0/+30
... if literal strings are copied with formula expression tokens. Change-Id: I13526907bb6c2c605c6ed9584fa6e3f2b18623b8 (cherry picked from commit dad412e07f805a53ad73ce2e80d187a70c77e8de)
2015-11-20loplugin:unusedfields forms,formula,fpicker,frameworkNoel Grandin1-4/+0
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-18cosmeticsEike Rathke1-13/+13
Change-Id: Ic06bef4c80426b97a2613fe296ae0aa0ee55a215
2015-11-18rename FormulaToken HasForceArray to IsInForceArrayEike Rathke2-12/+12
... to name it was it does and to distinguish from ScParameterClassification::HasForceArray(OpCode) which IS about a function having ForceArray parameters. Change-Id: I8af4e1d0353cdb5ad0a9b837ae0763dc77242734
2015-11-16prevent ForceArray propagation on the same token, tdf#95670 follow-upEike Rathke1-1/+1
This may happen if the last RPN token is put and the function has a ForceArray parameter but now again would be wrong if not all parameters are ForceArray. Change-Id: I890fb6b5b88337033cfcf2e8189371ee39461205
2015-11-16Resolves: tdf#95670 propagate ForceArray per parameterEike Rathke1-3/+51
Regression of b5cd11b4b02a85a83db77ba9d8d1763f0cd88cb1 It was always wrong to propagate ForceArray already if a function had a ForceArray parameter *somewhere*, we need to do this per parameter instead. Change-Id: If188d45366279d9a7bf641edc7e4dd7095d6d035
2015-11-15tdf#95798: CRASH: when finish Function wizard on Report builderJulien Nabet1-1/+2
Following http://cgit.freedesktop.org/libreoffice/core/commit/?id=844b7287a4ccd8e3d5e458bb1dc6c52e71322b01 Change-Id: Ia5a2cd39cf3fdf87619f55710a188545830b4088 Reviewed-on: https://gerrit.libreoffice.org/19970 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-13cppcheck: noExplicitConstructorCaolán McNamara2-7/+7
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann13-124/+124
Change-Id: Ib336ce9bc95f5c84dd6412ff3c098e68c5b0f4ff
2015-11-09Replace a local functor and bind2nd by a lambda in formula.Mario J. Rugiero1-13/+3
Change-Id: Ied06b3f167c566d754d32708eaec4a354f7ee663 Reviewed-on: https://gerrit.libreoffice.org/19848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26Revert "tdf#90695: In function Wizard Array box cannot be unchecked"Eike Rathke1-0/+1
This reverts commit bebc20c62be2df2cf2741fb82945ce6b631d2fe5. Removing the disabling is plain wrong. Please see the code for when the button is disabled, when it is enabled, and what consequences it has when changing the state from checked to unchecked. Unchecking will result in the formula not being applied as array formula anymore, which it was before editing. Actually tdf#90695 is not even a bug. The checked but disabled Array button is meant as an indicator that the formula IS an array/matrix formula. Change-Id: Ic7f9f7010ce208171ef614e0885474f2deae4ac9 Reviewed-on: https://gerrit.libreoffice.org/19602 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-26tdf#90695: In function Wizard Array box cannot be uncheckedJulien Nabet1-1/+0
Just remove the disabling Change-Id: Ia03591610ba1b60a66d9962169383c4ab85288ca Reviewed-on: https://gerrit.libreoffice.org/19590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-10-19loplugin:defaultparamsStephan Bergmann1-4/+4
Change-Id: I4cb8e39dfe7efcb7ac75ebf41e3d76b8f12750f2
2015-10-16convert Link<> to typedNoel Grandin3-11/+8
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14com::sun::star->css in fpicker/Noel Grandin1-9/+9
Change-Id: I211687bfeaf456e0f9639567bff401083011cd74 Reviewed-on: https://gerrit.libreoffice.org/19353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-13do not use white text on white background in controlEike Rathke1-0/+6
... setting a control's background color has no effect (until input field text is changed?) Could be observed in the pivot table dialog's source range edit when an invalid range was entered. Change-Id: Iafb2a9016ac6bd4c020273911d62dd7423ee0458
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann5-27/+27
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-1/+1
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12convert Link<> to typedNoel Grandin2-5/+4
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12loplugin:mergeclassesNoel Grandin2-8/+7
Change-Id: Ia4c09c5b835e77eaa2d4c0d8c74f146feb0905be
2015-10-08leave room for three lines of text in function descriptionEike Rathke1-4/+8
... so we can get a little bit more verbose. The new "this is for interop with old ... instead use ..." description fit into the function overview but was truncated in the parameter window. Change-Id: I73c5e6cfb64a2b1573ab15f5ceb6aa16e6da4a99
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-9/+9
Change-Id: I273aee2d65f952afd78f6e2e504b5fa70dd65ef0
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+1
Change-Id: I6a903931fdb3ac1b13d2d9c39071cc27c08fe194
2015-10-06tdf#50950 Add ODFF1.2 Calc function ISOWEEKNUM,Winfried Donkers2-15/+65
make Calc function WEEKNUM compliant with ODFF1.2, provide backward compatibility for Calc function WEEKNUM, add unit tests for ISOWEEKNUM, WEEKNUM and backward compatibility. Change-Id: I63af5543cea2f470d710462e55404ac754022c89 Reviewed-on: https://gerrit.libreoffice.org/18760 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-03no need to allocate that vector on the heapMarkus Mohrhard1-20/+18
This seems to give about 10% performance improvements in some calc cell calculations. Change-Id: Ibd91558b3c107e4c8e1401345c9332f97645453e
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann3-12/+12
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29i#126557# increase number of lines of dropdown of category listboxKay Schenk1-0/+1
(cherry picked from commit 48cb20bb5c32f076f295c7490d6ba9ac96e85ed0) Change-Id: I18ba8a781e111fd7706de1eadb41c93a78e27c62
2015-09-28tdf#94214 ODFF function FINV incorrectly saved as COM.MICROSOFT.F.INVWinfried Donkers1-1/+1
Change-Id: Ic053342fde436a7053c15e32683e09b9e91f5308 Reviewed-on: https://gerrit.libreoffice.org/18792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-09-24convert Link<> to typedNoel Grandin3-11/+7
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b Reviewed-on: https://gerrit.libreoffice.org/18825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-17convert Link<> to typedNoel Grandin3-9/+8
Change-Id: I70de366349801fed36fb5d62bc53236efa8b6967
2015-09-17convert Link<> to typedNoel Grandin3-17/+14
Change-Id: I93988860f409e13d99aaec06a0b0833b3814da24
2015-09-17remove unused Link<> fieldNoel Grandin2-5/+3
Change-Id: I6aee7b6ede35aa590a263c3851d181115233a790
2015-09-17convert Link<> to typedNoel Grandin3-24/+20
Change-Id: I0521aad1bc63c75242ae07feccebe24dbc754d6b
2015-09-17convert Link<> to typedNoel Grandin4-15/+12
Change-Id: I8465811de6794345d79eb29c8efbc70f82b3168e
2015-09-17remove unused Link<> fieldNoel Grandin2-20/+0
Change-Id: Ia2e3180b8794e0875869640ae0c45026718c1946
2015-09-17convert Link<> to typedNoel Grandin4-7/+6
Change-Id: I83a418c81a5d1267286236cfcdedc889d34fc963
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 13:46:13 +0000