summaryrefslogtreecommitdiff
path: root/formula
AgeCommit message (Collapse)AuthorFilesLines
2015-11-20Resolves: tdf#95670 propagate ForceArray per parameterEike Rathke1-2/+46
Regression of b5cd11b4b02a85a83db77ba9d8d1763f0cd88cb1 It was always wrong to propagate ForceArray already if a function had a ForceArray parameter *somewhere*, we need to do this per parameter instead. (cherry picked from commit 49257e1da7e371fdea0fac080116b0511789cac7) Conflicts: formula/source/core/api/FormulaCompiler.cxx prevent ForceArray propagation on the same token, tdf#95670 follow-up This may happen if the last RPN token is put and the function has a ForceArray parameter but now again would be wrong if not all parameters are ForceArray. (cherry picked from commit b31b17e52b2b2b94999d68c4b2ed5c74ee7eed0a) 890fb6b5b88337033cfcf2e8189371ee39461205 Conflicts: sc/source/core/inc/interpre.hxx -Werror,-Winconsistent-missing-override (cherry picked from commit 6edc492efd6fe2de15c1ae306b400ca054772ad1) Backported to SAL_OVERRIDE 3bb2764b625d44f6e0cecbdde3363440faef63b5 Change-Id: If188d45366279d9a7bf641edc7e4dd7095d6d035 Reviewed-on: https://gerrit.libreoffice.org/19997 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-15Resolves: tdf#89643 report builder function wizard segfaultsCaolán McNamara1-3/+1
regression from commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that "someone else" needs to look after, i.e. the reportdesign variant is the more correct so revert 3d6521280929ecacc53b7c358d29d0b5d31b3462 and to fix the leak make the sc own the ScFunctionCategories and just cache them like the reportdesign one does Change-Id: Ifd986301a54b4d20449e864697655cd973e0c4df (cherry picked from commit 7c3abee29c742593206b755b20a718c46f0780fa) (cherry picked from commit 73107eb3375f1671f549f0467be2812df9223848) Reviewed-on: https://gerrit.libreoffice.org/16232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-04-30string access out of boundsEike Rathke1-1/+1
This convoluted logic may pass FUNC_NOTFOUND -1 as position around if there was no initial function. Change-Id: I217fc745d8e0b8e532642d0f69110371d183610d (cherry picked from commit d6635af3186314de0c20a904b36e50bba4ae63cd) Reviewed-on: https://gerrit.libreoffice.org/15570 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-03-31Resolves: tdf#90301 string access out of boundsEike Rathke1-1/+3
Apparently yet another leftover of UniString to OUString conversion where with UniString out-of-bounds accesses didn't harm and returned NIL. (cherry picked from commit eed393039a9067f7a1a318934ff1c5ff90bfe443) Include <algorithm> for std::min() (cherry picked from commit 3394ac816a573030feda145dbdabd2a1eabd78c4) 13ed47d23ed4b94501d9445555d99ce08af94698 Change-Id: Id88456a52df3fc8cdaf90d9d509e327b96269808 Reviewed-on: https://gerrit.libreoffice.org/15074 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-02-17fdo#81596 export to OOXML that need argument changesWinfried Donkers2-96/+260
Reviewed-on: https://gerrit.libreoffice.org/10831 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4feaf96f50fa89eccb4e7a638220099e9a8482f1) sensible indenting, fdo#81596 related (cherry picked from commit 3dd241c52d6db424bd4696ff8f223976542e411b) simplify RewriteMissing() and switch in Add...(), fdo#81596 related (cherry picked from commit 14aabee5a73e57e26b2062b1ebf00c3f1dff1250) write TRUE() for 2nd IF() parameter, fdo#81596 related (cherry picked from commit 8f031861f590ba914321816657a003375d93ef5d) f7eb11a950b45793d04837d02f9546a93673fa2f f2ca37e1fda87ce56282fc2d2fc57a0784851139 52d0b43b19e10bee82109b635b3b7ce4f43650a3 Change-Id: I3a99e416be9f3f04175939e4560f8f7c55497185 Reviewed-on: https://gerrit.libreoffice.org/14388 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-12fdo#87534 fix HYPERLINK behaviour when used in namesWinfried Donkers1-0/+2
When using HYPERLINK() in names, the hyperlink was set to disabled on copying token. After fix, behaviour is consistent. Note: reducing the fix to 1 line does not work, a set hyperlink is only to be copied when applicable. Change-Id: I27ad24ed8912afa548f08d249ad51d18a792c275 Reviewed-on: https://gerrit.libreoffice.org/13920 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 944886f6d96843ca4f5833ecca48a693c81abc3b) Reviewed-on: https://gerrit.libreoffice.org/14448
2015-01-21fdo88632: Make the Calc random functions non-random when requestedTor Lillqvist3-2/+61
We don't want such a mode to affect other uses of randomness, though. Thus use a separate random number generator object for these two functions, and use a fixed seed for it if the SC_RAND_REPEATABLE environment variable is set. As RAND() is implemented in sc, and RANDBETWEEN() is implemented in scaddins, it was a bit hard to figure out where to add the new functions needed, without having to over-engineer things with UNO. (This functionality is totally Calc-specific, but neither sc nor scaddins has any public (non-UNO) API.) Caolan suggested the formula module, which seems like a good enough place to me. Change-Id: Ic1c9ca165278d53036598b03b13b4ffbdc98a75e Reviewed-on: https://gerrit.libreoffice.org/14053 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-12-11fdo#87203 make translatable AGGREGATE functionAndras Timar1-1/+1
Change-Id: Ic376a4e03cafbba65ec78723de188bd627c0ef4f (cherry picked from commit f6ef20b046c485c89fb25521dec1eb6642aac1ba)
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-10-23Move virtual ScToken members up to FormulaTokenStephan Bergmann1-0/+65
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-22Remove unused FormulaToken::Is3DRefStephan Bergmann1-5/+0
Change-Id: Ib720bc4b3bfff8e428d14d65ff73144db82c60e0
2014-10-03Make these methods non-inline again.Kohei Yoshida1-0/+39
Change-Id: I30c7969ab386f4cba2f0b44cbebe306ce6430b15
2014-09-26formula: std::auto_ptr -> std::unique_ptrStephan Bergmann2-11/+9
Change-Id: I7b4784abf5177e22a9df33c5d4faccfd39801b11
2014-09-23fdo#82577: Handle WindowNoel Grandin9-34/+34
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin6-12/+12
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist1-6/+6
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22convert OSL_FAIL to SAL_WARNEike Rathke2-2/+2
Change-Id: I001f29dca5f2a01d70115bb309c99c64c4a65efb
2014-08-22convert OSL_... to SAL_WARNEike Rathke1-5/+10
Change-Id: I073b6f985c4a67f56319e03790b2bceee2f957ff
2014-08-22reactivate the verifyEike Rathke1-1/+1
Missed this earlier. Should be a SAL_WARN, but postponed. Change-Id: Ia6b178702461c8a0fa5ded3e1c47795b95da7d98
2014-08-22fdo#82183 do not reset globals while loading a documentEike Rathke1-1/+1
Destroying the function list while an instance of the Formula Wizard is still open is a bad idea. Workaround not doing this when loading a document due to a DDE function or external reference being entered in the wizard. Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
2014-08-21it's about time to write GOALSEEK as ODFF ORG.OPENOFFICE.GOALSEEKEike Rathke1-1/+1
Change-Id: Ie5a0464b49baae62e217e87f4d0040151f3aa8a5
2014-08-21write COLOR function with extension namespaceEike Rathke1-1/+2
and add to Excel import/export maps so it survives saving in that format Change-Id: I3a8e07fdd1bded77d4bad60eefffeb0b1dbdd734
2014-08-20Fixed size of 'formula' dialog in CalcSzymon Kłos1-1/+1
Fixed: 1. Open Calc 2. Open formula dialog 3. Choose AMORDEGRC function or other with >= 4 params Edit field is covered by other controls Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3 Reviewed-on: https://gerrit.libreoffice.org/11035 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-09remove unused dlg resources from dbu_resource.hrcThomas Arnhold1-1/+0
Change-Id: I70c5f673413bb6ac2d37a5c15b52fcd26da6683a
2014-07-31fix memory leak around function descriptionsMarkus Mohrhard1-1/+3
Found by Lsan. Change-Id: Ia443ed6eb2a20854998a615f3c2bd9fdac156a8c
2014-07-29Remove some unused codeMarcos Paulo de Souza1-11/+0
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3 Reviewed-on: https://gerrit.libreoffice.org/10593 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-27fdo#81038 Fixed FormulaTokenIterator to use std::vector instead of linked listJeffrey Stedfast1-35/+31
Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07 Reviewed-on: https://gerrit.libreoffice.org/10565 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-08Explicit virtual dtor needed for auto_ptr member for MSVC.Kohei Yoshida1-0/+4
Else it won't build. Change-Id: I6d857ffc7a444abaf477ee820e577757287a707c
2014-07-08trivial conversion of RID_FORMULADLG_FORMULA_MODAL to .uiCaolán McNamara3-186/+6
Change-Id: I25f29821079cf4fa4759daffe78bec8c4b48abbc
2014-07-08fdo#73148 add options to Calc function AGGREGATEWinfried Donkers1-1/+2
matrix-ranges not supported Change-Id: I902c78da6d9c7a4a5f8c5e4a7e1678b69d49a6fe Reviewed-on: https://gerrit.libreoffice.org/9449 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-06-19callcatcher: update unused codeCaolán McNamara1-24/+0
Change-Id: Ia25c686dac799707cae3f6112c731f8cd3f686c2
2014-06-17remove helpids that are unused or go nowhereCaolán McNamara2-17/+0
Change-Id: I5af0b84ff4a85e72f5068d450a04d01df0592d3b
2014-06-17give refedit in formula wizard an initial sizeCaolán McNamara2-0/+6
Change-Id: I8e19c29c47dea2f7cff754e81ef51fc9898fdee8
2014-06-17restore these for the moment, still in use in scCaolán McNamara1-1/+34
Change-Id: I6967a3c871338d1801d913d9bb54eba50a7660ca
2014-06-17I could fight with ValWnd to fix it, or I could replace itCaolán McNamara4-99/+15
it's not handling resizing and redrawing well, so just drop it in favour of a read-only edit Change-Id: I5e6f85cf9326b908bf1bf835d8da0c49ca9209c9
2014-06-17RID_FORMULADLG_FORMULA conversion to .uiSzymon Kłos20-841/+1491
Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8 Reviewed-on: https://gerrit.libreoffice.org/9797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin1-5/+1
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13resolved fdo#79957 propagate ForceArray through jump tokensEike Rathke1-1/+6
ForceArray parameters weren't propagated and enforced to array arguments on svJump tokens (FormulaJumpToken), namely IF, CHOOSE, IFERROR and IFNA. Change-Id: Icf9074f11b826655a52858d778d9a0122d207aa4
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin5-14/+2
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-23whitespace clean-upMarkus Mohrhard1-7/+4
Change-Id: I10bdfc3356bda66fefa59fa2c9f63f9231d8728e
2014-05-21fix spellingNoel Grandin1-1/+1
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-21most certainly == was meantEike Rathke1-1/+1
Change-Id: I1b0833daa576cd8603421e1036b8773badc8c775
2014-05-21ODS load perf: transfer ownership of the ScTokenArray to save cycles.Michael Meeks1-0/+18
Add API to wnsure we don't end up allocating 32k bytes of tokens for each ScFormulaToken, as happens when you Add a token to a new empty ScTokenArray. Change-Id: Ib12a3065eb513243a2146ebb009fbaa650385dd9
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold5-11/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19add COLOR functionMarkus Mohrhard1-0/+6
This function makes property mapping in charts more user friendly. Change-Id: I01cfb31edd749ee474d5078042fa5c4b4a270f86
2014-05-14Bail out of group calculation in case the array fetching fails.Kohei Yoshida1-5/+24
Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3
2014-05-14No more SetCompileForFAP(). Use respective flag setting methods instead.Kohei Yoshida2-4/+9
Change-Id: Ib2256ebac8a7e63e7e24fb35d13d47b811bd8e19
2014-05-14Use "stop on error" concept rather than "ignore error if true".Kohei Yoshida1-12/+12
Just to keep the pattern of "true" -> "action", "false" -> "no action". Change-Id: I6303bc779cd7048eef2fdc3c2abba8be8f15da6d
2014-05-14Introduce a new boolean flag and use it in lieu of bCompileForFAP.Kohei Yoshida1-8/+14
To make it sound more general than "compile for FAP". Change-Id: Ia6916b6f3579a290be7d5074f809666be2bd2473
2014-05-11coverity#1169835 Improper use of negative valueCaolán McNamara1-3/+3
Change-Id: I1857f5c712f9407c8a4b69f30044e8bb444afad2
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 08:37:19 +0000