summaryrefslogtreecommitdiff
path: root/formula
AgeCommit message (Collapse)AuthorFilesLines
2017-07-31Resolves: tdf#104186 spaces between function name and ( not allowed in OOXMLEike Rathke1-6/+22
(cherry picked from commit 7232980be6a4d67ed28a21b74ef3544cacb29d6a) Conflicts: formula/source/core/api/FormulaCompiler.cxx Backported. Change-Id: I6f6fcdab24a426d0f62052fa2d31f4098d1d893a Reviewed-on: https://gerrit.libreoffice.org/40086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 6ff7de9c93e280cfe54a0ed660595c98d052ab11)
2017-07-06Set error on more than max params (255) per functionEike Rathke1-2/+6
Parameter count is size byte, so.. SUM(1,1,1,...) with 256 arguments resulted in 0 (uint8 wrapping around). (cherry picked from commit 209cc5c211260a6c20cc6fb5ac02fd5a88100314) Change-Id: Ib9997ad0d0d13d4c5171f276148b6c5cad570d5b Reviewed-on: https://gerrit.libreoffice.org/39506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 1d1bdfd94fc2963d0281ea4fd8d3a98e39f4ccf7)
2017-05-30Resolves: tdf#96426 more whitespace intersection operator in Excel syntaxEike Rathke1-7/+16
Handle also stacked token arrays resulting from named expressions like =range1 range2 Change-Id: I1838af155f17b5e4f941e46895303caed75b6075 (cherry picked from commit 70cb7757f971c4c16d1b0a5585d95816cd4382e6) Reviewed-on: https://gerrit.libreoffice.org/37712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 9c89d41ed44c1a4126b82f0c05768f5d640f741b)
2017-01-06check length of string as this can be called untokenized, tdf#105024 relatedEike Rathke1-2/+3
i.e. during import of ODFF Change-Id: I7f5419d393f89d8a84efca7444e8dde3a3e9199f (cherry picked from commit b36bf9f567f5b531f526dad6776c84e06203396f) Reviewed-on: https://gerrit.libreoffice.org/32791 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-upEike Rathke1-1/+1
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7 (cherry picked from commit 6b89bcf85a911d043c9d93e843be12e6f23adedd) Reviewed-on: https://gerrit.libreoffice.org/32763 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-01-06Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constantsEike Rathke1-1/+20
Change-Id: I4e5d98cdbbc2f3e7746cd3892f70151376bc5808 (cherry picked from commit 857be5b2db4b2726306199bc279942f621bf55d8) Reviewed-on: https://gerrit.libreoffice.org/32761 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin1-1/+1
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-10loplugin fixes here, tooTor Lillqvist1-8/+1
Change-Id: I32cf90d524f8dd9fb454d4145d314b748ac0b281
2016-11-10use-after-free fix here, tooTor Lillqvist1-2/+2
Change-Id: I228b6367abadfc25c85fdb6821faebc7e4e8dda8
2016-11-10TyposTor Lillqvist1-1/+1
Change-Id: I87a63c4b1a13186efa5d0bd807605092197082e0
2016-11-08loplugin:expandablemethods in forms..formulaNoel Grandin4-15/+2
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b Reviewed-on: https://gerrit.libreoffice.org/30688 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in frameworkNoel Grandin1-2/+2
Change-Id: I893bf955e45e661e3ec440dbd530fca22931c23b Reviewed-on: https://gerrit.libreoffice.org/30666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03loplugin:unusedmethods unused return typesNoel Grandin1-22/+21
Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930 Reviewed-on: https://gerrit.libreoffice.org/30519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I695b3709c2b53f62773dc390b89966061c7b0ae9
2016-10-29display matching search per selected category, tdf#67974 follow-upEike Rathke1-12/+30
Also select category All while typing in Search, and display the LRU list independently. Change-Id: I8a734cc202e017d3a10d8a6f89b1814073a77c81
2016-10-29filter hidden functions also in search, tdf#67974 follow-upEike Rathke1-2/+6
Change-Id: Iaa23759e01d8f86bfc5c0bbd8b333cd331b7b8cd
2016-10-29tdf#67974 UI: Add a search box in function wizard in SpreadsheetAbhilash Singh3-30/+100
Change-Id: Idd243824a25ba99b2163f094c531dad7fe1153c8 Reviewed-on: https://gerrit.libreoffice.org/30118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-26tdf#103088, improve interoperability with Excel for LOGNORMDIST().Winfried Donkers1-4/+20
Change-Id: I5f4ccbb54b212247a3ff8b13ff012c930d18a86c Reviewed-on: https://gerrit.libreoffice.org/30020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-25no Edit controls loaded from .src nowCaolán McNamara1-11/+0
Change-Id: I42c7377c101c642ea39028e05e4ffd58fc7435d7
2016-10-24tdf#103186, make LOGINV ODFF1.2 compliant.Winfried Donkers1-0/+4
(Also retain Excel-interoperability and backward compatibility with Calc.) Change-Id: Ibbe7224eabfb776cf6e7ecfeabae6d188178f4ed Reviewed-on: https://gerrit.libreoffice.org/29885 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-19loplugin:expandablemethodds in formula..frameworkNoel Grandin4-68/+10
Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa Reviewed-on: https://gerrit.libreoffice.org/30015 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18tdf#93894: Prohibit grouping when certain token types are present.Kohei Yoshida1-1/+4
For instance, column / row label tokens don't work correctly in grouped cells with the current implementation. Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683
2016-10-14tdf#102948 Make HYPGEOMDIST ODFF1.2 compliant.Winfried Donkers1-0/+16
Also reduce duplicate code. On Export to OOXML, HYPGEOMDIST is converted to HYPGEOM.DIST. Change-Id: I70a70ee6b5c542e272ef574073ebcd1924f31083 Reviewed-on: https://gerrit.libreoffice.org/29767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara2-19/+8
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara4-4/+1
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05convert MapUnit to scoped enumNoel Grandin3-3/+3
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann9-47/+47
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-23convert formula error codes to scoped enumNoel Grandin2-61/+63
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: https://gerrit.libreoffice.org/28897 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-16loplogin:singlevalfields in include/Noel Grandin1-6/+2
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-5/+5
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-26handle overwriting of symbols/opcodes in symbol map for known casesEike Rathke1-7/+84
This silences the SAL_WARN_IF like warn:formula.core:6944:1:formula/source/core/api/FormulaCompiler.cxx:625: OpCodeMap::putOpCode: reusing OpCode 161, replacing '_xlfn.ORG.OPENOFFICE.ERRORTYPE' with 'ERRORTYPE' in English map 0x1018000 that occurred during the first load of OOXML .xlsx documents since the old bad entries were added with commit 89c4a69103b6e15e7f52401c51110b926c3ccf36 In fact the direction opcode -> string was replaced, which it should had not. That specific mapping is only used though when loading msoxl namespace formulas from ODF. Also, the replacement of parameter separator and array column and row separator worked merely by chance, depending on in which order the entries where inserted to the hash map. Fixed along as it popped up with the new handling. Change-Id: I88017a8b38ccc30874c3dca7d78f0fa47a77a36f
2016-08-18screenshots: add new global make targetArmin Le Grand1-1/+2
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand1-74/+2
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for formulaArmin Le Grand4-0/+255
Change-Id: I2fb495dd8603b00127504240e4bec16726c2153f
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin1-4/+4
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-03Resolves: tdf#69539 UI rename CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERTEike Rathke1-4/+4
... with same syntax but different semantics that was even more confusing. Change-Id: Ibe1efcd5c4e82c9ce8d9fe8ed0f85e86dac327f7
2016-08-03rename ocConvert to ocConvertOOo and relatedEike Rathke2-7/+7
... to clarify that this is not the "real" CONVERT function. Change-Id: Ia71949ffabd2c983be0dbf9fa36bb8c52f0077ee
2016-08-03UI rename DURATION to PDURATION, DURATION_ADD to DURATION, tdf#50488 relatedEike Rathke1-4/+4
Change-Id: I7ba783b59a711fc9c9d6bbe68dcf8c3c1a0d409d
2016-08-03rename ocDuration to ocPDuration and relatedEike Rathke1-6/+6
... to clarify that these belong to PDURATION (currently DURATION in UI) instead of DURATION (currently DURATION_ADD in UI). The confusing UI name situation will be resolved separately. Change-Id: I09a7bc8437be1c4c9e72f94e61c877111fb48806
2016-08-03use GRAM_API instead of GRAM_PODF_A1 in API contextEike Rathke1-1/+1
... which right now is identical but may get corrections in future. Change-Id: Id4e1707afb32a3d8e073705072e5e65105f2a14a
2016-08-03InitSymbolsAPI() for FormulaLanguage::APIEike Rathke1-11/+5
Change-Id: I203557ed50d0d54fe9977e3d51e7f979551b472b
2016-08-03introduce formula::FormulaGrammar::Grammar::GRAM_APIEike Rathke1-0/+1
Change-Id: Iceaf114847129f0b014ffd61d547e131baf1f07b
2016-08-02introduce mxSymbolsAPI and InitSymbolsAPI()Eike Rathke1-0/+21
Change-Id: I1c4673a25bb0f686e0705f87318a04166e6688bb
2016-08-02InitSymbolsPODF() from RID_STRLIST_FUNCTION_NAMES_ENGLISH_PODFEike Rathke1-1/+1
Change-Id: I03f8d183303b869a4cfaa76ea4170da95574e5d5
2016-08-02prepare to disentangle RID_STRLIST_FUNCTION_NAMES_ENGLISHEike Rathke2-7/+901
RID_STRLIST_FUNCTION_NAMES_ENGLISH grew to a conglomerate of English UI names, names used in PODF (ODF 1.0/1.1) and XFunctionAccess API names. Copy it to independent resources so we can start to correct names in English UI, keep PODF oddnesses and cater for API compatibility needs. Change-Id: I7c2053d7627c4da220d8fc991158e8e7a81f0b37
2016-08-01keep a broken expression as originally brokenEike Rathke1-0/+1
The invalid expression ISOWEEKNUM(A1,0+) lead to a replacement with ISOWEEKNUM(A1+) which of course is also wrong but loses the original context. Just exchange the call and convert to WEEKNUM_OOO(A1,0+) without fiddling with the parameters. Change-Id: Id1c42d3ba084382e09c164b6c35db996f2b0197a
2016-08-01refine ISOWEEKNUM vs WEEKNUM_OOO detectionEike Rathke1-1/+4
Change-Id: I7cf5d51946235ea1bc6a4d0999fa98e1a3f8a095