summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2013-11-27forms: avoid deadlock when setting FontControlModel propertiesMichael Stahl5-60/+96
Deadlock found in forms_unoapi on Windows, with OGridControlModel::setFastPropertyValue_NoBroadcast() calling event handler that tries to lock SolarMutex. FontControlModel::setFastPropertyValue_NoBroadcast() and its callers in 3 other classes must not send events via firePropertyChange() because they are called by OPropertySetHelper::setFastPropertyValues() with its Mutex locked. It is possible (though sadly quite convoluted) to delay the sending of the events by calling setDependentFastPropertyValue() instead. Change-Id: I0c767cfec01fe1bcaeb1236287b5faf81a2e7441 (cherry picked from commit 6aefcb6a6f90896754f3432e5ae41403998b7ab0)
2013-11-27FontControlModel::convertFastPropertyValue: fix bad cast of KerningMichael Stahl1-1/+1
Casting sal_Bool to integer lets the comparison always fail. Change-Id: I33cf9e9b6a65f81166870bdfe32e9a97101501df (cherry picked from commit e521a803c914e0d3718ae795976948aabbb9c76c)
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin8-22/+22
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-16cppcheck: Array index is used before limits checkJulien Nabet1-1/+1
Change-Id: I30154dd9504b70dc3212af3ac1d88dfc9a9d8396
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann2-2/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-142/+0
Change-Id: Ia04390e5a3d4c5833c24add581985a9491af0443
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin4-28/+28
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14i18npool, forms: remove warnings_guard_unicode*.hMichael Stahl2-43/+2
These horrible headers use "#pragma GCC system_header" and thereby prevent generated Makefile dependencies, which is what broke incremental builds after the ICU upgrade today. Change-Id: Ife983b3c4de86968da8a0187a1acb1bbb2b5c81f
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-1/+1
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin1-1/+1
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin2-10/+8
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructor in FORMS moduleNoel Grandin10-35/+34
Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3
2013-11-05fixincludeguards.sh: formsThomas Arnhold105-289/+289
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt1-3/+3
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructorNoel Grandin2-4/+4
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-1/+1
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza5-64/+11
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d Reviewed-on: https://gerrit.libreoffice.org/6423 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist2-2/+2
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-20drop unnecessary tools/string includesCaolán McNamara4-4/+0
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-17bogus WaE: 'bValue' may be used uninitialized in this functionLionel Elie Mamane1-11/+3
Change-Id: Ifde0f9370d093f447edac4899c5bbc7940da5a8c
2013-10-17WaE: unknown warning group '-Wmaybe-uninitialized'Tor Lillqvist1-3/+3
Seriously, would it be so awful to initialise the value even if strictly speaking it is unnecessary? Hopefully avoiding that is not an attempt at manual micro-optmisation? (Or did the initialisation actually cause some warning?) Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux, too. It is great. Our Clang plug-in (which can be easily used only on Linux) is very useful. Change-Id: I379afed707d96745ee29979bd79467309adf0147
2013-10-17MacOS X fixup to bogus WaE: 'bValue' may be used uninitializedLionel Elie Mamane1-7/+9
Change-Id: I1485e7f6b9147d4cec94833c0a2b35e730c397cf
2013-10-17bogus WaE: 'bValue' may be used uninitialized in this functionLionel Elie Mamane1-1/+11
Change-Id: I14983509a41bd6be0d7fed29d7f89fa4a21fe08a
2013-10-16WaE: 'bValue' may be used uninitialized in this functionTor Lillqvist1-1/+1
Change-Id: I6fd6f679dd81707483c6834a4d4b2ca935f7c515
2013-10-16respect reference values in checkboxesLionel Elie Mamane2-4/+34
Change-Id: Ifd0953f779f530af6b190425794f009a891f0afb
2013-10-02Spell "indices" correctlyTor Lillqvist1-2/+2
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
2013-10-02Use std::auto_ptr::reset where applicableStephan Bergmann1-6/+3
(avoids warnings about std::auto_ptr ctor being deprecated) Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
2013-10-01convert FORMS modules from String to OUStringNoel Grandin7-23/+23
Change-Id: Iadb3638b03e1a9712553ea5e4c041493d4e1656a
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara3-0/+3
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák6-8/+8
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-10BUG:57950 Remove chained appendsNeil Moore3-33/+12
Removed some chained OUString::append()'s from forms. OUStringBuffer could really use a append operator(+=). Change-Id: I635bdd25da9f09373e686d87a1d198bc09bda906 Reviewed-on: https://gerrit.libreoffice.org/5329 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-04fdo#67235 adapt form control code to time nanosecond API change, step 3Lionel Elie Mamane2-64/+11
Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d Reviewed-on: https://gerrit.libreoffice.org/5270 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-07-28More details in debug outputLionel Elie Mamane1-11/+22
In particular, give type and message of exception when unexpectedly caught. Also miscellaneous other details. Change-Id: I87d71028dbc902e1770fee4c3643c85e75b7646d
2013-07-27...and remove now-unnecessary commentStephan Bergmann1-2/+0
Change-Id: I8c707937ac3e40c4a5f2caa1a928a373ee675d89
2013-07-27lcl_getFormatTable result is used non-constStephan Bergmann1-7/+7
Change-Id: I9fbd62c24190c28752fd9f4cf37d84d1fd466983
2013-07-27Mark as const/staticTakeshi Abe1-2/+2
Change-Id: I9000ea607e1df140ac18d59f7c4d4abd999c71d1
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl1-5/+5
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18 Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-07-15callcatcher: update unused codeCaolán McNamara2-21/+0
All FontSizeBoxs and SmFontPickListBoxs are now .ui loaded, .res ctors unused Change-Id: I50aa8606fefacab0b15b6795a7ba90dff8109802
2013-07-13use static LanguageTag::convertTo...() for standalone conversionsEike Rathke1-2/+2
If no LanguageTag instance is at hand use the static methods to convert between BCP 47 string, Locale and MS-LangID instead of creating temporary instances. Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-07-04Try to fix clang tinderboxJulien Nabet1-2/+2
Change-Id: I48124ea0f617396d92f82e4afd8b84a162af2862
2013-07-03fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFORadu Ioan3-22/+19
- replaced RTL_CONTEXT_ with SAL_INFO - replace OSL_* with SAL_* Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e Reviewed-on: https://gerrit.libreoffice.org/4620 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-02drop unused convertWhitespaceCaolán McNamara2-38/+0
Change-Id: I2e27e498cb86d5aaeff692e62e75ee8c8200e729
2013-07-02OUString convertion for unotoolsNorbert Thiebaud1-6/+5
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707 Reviewed-on: https://gerrit.libreoffice.org/4659 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-29remove OUString wrap for string literalsThomas Arnhold10-14/+14
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29Search for char instead of 1 char long string, when possible.Thomas Arnhold1-1/+1
follow-up of a7674482254ee996b1c4fee60f3064778be369aa Change-Id: I25f40c601454c092078307d931333af1bc1447ac
2013-06-27fdo#66171 ListBox correctly save empty or zero BoundColumnLionel Elie Mamane1-0/+5
Change-Id: I05fa923f962191081ea3318837d3e181c183b466
2013-06-23make "gcc -Werror" happyLionel Elie Mamane1-1/+1
Change-Id: I6dd1bf6b4535bb956cb7e85908312d52749a6f2b
2013-06-23Data-aware ListBox: fix case ListSourceType==TableFieldsLionel Elie Mamane1-0/+12
Change-Id: I9a89374fd1cc56c8185753f5959275a0a2d841ff
2013-06-23Don't second-guess the databaseLionel Elie Mamane1-1/+1
If it gives us a NULL as bound value, use it, even if the underlying column has constraint NOT NULL. This can happen e.g. in OUTER JOIN, with UNION, ... Change-Id: I1fc0d9366764b90e0cdb443cd34c32b52f059e0b
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 15:23:49 +0000