summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2019-06-23Fix typosAndrea Gelmini1-2/+2
Change-Id: If81c6224abbd0028bcc446159cf12436e89325d8 Reviewed-on: https://gerrit.libreoffice.org/73421 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-21tdf#39593 Remove frm::OGridControlModel::getColumnImplementationArkadiy Illarionov4-17/+7
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I3b662136778340a95216ac08035f7c25d5882349 Reviewed-on: https://gerrit.libreoffice.org/74472 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-20tdf#39593 Remove static xforms::Binding::getModelImplArkadiy Illarionov2-12/+2
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I001293ca25387a34cff9872c6db2ab72c6c4d617 Reviewed-on: https://gerrit.libreoffice.org/74385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Model::getModelArkadiy Illarionov4-25/+8
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I52f780059be7626a03bf79044cfc580bb33f3fd3 Reviewed-on: https://gerrit.libreoffice.org/74383 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Binding::getBindingArkadiy Illarionov6-25/+19
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ic569783ae01f731f54b54775b8e0eba162cc4b78 Reviewed-on: https://gerrit.libreoffice.org/74381 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-20tdf#39593 Remove xforms::Submission::getSubmissionArkadiy Illarionov4-20/+12
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I8dcd0bf1cfbaa02fbb7c128421506f1c30d87773 Reviewed-on: https://gerrit.libreoffice.org/74387 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov2-2/+2
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-16loplugin:logexceptionnicely in filter..frameworkNoel Grandin2-5/+6
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468 Reviewed-on: https://gerrit.libreoffice.org/74098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4 Reviewed-on: https://gerrit.libreoffice.org/73637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I577cecc9b5c73a999b0e38478adf71c527210619 Reviewed-on: https://gerrit.libreoffice.org/73635 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I1ed7280266fc2612ca1286c129a614c51aba3571 Reviewed-on: https://gerrit.libreoffice.org/73636 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini1-2/+2
Change-Id: I3883dedde0ad3ca6c4d6190d711af9c1e6411a50 Reviewed-on: https://gerrit.libreoffice.org/73573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini1-1/+1
Change-Id: I351a41c7b6964bdf60d9231640c18461fca81ff2 Reviewed-on: https://gerrit.libreoffice.org/73575 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini1-6/+6
Change-Id: Iedf4ec187812fd152d19f70405d2f4554211bf6b Reviewed-on: https://gerrit.libreoffice.org/73576 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I2d361544b571144e7f0f2c4190ec3e578427ec7c Reviewed-on: https://gerrit.libreoffice.org/73475 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib92c1a4b60e46019b4c6f89f88b9e99e5b2d497a Reviewed-on: https://gerrit.libreoffice.org/73473 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie8b8aeb1ebcb78cca73c6c2bc0512b2f30d245ae Reviewed-on: https://gerrit.libreoffice.org/73474 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov2-2/+2
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-04Fix typoAndrea Gelmini1-1/+1
Change-Id: I1a657bd08ff7a6108a20d57d5ebe9f104fcbe3fd Reviewed-on: https://gerrit.libreoffice.org/73420 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-04Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib72667f1360e190b15eac187b46fc563b9f65524 Reviewed-on: https://gerrit.libreoffice.org/73419 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Fix typoAndrea Gelmini1-1/+1
Change-Id: I86e2040fb54bb13f26a458b7ad96353b7bf7065d Reviewed-on: https://gerrit.libreoffice.org/73353 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-2/+2
Change-Id: I588837ea6eeeb271a821edcd4e9bc14bb78bf933 Reviewed-on: https://gerrit.libreoffice.org/73351 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov5-16/+16
Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-23Re-enable JunitTest_forms_unoapi_2 forms.ODateModelStephan Bergmann1-1/+1
f9905401d8cf2d73576231ebd84cfa5f4f73bcac "tdf#125170 Deliver mouse events also when clicking into document content" had disabled it because its gerrit_linux_clang_dbgutil Jenkins build had failed it successively like > LOG> Execute: Date > LOG> try to set: > LOG> old = com.sun.star.util.Date@271053e1{1, 1, 1800} > LOG> new = com.sun.star.util.Date@589838eb{2, 0, 0} > warn:tools.datetime:303:1063:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. > LOG> Property Date is void > LOG> Value for 'Date' hasn't changed as expected > LOG> result = com.sun.star.util.Date@42dafa95{1, 1, 1800} > Method Date finished with state FAILED > LOG> Date: COMPLETED.FAILED (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/32715/>). But it is unclear how that commit would have affected that test, and at least a recent local build of mine succeeds with > LOG> Execute: Date > LOG> try to set: > LOG> old = com.sun.star.util.Date@dc24521{0, 0, 0} > LOG> new = com.sun.star.util.Date@10bdf5e5{1, 0, 0} > warn:tools.datetime:10048:10220:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. > LOG> Property Date is void > LOG> Property 'Date' OK > LOG> result = com.sun.star.util.Date@6e1ec318{1, 0, 0} > Method Date finished with state OK > LOG> Date: COMPLETED.OK (note the difference of initial date, {1, 1, 1800} vs. {0, 0, 0}, whether or not that is relevant), so lets re-enable the test for now and see... Change-Id: I53b462954650e32de85c795c94f9b8038dc01918 Reviewed-on: https://gerrit.libreoffice.org/72863 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22New loplugin:dataStephan Bergmann2-2/+2
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-16tdf#125170 Deliver mouse events also when clicking into document contentSamuel Mehrbrodt1-1/+1
Event listeners are added once VCLXWindow::SetWindow is called. This never happened for the document content window. So we need to call Window::GetComponentInterface which will create an XWindowPeer and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow. After that, event listeners are registered so that we can deliver events. Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043 Reviewed-on: https://gerrit.libreoffice.org/71948 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin3-7/+7
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10an uno -> a unoCaolán McNamara1-1/+1
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara2-4/+4
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák1-37/+22
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09avoid copying when placing items into SfxItemSetNoel Grandin2-9/+4
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I43ba5d6591be6ad782bc72bac1938ae9763c7103 Reviewed-on: https://gerrit.libreoffice.org/71900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-21Fix typoAndrea Gelmini1-1/+1
Change-Id: I5bacb30918f72d8b6a992c88a209b30647303177 Reviewed-on: https://gerrit.libreoffice.org/71031 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini1-2/+2
Change-Id: I39f878774386c896b842e23b3ad6e6637dc79f64 Reviewed-on: https://gerrit.libreoffice.org/71000 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I10729c848b6b5db0e9880ac2ca27b2d0ef24b5f4 Reviewed-on: https://gerrit.libreoffice.org/70977 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini1-1/+1
Change-Id: If0104ebab265a98982808fa5003a499deae542b6 Reviewed-on: https://gerrit.libreoffice.org/70908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-13loplugin:sequentialassign in filter..fpickerNoel Grandin3-7/+3
Change-Id: I4ba0e1e982897bd570612f6cda8ba1e6a9fa5dbd Reviewed-on: https://gerrit.libreoffice.org/70700 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-09[API CHANGE] Asserts to never clear already cleared guardMike Kaganski2-3/+1
... which could help catch copy-paste errors when wrong guard is cleared second time. Also an assert added that when resetting, there's something to reset (i.e., no descendant class had cleared protected pResetT, making reset impossible, and thus actually unable to guard anything). framework/source/layoutmanager/layoutmanager.cxx: made sure to not call clear() second time framework/source/layoutmanager/toolbarlayoutmanager.cxx: restored lock lost in commit 777bc22ca6490a4300f30fc1b45287dce789a36f forms/source/misc/InterfaceContainer.cxx: removed a leftover from commit a19cd21e3c03559877428315bebc0ceaf367a461 which reduced guarded scope forms/source/component/DatabaseForm.cxx: fixed clear-reset sequence broken from the initial commit bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d Change-Id: Ibab6660c79561eee31faf3e6c1128ab141a7e8a3 Reviewed-on: https://gerrit.libreoffice.org/70381 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski3-12/+12
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06Use char version of OString/OStringBuffer methodsMatteo Casalin1-12/+12
Change-Id: I0222e6675f63797f870746fd34a29702ad190311 Reviewed-on: https://gerrit.libreoffice.org/69240 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-04-06Use getTokenCount and indexed getTokenMatteo Casalin1-10/+4
Change-Id: Id57a1771c897c69b05d02a359f22e5fb2b1f5a31 Reviewed-on: https://gerrit.libreoffice.org/69239 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-04-05Remove unused using declarations in directories [e-l]*Gabor Kelemen8-18/+0
Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen2-0/+3
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25new loplugin:unoqueryNoel Grandin3-7/+7
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-20Improve parseDateTime tokenization and reduce OUString copiesMatteo Casalin1-13/+6
Change-Id: If84f455c235176d56d72bdc11d813f1ee1e3122e Reviewed-on: https://gerrit.libreoffice.org/69241 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-12tdf#42949 Fix IWYU warnings in include/connectivity/*Gabor Kelemen4-0/+4
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07log nice exception messages whereever possibleNoel Grandin2-2/+4
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin4-41/+45
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin5-6/+2
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-23loplugin:unusedfields in forms..fpickerNoel Grandin4-10/+0
Change-Id: Ifd3afbf276100e3cef802bbcc0792b43a9cd84f8 Reviewed-on: https://gerrit.libreoffice.org/68228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 11:55:00 +0000