summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2014-01-21FORMS : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini39-187/+0
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db Reviewed-on: https://gerrit.libreoffice.org/7534 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-18Window::PreNotify should return boolStephan Bergmann2-4/+4
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Window::Notify should return boolStephan Bergmann2-4/+4
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-15remove last xub_StrLen in formsCaolán McNamara1-1/+1
Change-Id: If6c711cf9c317411c72260b4029521782f8a282c
2014-01-14bool improvementsStephan Bergmann2-3/+3
Change-Id: Iba5bf2d2207f80098cb43ff8ce290eef741d21c9
2014-01-08Lock SolarMutex in RichtTextEngine::CreateStephan Bergmann1-0/+2
...as always, the question is where exactly to place the mutex guard, but without it querying for XServiceInfo of a freshly instantiated "stardiv.one.form.component.Edit" (i.e., OFormattedFieldWrapper) would lead to failing > DbgTestSolarMutex () at include/tools/debug.hxx:295 > OutputDevice::ImplGetGraphics (this=0x2b81dc11e680) at vcl/source/gdi/outdev.cxx:560 > OutputDevice::DrawRect (this=0x2b81dc11e680, rRect=Rectangle = {...}) at vcl/source/gdi/outdev.cxx:1649 > OutputDevice::ImplDrawColorWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:778 > OutputDevice::ImplDrawWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:1083 > OutputDevice::Erase (this=0x2b81dc11e680) at vcl/source/gdi/outdev6.cxx:1144 > VirtualDevice::ImplInitVirDev (this=0x2b81dc11e680, pOutDev=0x28dc0a0, nDX=1, nDY=1, nBitCount=0, pData=0x0) at vcl/source/gdi/virdev.cxx:114 > VirtualDevice::VirtualDevice (this=0x2b81dc11e680, nBitCount=0) at vcl/source/gdi/virdev.cxx:136 > ImpEditEngine::SetRefDevice (this=0x2b81dc045f10, pRef=0x0) at editeng/source/editeng/impedit2.cxx:195 > ImpEditEngine::ImpEditEngine (this=0x2b81dc045f10, pEE=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/impedit2.cxx:156 > EditEngine::EditEngine (this=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/editeng.cxx:104 > frm::RichTextEngine::RichTextEngine (this=0x2b81dc0c8a00, _pPool=0x2b81dc0a0960) at forms/source/richtext/richtextengine.cxx:103 > frm::RichTextEngine::Create () at forms/source/richtext/richtextengine.cxx:52 > frm::ORichTextModel::ORichTextModel (this=0x2b81d866ff30, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/richtext/richtextmodel.cxx:66 > frm::ORichTextModel::Create (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/richtext/richtextmodel.cxx:243 > cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171 > cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203 > cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a638, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432 > non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433 > cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.RichTextControl", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979 > non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987 > frm::OControlModel::OControlModel (this=0x2b81d8679408, _rxContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSetDelegator=0 '\000') at forms/source/component/FormComponent.cxx:593 > frm::OBoundControlModel::OBoundControlModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", _rDefault="com.sun.star.form.control.TextField", _bCommitable=1 '\001', _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/FormComponent.cxx:1273 > frm::OEditBaseModel::OEditBaseModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, rUnoControlModelName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/EditBase.cxx:57 > frm::OEditModel::OEditModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/component/Edit.cxx:296 > frm::OEditModel_CreateInstance (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/component/Edit.cxx:280 > cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171 > cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203 > cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a558, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432 > non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433 > cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.TextField", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979 > non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987 > frm::OFormattedFieldWrapper::ensureAggregate (this=0x2b81d8879818) at forms/source/component/FormattedFieldWrapper.cxx:342 > frm::OFormattedFieldWrapper::queryAggregation (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.cxx:164 > cppu::OWeakAggObject::queryInterface (this=0x2b81d8879818, rType=invalid uno::Type) at cppuhelper/source/weak.cxx:281 > frm::OFormattedFieldWrapper::queryInterface (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.hxx:68 > com::sun::star::uno::BaseReference::iquery (pInterface=0x2b81d8879818, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:43 > com::sun::star::uno::Reference<com::sun::star::lang::XServiceInfo>::iquery (pInterface=0x2b81d8879818) at include/com/sun/star/uno/Reference.hxx:58 > com::sun::star::uno::Reference<com::sun::star::lang::XServiceInfo>::Reference (this=0x2b81d8663a98, rRef=...) at include/com/sun/star/uno/Reference.hxx:158 Change-Id: I16ebbb2caf4f0fe943c9e43bddde03b5a2627e35
2014-01-08This can be privateStephan Bergmann1-1/+1
Change-Id: Ida54a46580fb3d1ec49ea5daeb55c0235d2bf85a
2013-12-22Fix other typosJulien Nabet1-1/+1
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-20Spelling correction: s/retrive/retrieve/Tor Lillqvist1-1/+1
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20typo fixesAndras Timar4-5/+5
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann1-0/+4
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann1-2/+2
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-16Clean-up uno/lbnames.hStephan Bergmann1-1/+0
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann5-12/+12
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann1-3/+3
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann1-3/+3
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann1-3/+3
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-06Clean up includes of comphelper/stl_types.hxxStephan Bergmann1-1/+0
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06Get rid of unnecessary comphelper::UStringEqualStephan Bergmann1-2/+1
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06Get rid of DECLARE_STL_VECTORStephan Bergmann7-16/+25
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06Get rid of DECLARE_STL_USTRINGACCESS_MAPStephan Bergmann1-1/+2
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-11-27forms: avoid deadlock when setting FontControlModel propertiesMichael Stahl5-60/+96
Deadlock found in forms_unoapi on Windows, with OGridControlModel::setFastPropertyValue_NoBroadcast() calling event handler that tries to lock SolarMutex. FontControlModel::setFastPropertyValue_NoBroadcast() and its callers in 3 other classes must not send events via firePropertyChange() because they are called by OPropertySetHelper::setFastPropertyValues() with its Mutex locked. It is possible (though sadly quite convoluted) to delay the sending of the events by calling setDependentFastPropertyValue() instead. Change-Id: I0c767cfec01fe1bcaeb1236287b5faf81a2e7441
2013-11-27FontControlModel::convertFastPropertyValue: fix bad cast of KerningMichael Stahl1-1/+1
Casting sal_Bool to integer lets the comparison always fail. Change-Id: I33cf9e9b6a65f81166870bdfe32e9a97101501df
2013-11-23outter -> outer (also when "outter" is inside another word)Julien Nabet1-1/+1
Change-Id: I0290d57f1c27a82a34a7dba56d88d51ec6d0bd9e
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin8-22/+22
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-16cppcheck: Array index is used before limits checkJulien Nabet1-1/+1
Change-Id: I30154dd9504b70dc3212af3ac1d88dfc9a9d8396
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann2-2/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-142/+0
Change-Id: Ia04390e5a3d4c5833c24add581985a9491af0443
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin4-28/+28
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14i18npool, forms: remove warnings_guard_unicode*.hMichael Stahl2-43/+2
These horrible headers use "#pragma GCC system_header" and thereby prevent generated Makefile dependencies, which is what broke incremental builds after the ICU upgrade today. Change-Id: Ife983b3c4de86968da8a0187a1acb1bbb2b5c81f
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-1/+1
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin1-1/+1
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin2-10/+8
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructor in FORMS moduleNoel Grandin10-35/+34
Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3
2013-11-05fixincludeguards.sh: formsThomas Arnhold105-289/+289
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt1-3/+3
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructorNoel Grandin2-4/+4
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-1/+1
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza5-64/+11
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d Reviewed-on: https://gerrit.libreoffice.org/6423 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist2-2/+2
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-20drop unnecessary tools/string includesCaolán McNamara4-4/+0
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-17bogus WaE: 'bValue' may be used uninitialized in this functionLionel Elie Mamane1-11/+3
Change-Id: Ifde0f9370d093f447edac4899c5bbc7940da5a8c
2013-10-17WaE: unknown warning group '-Wmaybe-uninitialized'Tor Lillqvist1-3/+3
Seriously, would it be so awful to initialise the value even if strictly speaking it is unnecessary? Hopefully avoiding that is not an attempt at manual micro-optmisation? (Or did the initialisation actually cause some warning?) Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux, too. It is great. Our Clang plug-in (which can be easily used only on Linux) is very useful. Change-Id: I379afed707d96745ee29979bd79467309adf0147
2013-10-17MacOS X fixup to bogus WaE: 'bValue' may be used uninitializedLionel Elie Mamane1-7/+9
Change-Id: I1485e7f6b9147d4cec94833c0a2b35e730c397cf
2013-10-17bogus WaE: 'bValue' may be used uninitialized in this functionLionel Elie Mamane1-1/+11
Change-Id: I14983509a41bd6be0d7fed29d7f89fa4a21fe08a
2013-10-16WaE: 'bValue' may be used uninitialized in this functionTor Lillqvist1-1/+1
Change-Id: I6fd6f679dd81707483c6834a4d4b2ca935f7c515
2013-10-16respect reference values in checkboxesLionel Elie Mamane2-4/+34
Change-Id: Ifd0953f779f530af6b190425794f009a891f0afb
2013-10-02Spell "indices" correctlyTor Lillqvist1-2/+2
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
2013-10-02Use std::auto_ptr::reset where applicableStephan Bergmann1-6/+3
(avoids warnings about std::auto_ptr ctor being deprecated) Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 03:51:38 +0000