summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2017-02-01loplugin:stringconstant handle calls to constructors with one argNoel Grandin1-1/+1
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin2-4/+4
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin1-1/+1
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann123-1978/+1583
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26use rtl::Reference in OImageControlModelNoel Grandin2-9/+6
instead of storing both a raw pointer and an uno::Reference Change-Id: If0e1380815e93015249cc19bc66b40befbfab50e Reviewed-on: https://gerrit.libreoffice.org/33570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26use rtl::Reference in ModelNoel Grandin3-68/+45
instead of storing both raw pointers and an uno::Reference Change-Id: I93871eaf9807d0fa846a4e1090d7ee7b1db01c5e Reviewed-on: https://gerrit.libreoffice.org/33571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25loplugin: unnecessary destructor forms..idlcNoel Grandin5-7/+0
Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski3-4/+4
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23use rtl::Reference in ODatabaseFormNoel Grandin2-13/+10
rather than manual acquire/release Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
2017-01-20don't need an intermediate ImageCaolán McNamara1-1/+1
Change-Id: I090d94cfe433763ded70f28b5139772bca229c34
2017-01-19New loplugin:dynexcspec: Add @throws documentation, formsStephan Bergmann9-1/+17
Change-Id: Ib5e1f2ef4143ad1c75ec705624a547e47affbc79
2017-01-19use rtl::Reference in OClickableImageBaseModelNoel Grandin2-13/+7
instead of storing both a raw pointer and an uno::Reference Change-Id: I92dc79edef9046acc137a878d35dde935bb17674
2017-01-19use rtl::Reference in OComponentEventThreadNoel Grandin2-17/+9
instead of storing both a raw pointer and an uno::Reference Change-Id: I8cd4d04ffb9f40a48d48ade2b171a9a9942cf87f
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski1-1/+1
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17new loplugin: useuniqueptr: forms..frameworkNoel Grandin4-7/+7
Change-Id: I4300a13f455148b7156ac3f444c7102d63ae6db3 Reviewed-on: https://gerrit.libreoffice.org/33164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-16forms,qadevOOo: dispatch of .uno:SwitchControlDesignMode is asyncMichael Stahl1-0/+6
Follow-up to e19cdeaf7ddbcf39da47d9685d8e79e775dde7f4. Change-Id: Ic4f8f0373199a4237fa30a830fc89a263eb40d62
2017-01-11Some loplugin:conststringvar/stringconstant improvements: formsStephan Bergmann1-1/+1
Change-Id: Iec2be8c9ddbdf8d5d8bc1054c20a0bd40707262a
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht1-2/+4
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-06This apparently doesn't happenStephan Bergmann1-5/+1
The code has been like this ever since ed8c4fd992a4e2e43e65d05e6f06336bfe2fdba2 "INTEGRATION: CWS eforms2", but it doesn't make sense: It apparently wants to clear XCurrent to leave the for-loop early, but would acutally cause a null deref instead. So this branch apparently doesn't get executed routinely. Is it impossible to be reached? To play it safe, assume no. But I can't find anything substantiating the "we'll remove the slash below" claim, so just return an empty string instead. Change-Id: I18e05385bbef05e7682a2eb4d525cfee25d9a6f5
2017-01-06Use OUString::booleanStephan Bergmann1-1/+1
Change-Id: I8989fcc18cd0f0b28ef6da5c3c3d7f87429b569b
2017-01-06No need for an OUStringBuffer hereStephan Bergmann1-16/+5
Change-Id: I01697ac2b84f836ff0b3d15aa8d03042f229eacb
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann1-1/+1
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2016-12-23tdf#101442 - "hyperlink" to "link"Federico Bassini1-1/+1
changing other words "hyperlink" to "link!" Change-Id: I29d97bab7844183759bc34624a14c0216258ad8b
2016-12-21remove newly unused SfxImageManagerCaolán McNamara1-1/+0
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-17add dbtools for !HAVE_FEATURE_DBCONNECTIVITY anywayCaolán McNamara3-14/+5
Change-Id: I7a769ab3c7881eae80849efc5e75eca5846d254f
2016-12-17more !HAVE_FEATURE_DBCONNECTIVITY build fixingCaolán McNamara1-2/+3
Change-Id: I1f949c29020c498200decdac487e0519f48a4142
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin1-15/+2
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin1-2/+2
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin8-12/+12
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin1-2/+2
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05loplugin:unnecessaryoverride (dtors) in formsStephan Bergmann2-10/+0
Change-Id: Ia6787aa9dc7963b1e44604f22bfc95e0333a7f79
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2-2/+2
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl2-3/+3
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-21remove use of tryPropertyValue Any specialisationJochen Nitschke2-10/+18
change return value of getCurrentMultiValue from Any<Sequence<Any> > to Sequence<Any>. return value of getCurrentSingleValue (Any of connectivity::ORowSetValue) can't be changed to use tryPropertyValue. inline functionality Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3 Reviewed-on: https://gerrit.libreoffice.org/30091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin2-5/+2
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin1-1/+1
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin4-5/+5
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in forms..formulaNoel Grandin26-206/+31
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b Reviewed-on: https://gerrit.libreoffice.org/30688 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-2/+2
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin4-12/+2
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27coverity#1374310 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27coverity#1374311 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27coverity#1374312 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27coverity#1374313 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27coverity#1374314 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I07a39774a1372ea26e8d66376c27d3b98229892e
2016-10-27coverity#1374315 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27coverity#1374316 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-26coverity#1374286 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26coverity#1374281 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26coverity#1374280 Uncaught exceptionCaolán McNamara2-4/+2
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 14:24:16 +0000