summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2014-11-14coverity#706540 Uncaught exceptionCaolán McNamara1-1/+13
Change-Id: I9dabd74824ec7cffe5371ed8be202ad27fecc80d
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava9-16/+16
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini5-6/+6
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin4-14/+10
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11Revert "Some SvxFontHeightItem clean-up"Stephan Bergmann1-6/+4
This reverts commit d5f93eb47ec4c27e93ad908b0199790c702491a0, SvxFontHeightItem::SetProp was used to override "dummy" 100% nProp/ePropUnit values that did not match the computed nHeight value with nProp/ePropUnit values that are supposed to match the computed nHeight value. Yuck. Change-Id: Ic12e824054b3c5da7aca766b9b3eb076d1837d9a
2014-11-11Some SvxFontHeightItem clean-upStephan Bergmann1-4/+6
...and operator= shall probably copy rSize.ePropUnit... Change-Id: I112c02b3a3b2ce23f3d03f03881136e05be29017
2014-11-07Try to fix ambiguity errorZolnai Tamás1-1/+1
Change-Id: I93cf7497e52d065d00f762f61f79a4e8f8609bfc
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05markup with event type not checker typeCaolán McNamara1-1/+1
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05new loplugin: use more efficient find() methodsNoel Grandin1-3/+2
(Original idea from Kendy) Look for code that is calling std::find on a sorted container (set/map/vector) and warn about it - the code should be using the find method on the container itself, since that is considerably faster. Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin1-1/+1
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin2-3/+3
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04coverity#706543 uncaught exceptionDavid Tardon1-1/+1
Change-Id: I65932932712dad87f8e21dcd09f477744cc33763
2014-10-31Removed duplicated includesAndrea Gelmini1-1/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30forms: The if statement is redundantRobert Antoni Buj i Gelonch7-38/+13
Change-Id: I1d339ea6052e648acf4405d2d40795c82ee043ca Reviewed-on: https://gerrit.libreoffice.org/11713 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-27coverity#706537 Uncaught exceptionCaolán McNamara1-2/+5
Change-Id: I687948ef04e4ffdce51a7ac20854d6ebe96f1f25
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky1-1/+1
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky1-1/+1
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23loplugin: cstylecastNoel Grandin8-15/+15
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin1-1/+1
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20tweak CaughtExceptionCaolán McNamara1-1/+2
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
2014-10-20Missing includeStephan Bergmann1-1/+3
...and only use getCaughtException as first statement in catch block. Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
2014-10-20coverity#706540 Uncaught exceptionCaolán McNamara1-0/+12
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
2014-10-20coverity#706538 Uncaught exceptionCaolán McNamara1-5/+13
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-2/+2
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin2-2/+2
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin1-6/+6
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon1-1/+1
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin1-1/+1
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch1-3/+11
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d Reviewed-on: https://gerrit.libreoffice.org/11991 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin1-2/+2
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11convert vcl StateChangedType to enum classNoel Grandin3-8/+9
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca1-1/+1
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke2-2/+2
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-07java: optimise calls to toArrayNoel Grandin1-3/+1
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-02fdo#39468 Make forms/ German comments cleanPhilipp Weissenbacher2-18/+18
Change-Id: Iec24928324bec1caee65ca37cbf0fb5b66e6975e Reviewed-on: https://gerrit.libreoffice.org/11760 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01forms: enhanced for loopRobert Antoni Buj i Gelonch1-6/+2
Change-Id: I0c83d6fce9440f5d8b23e5f1bfca71d8f61d056b Reviewed-on: https://gerrit.libreoffice.org/11719 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin4-12/+12
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30forms: use Arrays.toString in integration.forms.RadioButtonsRobert Antoni Buj i Gelonch1-10/+2
Change-Id: I797692857c874d879192ca9a4ff73b98ed5ebd86 Reviewed-on: https://gerrit.libreoffice.org/11721 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30forms: replace StringBuffer with StringBuilderRobert Antoni Buj i Gelonch2-4/+4
Change-Id: Iee1b7ea214e5ed2fdd8bd5fe93dc16fbaaf312a8 Reviewed-on: https://gerrit.libreoffice.org/11720 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30forms: the assigned value is never usedRobert Antoni Buj i Gelonch2-5/+2
Change-Id: I8eadc27ba8880630ec93c68145969f3e8ba6c189 Reviewed-on: https://gerrit.libreoffice.org/11712 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30forms: remove import from the same packageRobert Antoni Buj i Gelonch5-16/+0
Change-Id: Ia15b4586e183bcd24a47c1a072c4d6e8ca280e98 Reviewed-on: https://gerrit.libreoffice.org/11714 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30forms: std::auto_ptr -> std::unique_ptrStephan Bergmann15-27/+16
Change-Id: Ia8f045715a508de77c8ce86cf224a3038162faac
2014-09-29Fix java.util.Calendar.set in integration.forms.DateValidatorRobert Antoni Buj i Gelonch1-1/+1
Change-Id: I1bd87c623b923469c325ebfcba4ba82e2a648ae2 Reviewed-on: https://gerrit.libreoffice.org/11694 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29forms: getMonth() and getYear() are deprecated in java.util.DateRobert Antoni Buj i Gelonch1-7/+6
Change-Id: I31664bbd8c1c3b02e8a7381226d4d558b37466a2 Reviewed-on: https://gerrit.libreoffice.org/11690 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29forms: Pass array of length equal to the size of the collectionRobert Antoni Buj i Gelonch1-1/+3
Change-Id: Id880953105f6100b15cd78f48ce0c8dbcb7ffb8d Reviewed-on: https://gerrit.libreoffice.org/11687 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-25fdo#39468 Translate German comments, clean some wsPhilipp Weissenbacher13-101/+92
Conflicts: forms/source/component/FormComponent.cxx forms/source/component/FormattedField.cxx Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb Reviewed-on: https://gerrit.libreoffice.org/11622 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-24fdo#39468 Translated German to EnglishTobias Madl2-19/+18
Change-Id: I7405b8251b977f8e5c1b95c37fbab6ae6cb120e7 Reviewed-on: https://gerrit.libreoffice.org/11461 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin11-41/+41
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 03:46:49 +0000