summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2016-11-21remove use of tryPropertyValue Any specialisationJochen Nitschke2-10/+18
change return value of getCurrentMultiValue from Any<Sequence<Any> > to Sequence<Any>. return value of getCurrentSingleValue (Any of connectivity::ORowSetValue) can't be changed to use tryPropertyValue. inline functionality Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3 Reviewed-on: https://gerrit.libreoffice.org/30091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin2-5/+2
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin1-1/+1
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin4-5/+5
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in forms..formulaNoel Grandin26-206/+31
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b Reviewed-on: https://gerrit.libreoffice.org/30688 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-2/+2
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin4-12/+2
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27coverity#1374310 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27coverity#1374311 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27coverity#1374312 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27coverity#1374313 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27coverity#1374314 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I07a39774a1372ea26e8d66376c27d3b98229892e
2016-10-27coverity#1374315 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27coverity#1374316 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-26coverity#1374286 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26coverity#1374281 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26coverity#1374280 Uncaught exceptionCaolán McNamara2-4/+2
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26coverity#1374279 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26coverity#1374278 Uncaught exceptionCaolán McNamara2-4/+3
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26coverity#1374277 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26coverity#1374276 Uncaught exceptionCaolán McNamara2-4/+3
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26coverity#1374275 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26coverity#1374274 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26coverity#1374273 Uncaught exceptionCaolán McNamara2-2/+4
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26coverity#1374272 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26coverity#1374271 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26coverity#1374270 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26coverity#1374269 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke1-1/+1
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19loplugin:expandablemethodds in filter..formsNoel Grandin9-44/+12
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0 Reviewed-on: https://gerrit.libreoffice.org/30014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke2-2/+2
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann1-2/+2
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-05loplugin:unnecessaryoverride in forms/frameworkNoel Grandin12-81/+0
Change-Id: Ia2aabec5af5559903be09e1ef81d156a7538ab3f
2016-10-05convert MapUnit to scoped enumNoel Grandin4-8/+8
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann22-28/+28
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580 Reviewed-on: https://gerrit.libreoffice.org/29433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16Drop redundant castTakeshi Abe1-1/+1
Change-Id: Ief00bc6e82cd4e54602e069c0bafd1dfc7bdd2ff
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl1-5/+5
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann42-52/+52
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin4-43/+18
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01coverity#1372386 Uncaught exceptionCaolán McNamara4-6/+6
Change-Id: Ic1fd5486e6b26718086d2f062459f11c00f244d2
2016-08-30default dtors are fine hereCaolán McNamara3-13/+0
Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (forms)Stephan Bergmann1-1/+1
Change-Id: I25323e586bb80b833d1b2dace5498de853aa039e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke2-2/+2
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu1-2/+2
Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-21tdf#89329: use unique_ptr for pImpl in richtextvclcontrolArnold Dumas2-3/+4
Change-Id: Icaa9b8bed2ae6efc8d87b44b5f104c4a4b272f70 Reviewed-on: https://gerrit.libreoffice.org/28263 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara2-5/+5
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-17convert SvxEscapement to scoped enumNoel Grandin1-4/+4
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxLineSpace to scoped enumNoel Grandin1-1/+1
and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17convert SvxInterLineSpaceRule to scoped enumNoel Grandin1-1/+1
and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf