summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2017-02-27better fix for tdf#103830Noel Grandin1-7/+9
the first fix in commit 3a404ea870f1eed86f9765447ce0a364d39ae8f8 did not take into account that this a multimap, not a map. Thanks to Aron Budea for spotting that. Change-Id: I86d2d2a9d6cb08fd3cee3965a5b787d5691f0352 Reviewed-on: https://gerrit.libreoffice.org/34604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e146741ec96292ef092c6eebfd7fe18fa5ca3cc0) Reviewed-on: https://gerrit.libreoffice.org/34606 (cherry picked from commit 46885644fe87a6e9f86a79b7fd1eafbe3ea0e5a6) Reviewed-on: https://gerrit.libreoffice.org/34611 (cherry picked from commit 1f3ce5a00b2a85374204f3f05433d3cfd3292fe7)
2017-02-27tdf#103830 Form field names not update in python macroNoel Grandin1-2/+2
regression from commit 5f15cc01b31ccaed0c6482a36556dece084ce302 "new loplugin: use more efficient find() methods" Regression found by Aron Budea. Change-Id: I0e84376dfd754738de97882979058f86c2476bd6 Reviewed-on: https://gerrit.libreoffice.org/34600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 3a404ea870f1eed86f9765447ce0a364d39ae8f8) Reviewed-on: https://gerrit.libreoffice.org/34602 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 858aa013061fb179e68c90a9dce6341a352b17c1)
2016-07-20Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann4-5/+5
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. (cherry picked from commit 14cd5182c5f64c43581c82db8c958369152226ac) Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-07-20use Any constructor instead of temporariesNoel Grandin1-1/+1
(cherry picked from commit 58a32075ca4f457f570af75aef368dd6c389aca7) Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-07-20tdf#97087 Give comprehensible names to timersMuhammet Kara1-1/+1
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c03a11b8f0c93b1c55d9abc9aa224aeb298d1976)
2016-07-20vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock1-1/+1
(cherry picked from commit 88730cdae3520b18fc073dc59bd0ed660e15d6b4) Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-07-20Fix typosAndrea Gelmini2-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 534b2a4b58ba765dbc256d6297e33453524915e2)
2016-07-20vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> (cherry picked from commit 28c96fc2553a5c3dee108f1e2060d7bc081a7e7e) Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
2016-07-20Fix typosAndrea Gelmini19-26/+26
Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 64d624b65124ac02d8ee59b135593fd9d8eb9067) Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
2016-07-12loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864 (cherry picked from commit ec3f72415850bd865eb030cf2b7edb55b99d4756)
2016-07-12Remove excess newlinesChris Sherlock52-127/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> (cherry picked from commit a238b1f8d304bf1e2ffb357937f3ec888ee8ac89) Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
2016-07-12update unusedmethods plugin to deal with constructorsNoel Grandin5-12/+8
and fix the operator< implementations in some of the other plugins too. Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae) Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
2016-05-31tdf#93403 check for changed DataSource on all Controls on form reloadLionel Elie Mamane1-1/+1
1) OBoundControlModel: when reload() asks us to connect to database column, redo it even if it was previously done. 2) FmXGridPeer: when getting Reloaded event that we subscribed to (and specifically from frm::ODatabaseFrom), pass along the event to all columns before we treat it. The columns (controls) are themselves subscribed to it, but they may get the event after us, which means our treatment still uses stale data, which we continue to display. The column controls should continue to subscribe by themselves for the case that they are not in a grid, but direct children of the form. Change-Id: I0cbcf2dc792e8650157a69ddc414d755de0e549a Reviewed-on: https://gerrit.libreoffice.org/25549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-13Missing break in switchStephan Bergmann1-0/+1
Apparently forgotten when introducing the case PROPERTY_ID_GENERATEVBAEVENTS in 4fae740db79d4e7cc97440e2bab8d1ef612d9b51 "Disable fake VBA events for the old-style form controls." Change-Id: Id2783fd4f087669bd200a9c33eaad2bb6b7b50cd (cherry picked from commit 1f7a31a461bb3a6fcd277ab57875405875568f8b) Reviewed-on: https://gerrit.libreoffice.org/24916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock1-1/+1
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-11-20loplugin:unusedfields forms,formula,fpicker,frameworkNoel Grandin2-3/+0
Change-Id: Ic7af56ac801c1e5b3fcf3c4e8413656e96220279
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin4-32/+6
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19use comphelper::containerToSequenceNoel Grandin6-24/+7
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-203/+115
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin1-2/+1
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann52-251/+251
Change-Id: Ic67c3138ca66c6b6d6fcf76b09d4581e23f51f8d
2015-11-09new loplugin: oncevarNoel Grandin1-3/+1
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06coverity#1338244 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: If46689d2b9cf8f6cb76d61296332444d4c3fb5fd
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann3-5/+5
Change-Id: I5b543edcae47c9ae4c90dba8082127fcb2b9b938
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin1-1/+1
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin1-1/+1
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-04yyyyyNoel Grandin1-2/+1
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-02use uno::Reference::set method instead of assignmentNoel Grandin11-26/+23
Change-Id: I3d94c94a9829161663a7ed18421ace38ce95a659 Reviewed-on: https://gerrit.libreoffice.org/19733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin1-2/+2
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27don't allocate uno::Reference on the heapNoel Grandin2-5/+3
There is no point, since it's the size of a pointer anyway (found by temporarily making the new operator in uno::Reference deleted). Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34 Reviewed-on: https://gerrit.libreoffice.org/19603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin1-3/+3
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26remove extra spaces around ::Noel Grandin3-3/+3
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-21more removal of com::sun::star typedefsNoel Grandin10-46/+31
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21refactor out some com::sun::star typedefsNoel Grandin2-42/+31
which mostly serve to make the code harder to read Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-20loplugin:defaultparamsStephan Bergmann2-3/+3
Change-Id: I0a64398f49c8823327263aad0c79b182161177ea
2015-10-19loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I0c2635092096cbacb120426d1d6805afdaac3503
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin2-5/+3
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-13remove some useless commentsNoel Grandin1-1/+1
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann82-1300/+1300
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann11-24/+24
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12loplugin:mergeclassesNoel Grandin4-24/+12
Change-Id: Id6e39c2c20ab3da5a8b8628f99a940b896feff78
2015-10-07cppcheck: noExplicitConstructorCaolán McNamara37-54/+54
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
2015-10-05cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
2015-10-02Fix typosAndrea Gelmini9-10/+10
Change-Id: Ib30f4e5f16518cbbe71cf03998513ebd8c2a4d1a Reviewed-on: https://gerrit.libreoffice.org/18949 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-02com::sun::star->css in forms/Noel Grandin129-2235/+2191
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
2015-10-01loplugin:unusedmethodsNoel Grandin3-11/+0
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30 tdf#94559: second step to remove rtti.hxxOliver Specht1-9/+9
replaced use of PTR_CAST, IS_TYPE, ISA in chart2, connectivity, editeng, extensions, filter, forms, framework, idl Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99 Reviewed-on: https://gerrit.libreoffice.org/18920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann2-5/+5
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-6/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350