summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2017-06-27tdf#108732 ListBox: in absence of a field, treat data as stringLionel Elie Mamane1-1/+3
so that one meaningfully compare it; default is DataType::OTHER, which is not comparable Change-Id: Ifc1e1c9b801f45d0a95a83d30cc205b91e647880 Reviewed-on: https://gerrit.libreoffice.org/39211 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 39ea36bf8602744c27c16369c88db2858653b59f)
2017-05-30tdf#107720 Bound Control initFromField: consider the case of the insert rowLionel Elie Mamane1-1/+11
loplugin: simplifybool (cherry picked from commit 95b25532d24bfb08c4846b991451a36475dd439f) Change-Id: If18e161c994c926fd86453ab5736df1e89bb61de Reviewed-on: https://gerrit.libreoffice.org/37427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit bb50f9d66540a87065f30da8fd8cadde8e730704)
2017-03-10tdf#106462 old value and new value were swappedLionel Elie Mamane1-2/+2
in commit 66ccfcd2908445b8194c364c89778056374b02af Author: Jochen Nitschke <j.nitschke+logerrit@ok.de> Date: Fri Oct 21 09:36:10 2016 +0200 remove use of tryPropertyValue Any specialisation Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Change-Id: I90dd3f6dba799eec9210dbb7560be105cb50e6d1 Reviewed-on: https://gerrit.libreoffice.org/35021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 23b8a097090ad544c596e644cf477feb360c9469)
2017-03-01better fix for tdf#103830Noel Grandin1-7/+9
the first fix in commit 3a404ea870f1eed86f9765447ce0a364d39ae8f8 did not take into account that this a multimap, not a map. Thanks to Aron Budea for spotting that. Change-Id: I86d2d2a9d6cb08fd3cee3965a5b787d5691f0352 Reviewed-on: https://gerrit.libreoffice.org/34604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e146741ec96292ef092c6eebfd7fe18fa5ca3cc0) Reviewed-on: https://gerrit.libreoffice.org/34606 (cherry picked from commit 46885644fe87a6e9f86a79b7fd1eafbe3ea0e5a6)
2017-02-24tdf#103830 Form field names not update in python macroNoel Grandin1-2/+2
regression from commit 5f15cc01b31ccaed0c6482a36556dece084ce302 "new loplugin: use more efficient find() methods" Regression found by Aron Budea. Change-Id: I0e84376dfd754738de97882979058f86c2476bd6 Reviewed-on: https://gerrit.libreoffice.org/34600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 3a404ea870f1eed86f9765447ce0a364d39ae8f8) Reviewed-on: https://gerrit.libreoffice.org/34601 (cherry picked from commit 81e5ba515c66bc23520f3d9c06c54c63d927e467)
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2-2/+2
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-01-26tdf#101828 handle rtf/richtext correctlyOliver Specht1-2/+4
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 048e30c1f8231e6cd144a9251061f6fa127b353e) Reviewed-on: https://gerrit.libreoffice.org/33567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-21remove use of tryPropertyValue Any specialisationJochen Nitschke2-10/+18
change return value of getCurrentMultiValue from Any<Sequence<Any> > to Sequence<Any>. return value of getCurrentSingleValue (Any of connectivity::ORowSetValue) can't be changed to use tryPropertyValue. inline functionality Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3 Reviewed-on: https://gerrit.libreoffice.org/30091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin2-5/+2
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin1-1/+1
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin4-5/+5
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in forms..formulaNoel Grandin26-206/+31
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b Reviewed-on: https://gerrit.libreoffice.org/30688 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-2/+2
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin4-12/+2
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27coverity#1374310 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27coverity#1374311 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27coverity#1374312 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27coverity#1374313 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27coverity#1374314 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I07a39774a1372ea26e8d66376c27d3b98229892e
2016-10-27coverity#1374315 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27coverity#1374316 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-26coverity#1374286 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26coverity#1374281 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26coverity#1374280 Uncaught exceptionCaolán McNamara2-4/+2
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26coverity#1374279 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26coverity#1374278 Uncaught exceptionCaolán McNamara2-4/+3
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26coverity#1374277 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26coverity#1374276 Uncaught exceptionCaolán McNamara2-4/+3
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26coverity#1374275 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26coverity#1374274 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26coverity#1374273 Uncaught exceptionCaolán McNamara2-2/+4
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26coverity#1374272 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26coverity#1374271 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26coverity#1374270 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26coverity#1374269 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke1-1/+1
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19loplugin:expandablemethodds in filter..formsNoel Grandin9-44/+12
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0 Reviewed-on: https://gerrit.libreoffice.org/30014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke2-2/+2
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-12Don't allow O[U]StringBuffer in string concatenationStephan Bergmann1-2/+2
...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-05loplugin:unnecessaryoverride in forms/frameworkNoel Grandin12-81/+0
Change-Id: Ia2aabec5af5559903be09e1ef81d156a7538ab3f
2016-10-05convert MapUnit to scoped enumNoel Grandin4-8/+8
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann22-28/+28
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580 Reviewed-on: https://gerrit.libreoffice.org/29433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16Drop redundant castTakeshi Abe1-1/+1
Change-Id: Ief00bc6e82cd4e54602e069c0bafd1dfc7bdd2ff
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl1-5/+5
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann42-52/+52
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin4-43/+18
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01coverity#1372386 Uncaught exceptionCaolán McNamara4-6/+6
Change-Id: Ic1fd5486e6b26718086d2f062459f11c00f244d2
2016-08-30default dtors are fine hereCaolán McNamara3-13/+0
Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (forms)Stephan Bergmann1-1/+1
Change-Id: I25323e586bb80b833d1b2dace5498de853aa039e