summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2016-06-07filter: "tga" import: fix some endian issues in ImplReadPaletteMichael Stahl1-2/+9
Change-Id: Ia8ec7b7e19cf9b6b19497cbd77ae5a4e2fdccee7 (cherry picked from commit da4f7d5d76e054627b61521657d40141b9728e15) Reviewed-on: https://gerrit.libreoffice.org/25993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07filter: PPT import: PptPlaceholder is 1 byte largeMichael Stahl1-0/+1
The array of 8 bytes corresponds to 8 enum values and is read directly in ReadPptSlideLayoutAto(); this was wrongly converted to enum. (regression from e5a03da8eb02c333502d6b427625e7bf554ff203) Change-Id: I5757e06459467b3c84c4a404493fa3be23e4e9a0 (cherry picked from commit 6325cdb735effc5c9ff85819b20aec4271158519) Reviewed-on: https://gerrit.libreoffice.org/25990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-30Resolves: tdf#100057 force libxslt to give up when we cancel a transformationCaolán McNamara2-42/+53
we're already using libxslt internals, so using XSLT_STATE_STOPPED isn't an additional exposure This probably isn't all that useful to the original reporter in terms of importing useful data, but it does turn a hopeless situation into something that can be cancelled. Change-Id: I08e9a1dcd9ee78e1804faec500bbcca36a546988 (cherry picked from commit 2805adb0d3cf68d7def01a93bf07fb2e8121ec10)
2016-05-25filter: generate that with the python script, not BOOST_PPMichael Stahl2-6/+8
Change-Id: I9ab4cf721dd135aaae021fa05b8b6df54389a9b7
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin1-2/+1
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert Disposal to scoped enumNoel Grandin2-4/+4
and drop unused FULL value Change-Id: I3b9c26cb164785ef86f1a8d57cce962b015c85d6 Reviewed-on: https://gerrit.libreoffice.org/25432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Convert SbxClassType to scoped enumNoel Grandin1-2/+2
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23convert tnode to scoped enumNoel Grandin2-57/+57
Change-Id: I66b343db2c6e61e2316773f8995f78bbb1890eef Reviewed-on: https://gerrit.libreoffice.org/25210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21coverity#1362017 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: I7b13104ff579f9dd40dbc05245146440e55e7e18
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin5-19/+19
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Revert "tdf#35208 Allow choosing encoding for old Excel files"Maxim Monastirsky2-31/+0
This reverts commit 4f1ce46b8d65360436e09750242101b566e6186c. Change-Id: I4b93ef8233f172935e72401ec51abd3d4c8a9fac Reviewed-on: https://gerrit.libreoffice.org/25152 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin2-3/+5
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#35208 Allow choosing encoding for old Excel filesMaxim Monastirsky2-0/+31
Lots of BIFF2-BIFF5 files out there don't have CODEPAGE record at all, or have one with a wrong value, and/or FONT records with wrong charset value. To solve that, this patch adds a new "Choose Encoding" entry to the file picker, so that users could specify the encoding to use for a given file, instead of relying on the information that might be present (or not) inside the file. It can be also used in headless mode, e.g. --infilter="MS Excel (encoded)":61 This doesn't affect BIFF8 import, nor the default behavior when not explicitly using the "Choose Encoding" entry. Change-Id: I89d850d7679b81bd399044478fac7a02e8b7680e
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin9-158/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin1-2/+2
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16 tdf#64748: added placeholder option to pdf export dialog in WriterOliver Specht6-8/+43
This patch introduces a setting 'Export placeholders' to File/Export as PDF. It works like the related printer setting. Change-Id: I3a11a4601b1244b57e55c9b73b58116d355e105c Reviewed-on: https://gerrit.libreoffice.org/24976 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-15coverity#1361575 Logically dead codeCaolán McNamara1-1/+1
commit 6312dfdc16f7da09f48628f51bb20b09dc5b7001 Date: Wed May 11 20:11:18 2016 +0200 convert TSS_TYPE to scoped enum changed - if ( ( nInstance < PPT_STYLESHEETENTRYS ) && to + if ( ( nInstance < TSS_Type::LAST ) && but PPT_STYLESHEETENTRYS is 9 and TSS_Type::LAST is 8 Change-Id: I08fb0ad04332cd17e1bdc724799f2927a77359a7
2016-05-13filter: convert boost::bindMichael Stahl1-9/+8
Change-Id: Ib17cfa114b7a218c31690c780cf14e128a7992c2 Reviewed-on: https://gerrit.libreoffice.org/24981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert TSS_TYPE to scoped enumNoel Grandin1-151/+158
Change-Id: Ic76d7bfcfe4015c6a02dc5989f8300e5ddde706e Reviewed-on: https://gerrit.libreoffice.org/24896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin3-7/+5
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Include cppumaker-generated .hpp, not .hdlStephan Bergmann1-1/+1
Change-Id: Ib0451f26edbfbcdfdca78caa97bd09bc65ec2782
2016-05-10Fix typosAndrea Gelmini1-9/+9
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Presumably missing break in switchStephan Bergmann1-0/+2
Was like that at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but as clarified on IRC: <vmiklos> sberg: doesn't look intended, i think ESCHER_Prop_lineDashing and ESCHER_Prop_fNoLineDrawDash are supposed to be mutually exclusive. Change-Id: I5ea92e6bdc9800c4511ca041c0572d1f9ffca49c
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann3-0/+37
Change-Id: I6df171debbf4940bf27898c3ff5d8597f437897f
2016-05-10Silence Clang -Wimplicit-fallthrough in gperf-generated codeStephan Bergmann1-3/+2
...in preparation of eventually enabling -Wimplicit-fallthrough for Clang. Change-Id: Idca352d011505e83dbe275cb19626c8b9d8560c8
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann8-17/+17
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann7-0/+11
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin2-3/+3
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-07tdf#84394: xls load: delay cell-anchoring of object groupsGiuseppe Bilotta1-0/+25
When cell-anchored object groups are loaded, their anchoring must be delayed until all nested objects have been loaded, lest the invalid rectangle dimensions lead to incorrect positioning of the object. To achieve this, we keep track of the DffObjectData of the pending group, and move the anchoring to a FinalizeObj() method. Since DffObjectData has a const reference to a DffRecordHeader (which we need when setting the object anchoring) whose scope has closed by the time we call FinalizeObj() on the parent object, the stack of pending DffObjectData has references to clones of the original DffRecordHeader held in shared pointers. (This is to minimize the invasiveness of this patch wrt the Import* API.) Change-Id: Id23f5549dbc82306271cc02afc750f37eeea3ca2 Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-05tdf#93124: Fix incorrect text fit in imported PPT - take twoMike Kaganski1-28/+26
This patch just fixes incorrect decision when the block alignment must be applied. Also, unit test is included. Change-Id: I458184778c5e9e115d1a4eac749ecb6991b227a8 Reviewed-on: https://gerrit.libreoffice.org/24648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-04filter: svg: avoid undefined variablesHenry Castro1-3/+5
Change-Id: Ibc3b678decfb36f5ac5779edb43aef1657507df2 Reviewed-on: https://gerrit.libreoffice.org/24627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin2-70/+32
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann1-6/+3
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-04Rewrite fix for tdf#99353 in way that doesn't trigger loplugin:passstuffbyrefStephan Bergmann1-34/+39
c4acf692e858530b8353dd65876501eb38ce9bab "loplugin:passstuffbyref" had accidentally reverted 390ddd3bde617388e481b6747aa7bbea17d5ddf1 "tdf#99353 take the footgun away from FilterCache". Many thanks to Matteo Casalin for spotting it. Change-Id: I572b940cf215d6e83cac56fd8d2ac2f24b659579
2016-05-03-Werror,-Wpessimizing-moveStephan Bergmann1-1/+1
Change-Id: Ic20ae0c0534220a2613b73a2bd2e1aa277aecce9
2016-05-03loplugin:passstuffbyrefStephan Bergmann2-2/+2
Change-Id: Iaaaa0569a3e16bd79eeb7830ab9fb4be6ae57f98
2016-05-03use unique_ptrDavid Tardon4-12/+14
Change-Id: I28615a645e6e4763bb03362a90da93a818985a78
2016-05-03drop obsolete commentDavid Tardon1-2/+0
Change-Id: Iad565ccd92b4518ee57f10b65ca4d8ca0730474d
2016-05-03tdf#99353 take the footgun away from FilterCacheDavid Tardon2-2/+2
FilterCache::impl_saveItem changes the properties of a config. item one-by-one. But it also listens to the configuration changes and reloads the whole item from the configuration on change... Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
2016-04-29use initialization listJochen Nitschke1-5/+6
last commit to please cppcheck m_bCreated in SdPublishingDesign is commented as unused but is read and written by a raw stream to a 'designs.sod' so something might break we remove it Change-Id: Ie8f08a2354e247284e3aafee8097db29bcee8567 Reviewed-on: https://gerrit.libreoffice.org/24490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin1-6/+6
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27clang-tidy modernize-loop-convert in f*Noel Grandin14-123/+102
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin2-6/+6
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-8/+8
Change-Id: I32874fb49b361c14f33810e606ede1e49c1acd30
2016-04-25remove redundant initializationJochen Nitschke1-3/+0
DataNode has a default initializer who sets all members to 0 Change-Id: If5086fa54701394f9ba3eadd1c130ddede945fb2 Reviewed-on: https://gerrit.libreoffice.org/24331 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-21Fix typosAndrea Gelmini3-4/+4
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-21new plugin stylepoliceNoel Grandin6-29/+29
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann9-39/+39
Change-Id: I887a9161107e58c9343d240c2b54e02f4e59567f
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin1-4/+3
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 09:39:34 +0000