summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2021-01-06Move TIFF reader and writer from filter module into VCLTomaž Vajngerl53-4021/+2
Moving graphicfilter one by one into VCL to get rid of filter_gio module and all the nonsense of dynamic/static library loading in "GraphicFilter". Change-Id: I21ebc0334ee07d36553a88557d33e01d9caec9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-03Degree10->Degree100 in XPolygonNoel Grandin1-1/+1
Since some of the call sites are passing in Degree100, let us preserve that accuracy. Change-Id: Idfc9c6dfcbc9e164085aacd0c775eac929f33d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-03ofz#29152 short readCaolán McNamara1-328/+335
Change-Id: I2065a728625be2c770c5f0e10d8d04bd4674986c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-02introduce Degree100 strong_int typeNoel3-45/+45
Change-Id: I78f837a1340be0ca5c49097f543a481b7b43a632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108367 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-01ofz#29151 short readCaolán McNamara1-4/+6
Change-Id: I908d19903ff0b16f5c6a87b8aa989b6a410a7b3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108563 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-01Typo in code 'Reapeat'->'Repeat'Julien Nabet1-7/+7
Change-Id: I50bd9648584a60feccc115b4e58dff896e1284be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108499 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-01use more NbcRotate utility methodNoel Grandin1-2/+1
Change-Id: I74330033c1540c4ed8633dd176a88ed5cacb7c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108517 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-30use Degree10 in XPolygonNoel Grandin1-2/+5
Change-Id: I1820455de46bd428e1fbc0601aba58d377fdb930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108488 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann23-43/+54
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-29ofz#28931 Indirect-leakCaolán McNamara1-40/+48
Change-Id: I9ed9d7680cc036c5e6e00a2603bb100628210685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108424 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-28ofz#28912 Direct-leak in PPTStyleSheet::PPTStyleSheetCaolán McNamara1-36/+36
Change-Id: If6ee82bab1937599ee2908f9c610c63e505189ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann4-7/+7
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-24custom literal for Degree10Noel Grandin4-9/+9
Change-Id: Id13869138a622e62d9ffebf2c89bddccda6aff01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-24vcl: move access functions into appropriate bitmap access filesChris Sherlock5-5/+5
Split class functions into BitmapInfoAccess.cxx, BitmapReadAccess.cxx and BitmapWriteAccess.cxx Split header files into BitmapInfoAccess.hxx and BitmapReadAccess.hxx Change-Id: I7dcbe1d26c5b64d297658a6b809c93d7ad7f053d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108039 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-12-23add utility NbcRotate methodNoel Grandin2-16/+4
Change-Id: I66d016a22158f9f9ef68a80842e95e45516f0b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23fix ppt gradient importNoel Grandin1-1/+2
it is this way as far back as 2009 (couldn't see beyond that). Found while doing some work on verifying how degree units are passed around. Change-Id: I6c8839aa390825f2aab38c70d623109543fddf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara7-2209/+2058
for filter Change-Id: If10a96a3f51849076d45ed7d1553bb898a64b5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23Related tdf#139073: deal with "none" for border-width in odf2uof_spreadsheetJulien Nabet1-15/+50
Change-Id: I040aab5a1863b359cf343de45930127a80e28506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108217 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-22oss-fuzz: tgafuzzer doesn't pass sanity checkCaolán McNamara1-2/+13
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/tgafuzzer+0x63cce7f) Step #5: #7 0x4f13aa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/tgafuzzer+0x4f13aa) Step #5: #8 0x1d8d9c5 in (anonymous namespace)::TGAReader::ImplReadHeader() (/tmp/not-out/tgafuzzer+0x1d8d9c5) Step #5: #9 0x1d8c9ca in (anonymous namespace)::TGAReader::ReadTGA(Graphic&) (/tmp/not-out/tgafuzzer+0x1d8c9ca) Step #5: #10 0x1d8c598 in itgGraphicImport (/tmp/not-out/tgafuzzer+0x1d8c598) Change-Id: I1b01435d07d5e553e2941b402d4820836a9dce15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: psdfuzzer doesn't pass sanity checkCaolán McNamara1-3/+12
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/psdfuzzer+0x63cce7f) Step #5: #7 0x4f1af9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/psdfuzzer+0x4f1af9) Step #5: #8 0x1d9dfd6 in (anonymous namespace)::PSDReader::ImplReadHeader() (/tmp/not-out/psdfuzzer+0x1d9dfd6) Step #5: #9 0x1d9d1a6 in (anonymous namespace)::PSDReader::ReadPSD(Graphic&) (/tmp/not-out/psdfuzzer+0x1d9d1a6) Step #5: #10 0x1d9cd38 in ipdGraphicImport (/tmp/not-out/psdfuzzer+0x1d9cd38) Change-Id: I407e7a32dd8e2fffb508edf896b9ca4783b94c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108157 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: epsfuzzer doesn't pass sanity checkCaolán McNamara1-172/+183
Step #5: #6 0x640b42f in __cxa_throw (/tmp/not-out/epsfuzzer+0x640b42f) Step #5: #7 0x5413d9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/epsfuzzer+0x5413d9) Step #5: #8 0x1dd29b1 in ipsGraphicImport (/tmp/not-out/epsfuzzer+0x1dd29b1) Change-Id: Ieab45edabd5f13d07359be558618ff65badfde2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: pcxfuzzer doesn't pass sanity checkCaolán McNamara1-1/+11
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/pcxfuzzer+0x63cce7f) Step #5: #7 0x4f13aa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/pcxfuzzer+0x4f13aa) Step #5: #8 0x1d86707 in (anonymous namespace)::PCXReader::ImplReadHeader() (/tmp/not-out/pcxfuzzer+0x1d86707) Step #5: #9 0x1d858b1 in (anonymous namespace)::PCXReader::ReadPCX(Graphic&) (/tmp/not-out/pcxfuzzer+0x1d858b1) Step #5: #10 0x1d85496 in ipxGraphicImport (/tmp/not-out/pcxfuzzer+0x1d85496) Step #5: #11 0x4e3ab5 in LLVMFuzzerTestOneInput (/tmp/not-out/pcxfuzzer+0x4e3ab5) Step #5: #12 0x30a5a86 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/tmp/not-out/pcxfuzzer+0x30a5a86) Step #5: #13 0x30a3a31 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/tmp/not-out/pcxfuzzer+0x30a3a31) Step #5: #14 0x30a8666 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__1::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/not-out/pcxfuzzer+0x30a8666) Step #5: #15 0x30a92b5 in fuzzer::Fuzzer::Loop(std::__1::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/not-out/pcxfuzzer+0x30a92b5) Step #5: #16 0x306d4c7 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/tmp/not-out/pcxfuzzer+0x306d4c7) Step #5: #17 0x305ea37 in main (/tmp/not-out/pcxfuzzer+0x305ea37) Change-Id: I4c70f8879c7fb1f9bcd1c857c5fcad9bcaf8d142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108148 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-20No longer need to worry about ambiguous operator== in loplugin:stringviewparamStephan Bergmann6-10/+22
...after 46c5de832868d2812448b2caace3eeaa9237b9f6 "make *String(string_view) constructors explicit" Change-Id: I6e884c762a2fc91f5dd6fbb197a596fd60f17cae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara1-1/+1
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19make *String(string_view) constructors explicitNoel Grandin1-1/+1
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-19tdf#138818: libtest_filter_tiff: Add unittestXisco Fauli2-0/+20
Change-Id: Ibb8566d58c23a76923d39f6f9d4dabf5a01d101a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107939 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18tdf#126460: libtest_filter_tiff: Add unittestXisco Fauli2-0/+18
Change-Id: I60ad27828df684d1886c21a50247dd5fa59e933c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107942 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18tdf#115863: libtest_filter_tiff: Add unittestXisco Fauli2-1/+30
Change-Id: I4877005287181189c4210052ab57ada876ae2e90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107926 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-18throw exception in SvStream when reading past end of fileNoel5-13/+37
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-17tdf#138818 Import full TIFF fileGeorgy Litvinov1-1/+1
Change-Id: I519c810b8e52f698884eb8feac6994140ce9ca25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-16tdf#95662 Convert , to . for the min-width in the Lists onlygerrit1-2/+2
Works where strings should never have a ",", didn't check other strings. Change-Id: I693a2dbf13701420768c70c3cd11b84eac81f378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104544 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-15impress: <count> variable not substituted in presentation on slideshowMarco Cecchetti2-0/+12
Change-Id: Ifa93c112dae217b65a874b37de7727e671da8b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107580 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 345fcef24098cf7f827bfc49c7976b0bfe814edc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107699 Tested-by: Jenkins
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann5-10/+12
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-08Avoid calculating checksums if we can.Michael Meeks1-3/+4
We can compare the underlying mxImpGraphic pointers via the Graphic's uno tunnelling magic easily enough anyway. Change-Id: I09bd0fd97b662f07378197fce2956ed0776ba458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106186 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> (cherry picked from commit a52246d5a45548820dac55395e64dc1ff83ae11f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107375 Tested-by: Jenkins
2020-12-03tdf#96505: Get rid of cargo cult long integer literalsGökhan Özeloğlu1-1/+1
Change-Id: I7226f93a87e0b31634a3c0942f3f5ec8778161fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106843 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-02tdf#128501: DOC export: fix lost bitmap fill for OOXML custom shapesXisco Fauli1-8/+29
this fix is based on 7032be2e9edd82dad2d67f1582aaa57676bda4a1 which fixes the same problem for PPT filter Change-Id: Id62c29892dd3fce42d27e2e46a7933154cb973f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107003 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-02ofz#27839 TimeoutCaolán McNamara1-7/+2
use sal_uInt32 and truncate to limit instead of using sal_uInt16 Change-Id: I454fcf23ff272069f8e4499b1ce9674cfb8e4564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel1-1/+2
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel1-27/+27
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26tdf#131269 - fix importing PPT with different notes/presentations ordernd1011-2/+26
Normal PPT has the order of master-presentation-note slides. But for certain PPT document, the order is master-note-presentation. This fix is to change the importing of page list for those documents with different structure. Change-Id: I2d682a30a3550a6182fcfff7f71f4993ca27a5f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel2-2/+2
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-21tdf#123936 Formatting files in module filter with clang-formatPhilipp Hofer4-27/+23
Change-Id: I787835eb102868bbd52cdb1c9999b5dad553947f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105669 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-20SvStream::{Tell,TellEnd,remainingSize} all return sal_uInt64Stephan Bergmann1-35/+36
...so use that type where appropriate here Change-Id: I3e419457bc04b5908128bad04eb16c72052d2ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106267 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-20Lengths passed into the SvxMSDffManager::Get*Data functions are all sal_uInt32Stephan Bergmann1-6/+7
(i.e., rLength obtained from SvxMSDffManager::ReadCommonRecordHeader) Change-Id: I04b51cb7e6cb771d89d07a86c00ee9fdaa72aaa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-19nChain should presumably be sal_uInt32 hereStephan Bergmann1-1/+2
...given that SvxMSDffShapeInfo::nTxBxComp it interacts with is sal_uInt32, too Change-Id: I38d9bc9c467d10644bddedcd873b14b1b4c3d1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106175 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-18Remove unused SdrGrafObj::SetGraphicLink rReferer, rFilterName parametersStephan Bergmann1-5/+2
unused since 9fb7aaf570c03c8a26d763f1205fb8c890e8211a "Make linked graphic register into LinkedManager again", and remove further function parameters and class members that turn out to be unused now, too Change-Id: I3dd2b138fd8787d12b89547526da751ea5954845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106041 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam check methods tooNoel2-3/+3
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-16Instead of labs, use overloaded absStephan Bergmann1-1/+2
...more likely to pick an appropriate version for the involved integer types, esp. after the recent long -> tools::Long changes Change-Id: Ia91259ca35aaf74b0e907de6831fc926f30057f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara12-0/+47
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-12tdf#42949 Fix new IWYU warnings in directories [e-f]*Gabor Kelemen30-32/+8
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I963aa5fb892a0be36212fd0587b69f217f017947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105469 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-26 19:42:15 +0000