summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2016-01-08tdf#96713 OdfFlatXml: Seek to 0 before readingMaxim Monastirsky1-0/+4
Similar to tdf#45418. The problem is that sfx2 DocumentInserter code calls SfxMedium::IsStorage, which reads the stream but doesn't correctly seek back to 0. Actually SfxMedium_Impl has 2 members for the input stream, one of SvStream type and another one as Reference<XInputStream>. Turns out that reading with SvStream::Read changes the position in the object referenced by Reference<XInputStream>, but SvStream::Seek doesn't, so Seek(0) doesn't do the desired effect. My current solution is to ensure that we're reading from 0 inside the filter. I think it's a good thing to do anyway, and should be sufficient, given that other filters doesn't seem to be affected by this bug. Change-Id: I49b41077032d3e395c675e4f7824cc778c075473 (cherry picked from commit 5e4124396cafc2b0a435f17a66b33e36303ae4e4) Reviewed-on: https://gerrit.libreoffice.org/20983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 47f6e49e2a204a00ac631f9fa021d6320752d039)
2015-12-19svg export: presentation engine: source code clean upMarco Cecchetti1-158/+135
Change-Id: I83f6d524feb21197ad930180f36224feae565ab0 Reviewed-on: https://gerrit.libreoffice.org/20808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit 84dc88a0d5316802998bbcccfdd0e5c87652bfed) Reviewed-on: https://gerrit.libreoffice.org/20831 Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2015-12-14svg export: borders of leaving slide are not covered by the entering oneMarco Cecchetti2-3/+39
Change-Id: I4b7422eb77edd39a2c6bd427aa8c10d62b1e370d
2015-12-14svg export: transition not displayed when switching from last to first slideMarco Cecchetti2-17/+51
Some transition, such as those involving clipping, is not displayed when switching from last to first slide. That is due to the fact that the leaving slide (the last one) is over the entering slide (the first one). The issue has been solved by hiding the last slide and placing a view to it (svg:use) behind the first slide. Change-Id: Iac1d23a1b9834c301b8ae511ea3f81397e5a4229
2015-12-14svg export: added support for random bar and dissolve transitionsMarco Cecchetti1-8/+169
Change-Id: Ib5e303599b04b031d7eefed56603bce0d1e1e570
2015-12-10svg export: transition on first slide are not run - fixedMarco Cecchetti2-5/+78
A dummy slide has been added to be used as leaving slide for transition on first slide. SVGExportTextDecorations unit test - fixed wrong XPath. The new dummy slide group element caused the xpath to the slide group to be wrong. Change-Id: I6c1a0a80f71a79668c309bc0bcb3d5e588ef3a39
2015-12-07svg-export: added a new bullet typeMarco Cecchetti1-0/+2
The new bullet type is used in a pptx document. Change-Id: I0bf970c2a25fb21b666e263b67023c299041e4cf
2015-12-03build fixAndras Timar1-1/+1
Change-Id: I4cfc98bc7bb12b0f327a2b575dfea49483ce6519
2015-12-02svg export: no more an experimental featureMarco Cecchetti3-255/+182
Removed experimental feature check. Single slide exporting works as for multi slides exporting. Change-Id: I3b4f100f5ab9c76896e7f52d65ec27c364216c21
2015-11-29svg-export: text animation didn't work - fixedMarco Cecchetti1-2/+2
That was due to 2 problems: - The namespace for an animation attribute was wrong - For debug build the bullet placeholder is not the first child Change-Id: If10c362f6fcffd4a05164cc5ca3ff6cacf5c28c1 Reviewed-on: https://gerrit.libreoffice.org/20238 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1b26e2ef0a97ded5cc812664ef8455251468e847)
2015-11-29svg-export: slide transition did not work - fixedMarco Cecchetti1-6/+6
Slide transition didn't work anymore since the attribute parsing did not take into account the smil namespace prefix. Change-Id: I779f6408b1eac964f934019d219dc4111debe592 Reviewed-on: https://gerrit.libreoffice.org/20237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 23f5c03d964c3a069eb692c7a2b1d586c124cfd1)
2015-11-29svg-export: animation sequence was wrongMarco Cecchetti1-22/+33
Animation sequence was wrong due to the priority queue and related compare functions implementation. Change-Id: I359abd087e922ffa0aa4f7770fcc0c9bdb029843 Reviewed-on: https://gerrit.libreoffice.org/20236 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1ed6d1423c7cffa5403dad69a9946ec790a374f2)
2015-11-29svg-export: now animation elements are exported with namespaceMarco Cecchetti2-33/+56
For debug build an assertion failed because of presentation, smil and anim namespaces were not registered before exporting. The JavaScript engine has been modified in order to handle qualified animation elements and attributes. Change-Id: I2415fd59c2d1afddb1c68b708feb62e446ea5252
2015-11-29svg export: fixed issue about text fields and shape bounding boxMarco Cecchetti2-22/+46
- issue: text fields were not displayed; this happened for debug build only: the problem was due to 2 facts: 1) the last fix for text decoration which changes the order in which tspan and desc elements are exported; 2) a workaround implemented for fixing the fact that date/time fields were not exported correctly when positioned chars are used (see commit c0a08eab). - issue: text fields were no more aligned correctly: this was due to the fact that the rect element representing the bounding box of the exported shape is not exported any more: I suspect that the rectangle was present in the generated GDIMetaFile representation of the exported shape. Change-Id: I3cd7b0d3a7f2bde8bfd8b933297cbdd7b90e6567
2015-11-29tdf#95356: unit test about text decorations for svg exportMarco Cecchetti1-2/+6
1) Fixed the trailing space issue in text decoration attribute value. 2) Changed the SVG export suite in order to make it more reusable for other tests. 3) Added a unit test for testing that text decorations are exported correctly. Reviewed-on: https://gerrit.libreoffice.org/19870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 50506421f29d09fa4c44c46c3d60208a64a1c450) Conflicts: sd/qa/unit/SVGExportTests.cxx Change-Id: I2bd71974242a0007726fbdd5ef5637a9ec62fd47
2015-11-28filter: fix DrMemory/valgrind warnings in PPT paragraph importMichael Stahl1-27/+124
various uninitialized variables in CppunitTest_sd_filters_test hang-8.ppt Change-Id: Id0b9f146a7ab8b5bb2b36a5c2a39d65ee52e122d (cherry picked from commit 78407eea3ddb5717a501d9336e3b3cbef188d010) Reviewed-on: https://gerrit.libreoffice.org/20157 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d130afe6c04dd53b5500e3b9335ca2e615aa6bb6)
2015-11-18tdf#39080 Hide white space between pages in 'print layout'Ashod Nakashian1-4/+23
Merged Hide Whitespace with Browser Mode and hooked the former with the UI. In Hide Whitespace mode the headers and footers are removed and page margins as well as between-page gaps are reduced to minimum. In single-page view the side margins are left as-is. In multi-page and book-view the sides are removed, however, they have twice the width of the top and bottom. Printing and PDF export disable this mode. The usable screen real-estate is greatly improved in this mode, which is controlled from the View menu. Change-Id: I2d0075ae9a76162c26c78e9eb23a71920cdfc522 Reviewed-on: https://gerrit.libreoffice.org/17281 Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2b8e62f7b6e0a45a9ff1ec530b2e941f3fbcf1a0)
2015-10-29tdf#95356 Now text decorations are applied correctlyMarco Cecchetti2-90/+49
Now the default for using the SVG tiny profile is false. Now the default for use native text decoration is true. Fixed the following issues: 1) Text decoration (underline, strike-out) was not exported. 2) Commit 0a4e913 (tdf#56467: improve export of formulas to SVG) had a side effect: all exported text portions have position attributes (x,y) even if they are on the same line (y_old == y_new): this caused that underlined text belonging to 2 different `tspan` element was not underlined by a continuous line but there was a gap where a `tspan` ended and the next `tspan` started. 3) In commit (tdf#37650: further improvement of svg export) StartTextShape method is invoked even when positioned characters are used but the `implWriteText` method always adds a `text` element by itself so there is no need to call StartTextShape. The changes for non-positioned characters have been embedded inside the `WriteTextPortion` method. Change-Id: Iee0d6a6816dcbd2d97f2fbdf969f012de678604e Reviewed-on: https://gerrit.libreoffice.org/19672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-10-20sc: initial png exportMiklos Vajna2-0/+29
Change-Id: Iae0e89646eab794879529274f09839ad34aa4696 (cherry picked from commit 03bb5d52fecd6c613c6cc36508eb44e5e1c3456a)
2015-10-20svg export: left mouse click is working againMarco Cecchetti1-0/+19
Change-Id: I5a80fe3eb55caa6e57c7842e5ac74cd1abb93f0b Reviewed-on: https://gerrit.libreoffice.org/19471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-10-19Writer image export: cmd. line, default to white backgroundTomaž Vajngerl1-1/+4
This commit fixes the writer image export (jpeg, png) that didn't work because the export pixel size was set to 0 by default. Now the default is set to document size (which depends on system DPI). When exporting to a PNG the background was transparent, which may not be desired. The background color is now by default white and can be changed for DocumentToGraphicRenderer, but the dialog or command line don't support such an option - for now. Change-Id: I16ffd3cd60c47b52768f43ae4c4c170fc821033b
2015-10-17ignore orcus::sax::malformed_xml_error etc tooCaolán McNamara1-8/+8
e.g. kde323651-1.pptx etc Change-Id: I59319733902a0c1298094bc1541d763938334ad4 (cherry picked from commit 70049dbeb286cb0613526e1c3c0318d32a446e58) Reviewed-on: https://gerrit.libreoffice.org/19311 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d8fbdc178148d8239be3b7bf3ad2b3a789320bb1)
2015-10-16lok svg export: Default to exporting all slides, use the interactive SVG.Jan Holesovsky2-18/+17
The slides to export can be tweaked via a "PagePos" parameter. Change-Id: I66f19521bd8f699710eefafb29f54036d7e604c3 (cherry picked from commit e0769daf7b4335024733fa43b26cd0ef0b03108f)
2015-10-16svg export: Some whitespace cleanup, fix typos.Jan Holesovsky1-31/+28
Change-Id: I0de8b5229a83d2ed1ccecbd5608c94881b9baad3 (cherry picked from commit 2cb172582a034dccc40be16f73b369e772c97ecb)
2015-09-18check stream status more oftenCaolán McNamara2-15/+32
Change-Id: I233c2fff9c06a81117f8114ccee83b53ea4026db (cherry picked from commit b43e03353aeb04ed74a272d98df03dd7c20f3478) Reviewed-on: https://gerrit.libreoffice.org/18505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-09-18fix size check related hangCaolán McNamara2-9/+10
Change-Id: I3e8aa5c48ba802cd363688502b44e27bfdf67f01 (cherry picked from commit b02f1c58e7bb8b6c9381107431557d3f39794fe0) Reviewed-on: https://gerrit.libreoffice.org/18464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-18check for legal field sizes before readingCaolán McNamara2-6/+19
Change-Id: I3cdb647e1a057be5bb4b32d119ee5bcbbedf7473 (cherry picked from commit ad6d83defb33c414885ce6d4bfa85571d463f3c3) Reviewed-on: https://gerrit.libreoffice.org/18169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-18tdf#93532 - Switching to 64-bit checksumMarco Cecchetti7-21/+23
Added a C++ and a GLSL implementation of a 64-bit CRC algorithm. Changed hardcoded checksum value in ooxmlimport unit test (testN777345). Change-Id: I16bb985a14866775efda49e21fe033ff64645896 Reviewed-on: https://gerrit.libreoffice.org/18254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-18check stream statusCaolán McNamara2-4/+6
Change-Id: I65ed5979d35d8739367294a71620782b832cfd71 (cherry picked from commit a8fe085f973b4ccf846fe231af0fa25eda59911e) Reviewed-on: https://gerrit.libreoffice.org/18160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-31pClientData can be nullCaolán McNamara1-1/+1
Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc (cherry picked from commit 7d4c77e374310bef538465d11980d1d610cbe0f1) Reviewed-on: https://gerrit.libreoffice.org/18149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-31eof isn't a Error, so use good not GetErrorCaolán McNamara1-14/+14
Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1 (cherry picked from commit 078235028a8c4ea36b6b366348016e19759c456a) Reviewed-on: https://gerrit.libreoffice.org/18114 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check seeks and readsCaolán McNamara1-18/+44
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562 (cherry picked from commit 1847753ab135f522df6a293a8539155437f0129f) Reviewed-on: https://gerrit.libreoffice.org/18112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check stream state after read attemptCaolán McNamara1-1/+5
Change-Id: Ie3836f2e95acab963634181a07565343501f00f8 (cherry picked from commit 9a695e071020639926f8b038aba64eb016a1801a) Reviewed-on: https://gerrit.libreoffice.org/18092 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check SeekToEndOfRecord for successCaolán McNamara1-1/+3
Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943 (cherry picked from commit d417ffb7dd93306be7c89526a75acab53dbd8831) Reviewed-on: https://gerrit.libreoffice.org/18090 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31avoid loops in atom chainsCaolán McNamara1-3/+15
(cherry picked from commit de71eae5807ff94c8eace0eccaabf1ffa08e77b6) Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd Reviewed-on: https://gerrit.libreoffice.org/18093 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check seeks and offsetsCaolán McNamara1-5/+10
Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae (cherry picked from commit 5ed690a3e8a575784ca25048e0229ebc52e6fccd) Reviewed-on: https://gerrit.libreoffice.org/18099 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check seekCaolán McNamara1-2/+4
Change-Id: I358758999bb918e73cdee2224e575e72c2131453 (cherry picked from commit 0c713e45f9831073e34777f50abf9b5801f08ed9) Reviewed-on: https://gerrit.libreoffice.org/18098 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check returns of SeekToEndOfRecordCaolán McNamara1-4/+22
Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445 (cherry picked from commit d400f155fdc3867ad4a067c2bf85588fc0fbb2a2) Reviewed-on: https://gerrit.libreoffice.org/18096 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31crashtesting: tiff loop detection too slowCaolán McNamara1-4/+4
moz323894-1.tiff and moz456356-1.tiff take too long to load Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01 (cherry picked from commit 7e373e92fc02393732422d05264dd5115076183f) Reviewed-on: https://gerrit.libreoffice.org/18095 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31extend seek, loop ending tests to ppt specific codeCaolán McNamara1-24/+21
Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f (cherry picked from commit c249f93d96ec87b0acbd25ffe087543d6fe9fb14) Reviewed-on: https://gerrit.libreoffice.org/18052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-08-31various hangs, check seeks and record lengthsCaolán McNamara1-42/+70
Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7 (cherry picked from commit a8b2dc80c41022515c3a1df6f7ea245c3390dc39) Reviewed-on: https://gerrit.libreoffice.org/18024 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31don't hang on unreachable record endsCaolán McNamara1-2/+12
Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff (cherry picked from commit cadac8400a018c8c566379f7767ea5edff78523d) Reviewed-on: https://gerrit.libreoffice.org/18017 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31fix crash on loading certain pptsCaolán McNamara1-3/+3
Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6 (cherry picked from commit 334dba623dfb0c4fb2b5292c2d03741b7b33aef1) Reviewed-on: https://gerrit.libreoffice.org/18015 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31Avoid overflow in PBMReader::ImplReadHeaderStephan Bergmann1-0/+24
...as found by UBSan in CppunitTest_filter_ppm_test on filter/qa/cppunit/data/pbm/fail/crash-1.pbm Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe (cherry picked from commit 662498ab80833a2b671c247fb859603632e52105) Reviewed-on: https://gerrit.libreoffice.org/17984 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31in reality we are limited to max sal_Int32 hereCaolán McNamara2-5/+12
so accept that and test if the values were accepted or limited Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac (cherry picked from commit 0a76c1fd6875bd094ebe2bfbed3d01c98dc0c19e) Reviewed-on: https://gerrit.libreoffice.org/17972 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31detect and reject loop in tifCaolán McNamara2-0/+12
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283 (cherry picked from commit 6b82437dca30eba0f0c9dde6fdc84cb8f7740f8f) Reviewed-on: https://gerrit.libreoffice.org/17957 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-20tdf#91782 - fix VirtualDevice allocation crasher in eps filter.Julien Nabet1-1/+1
Change-Id: I59cc13cebf9a15e873cd0b7f8fccffa37a6a8f39 Reviewed-on: https://gerrit.libreoffice.org/17688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-06tdf#92471: Improve color conversion to MSO highlightingZolnai Tamás4-1/+193
The simple color distance on RGB color space is not good enough. It leads to a better result if we use the scheme of the primary colors. This method works well with MSO highlighting color palette, but not neccessarily in general. In highlighting palette light and dark variant of the same color type (e.g. blue and light blue) has the exactly same scheme. (cherry picked from commit 16f9cf57e20ffbe34cb184f694f465708250a578) filter: filter_utils test needs tools library (from Michael Stahl) (cherry picked from commit 75d0f7262004d93d457b4b0b499ebf0b23fcda04) Missing boost_headers (from Stephan Bergmann) (cherry picked from commit bd8e8db250f99445dc1a8baa7ffc6ddfe90fdf5b) Change-Id: I0de6e4598f365fda1cccd1d3466429e52cf4067f Reviewed-on: https://gerrit.libreoffice.org/17052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-06reject invalid tiff dimensionsCaolán McNamara2-0/+2
Change-Id: I64e77f12cb016a7f4a9d21c732aaeaae7959da76 (cherry picked from commit 34d062147c16090fa42c27ac7960e3f5e3b65d2b) Reviewed-on: https://gerrit.libreoffice.org/17257 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06bail if offsets are past eofCaolán McNamara2-10/+19
Change-Id: I4a8e78231befff498894ec92a1f38af206e13129 (cherry picked from commit 97a0e7558b24792827d77217fb2d8b1106056963) Reviewed-on: https://gerrit.libreoffice.org/17232 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>