summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2018-09-10tdf#108691, tdf#119639 Don't print hidden objects in XLS(X)Aron Budea2-7/+20
In Excel hidden drawing objects aren't printed. When not hidden, printing is controlled by a separate 'Print object' setting. Only rely visibility setting for now, but properly: visible means also printed, hidden means not printed. Ie. import visible property also as printable, and only output visible property in XLS(X) formats. For the future, in XLSX format printability is controlled by attribute 'fPrintsWithSheet' of element 'clientData', don't know about XLS, there fUsefPrint/fPrint bits don't appear to be used anymore (see note in tdf#119639). Reviewed-on: https://gerrit.libreoffice.org/59915 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b38065ea941375bf4f78f13314e84f4a875545d9) Change-Id: I728107b30056f7bf073f2fefddece1bef1eb2e7a Reviewed-on: https://gerrit.libreoffice.org/60275 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-08Revert "tdf#110987: type detection, binary Office formats > templates"Aron Budea1-8/+8
This reverts commit c1817a5b12da642e365a3ef72b556d33c6e29a76. Change-Id: Ia1442dedd07436e5954943c6ff09ed8d9d2b9fc6 Reviewed-on: https://gerrit.libreoffice.org/60197 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 1bb732acc6b4d3de94f343041472ccc096723b30) Reviewed-on: https://gerrit.libreoffice.org/60204 Tested-by: Aron Budea <aron.budea@collabora.com>
2018-07-13tdf#110987: type detection, binary Office formats > templatesAron Budea1-8/+8
The templates for binary MS Office formats were higher prioritized than non-templates, this caused files in binary format and lacking file extension to be identified as templates. Change-Id: I5638b38dfa0a7520dd09cb497c05b6af0eb00834 Reviewed-on: https://gerrit.libreoffice.org/57397 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-05-28tdf#35798: Hide empty Database fields' paragraphs (+ compat option)Mike Kaganski1-0/+13
With this change, Database fields that expand to empty values behave as if they are "Hidden Paragraph" fields. A compatibility option to enable this behaviour is added. The option is enabled by default, and for any non-native documents (for compatibility with other office suites). For existing (F)ODT documents, the option is disabled for those documents that don't have this setting set, to keep the layout of legacy documents. Change-Id: Ic5e8cb15a3a7d1a765a984eef4b0d97666df7dfd Reviewed-on: https://gerrit.libreoffice.org/54552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/54929 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-25StarOffice XML is not exotic, old binary format is exoticAndras Timar6-6/+6
Change-Id: Ie435dda390e434e34ef753b5cb2715ac2252e82e Reviewed-on: https://gerrit.libreoffice.org/53450 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-04-23Resolves: tdf#116999 fix reading cgm text at record boundsCaolán McNamara3-13/+9
Change-Id: Ibbff7b0a3c3447135e0f6c585914dc6018e51765 Reviewed-on: https://gerrit.libreoffice.org/52952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a0c008175eee894f6b4a8975d6c0b4bec2592d08)
2018-04-17Flag a few more import filters as EXOTICAndras Timar36-36/+36
Change-Id: I171efc7e533039ab61d7ae607673aaf81d88c73d
2018-04-12tdf#116555 filter: make sure default extension for HTML is not .xhtmlMiklos Vajna1-1/+2
Since by default we don't write XHTML markup in the sw HTML export. (cherry picked from commit 87e7fd163bc587b5c7cbb59ba40a9856f8bb225d) Change-Id: Ifbf9850652d7838582725be391b2fd1a062495e5 Reviewed-on: https://gerrit.libreoffice.org/52709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit a3925ee114d551567a106161d9e747318ab60c6f)
2018-03-27First cut at annotating 'exotic' filters.Michael Meeks14-12/+19
The idea being that we can improve security by warning for these. Change-Id: I7d993417bfb6a8fe868bc3e07ccbcfe71bf285ff Reviewed-on: https://gerrit.libreoffice.org/50387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 25e4b59b2e9805ebd3c38c40e5591125a05ed5b0)
2018-03-26tdf#116179 Support reading "auto" colour from docxLuke Deller1-5/+2
In docx a colour value is represented as a 6-digit hex RGB value, or alternatively the word "auto" to represent automatic colour. - Add support for reading the value "auto" as COL_AUTO. Previously this would be read as if it were a hex value, stopping at the letter 'u' which is not a valid hex digit, resulting in the colour 0x00000A - a very dark blue, which looks close enough to black that it went unnoticed for a long time :-) - Remove code which tried to handle this wrong 0x00000A value, including the constant OOXML_COLOR_AUTO, as it is no longer needed and will cause surprises for anyone who really wanted this exact shade of dark blue - Fix unit tests that were checking for 0x00000A Change-Id: I6000070341931147ff9341ad6281cd3b53c02b46 Reviewed-on: https://gerrit.libreoffice.org/50995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/51461 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 3967aebca94be9ceea3e36b43f7f53589473ad4e)
2018-03-20lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky2-10/+2
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 101a79cc4d13a1f566c1b97c1329813eb7c61bcf)
2018-03-15Let sysadmins disable individual file format filtersAndras Timar2-3/+5
It makes sense to disable a filter, as a temporary security measure, when there is a 0-day vulnerability in it. E.g., when 0-day found in AbiWord filter, this config snippet disables it: <item oor:path="/org.openoffice.TypeDetection.Filter"> <node oor:name="Filters"> <node oor:name="AbiWord"> <prop oor:name="Enabled" oor:finalized="true"> <value>false</value> </prop> </node> </node> </item> Change-Id: I8b84250c7e4aac3555877d23f58ed13a2210ebfc Reviewed-on: https://gerrit.libreoffice.org/50961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 4547fa2c1e205e1989611b1c4493cbbd12541372)
2018-03-08Support for GPG encryption in more ODF filtersKatarina Behrens4-4/+4
not only Writer but also Calc, Impress, Draw and Math Change-Id: I7f9fe86ffe5f9a812a5215617b9e673c73134202 Reviewed-on: https://gerrit.libreoffice.org/45472 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 9e5e92c4a1415aac8b0107950f577d1679499e62) Reviewed-on: https://gerrit.libreoffice.org/50923 Tested-by: Jenkins <ci@libreoffice.org>
2018-02-24tdf#115863: fix TIFF importAron Budea1-2/+2
Regression from 651e1f6cda04468394c65c2fd88d915902ac0306 Change-Id: Id1604fb8eb11ea4e39846591e3912b40a7e7cc96 Reviewed-on: https://gerrit.libreoffice.org/50269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 40c33132cfa6582dfccf17e787f10dd4dbd0819d) Reviewed-on: https://gerrit.libreoffice.org/50270 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14ofz: AbrtCaolán McNamara1-1/+2
Change-Id: I814b0e4255894d909d29a9a301488a23acf418a0 Reviewed-on: https://gerrit.libreoffice.org/49687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-29Resolves: tdf#114221 generate both std97 and cryptoapi keys from password..Caolán McNamara1-6/+19
when we open a cryptoapi encrypted binary msoffice document. That way when we save as the same format, and try to reuse the generated keys for encryption, we have matching std97 encryption keys available because we always export using that scheme. Change-Id: I25f24a01d102242615768255ce888acb08ef6447 Reviewed-on: https://gerrit.libreoffice.org/48712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-27tdf#114428 filter: recognize XHTML with XML declaration as HTMLMiklos Vajna5-3/+140
The problem was the additional <?xml version="1.0" encoding="utf-8"?> XML declaration before the usual <!DOCTYPE html ... line, just ignore it. Change-Id: I294aae5504b40b42f76da00fef645d0d89009da9 Reviewed-on: https://gerrit.libreoffice.org/46324 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4af729f31c64c09c76ea8bcfa5067092571b92de) Reviewed-on: https://gerrit.libreoffice.org/47587 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-27Related: tdf#114428 filter: associate .xhtml with HTML importMiklos Vajna1-1/+1
Since there is no XHTML import; and this way the expensive "deep" detection (that calls into all the DLP libs, etc) can be avoided. Times for a hello world input: 56 -> 23 ms is spent in Desktop::loadComponentFromURL() (41% of original). Change-Id: Ia2dec3837cf0c548ae2c5a0ca4d47a57a6cbb92a Reviewed-on: https://gerrit.libreoffice.org/46387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 14daba5bd0ba64ff53ad98de7a84537ff03024ea) Reviewed-on: https://gerrit.libreoffice.org/47588 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17tdf#114939 filter: don't use StarOffice SHA1 in MS Office filtersMichael Stahl1-4/+10
Always use real SHA1 here, to avoid interop issues. Change-Id: I28388db34f923bfc476a7eae526934b14d4473b5 (cherry picked from commit f66fbd947f70f6be6b22ab372facaeb9e2fb63ae) Reviewed-on: https://gerrit.libreoffice.org/47998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09ofz#5154 limit depth to max legal depthCaolán McNamara1-15/+11
i <= 5 was nonsense here Change-Id: Ic1b0daf874b9df13ad012d11efaee1c31a47b1d6 Reviewed-on: https://gerrit.libreoffice.org/47668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-09tdf#114308 DOC import correctly watermark without paddingSzymon Kłos1-16/+26
Change-Id: If44eb4d1354386f66c697206db9ab4d7f2be374d Reviewed-on: https://gerrit.libreoffice.org/46110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46146
2017-12-08tdf#114308 Export Watermark size as isSzymon Kłos2-7/+3
* refactoring * removed size hack * export/import "trim" attribute * DOC: export set of parameters to fit shape & frame Change-Id: Ib00654626ae1e10ac5110d22eada7528e03357e7 Reviewed-on: https://gerrit.libreoffice.org/46036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 09da6dfcfb732dd621670f2b919eb5b5bf09b7ec) Reviewed-on: https://gerrit.libreoffice.org/46107
2017-12-08tdf#114304 break rather than return false on dodgy record lengthCaolán McNamara1-1/+4
Change-Id: I1bc8c400147beb8688ed3afd7402b3d3f68a4a3a Reviewed-on: https://gerrit.libreoffice.org/46044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05tdf#113037 Unify Watermark in DOC & DOCXSzymon Kłos1-7/+10
* use correct font for calculations Change-Id: Idd370678c000bf22c460c3323bd55cd827ba7153 Reviewed-on: https://gerrit.libreoffice.org/45698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 923ca4efe2095998e3da75c372cd7d716db9abb3) Reviewed-on: https://gerrit.libreoffice.org/45824
2017-12-04xhtml export: Prefer svg if it's availableSamuel Mehrbrodt1-4/+6
And not use the replacement graphic in this case. Change-Id: I5e1bb7a694f210e2681ff5acf241a131d38a4c5d Reviewed-on: https://gerrit.libreoffice.org/45782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit aa768bdbfd7442947cf0756f58c9bfe791ce047a) Reviewed-on: https://gerrit.libreoffice.org/45801
2017-12-04tdf#113696 XHTML Export: Prefer fallback graphicSamuel Mehrbrodt1-18/+23
Which is usually png and browsers can read that, but they can't read our internal metafile format (svm) Change-Id: Idfd82da630ead69f508b74285081e32315030825 Reviewed-on: https://gerrit.libreoffice.org/45590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-on: https://gerrit.libreoffice.org/45679
2017-12-03tdf#80713 Translate a few file format namesGabor Kelemen5-5/+5
These are visible in Tools > Options > Load/Save > General > 'Always save as' Change-Id: I879200a535b46b54653c9e0947a2e8064c72ac91 Reviewed-on: https://gerrit.libreoffice.org/45543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 1764c0358d7de602d6efaca940bde9081f7a0b65) Reviewed-on: https://gerrit.libreoffice.org/45699
2017-11-30upload libwps 0.4.8David Tardon1-1/+1
Change-Id: Ib285c227cd935987311be40df3745316943a54e0 Reviewed-on: https://gerrit.libreoffice.org/45331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 8d0e8d5d291cbb98de6964eab2f629a405c7e813) Signed-off-by: David Tardon <dtardon@redhat.com>
2017-11-27ofz#4435 Bad-castCaolán McNamara1-8/+16
Change-Id: Ie0364c758af84097cee93e4f6c5e8af2816359d4 Reviewed-on: https://gerrit.libreoffice.org/45286 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-27ofz#4436 check if seek succeededCaolán McNamara1-1/+4
Change-Id: I56d9692647b28c706b56ccacf08d494b3d830d94 Reviewed-on: https://gerrit.libreoffice.org/45295 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24set new document window as parent for dialogs during loadCaolán McNamara3-5/+49
and exit typedetection early and completely if application quits while detecting During typedetection, before loading proper, we have the hidden window as parent so warnings are not modal to existing windows and they are cancelled on exit. Once we do have a window, then reinit interaction handler to have that window as the parent for any further dialogs. Change-Id: I5c6711557266bf7d1eb9291f1c454cbfaf766886 Reviewed-on: https://gerrit.libreoffice.org/45148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23loplugin:simplifybool can't invert conditions involving float typesNoel Grandin1-2/+2
so revert some of the changes from commit 7a1c21e53fc4733a4bb52282ce0098fcc085ab0e loplugin:simplifybool for negation of comparison operator Change-Id: I937d575b86c1e418805d399b0dc16ae91876b4fe Reviewed-on: https://gerrit.libreoffice.org/45130 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin1-2/+2
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann5-8/+8
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22turn some eof checks to eof or errorCaolán McNamara3-5/+5
Change-Id: I4592d7aa86c2cc2f420bccc622ffb95aa5cefa17 Reviewed-on: https://gerrit.libreoffice.org/45077 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara2-10/+10
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara6-17/+17
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22RTF filter: drop now redundant astyle.optionsMiklos Vajna1-63/+66
I (tried to) keep the RTF filter style consistent locally with astyle in the past, but now that's redundant when we have an enforcing clang-format mechanism in place. So drop the astyle config and switch to clang-format in the RTF filter case. To minimize backport pain, do this shortly before the libreoffice-6-0 branch-off. Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin2-7/+7
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I40b3a46d46f0586d086bdbe41876c088f8c1cb58 Reviewed-on: https://gerrit.libreoffice.org/45007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin2-2/+2
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin2-7/+7
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin2-12/+12
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17ofz#4204 compare against available data lenCaolán McNamara1-1/+17
Change-Id: I407e104e08aa393d66ed5c6baf5e0b0ab2d361bd Reviewed-on: https://gerrit.libreoffice.org/44687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz#2977 TimeoutCaolán McNamara1-1/+5
Change-Id: Ib7c00120b97b0d387048a5d8d9d36954e98ffee7 Reviewed-on: https://gerrit.libreoffice.org/44825 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin2-12/+12
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15TypedWhichIdNoel Grandin2-13/+13
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-14Fix typosAndrea Gelmini1-1/+1
Change-Id: Id2f90d4798ded8f10ef559f434977870e2eab07a Reviewed-on: https://gerrit.libreoffice.org/44709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-13Fix typosAndrea Gelmini6-16/+16
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-11tdf#111738: Duplicated numbering alignment option on numbering dialogTamás Zolnai1-1/+1
Change-Id: Ifb18d5da84cc47da59448549f3c617e8040c246c Reviewed-on: https://gerrit.libreoffice.org/44636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>