summaryrefslogtreecommitdiff
path: root/filter/source/msfilter
AgeCommit message (Collapse)AuthorFilesLines
2015-08-31pClientData can be nullCaolán McNamara1-1/+1
Change-Id: I9375f84affdaef30d9b1ded31525e6b7b8709cbc (cherry picked from commit 7d4c77e374310bef538465d11980d1d610cbe0f1) Reviewed-on: https://gerrit.libreoffice.org/18150 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-31eof isn't a Error, so use good not GetErrorCaolán McNamara1-14/+14
Change-Id: Ie1df87c7eb9d391d0fa4a579f744051a1f1b2ae1 (cherry picked from commit 078235028a8c4ea36b6b366348016e19759c456a) Reviewed-on: https://gerrit.libreoffice.org/18118 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check seeks and readsCaolán McNamara1-18/+44
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562 (cherry picked from commit 1847753ab135f522df6a293a8539155437f0129f) Reviewed-on: https://gerrit.libreoffice.org/18116 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31check stream state after read attemptCaolán McNamara1-1/+5
Change-Id: Ie3836f2e95acab963634181a07565343501f00f8 (cherry picked from commit 9a695e071020639926f8b038aba64eb016a1801a) Reviewed-on: https://gerrit.libreoffice.org/18079 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check SeekToEndOfRecord for successCaolán McNamara1-1/+3
Change-Id: I7413a4e9e491b65122eaadb38ad574161f1aa943 (cherry picked from commit d417ffb7dd93306be7c89526a75acab53dbd8831) Reviewed-on: https://gerrit.libreoffice.org/18077 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check seekCaolán McNamara1-2/+4
Change-Id: I358758999bb918e73cdee2224e575e72c2131453 (cherry picked from commit 0c713e45f9831073e34777f50abf9b5801f08ed9) Reviewed-on: https://gerrit.libreoffice.org/18085 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check seeks and offsetsCaolán McNamara1-5/+10
Change-Id: I2b6ded138b9101415fc49e93e1ec3ebcd3a9d2ae (cherry picked from commit 5ed690a3e8a575784ca25048e0229ebc52e6fccd) Reviewed-on: https://gerrit.libreoffice.org/18086 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31avoid loops in atom chainsCaolán McNamara1-5/+17
(cherry picked from commit de71eae5807ff94c8eace0eccaabf1ffa08e77b6) Change-Id: Icc40c0ee6c7d8d305cf7cc60cbf3e511c763aedd Reviewed-on: https://gerrit.libreoffice.org/18080 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31check returns of SeekToEndOfRecordCaolán McNamara1-4/+22
Change-Id: Ia593dd0e2239a97f17bb03f005d22028da482445 (cherry picked from commit d400f155fdc3867ad4a067c2bf85588fc0fbb2a2) Reviewed-on: https://gerrit.libreoffice.org/18083 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31extend seek, loop ending tests to ppt specific codeCaolán McNamara1-24/+21
(cherry picked from commit c249f93d96ec87b0acbd25ffe087543d6fe9fb14) Change-Id: Id4419b6b902b742117e248870b6a663c9c58955f Reviewed-on: https://gerrit.libreoffice.org/18053 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31various hangs, check seeks and record lengthsCaolán McNamara1-42/+70
(cherry picked from commit a8b2dc80c41022515c3a1df6f7ea245c3390dc39) Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7 Reviewed-on: https://gerrit.libreoffice.org/18026 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31don't hang on unreachable record endsCaolán McNamara1-2/+12
Change-Id: I288f7ff0327831603eda6e827c8acbae678dfaff (cherry picked from commit cadac8400a018c8c566379f7767ea5edff78523d) Reviewed-on: https://gerrit.libreoffice.org/18021 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31fix crash on loading certain pptsCaolán McNamara1-3/+3
Change-Id: I544a67e3706c7d12414cc075118ef2f0f5ddd0f6 (cherry picked from commit 334dba623dfb0c4fb2b5292c2d03741b7b33aef1) Reviewed-on: https://gerrit.libreoffice.org/18020 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-04-16Related: tdf#74018 fix int wraparound + crash on exportCaolán McNamara1-18/+19
of fdo74018-2.docx to doc nPoints is 16bit and accumulated value wraps around, so use a 32bit nTotalPoints instead and move 16bit declarations to use points to confirm no other wraparounds (cherry picked from commit ce705ac56a8709970356d634abb964adef105594) Change-Id: If97ccb46ed8eb7f4305cdfe328ae83bc2b0c778c Reviewed-on: https://gerrit.libreoffice.org/15280 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-01-12Resolves: fdo#87015 image missing from docCaolán McNamara1-1/+1
regression from commit e0cce521f1ad0cc384d30ce2f1077ea229fffe62 Author: Armin Le Grand <alg@apache.org> AuthorDate: Thu Jan 10 16:28:40 2013 +0000 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Thu Jun 13 14:50:46 2013 +0100 Resolves: #i121504# Support for alpha channel in clipboard for all systems (cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519) which blindly just bulldozed out the bMSOFormat branch Change-Id: Iec354f1fb585f0803b9df472bc9ec9e103aa5847 (cherry picked from commit 470fcca594ba4f6bf473d4d44b415c2ba151b0d9) Reviewed-on: https://gerrit.libreoffice.org/13874 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-27fdo#84686 prevent std::bad_alloc exception by stricter input checkAndras Timar1-4/+4
The bugdoc has invalid length (rh.recLen) in header of blipStore's OfficeArtFBSE record. Therefore LibreOffice read junk for the next BLIP, and tried to seek to an invalid stream position, which caused bad allocation exception on 32-bit systems. Change-Id: I72fae4c2b00216b57736f4409a32c62a40f25785 (cherry picked from commit 6945971c79d70d77c5c8bb6593b3f25ef46b0887)
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl2-0/+2
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-4/+4
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-6/+6
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11callcatcher: dropping SwChapterNumRules binary Load/Store has knock-on effectCaolán McNamara1-1/+0
Change-Id: I2567026af23dd5fc42812b90bd6098c4c74a4f92
2014-11-07Make SdrGrafObj swapping methods private.Zolnai Tamás1-1/+0
Plus remove some useless call of them. Change the tests accordingly. Change-Id: I47a50b5734d799ac02ee7221c95f82415afb9497
2014-11-07DOC import: avoid manual swapout call.Zolnai Tamás1-1/+0
No reason to swapout the image directly after the import because it will be used for rendering just a second later. Change-Id: I78c8ef9225c55f306182dc5efd7bcaf0e88521c0
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin3-36/+36
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin2-2/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28coverity#1242844 Untrusted loop boundᚉᚐᚑᚂᚐᚅ McNamara1-1/+4
Change-Id: I64a805503d0c044b5c5a80df1513e35df5c39171
2014-10-24coverity#703957 Unchecked return valueCaolán McNamara1-4/+2
Change-Id: I3a5c0239f4615ff0ba832ac4c733c26e25c259e6
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky3-26/+26
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky3-11/+11
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23coverity#1242688 Untrusted loop boundCaolán McNamara1-19/+31
Change-Id: Ic3e2c390de22d3e998daf760d73619218da020ec
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist2-5/+8
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21true on success, false on failureCaolán McNamara1-1/+1
Change-Id: Iaba5f2634e985cf41d52bedcbf7ac1c060d02c1d
2014-10-20coverity#703957 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: If9e3e7297b1539c93902895c50af3fb8f6c83a76
2014-10-20coverity#1242606 Untrusted loop boundCaolán McNamara1-1/+4
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-17coverity#1242624 Untrusted loop boundCaolán McNamara1-20/+44
Change-Id: If2ae1982eec100f5602a13d648beec247ced6aa2
2014-10-17coverity#1242717 Untrusted loop boundCaolán McNamara1-4/+10
Change-Id: I983bba075ab9626c90555fa41f9d473ae60fafea
2014-10-17coverity#1242724 Untrusted value as argumentCaolán McNamara1-3/+8
Change-Id: I6041d09ef0a4ed4af5f1bf93f31a1eac60be1af7
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon3-11/+11
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15Blind Win fix attemptStephan Bergmann1-0/+4
Change-Id: I39df464321685ebef29f44221bab9005295d0c3f
2014-10-15avoid double-deleteDavid Tardon1-11/+11
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e. Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-10typo: follwing -> followingAndras Timar1-1/+1
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca3-26/+26
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-08fdo#75757: remove inheritance to std::vectorTakeshi Abe1-9/+3
from SvxMSDffShapeOrders. Change-Id: Idf551f1fbde907759d6a296141e2837264dbbb10 Reviewed-on: https://gerrit.libreoffice.org/11840 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-06fdo#75757: remove inheritance to std::vectorTakeshi Abe1-51/+50
from PptSlidePersistList. This also puts in assertions that every entry in a PptSlidePersistList is non-null. Cf. 9536a28ede89e8c29940e8ba225215a45667062c Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a Reviewed-on: https://gerrit.libreoffice.org/11807 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06loplugin: cstylecastNoel Grandin3-68/+71
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
2014-10-03coverity#1242529 silence Arguments in wrong orderCaolán McNamara1-1/+3
Change-Id: I662c89e6e3e0917b51e8084bc50a9ea38d6c0838
2014-10-02coverity#1202776 'Constant' variable guards dead codeCaolán McNamara1-1/+1
Change-Id: Ib1d5dcc8b09e11a8ef2399e3ef1a5ae1769de90f
2014-10-01fdo#82577: Handle TimeNoel Grandin2-4/+4
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin2-10/+10
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin2-24/+24
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 09:12:46 +0000