summaryrefslogtreecommitdiff
path: root/filter/source/graphicfilter
AgeCommit message (Collapse)AuthorFilesLines
2015-10-17bump size typeCaolán McNamara1-3/+4
Change-Id: I2c32c253499a3efb22a3312ed1f0a608649ce124 (cherry picked from commit dc71a72753202d29544845cfd58992bac63c6837) Reviewed-on: https://gerrit.libreoffice.org/17090 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8840f5c2d7739e751e29b88224b416b20e3cd26a)
2015-09-17check stream status more oftenCaolán McNamara1-15/+32
Change-Id: I233c2fff9c06a81117f8114ccee83b53ea4026db (cherry picked from commit b43e03353aeb04ed74a272d98df03dd7c20f3478) Reviewed-on: https://gerrit.libreoffice.org/18506 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-17fix size check related hangCaolán McNamara1-9/+10
Change-Id: I3e8aa5c48ba802cd363688502b44e27bfdf67f01 (cherry picked from commit b02f1c58e7bb8b6c9381107431557d3f39794fe0) Reviewed-on: https://gerrit.libreoffice.org/18465 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-04check for legal field sizes before readingCaolán McNamara1-6/+19
Change-Id: I3cdb647e1a057be5bb4b32d119ee5bcbbedf7473 (cherry picked from commit ad6d83defb33c414885ce6d4bfa85571d463f3c3) Reviewed-on: https://gerrit.libreoffice.org/18170 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-04check stream statusCaolán McNamara1-4/+6
Change-Id: I65ed5979d35d8739367294a71620782b832cfd71 (cherry picked from commit a8fe085f973b4ccf846fe231af0fa25eda59911e) Reviewed-on: https://gerrit.libreoffice.org/18161 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-31crashtesting: tiff loop detection too slowCaolán McNamara1-4/+4
moz323894-1.tiff and moz456356-1.tiff take too long to load Change-Id: Iaafa064fd05e4a4152004e7ceb6256af68aeef01 (cherry picked from commit 7e373e92fc02393732422d05264dd5115076183f) Reviewed-on: https://gerrit.libreoffice.org/18082 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-31Avoid overflow in PBMReader::ImplReadHeaderStephan Bergmann1-0/+24
...as found by UBSan in CppunitTest_filter_ppm_test on filter/qa/cppunit/data/pbm/fail/crash-1.pbm Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe (cherry picked from commit 662498ab80833a2b671c247fb859603632e52105) Reviewed-on: https://gerrit.libreoffice.org/17989 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31in reality we are limited to max sal_Int32 hereCaolán McNamara1-5/+6
so accept that and test if the values were accepted or limited Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac (cherry picked from commit 0a76c1fd6875bd094ebe2bfbed3d01c98dc0c19e) Reviewed-on: https://gerrit.libreoffice.org/17973 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-31detect and reject loop in tifCaolán McNamara1-0/+12
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283 (cherry picked from commit 6b82437dca30eba0f0c9dde6fdc84cb8f7740f8f) Reviewed-on: https://gerrit.libreoffice.org/17959 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03reject invalid tiff dimensionsCaolán McNamara1-0/+2
Change-Id: I64e77f12cb016a7f4a9d21c732aaeaae7959da76 (cherry picked from commit 34d062147c16090fa42c27ac7960e3f5e3b65d2b) Reviewed-on: https://gerrit.libreoffice.org/17258 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-03bail if offsets are past eofCaolán McNamara1-10/+19
(cherry picked from commit 97a0e7558b24792827d77217fb2d8b1106056963) Change-Id: I4a8e78231befff498894ec92a1f38af206e13129 Reviewed-on: https://gerrit.libreoffice.org/17227 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03fail on short readCaolán McNamara1-2/+4
Change-Id: I7215cf8d8b1e4a4156c87507018de3c2b7ed08d8 (cherry picked from commit 8eaef6b5217eecaa111c80e426bdf225481a71fb) Reviewed-on: https://gerrit.libreoffice.org/17221 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03don't hang on a bad ReadCodeAndDecodeCaolán McNamara1-1/+4
(cherry picked from commit 6964f67d0dd44c8a3c68caf194075ba5c649bf4b) Change-Id: I999012d428fa84e21fe9e9f851a016eacc96a686 Reviewed-on: https://gerrit.libreoffice.org/17218 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03ensure loop ends eventuallyCaolán McNamara1-17/+22
Change-Id: I318385286fcc27ffb2d938237d83e793564d2525 (cherry picked from commit c02e79874951ba86d926186e284612806d8bc0a3) Reviewed-on: https://gerrit.libreoffice.org/17215 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03test that nNumStripByteCounts value is within bounds of fileCaolán McNamara1-2/+5
Change-Id: If119628d7f510a7db30ed2180111063781cde887 (cherry picked from commit 33d43205c341e0cce36b6a1b3082c3927490cbde) Reviewed-on: https://gerrit.libreoffice.org/17211 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03final check np boundsCaolán McNamara1-0/+2
Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876 (cherry picked from commit dcbbe7741a08f6076f9e020f90cbb730c1edafb9) Reviewed-on: https://gerrit.libreoffice.org/17213 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03check np bounds yet againCaolán McNamara1-0/+2
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c (cherry picked from commit bca4d6f896fb12ceff37476c43ea8892898dd385) Reviewed-on: https://gerrit.libreoffice.org/17208 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03reduce scope, etc, don't loop endlesslyCaolán McNamara1-7/+2
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e (cherry picked from commit 5d32a4ac5c166264c2d44e8df625eb768eb42fbe) Reviewed-on: https://gerrit.libreoffice.org/17205 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03in reality we are limited to max sal_Int32 hereCaolán McNamara1-27/+27
so accept that and test if the values were accepted or limited Change-Id: I599cf8065a6f8786d380fdba03135857766770f3 (cherry picked from commit 80c591ea9c320fee9e975ac7b0e4e2df1bf5e447) Reviewed-on: https://gerrit.libreoffice.org/17198 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03check np bounds againCaolán McNamara1-0/+2
Change-Id: I0fb61954b2eaf0c015d7bdefe9f03bd459b31501 (cherry picked from commit fcdddbd30a8b5cf6a5cc4d2ff28b7d4a20f8ec6b) Reviewed-on: https://gerrit.libreoffice.org/17202 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03check np boundsCaolán McNamara1-0/+2
(cherry picked from commit be4e1141be7cd54cf5362d3de534050db5505437) Change-Id: Id16ae9325f3c67792941b9c88d83435aa98282ca Reviewed-on: https://gerrit.libreoffice.org/17200 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03don't loop forever if pcx has short readCaolán McNamara1-2/+2
Change-Id: I638792417924bcb8e48995f4e789f84a2cbf4757 (cherry picked from commit c9ba7a2a4d29af2542f31562cfdd64db2237aea8) Reviewed-on: https://gerrit.libreoffice.org/17159 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03detect another loop in tif formatCaolán McNamara1-1/+10
Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32 (cherry picked from commit 49bf2c6700d8f0fc9155ac2d06bf0a7bd84915d8) Reviewed-on: https://gerrit.libreoffice.org/17155 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03test that nNumStripOffsets value is within bounds of fileCaolán McNamara1-2/+5
Change-Id: I1483ea3671420be53496888892374641e10b344d (cherry picked from commit feedb957310fc3282ca47d5ffc1482dbb944a36e) Reviewed-on: https://gerrit.libreoffice.org/17152 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03detect loop in tif formatCaolán McNamara1-1/+11
Change-Id: I27645566cd9fc0ac8cf753f0217ae6cf0fa9929e (cherry picked from commit 290465b0effecb6d620adc20ca279f8057eeab9a) Reviewed-on: https://gerrit.libreoffice.org/17150 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03min size of eps for a preview is 32Caolán McNamara1-124/+125
(cherry picked from commit bf02304a0ea4771e01f39dd0032cbf276997ca00) + V668 no sense in testing the result of new against null cherry-picked from commit 556373c41fddbac6cbee1c89e7707631270a1852 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Mar 11 09:06:08 2015 +0000 V668 no sense in testing the result of new against null in order to merge simply Change-Id: Icb82d9dd0a3918f2bdc4cb768c566774cd0d8ac4 Reviewed-on: https://gerrit.libreoffice.org/17133 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03exception on div by 0Caolán McNamara1-0/+5
Change-Id: Id33d6a5e3df5812babd28ebfc65b95ce97219ad3 (cherry picked from commit cf4159e16c13a13d0bedccebb50bb08f1662bc1c) Reviewed-on: https://gerrit.libreoffice.org/17122 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-03avoid hang in short pbmCaolán McNamara1-1/+1
Change-Id: I9b7f0832a4dc231e1e8f963858c155e3cd392667 (cherry picked from commit b8637e67d6d39e47d22cfce496000288f0dc58d8) Reviewed-on: https://gerrit.libreoffice.org/17085 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03tools polygons limited to 16bit indexesCaolán McNamara1-7/+26
(cherry picked from commit 89857aacac98f0f8e5dca4718affec493951f904) WaE: C2220 (cherry picked from commit 8547c336b3253d90daae1c79a2b1a57996a39102) Change-Id: Ib0f727a3681492c15b807ca159d8bf7675ee8f29 Reviewed-on: https://gerrit.libreoffice.org/17089 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03don't hang with 0 len causing no progressionCaolán McNamara1-3/+9
Change-Id: Ie553dab291c7bfbde033d89b84159aff6b42a160 (cherry picked from commit 15dfcb7f461893f83abcf28bfe01a4164209a160) Reviewed-on: https://gerrit.libreoffice.org/17086 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03check stream state more often for failuresCaolán McNamara1-10/+14
Change-Id: Ie45d858021c3123ec21829cbf4742cf30ce46665 (cherry picked from commit adfa89b5ffc3589b3a19a32e707a134cee232429) Reviewed-on: https://gerrit.libreoffice.org/17072 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-03file format documentation states these are signedCaolán McNamara1-9/+9
Change-Id: Iaca58dda19d24a767333ff642759414951a03e6d (cherry picked from commit 8a60e78769ebf6fc73ddc8ed7e43991fcb30fff4) Reviewed-on: https://gerrit.libreoffice.org/17065 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-08ppc64: fix infinite loop with default unsigned charCaolán McNamara1-8/+39
(cherry picked from commit d6db7e20d31280547ab15455ad1bc2a6d84ca76e) Change-Id: I4c1d4c9228113bf83e8aabb50f153d2658c3cf59 Reviewed-on: https://gerrit.libreoffice.org/16776 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-01-05asan wrt mandriva57054-1.tiffCaolán McNamara1-6/+5
Change-Id: Ibb7ecfa637ff96fbda3a8ed5d67943ece28927e5 (cherry picked from commit f901624b5e13e300f8e2facd2a824202c21d9729) Reviewed-on: https://gerrit.libreoffice.org/13738 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-11-19Related: coverity#1242658 Untrusted loop boundCaolán McNamara1-2/+10
Change-Id: Ic785b333c1ad31036da20483dc7310fcc5338d80
2014-11-17don't reuse old var remnantsCaolán McNamara1-11/+9
Change-Id: I1074d0431695ec21e22cdef334dbe419763e7ba2
2014-11-17afl: divide-by-zeroCaolán McNamara1-1/+8
Change-Id: Ided311873f654c0f40dae57c8876a6412ee97d3e
2014-11-14coverity#1209889 Untrusted loop boundCaolán McNamara1-2/+10
Change-Id: I63039ca0de1dc54b5aa9d048e5110c31bf930bdc
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl7-0/+7
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini4-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11Related: coverity#1242658 Untrusted loop boundCaolán McNamara1-4/+2
Change-Id: I1e7e815c2800b4846498092239b0fadaa5d87b45
2014-11-10coverity#1202754 Bad bit shift operationCaolán McNamara1-6/+6
Change-Id: I51e8df896897b122965ada0ced161570d38f0468
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#1242658 Untrusted loop boundCaolán McNamara1-0/+5
Change-Id: I6b4605e3223d11fe4f905e0d9141043a0d7527da
2014-10-30inner condition is the same as outer oneCaolán McNamara1-7/+4
Change-Id: If573f4d21492506d631861d06842828f9abb61f4
2014-10-30coverity#1242658 Untrusted loop boundCaolán McNamara1-1/+8
Change-Id: Ib37d08e5c55ca3c9f054684aa79dbe38d441f37a
2014-10-29coverity#1202781 Division or modulo by zeroCaolán McNamara1-2/+2
Change-Id: I2908c57badd079c8f19c679f40ed815ce2cba374
2014-10-29coverity#1078542 Division or modulo by zeroCaolán McNamara1-3/+8
Change-Id: I3325328c01b23d43c774db4af080df535f47787b
2014-10-25coverity#1242746 turn this around to help out coverityCaolán McNamara1-1/+1
Change-Id: I06cc94395e6421b7e01811b3d5f17c2677650a83
2014-10-24coverity#704228 'Constant' variable guards dead codeCaolán McNamara1-3/+2
Change-Id: Ia3ccd40ae4a83b58f7d5986273c5bd7d8310b467
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-23 18:45:14 +0000