summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-26/+13
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04-Werror,-Winconsistent-missing-overrideStephan Bergmann1-1/+1
(loplugin:saloverride does not warn about them because they depend on template args) Change-Id: I41a1dbfd7db24e58154f6f3810781219119418ba
2014-11-01coverity#703954 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ifc8a4c2a3f22fc12b620a3bd0dd8ace57a99629c
2014-10-31Removed duplicated includesAndrea Gelmini1-8/+9
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30nothing to see here, move alongCaolán McNamara1-1/+1
brown bag fix for commit cdbfbd0f7c3ed3bd3235f97197d279c41913245b Date: Thu Oct 30 09:21:40 2014 +0000 coverity#735608 Division or modulo by float zero and coverity#735607 Division or modulo by float zero Change-Id: I8e04765cf5354d57a54b166a5e2af71b40b670bb
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#735608 Division or modulo by float zeroCaolán McNamara1-2/+6
and coverity#735607 Division or modulo by float zero Change-Id: Iceeab702e183d291d7b1b6ded9113d1a15163c94
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin7-7/+1
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29ref-counting vcl::Window subclassesNoel Grandin3-3/+1
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin1-1/+1
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27coverity#982164 silence Unchecked return value from libraryCaolán McNamara1-2/+2
Change-Id: Ie2479e3dc73a7c7e8d2d0c5c979bde2ea5d05a1e
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-3/+3
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25coverity#982164 silence Unchecked return value from libraryCaolán McNamara1-2/+2
Change-Id: Ibec38a7e7846c463601b0a876778f53003cf0441
2014-10-25coverity#982163 silence Unchecked return value from libraryCaolán McNamara1-1/+1
Change-Id: I6b9a3c6ce75472da551706b1c1555eff4ba1abc8
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-6/+2
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin1-1/+1
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin1-1/+1
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02MWERKS etc. are not supported toolchainsMichael Stahl1-5/+0
Change-Id: I449fe34be396114529357388c87162aaf8976292
2014-10-02coverity#1242860 Unused valueCaolán McNamara1-5/+1
Change-Id: Ibd6d737cf117af0c2fdda7768da6a173c59bd346
2014-10-01loplugin: cstylecastNoel Grandin10-16/+16
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01fdo#82577: Handle TimeNoel Grandin2-2/+2
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30extensions: std::auto_ptr -> std::unique_ptrStephan Bergmann17-26/+20
Change-Id: I2d9d2e145584013d8e94f5aea2ec7732452b240c
2014-09-30fdo#82577: Handle RegionNoel Grandin2-4/+4
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29loplugin: cstylecastNoel Grandin1-3/+3
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin1-20/+20
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin1-5/+5
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin1-6/+6
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26coverity#983665 Uncaught exceptionCaolán McNamara4-4/+4
Change-Id: I3d0cd9a9bde8c3705abd876e832b6b7e56bb7fad
2014-09-25comphelper: std::auto_ptr -> std::unique_ptrStephan Bergmann2-10/+4
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-23Leftover XLIB_Window -> WindowStephan Bergmann6-7/+7
Change-Id: I51aa3e3fbf440bbd16d43ab8113cd69937060bf3
2014-09-23fdo#82577: Handle WindowNoel Grandin87-241/+241
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23Put schema.xml in the correct place, and drop the empty English strings fileTor Lillqvist1-1/+3
Change-Id: Ic9d3894611eedcffa9ce79ae8b2745de72eb9117 (cherry picked from commit 0b6555f594095ddc082d555852f7d8e9f7d7f266)
2014-09-23Use prex.h/postx.hStephan Bergmann2-15/+4
Change-Id: I055ae0426df86a1ea49385bc8c0b176cc4b9d940
2014-09-18Blind fix for WindowsStephan Bergmann1-2/+2
Change-Id: I1b923cba578b0acc2b9ce389c6c7d664fa00b268
2014-09-18Blind fix for WindowsStephan Bergmann1-4/+2
Change-Id: I186024f8a95ada752115750419a54a6231967f57
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler1-17/+0
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-18fdo#82577: Handle FontNoel Grandin3-7/+7
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15cppcheck: unpreciseMathCallJulien Nabet1-1/+2
Change-Id: I440dc3e30ee139d6cb261e1308e48e9b63b52bc8 Reviewed-on: https://gerrit.libreoffice.org/11434 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-12extensions: sal_Bool -> boolStephan Bergmann13-30/+30
Change-Id: I026056e093661d3beb7f7a231d6cf0e8c72e5b50
2014-09-12Mark template member fns that are supposed to override as SAL_OVERRIDEStephan Bergmann1-7/+7
Change-Id: Ic81b4510aef3476a53c811b7c91ee1941068ce59
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann2-11/+11
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-11create a master document template typeCaolán McNamara1-0/+1
of application/vnd.oasis.opendocument.text-master-template with suffic otm https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html desktop/icons/oasis-master-document-template.icns is just a copy of desktop/icons/oasis-master-document.icns because I can't draw Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1 Reviewed-on: https://gerrit.libreoffice.org/11350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-10fdo#55380 replaced use of obsolete interfacesDaniel Sikeler1-8/+8
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef Reviewed-on: https://gerrit.libreoffice.org/11256 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-09semibold->boldCaolán McNamara2-2/+2
Change-Id: I563f4530f2003ea3090cd15696ea53143f7b3aa6
2014-09-09fdo#45071: Remove ENABLE_NPAPI_INTO_BROWSER left-oversStephan Bergmann4-211/+0
...from previous commit Change-Id: I945faa6215f971ce817c6450fe0786da0696091f
2014-09-09fdo#45071 Remove Libreoffice browser pluginBryan Quigley16-3276/+0
This removes ENABLE_NPAPI_INTO_BROWSER while it should keep ENABLE_NPAPI_FROM_BROWSER (embed flash in LO) intact. Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: extensions/source/nsplugin/source/npshell.cxx Change-Id: I80a9159a75653c74423d8fdc7c188568d3188e04
2014-09-07create clang plugin to warn about C-style castsNoel Grandin1-8/+8
We don't like C-style casts in our nice C++ code Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d Reviewed-on: https://gerrit.libreoffice.org/10367 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-31Add help button to dialogOlivier Hallot1-0/+14
Change-Id: I2b4eab22da81379a94b21947872a4dc2e9214c5f Reviewed-on: https://gerrit.libreoffice.org/11210 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-31FDO#83283 (part) help btn for Label Field select'nOlivier Hallot1-0/+14
Help button for Calc Label Field Selection Change-Id: Ia3024992ff804be469cf32caf1a2b84675557415 Reviewed-on: https://gerrit.libreoffice.org/11208 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>